- 27 Feb, 2019 40 commits
-
-
Jonas Olsson authored
The new iceConnectionState had a few bugs late in beta. Instead of merging fixes in beta late we'll return to the old behavior for now. Bug: chromium:936370 Change-Id: I6d1e78d8f86812800ddf74f24d4bb31687228a14 Reviewed-on: https://chromium-review.googlesource.com/c/1489200Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Cr-Commit-Position: refs/heads/master@{#635978}
-
Kush Sinha authored
Bug: 925827 Change-Id: Id4aa0202ba4c97339fd8b470d28e096b5791e130 Reviewed-on: https://chromium-review.googlesource.com/c/1483024 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#635977}
-
Kush Sinha authored
Bug: 925827 Change-Id: Ic3c3c71fc7fe24898d681da73a878ed1b00a783f Reviewed-on: https://chromium-review.googlesource.com/c/1483022 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Balazs Engedy authored
If the active WebContents has a pending permission prompt when its renderer crashes, and then the user closes the WebContents, the following sequence of events takes place: 1) The WebContents is detached from the Browser. 2) This causes the WebView's crash overlay view to get torn down, and to make sure hit testing continues to work correctly on Mac, the hosted WebContents is made visible again temporarily. 3) This triggers the PermissionRequestManager, which has pending requests, to show the prompt bubble again, but at this point there is no BrowserView to anchor the prompt to. Make sure we silently suppress the prompt in step (3) as a quick fix. Bug: 933321 Change-Id: If8dbf09e1faae33fc615e7a6117c155d5f8707c4 TBR: raymes@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1489245 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#635975}
-
Daniel Bratell authored
With the changes to port from wtf/time.h to base/time/time.h the core test build target ended up with two TimeTicksFromSecondsD which clashed in some jumbo builds. This patch is a short term fix that inlines one of them. A long term fix would imho be to add a TimeTick::FromSecondsD method. Bug: 919383 Change-Id: I5ff65f2a8bcfb95fc0163453793f7c290bbd9e52 Reviewed-on: https://chromium-review.googlesource.com/c/1489196 Auto-Submit: Daniel Bratell <bratell@opera.com> Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#635974}
-
Hiroki Nakagawa authored
This CL enables to create WebWorkerFetchContext with response override suppilied from the browser process when the PlzDedicatedWorker flag is enabled. The response override is consumed during off-the-main-thread dedicated worker script fetch. Noteworthy points of this CL: - After this change, top-level dedicated worker scripts are considered as the main resources when PlzDedicatedWorker is enabled. See IsMainResourceType() in AppCacheRequestHandler and ServiceWorkerUtils. - DedicatedWorkerHostFactoryClient::CreateWorkerFetchContext() directly creates ServiceWorkerProviderContext without ServiceWorkerNetworkProviderForWorker. The provider is not necessary because script loading is done on the worker thread without (WorkerShadowPage's) documents. See also class level comments on ServiceWorkerNetworkProviderForWorker. - This CL adds new virtual functions in (Web)LocalFrameClient to connect blink::DedicatedWorker to content::RenderFrameImpl. Remaining issues: - Nested dedicated workers doesn't use this mechanism yet. See TODO comments in DedicatedWorker::CreateWebWorkerFetchContext(). - This change fails referrer and credentials tests because some fields on ResourceRequest constructed in the browser process are not set. These are fixed by follow-up CLs. Change-Id: I29f8d9c13f183e5eaeccf69acbec62379aa05b55 Bug: 731604, 906991 Reviewed-on: https://chromium-review.googlesource.com/c/1468852Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#635973}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ee85330e0ea1..23eea33f021a git log ee85330e0ea1..23eea33f021a --date=short --no-merges --format='%ad %ae %s' 2019-02-27 fmayer@google.com Merge "Use bytes as type for interned strings." Created with: gclient setdep -r src/third_party/perfetto@23eea33f021a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I62b021882a3f486897949bb5c9db042fe9e74706 Reviewed-on: https://chromium-review.googlesource.com/c/1490781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635972}
-
Michael Lippautz authored
Canonical fix: - Model liveness through MediaStreamAudioDestinationNode (AudioNode), i.e., keep alive listener from there. - Change off-thread handler to use a weak root This works as AudioNode disposes the handler in the pre-finalizer. Bug: 928781, 843903 Change-Id: Ia8eedeb29896bc29d9eb2b81c04d44bc1a21a3c0 Reviewed-on: https://chromium-review.googlesource.com/c/1489247Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#635971}
-
Antonio Gomes authored
R=haraken@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: Iec6129d374d6078cde863d9cd180335faa5ac627 Reviewed-on: https://chromium-review.googlesource.com/c/1489952 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Michael Lippautz authored
Frames that are detached may still have tasks scheduled to run. These tasks may hold unnecessary state and memory until they are run. While this may generally be not ideal, it also breaks testing infrastructure such as leak detection that assumes all cleanup tasks are run at some point. In order to guaranteee that tasks have a chance to run the leak detector schedules itself repeatedly. Since the tasks on the detached frames are low priority, there's no guarantee that they are run in time. Bug: 936360, 843903 Change-Id: Ifd4ec86beb9b27b4555d792c2b4df1336474ead1 Reviewed-on: https://chromium-review.googlesource.com/c/1491412 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635969}
-
Michael Lippautz authored
The test leaks memory as threads are just eagerly shut down when running leak detection which prevents them from releasing memory on the main thread. No-try: true Bug: 928781, 843903, 936374 Change-Id: Ic54fc75b3c0f8c8e58f7b2b46c2d50c64fe5dd7c Reviewed-on: https://chromium-review.googlesource.com/c/1491433Reviewed-by:
-
Antonio Gomes authored
blink::RemoteFrame, blink::RemoteFrameOwner and blink::RootFrameViewport are all switched over by this CL. R=jbroman@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: I2161c42388b5fe7e28af3bdf076ea34ad707462b Reviewed-on: https://chromium-review.googlesource.com/c/1489611 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Roman Aleksandrov authored
Add device reporting section to the management page. Clean-up related C++ backend. Apply text changes, add images. Bug: 879146 Change-Id: I50d65fabfb5cf7acf55a9f444794bcf8c34b8d3f Reviewed-on: https://chromium-review.googlesource.com/c/1470796Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#635966}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aca6308fdf25..f256796310cd Created with: gclient setdep -r src-internal@f256796310cd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1813cd6b7f26622877346cea8cfd4f56b70aede1 Reviewed-on: https://chromium-review.googlesource.com/c/1490778Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635965}
-
Kush Sinha authored
Bug: 925827 Change-Id: I9e0c1942eb60b39b251767d05549e4a136f8235f Reviewed-on: https://chromium-review.googlesource.com/c/1483018Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/32291a4d..933508f9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6390d231fd20d523a41921a6423eb696bcaa8747 Reviewed-on: https://chromium-review.googlesource.com/c/1490769Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635963}
-
Miyoung Shin authored
- unsigned short -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I122235e4673889c6607ba6d129cc651e2dc20841 Reviewed-on: https://chromium-review.googlesource.com/c/1491152Reviewed-by:
-
Daniel Vogelheim authored
Bug: 751996 Change-Id: I44dfc36dcec55efd2c68d02c06824fcbb94c879d Reviewed-on: https://chromium-review.googlesource.com/c/1464301Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#635961}
-
Karolina Soltys authored
Bug: 863341 Change-Id: I47e06b340428875125a139f764d2dae570a9eafc Reviewed-on: https://chromium-review.googlesource.com/c/1478874 Commit-Queue: Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#635960}
-
Karolina Soltys authored
Bug: 863341 Change-Id: I932ac6853e431d8629ff0b98035cfb878882411e Reviewed-on: https://chromium-review.googlesource.com/c/1477685 Commit-Queue: Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635959}
-
Sam McNally authored
Bug: 931469 Change-Id: Ifddf61cb092b0870a841a908d131ccbc8ce3e747 Reviewed-on: https://chromium-review.googlesource.com/c/1485612Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#635958}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I95837633f8ffffc82d6fc43b1ca05fad19d3f914 Reviewed-on: https://chromium-review.googlesource.com/c/1490352 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#635957}
-
Stephane Zermatten authored
With this patch, the Autofill Action reports a MANUAL_FALLBACK or FAILED_PRECONDITION error and let the server decide what to do about it. Before this patch, the Autofill Action would handle these case specially, displaying an error and then interrupting the script. The goal of this change is to allow configuring the way the errors from Autofill Action are handled from the server, allowing retries for MANUAL_FALLBACK. Nowadays, FAILED_PRECONDITION is the sign of a script error instead of an expected manual fallback case. This is why it's now reported separately. Bug: b/125245527 Change-Id: I79a0babd32affd2f2413813d377c458541dd2cac Reviewed-on: https://chromium-review.googlesource.com/c/1488890 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635956}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/695af944c472..7b3f4a203570 git log 695af944c472..7b3f4a203570 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 brandtr@webrtc.org Remove unused |keyframe_interval| from codec tests. 2019-02-27 benwright@webrtc.org Add const to variables in openssl_stream_adapter.cc that can use it. 2019-02-27 amithi@webrtc.org RtpSender's RtpParameters were invalidated in a call to SLD/SRD. 2019-02-26 Peter) Slatala Add ::Connect method to the media transport interface 2019-02-26 sprang@webrtc.org Remove VCMEncodedFrameCallback and VCMGenericEncoder 2019-02-26 srte@webrtc.org Respects min ALR probing interval. 2019-02-26 Peter) Slatala Remove deprecated CreateMediaTransport method 2019-02-26 jonaso@webrtc.org Add field trial for adding remote ufrag CreatePermission 2019-02-26 yvesg@webrtc.org clang-tidy helper script, with clang static analyzer included. 2019-02-26 sprang@webrtc.org Remove VCMEncoderDataBase and put remaining code into VideoStreamEncoder Created with: gclient setdep -r src/third_party/webrtc@7b3f4a203570 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I238f2f6f9adaa6b034ac57b7510cf0431dec6ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1491181Reviewed-by:
-
Balazs Engedy authored
Turn on the flag by default to restrict Device{Orientation|Motion}Events to secure origins. Intent to remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/5yqfAXibz1I Bug: 932078 Change-Id: I8f46a90a12375b734ba3d9a89b835c754960ef48 Reviewed-on: https://chromium-review.googlesource.com/c/1486091 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:Reilly Grant <reillyg@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#635954}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/738567f148b2..b2c5023c9c1f git log 738567f148b2..b2c5023c9c1f --date=short --no-merges --format='%ad %ae %s' 2019-02-27 jiawei.shao@intel.com Remove RenderPassDescriptorBuilder Created with: gclient setdep -r src/third_party/dawn@b2c5023c9c1f The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I6dc211fba48825ef9e1439187e18971b95164879 Reviewed-on: https://chromium-review.googlesource.com/c/1490777Reviewed-by:
-
Nick Diego Yamane authored
PrepareForAnimation does nothing when tab_drag_controller is set (tab dragging is started), so we can safely remove its needless call from TabStrip::StartedDraggingTabs method, which is called from TabDragController::Attach. R=sky@chromium.org Change-Id: I0b084512d2ee2804cf602d2a4e71bea2fd7c80ff Bug: 896640 Reviewed-on: https://chromium-review.googlesource.com/c/1489214Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#635952}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/49d0ee8be197..aca6308fdf25 Created with: gclient setdep -r src-internal@aca6308fdf25 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8752a76e544dfa109469b21178041f5cf140c347 Reviewed-on: https://chromium-review.googlesource.com/c/1490776Reviewed-by:
-
Ioana Pandele authored
This reverts commit 56aac4d8. Reason for revert: see crbug.com/936372 Bug:936372 Original change's description: > Add HTTP protocol scheme of the main frame origin to UKM > > Approval doc here: http://shortn/_FVcQvJsxmu > > Change-Id: I1b79f2be75a7fceef5c596ceda8372c62ac9e4ec > Bug: 893923 > Reviewed-on: https://chromium-review.googlesource.com/c/1484739 > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635713} TBR=holte@chromium.org,tbansal@chromium.org,ryansturm@chromium.org Change-Id: Ic466a05a0974ab8bb461604805cd04ebe7bbf48d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 893923 Reviewed-on: https://chromium-review.googlesource.com/c/1491432Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#635950}
-
Miyoung Shin authored
- unsigned short / unsigned -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I2195aa9d8daf5168273d0b3a03ad2669d041cf78 Reviewed-on: https://chromium-review.googlesource.com/c/1491062Reviewed-by:
-
Lukasz Suder authored
Generic details parameters takes precedence, when they are provided. Otherwise old logic of creating Details based on vertical specific parameters is used. Bug: 806868 Change-Id: I0bc0f77af3f86c9e7482c0893dc10be65b797883 Reviewed-on: https://chromium-review.googlesource.com/c/1488882 Commit-Queue: Lukasz Suder <lsuder@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#635948}
-
Julie Jeongeun Kim authored
This CL removes GaiaCookieManagerService, AccountTrackerService, ProfileOAuth2TokenService, AccountFetcherService and SigninClient. It also updates DomainsClearedOnBrowsingDataRemoved and DomainsClearedOnBrowsingDataRemoved2 to use IdentityManager, not GaiaCookieManagerService. It checks whether OnAccountsInCookieUpdated() is triggered or not after OnBrowsingDataRemoved() is called as it forces to call OnCookieChange(). Bug: 797931 Change-Id: I247370add1ed670a8b2aad99c7905bbe655f5d63 Reviewed-on: https://chromium-review.googlesource.com/c/1488476Reviewed-by:
-
Jinsong Fan authored
When the WebView Shell receives an error, the URL of mUrlBar will be red, while WebView goes back by onBackPressed(), the URL is still red, even though it is correct. Bug: Change-Id: I80a5b1c02eeaae8d99105955f2900acf81f0118f Reviewed-on: https://chromium-review.googlesource.com/c/732858 Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#635946}
-
Hirokazu Honda authored
The former way to enable kVaapiVp9Encoder in VEA unittest is wrong. It enables kVaapiVp9Encoder in the begging of main() function in the test. Features are overwritten later by base::TestSuite::Initialize(). Furthermore, it is too late if the feature is enabled in each test case. base::TestSuite::Initialize() queries the driver and the obtained capabilities will be used in the test case. Hence, we have to enable kVaapiVp9Encoder between base::TestSuite::Initialize() and media::VaapiWrapper::PreSandboxInitialization(). Bug: 811912, 930532 Test: VEA unittest with VP9 stream Change-Id: Id1601d5ce985c189820f380df5c2e23ea265e17c Reviewed-on: https://chromium-review.googlesource.com/c/1490987 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Pawel Osciak <posciak@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#635945}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: If0438689f9caeb70e83764e6fe8a691576a14843 Reviewed-on: https://chromium-review.googlesource.com/c/1491332Reviewed-by:
-
Jinsong Fan authored
No change to logic. Bug: 812553 Change-Id: Iaef19776322056885bb05fb80a5b234e7042b820 Reviewed-on: https://chromium-review.googlesource.com/c/1238093Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#635943}
-
Abhishek Bhardwaj authored
This change adds power manager implementation to be used by libassistant on Chrome OS. This implementation implements the API - To acquire and release Chrome OS wake locks. - To set wake up alarms on Chrome OS. BUG=chromium:913128 TEST=Set timers using assistant on Chrome OS. Change-Id: Ia54cf6508e2dd695fd3c76ee6d732e7aab5d15aa Reviewed-on: https://chromium-review.googlesource.com/c/1372830Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635942}
-
Luciano Pacheco authored
Migrate tests for <files-tooltip> component from unittest to integration tests, because unittest environment can't load chrome://resources which is required for our setup for Polymer. The unittest will be removed in follow up CL. Bug: 924873 Change-Id: I2c17fd07e2a2f2c1f062a6c4e7f29105a6917613 Reviewed-on: https://chromium-review.googlesource.com/c/1485623 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635941}
-
Gyuyoung Kim authored
BlinkMemoryMgt: Annotate DatabaseVersionCache and SQLiteFileSystem classes with the macros of Allocator The OnionSoup effort has a goal of allocating all garbage-collectible Blink objects with Oilpan or PartitionAlloc. However, some classes of //blink/renderer/modules/webdatagbase have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of SQLiteFileSystem class, it makes sense to use STATIC_ONLY because it only has static functions. To annotate SQLiteFileSystem class with STATIC_ONLY, this CL removes the default constructor. In DatabaseVersionCache class case, it makes sense to use USING_FAST_MALLOC because it's used by DEFINE_THREAD_SAFE_STATIC_LOCAL macro. Additionally, this CL annotates DOMWebSocketTestScope with STACK_ALLOCATED. Bug: 919389 Change-Id: Iaad117a1edf152bee6dbe43b2979aaee5ca4ce0d Reviewed-on: https://chromium-review.googlesource.com/c/1491070Reviewed-by:
-
Hiroshige Hayashizaki authored
https://chromium-review.googlesource.com/c/chromium/src/+/1476144/ Bug: 906850 Change-Id: I79bbcdddd8361e91b70af1b366c089b5496a924b Reviewed-on: https://chromium-review.googlesource.com/c/1476172 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635939}
-
