GitLab

This will enable us to select the back-end renderer for ANGLE.

BUG=380355

Review URL: https://codereview.chromium.org/474523003

Cr-Commit-Position: refs/heads/master@{#292634}

It will require an update of the gardening documentation to point to
safely-roll-deps.py instead of safely-roll-blink.py:
http://www.chromium.org/blink/gardening

BUG=None
TBR=eseidel@chromium.org (current LGTM not accepted...)

Review URL: https://codereview.chromium.org/523573002

Cr-Commit-Position: refs/heads/master@{#292633}

BUG=

Review URL: https://codereview.chromium.org/515983003

Cr-Commit-Position: refs/heads/master@{#292632}

When the WebView app makes a call to java over the JavaScriptBridge,
we leave the renderer hanging on a synchronous IPC. Once control
is passed into Java, it's possible that the WebView may get destroyed
(and thus the IPC channel back to the renderer closed) which means we
can't unblock the renderer waiting on the IPC response.

Instead we cache the IPC reply message and while waiting on Java to come
back to us, if we detect that the RenderFrame has been deleted, send a
reponse back before the IPC channel is closed.

BUG=408188

Review URL: https://codereview.chromium.org/498633003

Cr-Commit-Position: refs/heads/master@{#292631}

OpenSSL is no longer used by chromium and is not being merged any more.
libaddressinput and boringssl are being merged.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/518803002

Cr-Commit-Position: refs/heads/master@{#292630}

- Reorganize methods in cc file so they match up with the header
- In SetUpAutoSize, use the autosize flag parameter read in from
  the embedder to enable/disable autosize instead of passing true

BUG=386838

Review URL: https://codereview.chromium.org/510183002

Cr-Commit-Position: refs/heads/master@{#292629}

https://chromium.googlesource.com/chromium/blink/+log/8c8a7ba64b27fe8063e2211ecffcab1742d19a37..b8b43dd815f11fafd074bea301aa25cc3957be7c
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/524613002

Cr-Commit-Position: refs/heads/master@{#292628}

DirectShow supports a certain type of Video Capture Cards, in general
video digitizers (a.k.a. Analog video capture cards). These cards need
extra configuration of the "remote" ports in and out. For this purpose,
the Windows Driver Model is used [1], where special DS Filters are
added upstream of the capture source.

This CL adds support for enumerating these devices, which will show up
as another camera in the system list.

Other posterior CLs will figure out other parts needed, namely:

- which "normal" Filter is associated to the WDM Filter, for the
purpose of capabilities enumeration.

- if the VideoCaptureDevice::Name passed to VideoCaptureDeviceWin
is labelled as being WDM, a slightly different capture graph is
needed.

For the Hauppage USB-Live 2, this means another camera called
"Hauppauge Cx23100 Crossbar", in addition to the normal "Hauppauge
USB-Live2"

[1] http://msdn.microsoft.com/en-us/library/windows/desktop/dd373405(v=vs.85).aspx

BUG=402684

Review URL: https://codereview.chromium.org/510723003

Cr-Commit-Position: refs/heads/master@{#292627}

BUG=402257
TBR=phajdan.jr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/520693002

Cr-Commit-Position: refs/heads/master@{#292626}

The regexp were using single quotes but the DEPS files is
using single quotes. With this CL, the DEPS file is correctly
parsed and updated.

BUG=None
TBR=eseidel@chromium.org (current LGTM not accepted)

Review URL: https://codereview.chromium.org/524583002

Cr-Commit-Position: refs/heads/master@{#292625}

This reverts commit f1dc1186.

Reverting due to inconsistent behavior across toolchains, and lack of
clarity on whether armv7s is actually necessary.

BUG=407295,408027
R=rohitrao@chromium.org

Review URL: https://codereview.chromium.org/507423005

Cr-Commit-Position: refs/heads/master@{#292624}

Review URL: https://codereview.chromium.org/511213002

Cr-Commit-Position: refs/heads/master@{#292623}

BUG=405449
TEST=Manual testing using different WebRTC clients

Review URL: https://codereview.chromium.org/495983002

Cr-Commit-Position: refs/heads/master@{#292622}

Pulls in Arm64 SIMD support https://codereview.chromium.org/434123003.

BUG=356100
TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/515923004

Cr-Commit-Position: refs/heads/master@{#292621}

BUG=110610

Review URL: https://codereview.chromium.org/511323002

Cr-Commit-Position: refs/heads/master@{#292620}

Reason for revert:
Make WebKit Linux (dbg) to crash while running:
virtual/gpu/fast/canvas/canvas-style-intact-after-text.html

Original issue's description:
> Skia roll 60cc7d3:088f4b8
>
> https://skia.googlesource.com/skia/+log/60cc7d353b2adc8fcc1712e1f7a965e70121ebcc..088f4b8eb31b2af26e66dcbaae062f40b3955059
>
> CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
> TBR=djsollen@google.com
>
> Committed: https://chromium.googlesource.com/chromium/src/+/06f45538f0dbff916938fc4a949875991c02c06a

TBR=djsollen@google.com,skia-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/523603002

Cr-Commit-Position: refs/heads/master@{#292619}

Revert "Revert of Hook up the Mac password bubble to the browser and add browser tests. (patchset #8 of https://codereview.chromium.org/444603003/)"

This reverts commit e8e38740 and fixes
the flakiness of the tests.

The fix is in patch set #2: when the icon is deleted before the bubble, it
clears the icon pointer in the bubble.

Ran five times on the bots without causing failures.

BUG=328847
TBR=vabr@chromium.org,shess@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/505123002

Cr-Commit-Position: refs/heads/master@{#292618}

Once the user tries starting the video, the video should not be 'ended'.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/517963002

Cr-Commit-Position: refs/heads/master@{#292617}

BUG=398856
TEST=existing browser_tests

Review URL: https://codereview.chromium.org/494093002

Cr-Commit-Position: refs/heads/master@{#292616}

https://chromium.googlesource.com/chromium/blink/+log/4c64aba5ca8a0edb090a6be235efad2ba65c9c89..8c8a7ba64b27fe8063e2211ecffcab1742d19a37
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/518013002

Cr-Commit-Position: refs/heads/master@{#292615}

Cr-Commit-Position: refs/heads/master@{#292614}

Since PrefService provides a consistent and convenient way to check if a user
value has ever been saved for a preference, there is no need for
NETWORK_PREDICTION_UNSET in enum chrome_browser_net::NetworkPredictionOptions.
The default value is NETWORK_PREDICTION_WIFI_ONLY, this is reported by
PrefService if there is no user setting, policy, etc.

Note that since MigrateNetworkPredictionUserPrefs was introduced in
https://codereview.chromium.org/421653006/diff/160002/chrome/browser/net/prediction_options.cc,
there is no need to check the old preference NetworkPredictionEnabled in
CanPrefetchAndPrerender* or CanPreresolveAndPreconnect*.

Also note that Chromium at no point did save NETWORK_PREDICTION_UNSET to disk,
it only used to be provided as a default option.  This guarantees that this CL
does not introduce functional change.

TODO:
 * Remove network_prediction_enabled from profile_io_data.
 * Remove PrerenderCondition classes.

As this CL will also fix UI bug https://crbug.com/404794, I prefer to land it
first, and deal with the other two clean-up items on a separate CL.

BUG=406583

Review URL: https://codereview.chromium.org/516443002

Cr-Commit-Position: refs/heads/master@{#292613}

BUG=388893
TBR=phajdan.jr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/518043002

Cr-Commit-Position: refs/heads/master@{#292612}

We are getting renderer crashes, disable until someone can investigate.

BUG=392224,408496

Review URL: https://codereview.chromium.org/516883002

Cr-Commit-Position: refs/heads/master@{#292611}

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/518703003

Cr-Commit-Position: refs/heads/master@{#292610}

- Move file_manager/js/media/media_controls.{css,js}
   -> video_player/js
- Move file_manager/js/media/mouse_inactivity_watcher.js
   -> file_manager/js (parent directory)
- Move file_manager/images/media/*
   -> video_player/images/media/
- Move file_manager/images/media/error.png
   -> gallery/images/media/error.png

BUG=405838
TEST=compile pasees
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/504073002

Cr-Commit-Position: refs/heads/master@{#292609}

The GLIB_DISABLE_DEPRECATION_WARNINGS define disables the deprecation
warnings which is caused by the usage of the g_settings_list_schemas
method. Moving the define to the build scripts avoids any future build
errors (-Werror) and warning reports.

BUG=391250
TEST=ninja -C out/Release chrome

Review URL: https://codereview.chromium.org/367113004

Cr-Commit-Position: refs/heads/master@{#292608}

BUG=400728
TBR=phajdan.jr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/520543003

Cr-Commit-Position: refs/heads/master@{#292607}

Revert of Net-related fixups for scoped_refptr conversion operator cleanup. (patchset #2 of https://codereview.chromium.org/511163002/)

Reason for revert:
It seems to be breaking GPU Mac Builder (Blink):
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/builds/19306/steps/compile/logs/stdio

Original issue's description:
> Net-related fixups for scoped_refptr conversion operator cleanup.
>
> BUG=110610
> TBR=pkasting@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/aa3dd9e5a2d3215f9c756ddcbb11268569cbe473

TBR=mmenke@chromium.org,rsleevi@chromium.org,pkasting@chromium.org,dcheng@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=110610

Review URL: https://codereview.chromium.org/517873003

Cr-Commit-Position: refs/heads/master@{#292606}

Review URL: https://codereview.chromium.org/521573003

Cr-Commit-Position: refs/heads/master@{#292605}

BUG=408804

Review URL: https://codereview.chromium.org/522463003

Cr-Commit-Position: refs/heads/master@{#292604}

https://chromium.googlesource.com/chromium/blink/+log/ee13016d417011b60039bfe6f93cec2b081cf8d0..4c64aba5ca8a0edb090a6be235efad2ba65c9c89
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/519683002

Cr-Commit-Position: refs/heads/master@{#292603}

This CL wires up cryptohomed's GetKeyDataEx() as
HomedirMethods::GetKeyDataEx() in Chrome. The method will be used to
retrieve metadata such as the hashing algorithm and salt used for a
key.

BUG=367847
TEST=New homedir_methods_unittest.cc

Review URL: https://codereview.chromium.org/506943002

Cr-Commit-Position: refs/heads/master@{#292602}

BUG=328847

Review URL: https://codereview.chromium.org/513193002

Cr-Commit-Position: refs/heads/master@{#292601}

BUG=110610
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/511163002

Cr-Commit-Position: refs/heads/master@{#292600}

Move AppWindow, AppWindowRegistry and AppsClient from apps/ to extensions/browser/app_window
Change the namespace from apps to extensions.
Fix GYP and DEPS.

BUG=403726
TBR=sky@chromium.org for include and namespace changes

Review URL: https://codereview.chromium.org/494033002

Cr-Commit-Position: refs/heads/master@{#292599}

Revert of Try backing SkPicture with SkRecord in Chromium. (patchset #2 of https://codereview.chromium.org/504823003/)

Reason for revert:
This is breaking the following Blink test:
inspector/layers/layer-canvas-log.html

Original issue's description:
> Try backing SkPicture with SkRecord in Chromium.
>
> This is our first attempt, mostly to feel this out.  Performance and
> correctness problems are both possible.  Please revert this if a benchmark even
> smells funny.
>
> That said, we've been working on this a while, are pretty confident it's good
> stuff, and have had Skia's internal testing entirely switched over for a week.
> Parts of Chromium that serialize and deserialize SkPictures are already
> switched over.  This CL finishes things off by switching the default
> recorded-from-scratch SkPicture to use SkRecord too.
>
> BUG=
>
> Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5f2a6ab31313eb2fc6e456f65c3863a77d2d0c30

TBR=reed@google.com,mtklein@google.com,senorblanco@chromium.org,eroman@chromium.org,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/522623002

Cr-Commit-Position: refs/heads/master@{#292598}

Put tests next to the code being tested.

Move tests to components/ without actually removing dependencies with temporary DEPS rules added.
This results in these tests still built as parts of unit_tests, not components_unittests.

Fix TemplateURLServiceTestUtil to simplify the code and reduce chrome dependencies:
- Create KeywordWebDataService instead of depending on WebDataServiceFactory.
- Remove TemplateURLService::SetKeywordSearchTermsForURL() and TestingTemplateURLService.  Instead, TestingTemplateURLServiceClient is responsible to implement SetKeywordSearchTermsForURL().
- Remove content::TestBrowserThreadBundle from test util.  Tests are responsible to set up one.  This enables TemplateURLServiceTestSyncTest to use multiple test util instances.

BUG=387985
TEST=unit_tests

Review URL: https://codereview.chromium.org/513133002

Cr-Commit-Position: refs/heads/master@{#292597}

ImageService is an abstract superclass that will have subclasses
for each mobile platform. This class stores a salient image for
a bookmark which is removed when the bookmark node is deleted.

BUG=None

Review URL: https://codereview.chromium.org/513793002

Cr-Commit-Position: refs/heads/master@{#292596}

BUG=110610

Review URL: https://codereview.chromium.org/513323002

Cr-Commit-Position: refs/heads/master@{#292595}