- 20 May, 2019 40 commits
-
-
Caleb Rouleau authored
TBR=perezju@chromium.org Bug: 965066 Change-Id: Ie2c498aeec8d96f14402a99e7984817eaedec9c2 NOTRY: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620125Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#661396}
-
Maksym Onufriienko authored
Original cl introduced build breakage in ios_internal https://chromium-review.googlesource.com/q/I8c1dcc1abf61a7b3886dd6886174ea6eca1b6413 To solve the issue this cl has old methods that are used in external_url_egtests. This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. For GREYAsserts, the policy is to take assert- containing-helpers, modify them to return NSError* with localizedDescription containing the assert failure (in the event of a failure), and then assert on the result of the helper on the test side. Also cleaned code in internal_os repository(submit only after this cl) https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/1284395 Bug: 922813 Change-Id: I5d3556c1a016726797edb5daf38b783082a9979e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616542 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#661395}
-
Jared Saul authored
When I added an item in CL 1509135, I missed that there was another missing item before it. As a result, the metrics labels are shifted for these last couple of entries. This should fix the issue. Change-Id: I224b7fd14a62372a8ca99cf2c3985a4cd2e5de4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619965 Commit-Queue: Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Auto-Submit: Jared Saul <jsaul@google.com> Reviewed-by:
Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#661394}
-
Bailey Berro authored
Previously, CupsPrintJobManager relied on the fact that all installing a printer moved it into saved printers for checking whether the printer still exists to show a status notification. Bug: 962571 Change-Id: I72c4d69e52a73d1eca13f7e850dc884ec48f2296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617211 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#661393}
-
Robert Liao authored
This is due to the use of negative numbers in the line below and seems reasonable. BUG=940744 TBR=sky@chromium.org Change-Id: I5587681e6c30ebe09fa1f000062f1b9cc73e4dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619925 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#661392}
-
Cliff Smolinsky authored
Calls to pin or load user32.dll cannot happen on the main thread loop because they are blocking calls. The test code always executes on the main thread loop, so if the test code hits anything that requires user32 then it will crash (with dchecks on). To avoid this, we simply call PinUser32() in wWinMain before we get to the main thread loop. This same thing is done in browser_tests_main.cc. Bug: 962559 Change-Id: I82b4e7a41117db77e2ff3a01314cb9e82c7b1b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617911Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#661391}
-
sczs authored
The TabStrip pushes the Ombibox View down and we can't rely on its Guide for the banner presentation. This is intended to be a temporary solution and crbug.com/964136 has been created to fix the NamedGuide or create a new one. Bug: 911864 Change-Id: I50801c85233bf6a34e3beda3991a7bfa760aa80d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616381Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#661390}
-
Jan Krcal authored
Bug: 836718 Change-Id: I0562a387555335ed7f5b04aab7ea2995133e3744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619699 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#661389}
-
Jinho Bang authored
Before this patch, TypeError occurs due to the wrong order of test scripts. The error causes test failure and shutting down but service worker registration might be going on different thread. At that time, the service worker might not register to a finish and might cause DB errors internally. It might eventually cause a crash due to DCHECK. So, this patch fixes the wrong order of test scripts. After this patch, TypeError no longer occurs and we guarantee that service worker is activated at least. Bug: 964158 Change-Id: Id8ebe86de3c558e81aad732c6ef6b513647f6465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619531Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#661388}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5009f37bf713..f09f069a125f git log 5009f37bf713..f09f069a125f --date=short --no-merges --format='%ad %ae %s' 2019-05-20 eugenis@google.com Merge "Bump delay in HeapprofdEndToEnd.ReInit_Central test." Created with: gclient setdep -r src/third_party/perfetto@f09f069a125f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I61d216ffc707931a933de27ba068888031db37b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619012Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661387}
-
Xiaoqian Dai authored
From the crash stack, |Widget::widget_delegate_| has been deleted but not set to nullptr, thus caused the nullptr dereference crash. However, we did not find the equivalent number of crashes in WidgetDelegate::~WidgetDelegate(). This CL does: 1) Change DCHECK to CHECK in Widget::~Widget() when NATIVE_WIDGET_OWNS_WIDGET to see if we can get another crash stack to help investigate the bug. If crashes happen here, means Widget is destroyed while its native widget is still alive, thus Widget::OnNativeWidgetDestroyed() is not called, thus |widget_delegate_| is not set to nullptr. 2) Besides that, it may be also possible that a window is destroyed while building up the mru window. We added a scoped window observer to observe window in IsWindowConsideredActivatable() and see if there is any window is destroyed out from the function. Bug: 937381 Change-Id: I01172cc36fcb19078a5d416d7c87fb505f6304d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615384 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#661386}
-
Robert Liao authored
BUG=940744 TBR=sky@chromium.org Change-Id: Icc3035d8a5f07933abd6b6630a5e4470b46bc49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618174Reviewed-by:
-
Rayan Kanso authored
Add basic UI for Notifications & Push Messaging in Application > Background Services. One UI flag per feature is created. TBR=caseq@chromium.org Screenshot: crbug.com/942174#c28 Bug: 942174 Change-Id: Ifcdca9d3d78593968b0bd93d02d9dfea9419b822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611612 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#661384}
-
Steven Bennetts authored
NetworkIconPurger was added before ActiveNetworkIcon was introduced. It now makes sense to move the very limited functionality to ActiveNetworkIcon which already implements the required observer and interface. Bug: 862420 Change-Id: I6aa1a28ae18050563786f592beb082f32117ddb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611873 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#661383}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fc311e53e3ef..e4f5cbe5d994 Created with: gclient setdep -r src-internal@e4f5cbe5d994 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mbarowsky@google.com,sidereal@google.com Change-Id: I0fdac631b4cf5d7c9ae6e3d38786017916ba743e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618596Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661382}
-
Mitsuru Oshima authored
The reason why it was flaky was that it label animation was going while rotating. Wait until label is shown so that we rotate the screen including label. I'll file a separae bug to cancel the label animation. Bug: 952885 Change-Id: Ic2af278d44182ba87e3e934e58fe872d5bc3e83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619423 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#661381}
-
Morten Stenshorne authored
It's wrong to walk all the way to the root and look for something with a fixed block size just to determine whether we can collapse through the block or not. It only matters what the actual block size of the containing block is. This bug triggered DCHECK failures, because the cached state of self-collapsing got out of sync with reality, because some ancestor went from auto-height to fixed-height, a change that shouldn't affect the descendant at all. Bug: 962175 Change-Id: Ic24d9c46dfa515306563b195487310eedfae9ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617833 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#661380}
-
Ryan Hamilton authored
Change-Id: Ie60e33efd9b18c737d935349ae5ecaac5121ed66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619010 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#661379}
-
Koji Ishii authored
This patch unifies the same logic separated in two places into one. Originally, the logic needed for new LayoutObjects in the tree is put into |InsertedIntoTree()|. However, some logic are added to |LayoutObjectChildList| too because they are needed to run regardless of |notify_layout_object|, which is an optimization when some of existing notifications can be skipped for in-tree moves. As it turned out that all LayoutNG logic are needed regardless of |notify_layout_object|, this patch moves all of them to |LayoutObjectChildList|. The |SplitFlow()| case was found in crbug.com/964619. Bug: 964854 Change-Id: I777b05fa2355e301ceb713b49d83734546e5ecf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617055 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Rohit Rao authored
This will allow EG2 tests to use these constants without pulling in more of //ios/chrome/browser/ui. BUG=None Change-Id: Ifb5dbeaf841b598767a63521aea6e07bb5f9dc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618123Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#661377}
-
Koji Ishii authored
List markers are not selectalbe. Before this change, it still hits in |LayoutNGMixin::PositionForPoint()| as atomic inline, which leads to crashes. Change-Id: I4563c493417cf72900f9da48a052f564fb5f0369 Bug: 964813, 964814, 964925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619593 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
David Bienvenu authored
Bug: 396477 Change-Id: Ie64abe2a732405d44aec185e3f49907a5fc799a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618747Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#661375}
-
Matthew Jones authored
Bug: 963516 Change-Id: If52da6c0d3c9b1a68e48a1e6ac39d6e785b44126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618032Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#661374}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iac0c69514081b707ef518e8eae076bfe60f10551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619660Reviewed-by:
-
K Moon authored
The SK_CRASH and SK_DEBUGBREAK macros are no longer used by Skia, so there's no point in continuing to define them in SkUserConfig.h. There were a couple of references to SK_CRASH in //src/skia/ext; I've replaced them with equivalent CHECKs. Some other changes: * Refreshes skia/config/SkUserConfig.h from third_party/skia * Drops the now always-false |fatal| parameter in SkDebugf_FileLine * Consolidates customizations after the "Chrome-specific" line The changes pulled from third_party/skia's SkUserConfig.h mostly are comments and formatting, and should have no effect. Similar to https://pdfium-review.googlesource.com/c/pdfium/+/54650, but for Chromium instead of PDFium. The PDFium copy of SkUserConfig.h tries to minimize lint errors, while the Chromium copy tries to preserve the original formatting, so unlike the PDFium change, I haven't tried to fix lint errors. Change-Id: Ieb66af9e2f30a36a19184451966f9a85f2a10997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618148Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: K Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#661372}
-
Roman Sorokin authored
Mostly boilerplate code to let use it in the notification system. Bug: 930109 Change-Id: If263e6228c23f1b91c241b3d0444332a65fd73ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619809Reviewed-by:
A Olsen <olsen@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#661371}
-
David Benjamin authored
As of https://chromium-review.googlesource.com/c/chromium/src/+/882281/, that method no longer exists. Bug: 797998 Change-Id: Iaeadf89b1c696aeec0e7792ee08c406e867a6031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618302 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#661370}
-
Denis Kuznetsov authored
Existing approach did not work on official builds (because skipping update is not supported on them). Test: OobeConfigurationEnrollmentTest.*, with check that removing "updateSkipNonCritical" from sample configuration breaks tests. Bug: 854101 Change-Id: Ic8e598bec9297f5f6e3333abb42a5b2b0018df78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619810Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#661369}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/519d74a5fcd8..cc189177a63a git log 519d74a5fcd8..cc189177a63a --date=short --no-merges --format='%ad %ae %s' 2019-05-20 henrika@webrtc.org Revert "Improve spec compliance of SetStreamIDs in RtpSenderInterface" 2019-05-20 mbonadei@webrtc.org Remove unused dependency. 2019-05-20 mbonadei@webrtc.org Roll chromium_revision 243a2094..f5d37007 (660868:660984) 2019-05-20 danilchap@webrtc.org Update android tests to use single argument PeerConnectionFactory factory 2019-05-20 nisse@webrtc.org Delete configuration of unused transport_sequence_number_allocator 2019-05-20 titovartem@webrtc.org Fix test names in pc_full_stack_tests.cc 2019-05-20 nisse@webrtc.org Reland "Delete deprecated rtc::Thread default constructor" 2019-05-18 titovartem@webrtc.org Introduce peer connection level webrtc video quality tests. 2019-05-17 sukhanov@webrtc.org Add CreateDatagram to MediaTransportFactory 2019-05-17 hbos@webrtc.org Implement RTCOutboundRtpStreamStats.totalPacketSendDelay for video. 2019-05-17 thomasanderson@chromium.org Remove non-source sources from binary targets 2019-05-17 sukhanov@webrtc.org Add juberti@ to webrtc root owners 2019-05-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4c987269..243a2094 (660753:660868) 2019-05-17 srte@webrtc.org Adds feedback generator. 2019-05-17 guidou@webrtc.org Improve spec compliance of SetStreamIDs in RtpSenderInterface Created with: gclient setdep -r src/third_party/webrtc@cc189177a63a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:964411,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaec69a158a6b7d9c8ef4cd9a589bc16bb71f3a93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618595Reviewed-by:
-
Josh Nohle authored
See design at http://go/cros-devicesync-v2-scheduling In preparation for DeviceSync v2, we refactor the v2 Enrollment schedulers. DeviceSync v2 scheduling will be added to these schedulers in a subsequent CL. In this CL, we * Move ownership of the scheduler from the Enrollment manager to DeviceSyncImpl. This way the scheduler can be shared between the v2 Enrollment and DeviceSync managers. * Move all caching and invocation reason determination out of the Enrollment manager and into the scheduler. * Create a pending-request caching mechanism in the scheduler. This allows us store an Enrollment request that is made before scheduling has been started, while an Enrollment attempt is in progress, or while we are offline. * The latter point enables us to easily merge the "persistent" and "network-aware" schedulers into a single implementation. Note: M76 branch is May 30th, so these changes will make it into the v2 Enrollment rollout. Bug: 899080 Change-Id: Ia994141f7f245ff316f0df93b2f979c3756d94ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606244 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Robert Ogden authored
This enables other flags (in the next CL) to enable this behavior. Bug: 956685 Change-Id: I94e909bda16ff52ad9f5f794ade14dafbc198417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619214Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#661366}
-
Xianzhu Wang authored
By making caret rects using PhysicalRect, we avoid back-and-forth flipping for LayoutNG which was to adapt to legacy, and make it clear of caret rect's coordinate space. Temporary flippings are added before some mapping functions which still require flipped blocks direction. They will be removed soon when we make all mapping functions use pure physical coordinates. Change-Id: Ia8ccd5ca5ae1ca360822637c8946ae4809b4ca79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619042Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#661365}
-
Derek Schuff authored
Bug: 963490 Change-Id: I982e81cd76f0aa0717aa9e0cdcb0b8531df41873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618076 Commit-Queue: Derek Schuff <dschuff@chromium.org> Reviewed-by:
-
Madeleine Barowsky authored
The failures are caused by an internal WebSocketException, details in bug linked. TBR=eyaich@chromium.org Bug: 964960 Change-Id: I1ed9697988164151519eb0b2b1fbb56884f51061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619829 Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by:
Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#661363}
-
Caleb Raitto authored
Currently, RequestFinishedInfo contains UrlResponseInfo and Error members. Because struct-in-struct is implemented to use base::Optional<T>, it therefore contains inline copies of these members. These structures can be large -- the UrlResponseInfo can contain headers, and the Error contains error strings. Therefore, instead of copying these members into the UrlResponseInfo, separate pointers should be passed to OnRequestFinished(). Ownership of those pointers should be shared in a similar manner to |request_info| for consistency and to avoid confusion. Bug: 879208 Change-Id: I9b2ff91706819b8d10e7093e33002d6868dfb735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610591Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#661362}
-
Mihai Sardarescu authored
This CL updates the setting earl grey test to run with unified consent feature enabled. It also adds the settings earl grey tests to the list of tests that are run on the unified consent enabled bot. Note: There are a significant number of earl grey tests for settings, so this CL will significantly increase the time it takes to run the tests on the ios-simulator-full-configs bots. However the unified consent enabled bot is temporary and the current plan is to remove it once unified consent feature is enabled by default. Bug: 960260 Change-Id: If16d2d48f739b3e5e405a8b8976b84f75581e665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617443 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#661361}
-
Maksim Ivanov authored
This CL renames variables that have obsolete names like "gaiaAuthHost", now that the "GaiaAuthHost" class doesn't exist anymore and is finally renamed to "Authenticator" everywhere (see crrev.com/c/1605919). Also fixes some comments that were referring to the old "auth host" thing. This is a pure refactoring CL, no functional changes are expected. Bug: 470893 Test: existing tests Change-Id: Ia07803527e0bf9148e021266cb2e2bc9a1fa67ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617832Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
Madeleine Barowsky authored
Marking external/wpt/css/css-scroll-snap/scroll-margin.html as flaky. This was previously disabled for prefix virtual/threaded, but because of a wpt change, we expect the test to flake for all variants. TBR=majidvp@chromium.org Bug: 964239 Change-Id: Iee686a55ff9142a81a495ee211b65cbb5a0aa508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619833Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6fbc2c914856..fc311e53e3ef Created with: gclient setdep -r src-internal@fc311e53e3ef The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mbarowsky@google.com,sidereal@google.com Change-Id: Ia788396cfd8c470312bf86d397b91f5041803b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619657Reviewed-by:
-
Antonio Gomes authored
... in favor of CrossThreadBindOnce. Reasoning: this method schedules a task that runs once. Hence, coneptually CrossThreadBindOnce is the bind helper to be used. BUG=963574 R=haraken@chromium.org, hiroshige@chromium.org Change-Id: I0c1eede1ecbffeea3a14bacbd81fff40ce702712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619826 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#661357}
-
