GitLab

BUG=238224
R=joi@chromium.org, joth@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/16073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202981 0039d316-1c4b-4281-b951-d872f2087c98

R=jochen@chromium.org
TBR=jamesr@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/15952012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202980 0039d316-1c4b-4281-b951-d872f2087c98

much identical.

BUG=226965
R=jln@chromium.org

Review URL: https://codereview.chromium.org/16019017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202979 0039d316-1c4b-4281-b951-d872f2087c98

* Name/comment animation constants for clarity.  Make constants used in multiple
  places in the class be private static members to scope them to the class (not
  really a big deal as there are no other classes in the .cc file).
* Inline the calculations from GetTextAnimationSize() into GetPreferredSize()
  and nuke |visible_text_size_| as a result.
* To enable the above change, add a background_showing() method to tell us when
  the background painter is being painted.  This is basically equivalent to "are
  we animating", but also includes the "paused animation" state (during which
  the actual animation is technically reset).  Then use this everywhere
  appropriate.  This results in one functional change: if the content setting
  model changes our type while we're paused, we now just silently ignore it.
  This seems more correct, and I doubt this case can happen anyway.
* Eliminate pointless arg to OnClick().
* Make |background_painter_| a pointer, which will be necessary when it switches
  to being an image grid painter.
* Eliminate unnecessary #includes and a using directive.
* Other changes to braces, newlines, variable names, code order, comments, etc.
  with the aim of clarity, brevity, and stylistic consistency.

BUG=none
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/16209002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202978 0039d316-1c4b-4281-b951-d872f2087c98

BUG=235099

Review URL: https://chromiumcodereview.appspot.com/16075004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202977 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 1675fd68.
It causes DCHECK failure on an Android bot.

BUG=235188
TBR=vollick

Review URL: https://codereview.chromium.org/16018011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202975 0039d316-1c4b-4281-b951-d872f2087c98

Follow up on: https://codereview.chromium.org/14358005/

BUG=234733

Review URL: https://chromiumcodereview.appspot.com/15003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202974 0039d316-1c4b-4281-b951-d872f2087c98

The GetTotalNodesCount() function is called sufficiently often that it
makes sense to spend some effort optimizing its implementation.

The current implementation uses some traversal functions that are fairly
slow, especially since GetSuccessorId() was made more expensive by the
implementation of UniquePositions.

This change moves the implementation into the syncable::Directory.  This
allows it to take advantage of the Directory's internal data structures
and avoid unnecessary lookups. 

BUG=248143,238621

Review URL: https://chromiumcodereview.appspot.com/15322003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202973 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141788
TEST=Updated media_unittests.
R=scherkus@chromium.org

Review URL: https://codereview.chromium.org/15660002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202971 0039d316-1c4b-4281-b951-d872f2087c98

The scope approval component app's background script doesn't need to be running until the Identity API invokes the dialog, so there is no need to start the app when Chrome starts.

BUG=244220

Review URL: https://chromiumcodereview.appspot.com/15892012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202970 0039d316-1c4b-4281-b951-d872f2087c98

DnsTransaction::RecordLostPacketsIfAny shouldn't crash if some attempts failed to connect and thus have NULL socket_lease.

BUG=244507
TEST=net_unittests --gtest_filter=DnsTransactionTest.ConnectFailureFollowedBySuccess

Review URL: https://chromiumcodereview.appspot.com/15881008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202967 0039d316-1c4b-4281-b951-d872f2087c98

This fixes two issues:
1) Set use_tab_for_suggestions_ at the end of OnAutocompleteStart so that it
doesn't get overridden by calls to HideOverlay.
2) If not using tab for suggestions, make sure the overlay is ready to use.

BUG=241835

Review URL: https://chromiumcodereview.appspot.com/15755011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202966 0039d316-1c4b-4281-b951-d872f2087c98

Remember the initial checked state of {radiobutton|checkbox}. If autofill flow is not autocheckout, autofilling a form should just use remembered values for checkable elements.

BUG=244645

Review URL: https://chromiumcodereview.appspot.com/15659015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202965 0039d316-1c4b-4281-b951-d872f2087c98

On suspicions that it turns four CrOS bots red.

TBR=tengs@chromium.org

Review URL: https://codereview.chromium.org/16210002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202964 0039d316-1c4b-4281-b951-d872f2087c98

This also adjusts the baseline and min-X of the unread count.

BUG=243935

Review URL: https://chromiumcodereview.appspot.com/16159005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202962 0039d316-1c4b-4281-b951-d872f2087c98

Turns out that this cleanup introduced regression
 https://codereview.chromium.org/16105005/

BUG=244224
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16114008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202961 0039d316-1c4b-4281-b951-d872f2087c98

Add a missing null check for the case where missing recordings create
null tiles.

R=reveman@chromium.org
BUG=243839

Review URL: https://chromiumcodereview.appspot.com/16086003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202960 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes the Activity Log UI. I will be replacing it with an extension once the chrome.activityLogPrivate API is complete.

The only code changes in this CL are for code deletion.

BUG=241672

Review URL: https://chromiumcodereview.appspot.com/15812004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202959 0039d316-1c4b-4281-b951-d872f2087c98

able to override it. But there is already functionality in internals.settings to
to that.

BUG=231643

Review URL: https://chromiumcodereview.appspot.com/15898003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202958 0039d316-1c4b-4281-b951-d872f2087c98

Remove "--hsts-hosts" so we don't have to maintain it during upcoming changes to the TransportSecurityState data structures and JSON format.

The "--hsts-hosts" feature is likely unused, is redundant with net-internals,  and is dangerous since it fails silently.  Also it exposes the internal JSON format to the user.

BUG=156152
R=rsleevi,palmer

Review URL: https://chromiumcodereview.appspot.com/15711007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202957 0039d316-1c4b-4281-b951-d872f2087c98

When sync receives DISABLED_BY_ADMIN from server PSS stops SyncBackendHost and 
disables sync by settings DisabledByAdmin pref. This prevents sync from 
connecting to server in the future. The way to reenable sync is to sign out and 
sign in again.
In future milestone we will implement retry logic that will periodically 
(once a day) try to connect to sync server to see if sync is still disabled.

BUG=178417

Review URL: https://chromiumcodereview.appspot.com/14655009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202956 0039d316-1c4b-4281-b951-d872f2087c98

Motivation: Data collection exposed in this CL is needed by upcoming startup tests we're writing using Telemtry.

Expose a new window.statsCollectionController object to JS and move existing histogram reading code into it since that seemed misplaced in DOMAutomationController.

Add a new --enable-stats-collection-bindings to activate said object.

Example usage in telemtry:
with browser.Create() as b:
  b.tabs[0].Navigate("http://www.google.com")
  b.tabs[0].WaitForDocumentReadyStateToBeComplete()
  print b.tabs[0].EvaluateJavaScript('statsCollectionController.tabLoadTiming()')

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202620

Review URL: https://chromiumcodereview.appspot.com/12389073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202955 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131333,159026,222296
TBR=aa@chromium.org

Review URL: https://codereview.chromium.org/16193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202954 0039d316-1c4b-4281-b951-d872f2087c98

This is pretty much the same as existing Pepper Socket API.  Since the
original code for socket is in chrome_content_browser_client.h for
crossing chrome-content boundary, it's moved to the new file
pepper_util.cc, so that PepperCrxFileSystemMessageFilter can access
directory inside chrome space.

BUG=240865

Review URL: https://chromiumcodereview.appspot.com/15521002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202951 0039d316-1c4b-4281-b951-d872f2087c98

Adding additional containers in the media test directory (all generated from bear.ogv using avconv).

BUG=235108
TBR=xhwang@chromium.org

Review URL: https://codereview.chromium.org/16034004

Patch from John Rummell <jrummell@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202950 0039d316-1c4b-4281-b951-d872f2087c98

Previously we chrome trace and atrace is exclusive. Sometimes this is
inconvenient.

BUG=244501

Review URL: https://chromiumcodereview.appspot.com/15892014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202949 0039d316-1c4b-4281-b951-d872f2087c98

These two dialogs host web contents modal dialogs on their WebContents,
so they need to implement the WebContentsModalDialogManagerDelegate
and WebContentsModalDialogHost interfaces to provide dialog host view
and positioning.

BUG=244173

Review URL: https://chromiumcodereview.appspot.com/15879007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202948 0039d316-1c4b-4281-b951-d872f2087c98

R=vandebo@chromium.org
BUG=None

Review URL: https://chromiumcodereview.appspot.com/15742010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202946 0039d316-1c4b-4281-b951-d872f2087c98

Based on chrome/browser/profiles/OWNERS.

BUG=227219
R=erg@chromium.org, mirandac@chromium.org, rlp@chromium.org

Review URL: https://codereview.chromium.org/16114006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202945 0039d316-1c4b-4281-b951-d872f2087c98

Switch to NSStrings; NSNumbers may be tagged pointers.

BUG=244703
TEST=Mac 64 tester goes green

Review URL: https://chromiumcodereview.appspot.com/15690016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202944 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=chrisgao@chromium.org

Review URL: https://codereview.chromium.org/16161003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202943 0039d316-1c4b-4281-b951-d872f2087c98

If the main thread is unblocked and we access this function on the impl thread,
we're in a racy situation. This should be an error.

BUG=235188

Review URL: https://chromiumcodereview.appspot.com/14179022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202942 0039d316-1c4b-4281-b951-d872f2087c98

Pulls the call to open a new user's first window out of the ProfileManager and
into the UI layer that called for the creation of the new user. This improves
code layering (ProfileManager shouldn't have to know about the host desktop type)
and allows us to communicate errors during user creation (also
partially added here, although most errors aren't yet captured).

BUG=153864, 243379
TEST=existing unit tests

Review URL: https://chromiumcodereview.appspot.com/15734006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202939 0039d316-1c4b-4281-b951-d872f2087c98

When a user of the spelling service right-clicks on a misspelled word and 
selects 'Add to dictionary', the SpellingMenuObserver notifies spelling service
feedback sender. This feedback will be used to improve spellcheck suggestions 
from spelling service.

BUG=170514

Review URL: https://chromiumcodereview.appspot.com/15736012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202938 0039d316-1c4b-4281-b951-d872f2087c98

BUG=238418

Review URL: https://chromiumcodereview.appspot.com/14646034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202937 0039d316-1c4b-4281-b951-d872f2087c98

+remove separators in creation dialogs.

TBR=derat@chromium.org, nkostylev@chromium.org, oshima@chromium.org

NOTRY=true
Because of changes in binaries.
BUG=229762

Review URL: https://codereview.chromium.org/16103006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202936 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202934 0039d316-1c4b-4281-b951-d872f2087c98

Like the previous Blink roll of 151349:151373, this breaks WebViewInteractiveTest.PopupPositioningMoved on the Mac.


TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/15797008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202933 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/16082003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202931 0039d316-1c4b-4281-b951-d872f2087c98

TBR=lambroslambrou@chromium.org
BUG=244562

Review URL: https://codereview.chromium.org/15827007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202930 0039d316-1c4b-4281-b951-d872f2087c98