GitLab

Adds logic to trigger sign-out if account cookies are cleared while
there's only an unconsented primary account.

Bug: 1095112
Change-Id: Iaa65f31ef8da6759cd9afaed2ce9dd6f16e511d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410875
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808561}

Bug: 1112095
Change-Id: Idf4553fd4367378a5117900b5ab75cbbe1dfeee1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418013
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808560}

We should only show the HoldingSpaceTray if we have a logged in user.

Bug: 1129227
Change-Id: I4b1e6843c49f7bebfcdd47e4f9a4310fd726691e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414706Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#808559}

Enables the standard GPU Mac tests on the ARM-based Mac DTKs.

Bug: 1105652, 1105656, 1105648
Change-Id: I794e41fd55ded954fd7547435e97471240d8d837
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412217
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808558}

blink_perf.canvas target is removed in this cl
https://chromium-review.googlesource.com/c/chromium/src/+/2367753. As
the target is removed, we also need to remove all references to the
target in code description.

Bug: 1077148

Change-Id: Ibf60e37e58260a536a2392808e7bfc8b268c4edc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417853Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808557}

This reverts commit a4a8af90.

Reason for revert: Broke chromeos-amd64-generic-lacros-dbg
https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-lacros-dbg/129

Original change's description:
> Disable lacros_chrome_browsertests for device.
> 
> These tests only run on Linux, not on ChromeOS devices.
> 
> Change-Id: If22d19f0cdcb95efd412d7c099df05361413350f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419007
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Auto-Submit: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#808521}

TBR=avi@chromium.org,erikchen@chromium.org

Change-Id: I6ffb195890b15821d53a93972b9380e52652f8af
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419148Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808556}

There is evidence that malware is overwriting the memory of this header
string in the binary in order to avoid sending the header which then
identifies the app.

Try to confirm this theory by constructing the string from pieces at run
time which should disrupt a simple search / replace mechanism.

Bug: 1028189
Change-Id: I03b40a2a60ae29e06572d0bb501dba68acb4d201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416869Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808555}

Bug: 1109369
Change-Id: If22a2762311ecdce441fa695a19c528173b35214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332361Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: who/bttk <bttk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808554}

https://skia.googlesource.com/skia.git/+log/c884631f9942..be0a9ca63d9d

2020-09-18 johnstiles@google.com Migrate remaining SkSL GLSL tests to golden outputs.
2020-09-18 johnstiles@google.com Remove inliner from IR generation stage.
2020-09-18 robertphillips@google.com Actually test the direct-context's thread-safe proxy cache
2020-09-18 johnstiles@google.com Migrate geometry SkSL tests to golden outputs.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1108408
Tbr: scroggo@google.com
Change-Id: I1f0a3d6c6a31327b7a9693cfc9750aacb9bc3981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419454Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#808553}

The clusterfuzz test case is very large and complicated, so I wasn't
able to reproduce the test case in a normal/minimal page. From debugging
while using the clusterfuzz repro tool, all I can tell is that
find-in-page is trying to scroll to the "Choose File" text node inside
an <input type=file>, and that it doesn't have a LayoutObject for some
reason, despite being attached to the document and the call to
UpdateStyleAndLayoutForNode in the previous block being run.

Bug: 1129341
Change-Id: I6de3eac626899ab15c157150ed5015119c497876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419154
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808552}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/576f2f50..31d58940

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I5f40bf1aa676ef22bd8c190e1541c65b4dbbc664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419511Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#808551}

This reverts commit dc50a154.

Reason for revert: No longer needed

Original change's description:
> [ntp][modules] Add basic collapse and expand functionality
> 
> Collapsing/expanding hides/shows the local module UI.
> 
> Before: https://screenshot.googleplex.com/7YpsgDQZg6EQbjT
> After: https://screenshot.googleplex.com/3wv7qaoupMtPQj5
> 
> Bug: 1124089
> Change-Id: I80d88b1c2311da6a4d047e2ffb4837b6d4158add
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388977
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#805099}

TBR=mahmadi@chromium.org,tiborg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1124089
Change-Id: I8dda5d5d19debe25b618cb7b26f520a6307a653e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419464Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808550}

AtomicString statics are bound to the thread where they were
initialized. This change switches MSE implementation to instead use
enums or non-thread-specific strings, in anticipation of upcoming usage
of MSE in either the main thread or dedicated worker threads. Longer
term, similar will be needed for core/html/track objects, though we may
instead switch to using prepopulated, valid-everywhere, AtomicStrings at
that point (when the cross-thread MSE implementation has stabilized enough to
get AudioVideoTracks feature working fully when using MSE in worker).

BUG=878133

Change-Id: I37f973d5175deb7bce6b96106e0a30bd6fa15ceb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417452Reviewed-by: Will Cassella <cassew@google.com>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808549}

When invalidating surfaces we check for available mediums. We currently
look for a WiFi or Ethernet connection, but these are not actually used
for discovery or advertising until WiFi LAN is supported.

This adds a constant, |kIsWifiLanSupported|, which will let us turn off
this logic for now without discarding the related code.

Bug: 1129069
Change-Id: I550667151369d2df100e4dfb94af64bed0fa4a7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414781
Commit-Queue: Michael Hansen <hansenmichael@google.com>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808548}

This is the design doc:
https://docs.google.com/document/d/1zCIs8zBE7SPIS_OTvTuLkLbEgSfh-RxF0cYSCNAm-Ko/edit?ts=5f4ea439#heading=h.7o3hpjjptc4v

In this CL, we detect inline style mutation.

Bug: 1111392
Change-Id: I7ed591ee46429fc59d582dd47119974e9e585ba4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408152
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808547}

Add three new fields to the process fetcher: total memory, resident
memory and free memory. All fields are reported in KiB.

Bug: chromium:1102518
Change-Id: I894fdb4ed5605f12d95bdac4de67952e0414eff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417319Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Paul Moy <pmoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808546}

Currently the EventHandler has methods start() and stop(), while the
RepeatedEventHandler has methods startListening() and stopListening().

Standardize on start() and stop().

TBR=akihiroota@chromium.org

AX-Relnotes: n/a.
Bug: None
Change-Id: Iac26647a9f218e4ce3f838ee74575a1de542d3f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415408Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#808545}

This caps the number of entries in each Safe Browsing list to
2^{20} entries. Currently, the largest list on iOS has between
2^{19} and 2^{20} entries.

Bug: 1129162
Change-Id: Ibf6b8b7665b079d040e5d34e8b6e86492c136a67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415211
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808544}

- Maintains a mapping of fake methods, resolvers and fake data

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: Ic07ddfc300679611b4d8dc908bb61a30631e9874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417450
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808543}

Bug: None
Change-Id: Idde218c29a55dff202e71ba1b8871a95791f8fd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419160
Auto-Submit: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808542}

TBR: michaeldo
Bug: 1108809
Change-Id: Iae89246f4a66b6661db11292129631996f20d6cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419269
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808541}

TBR: vsemeniuk
Bug: 1129441
Change-Id: I7e6956083443f7b60ac29c0bfca515a23599ddf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419270
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808540}

This CL adds the initial connecting UI that will show up when the device
is trying to connect with the phone when user has opted in the Phone Hub
feature. Remaining work includes implementing the button click handler.

Demo: https://screenshot.googleplex.com/BeLuL2JWNbmmZLs.png

Misc:
Refactors the |SetButtons| API to use unique_ptr.

BUG=1106937,1126208

Change-Id: I537c1da298fbaf4fb67d0df38712618e2496fb3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414127
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808539}

crrev.com/c/2398906 wired |disable_accelerated_vp8_decode| for the video
profile enumerations. This is usually correct, because ChromeOS devices
come with only one of those APIs, but some devices (namely guado, rikku
and buddy), are Chromeboxes with VA-API (because they are Intel) and
V4L2 (for a video acceleration chipset). In this case, the GPU driver
workaround should apply to the VA only.

This CL basically removes the profile filtering from the top level
profile enumerations in gpu_mojo_media_client.cc and
gpu_video_decode_accelerator_factory.cc, and pushes it down the class
callstack to VaapiWrapper.

Bug: 1126058, b/167923822, b/168645037
Change-Id: Ic435826303cb01d71f6554acba798b38c5f0b8fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419262Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808538}

Previous implementation only parsed percentage values for these
descriptors, and treated 'normal' as a parse error.

This patch allows descriptors ascent-override, descent-override and
line-gap-override to parse their initial value 'normal' without
triggering a parse error.

Bug: 1098355
Change-Id: I5fc8ddaa0574becf6f8aa21e7c4df6b299f35533
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415226
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808537}

Ensures test coverage for active CryptAuth v2 DeviceSync field trial.
See
https://chromium.googlesource.com/chromium/src.git/+/master/testing/variations/

The change was made due to a Finch warning in cl/331561231.

Bug: 951969
Change-Id: I62e19971aa831216056e79e1b543022b5148df7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410745
Auto-Submit: Josh Nohle <nohle@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808536}

We are adding 3 new wallpaper apps, but this causes the "My Images"
category to not be shown. This CL shrinks the margin between category
list items so that all wallpaper categories in the list will be shown
upon opening the app.

https://screenshot.googleplex.com/h4QERzczpze5qK9

Fixed: 1129959
Change-Id: I631e28b6123804461794664d6ae37cd090ce5268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419003Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808535}

On the clipboard, MozUrl and Filename ClipboardFormatTypes are only
really used on Windows. Restricting this allows us to delete some code,
and make it more clear where these formats are (and are not) used.

Change-Id: Iead2dcac183147b3b6285f9a546e3a7e3f9d94a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413396
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808534}

https://webrtc.googlesource.com/src.git/+log/03fd7930c651..788480dcff70

2020-09-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 86ce521c..4ed1b071 (808263:808365)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I9aedc96315aa48b82559b721884b8730826f594f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419452Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#808533}

This change also adds two unit tests for the feedback log-gathering
code: a cross-platform one that tests the basic mechanics using a
key that is always present, and a Mac one that tests that the
value of cpu_arch is exactly one of the three values approved by
privacy review.

TEST=Manual
  On a Mac, navigate to chrome://system and check for a "cpu_arch" key.

Bug: 1126503
Change-Id: Ibed7da188eff7902038815140375d9990e4211c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419120
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Miriam Zimmerman <mutexlox@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808532}

Change-Id: I2fce37aa90b6f307b56c31f30e32e74fb32e9f09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414571Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808531}

Bug: 1113353
Change-Id: Ib14715fd050517e6099b0532bb31b829065a8951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416938Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808530}

Desk renaming is inconsistent with other renaming patterns. This CL aims
to make it consistent and improve it as well. It makes the following
changes:

- Change background color on hover.
- Give desk_name_view a minimum width.
- Add border when textfield is focused.
- Make desk_name_view variable length so it changes size with respect to
  the current desk name.

Test: Manual
Bug: 1127498
Change-Id: I602a43146692eecb1b8dd1a0b624fd3f4f1cee65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406282Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808529}

Change-Id: Ic4638fce166a6a5e42c2fd02e82eec20adca52f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419408
Commit-Queue: enne <enne@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808528}

makes LimitAImageReaderMaxSizeToOne not create unnecessary
std::strings and moves setting is_supported_ to member initializer
list.

BUG=none
TEST=none

Change-Id: I7e7acd9996d8e7594a70382a47aa0a27209d2494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419112Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808527}

WebLayer Shell listens for notifications that the active tab was changed
and updates the favicon of the active tab in response. However, when
the active tab is removed WebLayer sets the active tab to null, which
also causes an onActiveTabChanged(null) notification to be sent (cf.
[1]). WebLayerShellActivity does not currently guard against this case
(cf. [2]), resulting in a crash. One way to trigger this crash is to
open a tab via a navigation that results in an intent launch, which will
then cause the tab to be closed. Concrete example:

On a device/emulator with the Play Store installed, go to booking.com
and click on the Install icon. This will open a new tab for a navigation
that results in an intent out to the play store, upon which WebLayer
closes the newly-opened tab and the onActiveTabChanged(null) callback is
sent.

[1] https://source.chromium.org/chromium/chromium/src/+/master:weblayer/browser/browser_impl.cc;l=403?q=browser_impl.cc&ss=chromium
[2] https://source.chromium.org/chromium/chromium/src/+/master:weblayer/shell/android/shell_apk/src/org/chromium/weblayer/shell/WebLayerShellActivity.java;l=697?q=WebLayerShellActivity.java&ss=chromium

Bug: 1128607
Change-Id: I787824deeb4a3fea49f52f430c6523bed5258f1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414399
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808526}

Roll Chrome Mac PGO profile from chrome-mac-master-1600408803-f0e40d48b8629d1086dbcdc0a0535ae545c69485.profdata to chrome-mac-master-1600451996-a3f5003485801b4281790ccd12c8c92cfb8c34e9.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com
Change-Id: Ie6f363d3de29c3af68382a1e02e39ca91f241232
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419453Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#808525}

Since Android Q, views that are labeled with importantForAutofill=no
can still trigger the augmented Autofill service. If this happens, no
ordinary Autofill requests will be triggered anymore for as long as the
Autofill session remains active. This prevents the user-configured
Autofill service from running on web contents if the user's first
interaction is with the URL bar.

This issue is resolved by canceling the current Autofill session when
the URL bar loses focus.

R=dmazzoni@chromium.org, michaelbai@chromium.org

Bug: 1103555
Change-Id: If06c15f4c397107c284c4de757f58c3aeb939cf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302636Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808524}

Modify the AndroidFontLookup interface and implementation to make the
request to fetch the list of "available" fonts to be synchronous. Rather
than constructing a list of fonts available on device, this now returns
a list of fonts expected (but not guaranteed) to be available on device.
If a font fetch request fails for a particular font, it will be removed
from this list (stored in memory).

This list is still expected to be sufficient to prevent too many
unnecessary renderer IPC requests (which will be confirmed with
metrics), but is faster to generate, allowing us to make this method
synchronous.

Also add metrics to track time for the GMS font request only.

Bug: 1111148, 1127478
Change-Id: Ie0b1243d81496a975fe3b0db24e8534a02b17f38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414514
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808523}

The virtual/omt-worker-fetch/external/wpt/xhr/
    xhr-timeout-longtask.any.worker.html test is consistently failing
on Mac with the following error:

"xhr-timeout-longtask.any.worker.html is a all-pass testharness test,
but has an extra baseline file. Please remove [the baseline file]."

Based on that message, this change removes the baseline file.

Bug: 1129910
Change-Id: Ia4462140d9efbc86b12cf679170bd6f5ee26e42a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418985Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/master@{#808522}