1. 11 Sep, 2014 17 commits
    • sammc's avatar
      Make some fields non-nullable in serial.mojom and data_stream.mojom. · da421fab
      sammc authored
      This also removes some null checks for the now non-nullable fields.
      
      BUG=407683
      
      Review URL: https://codereview.chromium.org/562563002
      
      Cr-Commit-Position: refs/heads/master@{#294277}
      da421fab
    • sammc's avatar
      Make the ServiceProvider& arg to GetServiceProviderForFrame non-nullable. · afd3e88b
      sammc authored
      This call isn't meaningful with a null ServiceProvider&.
      
      BUG=407683
      
      Review URL: https://codereview.chromium.org/555373003
      
      Cr-Commit-Position: refs/heads/master@{#294276}
      afd3e88b
    • ccameron's avatar
      Workaround to prevent crashes when destroying CGL contexts · 282049cc
      ccameron authored
      Observation 1: It was discovered in crbug.com/410402 that deleting
      the GL textures bound to IOSurfaces before releasing the CGL context
      from the CAOpenGLLayer can result in crashes.
      
      Observation 2: It was discovered in crbug.com/411782 that not deleting
      the GL textures bounds to IOSurfaces before destroying the CGL context
      can result in crashes.
      
      As way speculative workaround for this, retain the CGL context when the
      texture is created (when it is known to be valid), and the post a task to
      - make that CGL context current
      - delete the GL texture
      - make no CGL context current
      - release the CGL context
      - release the IOSurface used by the GL texture
      
      The theory here is that by doing this in a posted task, having a fresh stack
      and having manually retained the CGL context when it was known-valid
      will work around the crash in Observation 1, and manually destroying the
      texture while its IOSurface is still retained and before the CGL context is
      destroyed will work around the crash in Observation 2.
      
      BUG=411782
      
      Review URL: https://codereview.chromium.org/558803002
      
      Cr-Commit-Position: refs/heads/master@{#294275}
      282049cc
    • ananta's avatar
      Ensure that mouse lock works correctly on Chrome ASH in Windows 8. · b306b1e6
      ananta authored
      The lock mouse operation invoked by plugins or pages hides the mouse cursor and ensures that the cursor stays within the bounds
      of the webpage. To ensure that the mouse stays within the bounds of the page, the SetCursorPos operation is executed by the host.
      In ASH, the SetCursorPos API is executed by the viewer process for historical reasons.
      
      As a result on Windows 8 there is a faint possibility that the user may move the mouse to the charms section of the OS, which causes the cursor to
      become visible.
      
      Fix for this is to track if the mouse changed from what was last set in the viewer process and restore it.
      
      The other change is in the RemoteWindowTreeHostWin class where the member ignore_mouse_moves_until_set_cursor_ack_ has been changed to a count
      from a bool flag. This is because the RemoteWindowTreeHostWin::MoveCursorToNative function can be called multiple times before the acks are received
      causing DCHECKs to fire on the ignore_mouse_moves_until_set_cursor_ack_ flag.
      
      BUG=398792
      
      Review URL: https://codereview.chromium.org/560633002
      
      Cr-Commit-Position: refs/heads/master@{#294274}
      b306b1e6
    • blink-deps-roller's avatar
      6226ba67
    • skia-deps-roller's avatar
      Skia roll cc0e311:d9ec549 · 262231d6
      skia-deps-roller authored
      https://skia.googlesource.com/skia/+log/cc0e3110bde60201882a2c512a5cdd73c838f351..d9ec549071581d9d1dc2e5fac3163305ae935a39
      
      CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
      TBR=fmalita@google.com
      
      Review URL: https://codereview.chromium.org/561833005
      
      Cr-Commit-Position: refs/heads/master@{#294272}
      262231d6
    • boliu's avatar
      Revert of Clean up WebMediaPlayerAndroid needs_establish_peer_ (patchset #7... · 515ae254
      boliu authored
      Revert of Clean up WebMediaPlayerAndroid needs_establish_peer_ (patchset #7 id:120001 of https://codereview.chromium.org/557593002/)
      
      Reason for revert:
      Suspected to break tough_video_cases. See crbug.com/412897 for details.
      
      BUG=412897
      
      Original issue's description:
      > Clean up WebMediaPlayerAndroid needs_establish_peer_
      >
      > needs_establish_peer_ has been used to skip actual estalishing a surface
      > texture peer based on many conditions. Not all places that modify
      > actually checks all these conditions so there are bound to be some bugs.
      >
      > This CL aims to tease out all these different conditions and put them in
      > a single function EstablishSurfaceTexturePeerIfNeeded. This function
      > should be called any time these conditions are changed. Makes for much
      > saner reading.
      >
      > BUG=412578
      >
      > Committed: https://crrev.com/701cb640efb326aa107b5b0c25dcf91766fe765f
      > Cr-Commit-Position: refs/heads/master@{#294068}
      
      TBR=qinmin@chromium.org,avayvod@chromium.org,ycheo@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      BUG=412578
      
      Review URL: https://codereview.chromium.org/562803002
      
      Cr-Commit-Position: refs/heads/master@{#294271}
      515ae254
    • scottmg's avatar
      Revert of -fno-exceptions only on .cc files (patchset #1 id:1 of... · f004ba61
      scottmg authored
      Revert of -fno-exceptions only on .cc files (patchset #1 id:1 of https://codereview.chromium.org/560873003/)
      
      Reason for revert:
      Causes ASAN LSAN Linux bot to fail (not in the CQ/try set):
      
      [191/22134 | 8.047] CC obj/third_party/speex/libspeex/libspeex.filters.o
      FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/libc++abi/trunk/src/libc++abi.cxa_new_delete.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DCHROMIUM_BUILD -DCR_CLANG_REVISION=214024 -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DADDRESS_SANITIZER -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DUSE_NSS=1 -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen '-I../../third_party/libc++abi/trunk/include' '-I../../third_party/libc++/trunk/include' -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_ASan_LSan_Builder/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -fstrict-aliasing -nostdinc++ -std=c++11 -Wno-format -Wno-unused-result -m64 -march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address -fsanitize=leak -O2 -fdata-sections -ffunction-sections -fno-slp-vectorize -funwind-tables -fno-exceptions -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-deprecated  -c ../../third_party/libc++abi/trunk/src/cxa_new_delete.cpp -o obj/third_party/libc++abi/trunk/src/libc++abi.cxa_new_delete.o
      ../../third_party/libc++abi/trunk/src/cxa_new_delete.cpp:50:13: error: cannot use 'throw' with exceptions disabled
                  throw std::bad_alloc();
                  ^
      ../../third_party/libc++abi/trunk/src/cxa_new_delete.cpp:77:5: error: cannot use 'try' with exceptions disabled
          try
          ^
      ../../third_party/libc++abi/trunk/src/cxa_new_delete.cpp:118:5: error: cannot use 'try' with exceptions disabled
          try
          ^
      3 errors generated.
      FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/libc++abi/trunk/src/libc++abi.cxa_aux_runtime.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DCHROMIUM_BUILD -DCR_CLANG_REVISION=214024 -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DADDRESS_SANITIZER -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DUSE_NSS=1 -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen '-I../../third_party/libc++abi/trunk/include' '-I../../third_party/libc++/trunk/include' -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_ASan_LSan_Builder/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -fstrict-aliasing -nostdinc++ -std=c++11 -Wno-format -Wno-unused-result -m64 -march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address -fsanitize=leak -O2 -fdata-sections -ffunction-sections -fno-slp-vectorize -funwind-tables -fno-exceptions -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-deprecated  -c ../../third_party/libc++abi/trunk/src/cxa_aux_runtime.cpp -o obj/third_party/libc++abi/trunk/src/libc++abi.cxa_aux_runtime.o
      ../../third_party/libc++abi/trunk/src/cxa_aux_runtime.cpp:24:5: error: cannot use 'throw' with exceptions disabled
          throw std::bad_cast();
          ^
      ../../third_party/libc++abi/trunk/src/cxa_aux_runtime.cpp:29:5: error: cannot use 'throw' with exceptions disabled
          throw std::bad_typeid();
          ^
      2 errors generated.
      FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/libc++abi/trunk/src/libc++abi.cxa_personality.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DCHROMIUM_BUILD -DCR_CLANG_REVISION=214024 -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DADDRESS_SANITIZER -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DUSE_NSS=1 -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen '-I../../third_party/libc++abi/trunk/include' '-I../../third_party/libc++/trunk/include' -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_ASan_LSan_Builder/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -fstrict-aliasing -nostdinc++ -std=c++11 -Wno-format -Wno-unused-result -m64 -march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address -fsanitize=leak -O2 -fdata-sections -ffunction-sections -fno-slp-vectorize -funwind-tables -fno-exceptions -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-deprecated  -c ../../third_party/libc++abi/trunk/src/cxa_personality.cpp -o obj/third_party/libc++abi/trunk/src/libc++abi.cxa_personality.o
      ../../third_party/libc++abi/trunk/src/cxa_personality.cpp:1269:21: error: cannot use 'throw' with exceptions disabled
                          throw;
                          ^
      ../../third_party/libc++abi/trunk/src/cxa_personality.cpp:1290:17: error: cannot use 'throw' with exceptions disabled
                      throw be;
                      ^
      ../../third_party/libc++abi/trunk/src/cxa_personality.cpp:1203:5: error: cannot use 'try' with exceptions disabled
          try
          ^
      3 errors generated.
      ninja: build stopped: subcommand failed.
      
      I'm not quite sure what the actual problem is, but revert for now.
      
      Original issue's description:
      > -fno-exceptions only on .cc files
      >
      > R=thakis@chromium.org
      > BUG=335824
      >
      > Committed: https://crrev.com/fad91907037b2616fe446bfbb880f8c19418de43
      > Cr-Commit-Position: refs/heads/master@{#294266}
      
      TBR=thakis@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      BUG=335824
      
      Review URL: https://codereview.chromium.org/564493003
      
      Cr-Commit-Position: refs/heads/master@{#294270}
      f004ba61
    • mostynb's avatar
      remove lambda expression in quic · b9081554
      mostynb authored
      Followup to CL 478153003 which added a lambda expression even
      though we haven't officially switched to c++11 yet.
      
      Review URL: https://codereview.chromium.org/565443002
      
      Cr-Commit-Position: refs/heads/master@{#294269}
      b9081554
    • jmadill's avatar
      Add a gpu_unittests isolate. · 5ffe286f
      jmadill authored
      The goal is to run gpu_unittests on the GPU bots, starting with the
      FYI bots.
      
      BUG=391895
      
      Review URL: https://codereview.chromium.org/562733003
      
      Cr-Commit-Position: refs/heads/master@{#294268}
      5ffe286f
    • jamiewalch's avatar
      Fix bump-scroll. · 73dafe3a
      jamiewalch authored
      Apply bump scroll to the entire client-plugin-render hierarchy, not just
      the plugin, which doesn't handle rendering when MediaSource is enabled.
      
      BUG=411996
      
      Review URL: https://codereview.chromium.org/558283002
      
      Cr-Commit-Position: refs/heads/master@{#294267}
      73dafe3a
    • Scott Graham's avatar
      -fno-exceptions only on .cc files · fad91907
      Scott Graham authored
      R=thakis@chromium.org
      BUG=335824
      
      Review URL: https://codereview.chromium.org/560873003
      
      Cr-Commit-Position: refs/heads/master@{#294266}
      fad91907
    • erikchen's avatar
      Revert of Mac: Fix rounded corners on browser windows on retina display.... · 4e8a2925
      erikchen authored
      Revert of Mac: Fix rounded corners on browser windows on retina display. (patchset #4 id:80001 of https://codereview.chromium.org/463263002/)
      
      Reason for revert:
      When the download bar is present, the rounded corners are on the wrong view.
      
      https://code.google.com/p/chromium/issues/detail?id=412580
      
      Original issue's description:
      > Mac: Fix rounded corners on browser windows on retina display.
      >
      > When a window's bottom corner is covered by a layer on a retina display, the
      > corner is incorrectly rounded. I added a layer mask to do the corner rounding
      > ourselves.
      >
      > BUG=396264
      >
      > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289811
      
      TBR=andresantoso@chromium.org,ccameron@chromium.org,shess@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      BUG=396264
      
      Review URL: https://codereview.chromium.org/560913004
      
      Cr-Commit-Position: refs/heads/master@{#294265}
      4e8a2925
    • mseaborn's avatar
      NaCl: Update revision in DEPS, r13710 -> r13724 · 9160b5dc
      mseaborn authored
      This pulls in the following Native Client changes:
      
      r13711: (mseaborn) Move syscall definitions to pure C code, replacing nacl_syscall_handlers_gen.py
      r13712: (dbrazdil) Fixed signatures of _Unwind_* stubs in PNaCl support library
      r13713: (uekawa) Minor consistency style fixes.
      r13714: (dschuff) Move REV file to metadata package and include all repos
      r13715: (mseaborn) Remove the old "SecureRandom" service, formerly used by get_random_bytes()
      r13716: (dyen) Unify the way irt_ext libc how tests are declared and defined.
      r13717: (dyen) Asserts used by irt_ext are now done through error_report.c.
      r13718: (dschuff) Update revision for PNaCl r13696->r13714
      r13719: (dschuff) Build host libc++ and host tools with clang on Linux and Mac
      r13720: (bradnelson) Switching pnacl download script to use gsutil for download too.
      r13721: (dyen) In IRT Extension API, added file stat support and tests.
      r13722: (dbrazdil) Add MinSFI loader
      r13723: (bradnelson) Vary build settings on fastbuild + configuration + buildtype (reland).
      r13724: (dbrazdil) Update signature of MinSFI's entry point
      
      BUG=none
      TEST=browser_tests and nacl_integration
      CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk,linux_chromium_dbg
      
      Review URL: https://codereview.chromium.org/553323002
      
      Cr-Commit-Position: refs/heads/master@{#294264}
      9160b5dc
    • scottmg's avatar
      gn: Add missing -Wexit-time-destructors on base · 9126e8db
      scottmg authored
      TBR=brettw@chromium.org
      BUG=335824
      
      Review URL: https://codereview.chromium.org/560143002
      
      Cr-Commit-Position: refs/heads/master@{#294263}
      9126e8db
    • jochen's avatar
      Refactor IsolateHolder to be able to always create the isolate · 2f43f2c9
      jochen authored
      Currently, blink creates its own isolates. We want to always use an
      IsolateHolder to create the isolates. To be able to do this, I introduce
      an Initialize method that setups V8. The new IsolateHolder ctor now
      doesn't take any parameters but just creates new isolates according to
      the configuration.
      
      All non-blink gin users are cut over to the new API
      
      BUG=none
      R=abarth@chromium.org,andrewhayden@chromium.org,eroman@chromium.org
      
      Review URL: https://codereview.chromium.org/553903003
      
      Cr-Commit-Position: refs/heads/master@{#294262}
      2f43f2c9
    • nednguyen's avatar
      Remove DesktopBrowserBackend.SetProfileDir since it's deadcode. · 2ab903f7
      nednguyen authored
      BUG=
      
      Review URL: https://codereview.chromium.org/560923002
      
      Cr-Commit-Position: refs/heads/master@{#294261}
      2ab903f7
  2. 10 Sep, 2014 23 commits