GitLab

Until the device and user policies are clearly defined, force to disable
a managed user to enable adb sideloading, even if on an unmanaged device
(and as the primary user).

TEST=powerwash and initialize with a managed account, then try to enable
     adb sideloading
     => see policy indicator with disabled toggle
TEST=bypass the UI to force enable
     => fail to enable
BUG=chromium:893332

Change-Id: I26b16046ef9210b878ab234b122b962bf090cf1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913071
Commit-Queue: Victor Hsieh <victorhsieh@chromium.org>
Auto-Submit: Victor Hsieh <victorhsieh@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715359}

Bug: internal b/140189221

Test: Cast from Youtube to Android TV.
      TTS on Android Things.

Change-Id: I285f06ce5f44d6d0875e43d5d7ed62328e7ece70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917342Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Ziyang Cheng <ziyangch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715358}

non-public fields cause issurs across ClassLoaders, which breaks some TriChrome
APKs.

Bug: 1023681
Change-Id: I074c73669cb04ad977e448753ee27b453640cade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914393Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715357}

https://quiche.googlesource.com/quiche.git/+log/ac35d459a911..83f29bd6fa2b

$ git log ac35d459a..83f29bd6f --date=short --no-merges --format='%ad %ae %s'
2019-11-13 rch Change CryptoServerConfigForTesting to return a unique_ptr instead of an object because CryptoServerConfigForTesting has now copy constructor.
2019-11-12 bnc Signal QPACK dynamic table usage from quic_client_interop_test.
2019-11-11 renjietang Send correct STOP_SENDING/RESET_STREAM frames for different stream types.
2019-11-11 nharper gfe-relnote: Deprecate gfe2_reloadable_flag_quic_framer_doesnt_create_initial_encrypter
2019-11-11 renjietang Remove unnecessary code in QuicSpdySession.
2019-11-11 dschinazi Introduce QuicDatagramFlowId
2019-11-11 nharper Support resumption in quic_client_interop_test_bin
2019-11-11 renjietang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_coalesce_stream_frames. The flag is replaced by gfe2_restart_flag_quic_coalesce_stream_frames_2 and is no longer in use.
2019-11-11 renjietang Modify write_index_ advancement to incorporate coalescing stream frames.
2019-11-11 nharper gfe-relnote: Enable certificate verification on TLS resumption in QUIC, protected by reloadable flag quic_supports_tls_handshake
2019-11-11 nharper gfe-relnote: Add SessionCache to TlsClientHandshaker, protected by reloadable flag quic_supports_tls_handshake
2019-11-11 dschinazi Allow changing max_packet_size from QuicConfig
2019-11-11 wub gfe-relnote: (n/a) Add some log for QUIC bbr2 code. Logging only.
2019-11-11 bnc Remove QuicDispatcher::set_new_session_allowed_per_event_loop().
2019-11-11 ianswett Add a missing flag count for gfe2_reloadable_flag_quic_bbr_one_mss_conservation.
2019-11-11 ianswett Re-enable QuicPacketCreatorTest::ConsumeDataLargeSendAckTrue for versions with the invariant header.
2019-11-08 fayang gfe-relnote: In QUIC, close connection if CreateAndSerializeStreamFrame fails. Protected by gfe2_reloadable_flag_quic_close_connection_on_failed_consume_data_fast_path.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I5d54d00941b84ab5b89d8d9ec5324268ce1d7745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914967
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Auto-Submit: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715356}

Instead of inlining 3 different test suites in a single TEST_F, split
these test suites into separate files and run them as 3 different
tests.

This is in preparation for migrating bookmarks to Polymer 3, since the
main test file cannot be a module script, but the file(s) containing the
tests themselves will need to be module scripts in order to import from
the Polymer 3/modularized code.

Note: All these tests are currently disabled, but ran them locally
successfully on Linux (with optimize_webui =  true and false).

Bug: 1022213
Change-Id: Id388411fd9b7a58c058cd49260f6fbe9036201c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915620Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715355}

This reverts commit d2d106df.

This patch had a side-effect of enabling SurfaceControl on cast
devices which had a bug in how the Surface was initialized for
use in the GPU process.

R=shaktisahu@chromium.org,boliu@chromium.org
TBR=zmo@chromium.org

Bug: 1021797
Change-Id: I9ff4e19253260debe7369e1267c23725385555bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915288Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715354}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I9cb1dc34856cf9a936f592e5bd2ae9603f546ff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917300Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715353}

The authentication scheme handler for Basic has a mini parser for
realms. Add a fuzzer so that we have some fuzz coverage here.

R=mmenke@chromium.org

Bug: None
Change-Id: Icc9501d41f31ad82d6e04f0ed9f610afbc7091aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907153Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715352}

Bug: 1023853
Change-Id: Ie4c250b4193dac8872476a2e7a45075c923969bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917500
Auto-Submit: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Reviewed-by: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715351}

Calculating the current time does not alter any variables
that could affect the play state, The check may have been required
previously when the finished state of an animation was only being
updated in UpdateCurrentTimingState.

This patch also removes a superfluous check from currentTime. It
is not possible to be in an idle state while having start time.

Bug: 960944
Change-Id: I5e17c6a9b73400eb5358ae762f8d61d431818a50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914828
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715350}

QuicTransport is a low-level JavaScript interface to permit
communication via the QUIC protocol. This CL implements only the
connection and close parts of the API, along with unit tests.

Bug: 1011392
Change-Id: I7383680e04c83a45f483e5d542e9227f8288ed65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899631Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715349}

crrev.com/c/1900130 renamed //aw/apk to //aw/nonembedded, but there were
two //aw/apk references added in crrev.com/c/1904674 that I missed
during the merge. Everything still seemed to build because they're
behind a non-default build flag (webview_devui_show_icon).

Test: 'ninja -C out/aw system_webview_apk' with webview_devui_show_icon=true in args.gn
Bug: 934152
Change-Id: I0693a1abfeffa6a858fc0655ff3ad17627c6ef45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913598Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715348}

When the expanded toolbar height is updated while the page is scrolled
to the top, the top of the page will be obscured behind the toolbar.
Toolbar heights only change during trait collection updates, so the
page can be re-scrolled to the top after the trait collection is
finished updating if it was detected that it was scrolled to the top
when the update began.

Bug: 1017146
Change-Id: I1065cae2c1824e61a8688b845b88211013fa1949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914968
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715347}

Using wpt-import in Chromium e2486aeb.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"
88d98fda "Add more scroll to text WPTs"
788a3004 "Fix failing Fetch Metadata WPT"
b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
binji@chromium.org:
  external/wpt/wasm

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: Ie8ebf3e274e43fbe35cf465aacd13751fc8f67d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917080Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715346}

https://android.googlesource.com/platform/external/perfetto.git/+log/68ff3171f360..ccb4439237a9

git log 68ff3171f360..ccb4439237a9 --date=short --no-merges --format='%ad %ae %s'
2019-11-14 hjd@google.com Merge "traced_probes: Ignore ip field on print events"
2019-11-14 lalitm@google.com Merge "Update Vulkan memory tracker counters"
2019-11-14 lalitm@google.com trace_processor: add benchmarks for measuring sort performance

Created with:
  gclient setdep -r src/third_party/perfetto@ccb4439237a9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: chromium:135177627
Change-Id: I3783fa09941e7d0c0262af3cafb52a0f1da4f09b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916636Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715345}

Bug: 890539
Binary-Size: Increase needed to implement a feature; the added entry points are necessary to expose the functionality.
Change-Id: I34c435bb6f576ee47f478810918599eb5fc82513
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888732
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715344}

The test suite already instantiates a FieldTrialList as per
https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so
it's no longer necessary to do so explicitly in tests.

This patch addresses unit tests under:
/ios/chrome

This CL was uploaded by git cl split.

R=rohitrao@chromium.org

Bug: 1018667
Change-Id: I3ce32f0feaa2d652f5f4b8c68ae93e337e5e16be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916824
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715343}

Bug: 870813
Change-Id: I01b36a864a3c573bc5ef392f88180e27206fdeb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914961Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Salvador Guerrero <salg@google.com>
Cr-Commit-Position: refs/heads/master@{#715342}

Previously, we notify an AXTreeObserver of a node removed from AXTree
before the node is actually removed from the tree. In this change, we
notify an AXTreeObserver of a node removed from AXTree after the tree
is stable and its nodes have been updated.

Previously, when in AXTree::Unserialize and before tree modification
takes place, we call NotifyNodeWillBeReparentedOrDeleted on the node
to be deleted. AXTreeObserver/
BrowserAccessibilityManager::OnNodeWillBeDeleted removes its
reference to the AxNode's BrowserAccessibility object and destroy it
as well. This takes place before the actual ax node is deleted from
the tree. The subsequent action, also before tree modification, such
as a call to BrowserAccessibility::InternalGetFirstChild() will reveal
the inconsistent state--retrieving the child node from ax tree,
however when we query through
BrowserAccessibilityManager::id_wrapper_map_ for its
BrowserAccessibility, it is not found because it is deleted in the
prior action. This inconsistent state can cause a null dereferencing
in BrowserAccessibility::PlatformIsLeafIncludingIgnored for
role::kButton.

In the following scenario, a crash would occur.
AXTree:
kRootWebArea #1
++kButton #5
++++kCheckBox #2
++++kGenericContainer #3 IGNORED
++++++kStaticText #4 IGNORED

AXTreeUpdate:
1. remove node kCheckBox #2
2. remove subtree kGenericContainer #3 IGNORED
---
AXTree::Unserailize: {
  NotifyNodeWillBeReparentedOrDeleted(kCheckBox#2)
    OnNodeWillBeDeleted(kCheckBox#2)
      id_wrapper_map_.erase(kCheckBox#2)
      delete BrowserAccessibility of kCheckBox#2
  NotifySubTreeWillBeReparentedOrDeleted(#kGenericContainer#3)
    FireWinAccessibilityEvent(kGenericContainer#3)
      ...
      PlatformIsLeafIncludingIgnored(kButton#5)
        InternalGetFirstChild(kButton#5)
          GetUnignoredChildAtIndex(0) returns kCheckBox ax node
          id_wrapper_map.get(kCheckBox#2) -> null
        Dereferencing null, exception occurs.

  //--- then tree modification/ax node deletion happens --
}

Bug: 1020187
Change-Id: I8e83b3450ca6253e837f4854a1c90a4779b3d435
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907774
Commit-Queue: Victor Fei <vicfei@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Adam Ettenberger <adettenb@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#715341}

Bug: 1024881
Change-Id: Id1d4d38856591b85f753c797e46288bdaca724d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917466Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715340}

Bug: 1015473
Change-Id: Icc8101ef374a8b00d4d1ad6986dedaffcc54a6bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911882Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715339}

This was most recently reverted by
https://chromium-review.googlesource.com/c/chromium/src/+/1912704
due to failures on the MSan bot.

Bug: 999737, 706728
Change-Id: I8a8e423b3bfbd57ef7871a809071c992251f209e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915321
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715338}

Bug: 987646
Change-Id: I01c8a58a8f51d7aeee0a03d1eed0e3cd040ea941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902068
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715337}

AccelerometerReader's data reading blocks shutdown on certain
devices. Use CONTINUE_ON_SHUTDOWN to run it on a thread that
Chrome does not wait to join during shutdown.

Bug: 1023989
Change-Id: I4fdad845fd59b45f3dc58a28edea031e733d934a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916691Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715336}

The previous CL [1] does not work anymore due to the changes in Worker
infrastructure, so this CL changes ThreadCreationParams to fix the
issue.

ThreadCreationParams will check the thread type and assign the right
priority for the WebAudio operation.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1580221

Bug: 813825, 877978
Test: third_party/blink/renderer/modules/webaudio/audio_worklet_thread_test.cc
Change-Id: I9be6b2ccc37feaed22c2342391d5ef27388ef912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865013
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715335}

Bug: 1021681
Change-Id: I551f94a2d195a8235a2c5292dbae67ccae5089b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904494Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715334}

Bug: 1024318
Change-Id: Ia01b50058e4addd0ae9ce22a37ff37f8d8e384df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915096
Commit-Queue: Mila Green <milagreen@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715333}

When Getting format modifiers, exclude I915_FORMAT_MOD_Y*_TILED_CCS
(Intel color control surface (CCS) for render compression) if it's not
an internal display.
This solves the bandwidth issue when driving more than 1 4K monitor with
rbc enabled.

BUG=996011,996036,994341,979736
TEST=External display doesn't pick I915...CSS modifier

Change-Id: I9d7aa06f5f9331d232a3cbd7e74bd41771bc4030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912460
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715332}

Move Incognito-related methods from PrefServiceBridge to IncognitoUtils.

This is part of a larger change to limit PrefServiceBridge to only
feature-agnostic logic related to the native PrefService.

Bug: 1016957
Change-Id: I82622c38daa7ada27c648a978ad76dbfe7a9ecb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909957Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715331}

To allow other communication channels to ingest messages into the
sharing architecture, this CL extracts the handlers into a new class.
This class can then be called when a new message is received, to look
up the handler that should handle the message.

Bug: 1021980
Change-Id: I1f8c9af0e08a9bd6fd1a99954d28ff22fd902d09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906152
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715330}

This CL adds PATL blocking page strings and blocking page.

Bug: 1015661
Change-Id: I9641c94c0989b1d6335eff6b1ef4cb59bc002f37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895784
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715329}

This meta-target had a couple of transitive dependencies on dawn,
despite dawn not being available on cros. This change makes those
dependencies conditional on `use_dawn`.

Bug: None
Change-Id: I630e8786ab21510a2caee54a85034591a215981a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917380Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715328}

This reverts commit 57ee9cf0.

Reason for revert: Speculative revert for the failures on deterministic builds, e.g. https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/12654

Original change's description:
> views: Enable toolkit_views on Chromecast builds that use views
> 
> Chromecast uses views, but does not set toolkit_views=true. Set this to
> true & remove desktop-oriented code that breaks in this case.
> 
> This replaces !defined(OS_CHROMEOS) with a new
> BUILDFLAG(ENABLE_DESKTOP_AURA) flag as necessary throughout views.  This
> is needed because Chromecast doesn't use desktop_aura and uses aura
> similarly to Chrome OS by creating one WindowTreeHost for the display
> [alternative suggestions on how to handle this distinction welcome].
> 
> This does not enable views in content(_shell) yet. That's left to the
> next patch as it changes the UI.
> 
> As of this change, views_unittests passes in Chromecast Linux builds.
> 
> Bug: 1021770
> Test: views_unittests, content_browsertests on is_chromecast=true build
> 
> Change-Id: I54e79402a761572feb76f122ed846558e84210b6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907559
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Michael Spang <spang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#715183}

TBR=sky@chromium.org,spang@chromium.org,jam@chromium.org,dpranke@chromium.org

Change-Id: I17c9efdff45b51d3a215bccd3be9eb9418478de0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1021770
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917294Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715327}

https://dawn.googlesource.com/dawn.git/+log/321c12255e73..58dbfcae38f4

git log 321c12255e73..58dbfcae38f4 --date=short --no-merges --format='%ad %ae %s'
2019-11-14 rharrison@chromium.org Refactor ShaderModule creation to use a Builder pattern

Created with:
  gclient setdep -r src/third_party/dawn@58dbfcae38f4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: Ie5d65800a7d164c19d5632d1310964c1537473d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916635Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715326}

This makes ConfigureBubbleMenuItem public in bubble_menu_item_factory.h
and makes use of it in ExtensionsMenuButton's constructor.

Bug: chromium:943702
Change-Id: I4c28038b73b7ac8b7922da1ac5d348b60777082f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916690
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715325}

The test suite already instantiates a FieldTrialList as per
https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so
it's no longer necessary to do so explicitly in tests.

This patch addresses unit tests under:
/content/public/test

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 1018667
Change-Id: I71fc1531d779cc0d4d1b1cc7255b5a53f445e6eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916867
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715324}

This will then be used by the SaveCardInfobarCoordinator.

Bug: 1014652
Change-Id: I2b92f3e4b818bb3844e87c15371a364797d22aec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915819
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715323}

https://skia.googlesource.com/skia.git/+log/d04f123cc7ff..95f0b1673fe6

git log d04f123cc7ff..95f0b1673fe6 --date=short --no-merges --format='%ad %ae %s'
2019-11-14 egdaniel@google.com Miscellaneous updates to handle more vulkan creation failures.
2019-11-14 flar@google.com Only define SK_GL for Flutter on non-Fuchsia platforms.

Created with:
  gclient setdep -r src/third_party/skia@95f0b1673fe6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC halcanary@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=halcanary@google.com

Bug: None
Change-Id: Ie6ffb2a0b1c61b530f573210e05201b0122bcd8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916637Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715322}

Follow-up on CL:1913508. This moves window minimization done during
transition to home when overview exit starts after observers were
notified about overview start animations have been canceled
(as window hiding is actually part of overview exit).

BUG=1024107

Change-Id: I1b5a520b3ef38c8cf2d69f32ea54b5ea94bd7c0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915227Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715321}

A recent change (5f37444e) to GURL::PathForRequest
led to some crashes caused by URLPattern calling PathForRequest
with invalid URLs, which was explicitly prohibited with a DCHECK
prior to the change but, in release builds, had been silently
accepted.

This change makes URLPattern only call GURL::PathForRequest with
valid input, by failing URLPattern::MatchesURL on pathless inputs
prior to the call to PathForRequest.

Test: Added a regression test.

Bug: 1022771
Change-Id: I52896977b6474603d30cbea99ebb776eb3ccf308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906511
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715320}