Commits · da58a15fc2c5551180c5484128a0b45a302cca8f · eriksson monteiro / tangled

21 Nov, 2019 40 commits

Roll src/third_party/devtools-frontend/src c36744bff1ae..4da3b30c3879 (1 commits) · da58a15f

chromium-autoroll authored Nov 21, 2019

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c36744bff1ae..4da3b30c3879

git log c36744bff1ae..4da3b30c3879 --date=short --no-merges --format='%ad %ae %s'
2019-11-21 aerotwist@chromium.org Migrates css_overview/ to esm

Created with:
gclient setdep -r src/third_party/devtools-frontend/src@4da3b30c3879

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1006759
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib42dd6434e4f078178a6025be24f7cc981495f06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928138Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#717664}

da58a15f

Reland "[base] Remove base::SharedMemory and base::SharedMemoryHandle" · cf96655e

Alex Ilin authored Nov 21, 2019

This reverts commit 8c36510c.

Reason for revert: Added missing include on ChromeOS.

Original change's description:
> Revert "[base] Remove base::SharedMemory and base::SharedMemoryHandle"
> 
> This reverts commit fa7e8cc7.
> 
> Reason for revert: It looks like there was at least one missed instance of transitively including file_util. Sample build log: https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-google-rel/4373
> 
> Original change's description:
> > [base] Remove base::SharedMemory and base::SharedMemoryHandle
> > 
> > There are no users of the deprecated shared memory left, so its code
> > can safely removed.
> > 
> > To use shared memory in Chrome, please refer to
> > base::WritableSharedMemoryRegion and base::ReadOnlySharedMemoryRegion
> > classes.
> > 
> > This CL removes all remaining #includes of
> > "base/memory/shared_memory.h" and
> > "base/memory/shared_memory_handle.h". They are replaced by new shared
> > memory includes when needed.
> > 
> > It also appears that "base/files/file_util.h" and
> > "base/posix/eintr_wrapper.h" were transitively included in many places
> > through the removed files. This CL includes them explicitly in all
> > those files.
> > 
> > TBR: wfh@chromium.org
> > Bug: 795291
> > Change-Id: I97ecac4b529c0ad6498b6e5ccf01515f750448ad
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919152
> > Commit-Queue: Alex Ilin <alexilin@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#717588}
> 
> TBR=dcheng@chromium.org,jochen@chromium.org,alexilin@chromium.org
> 
> Change-Id: I16c6e4c2ada01240d577706478cf739ce1061ee5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 795291
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929252
> Reviewed-by: Tommy Martino <tmartino@chromium.org>
> Commit-Queue: Tommy Martino <tmartino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#717644}

TBR=dcheng@chromium.org,tmartino@chromium.org,jochen@chromium.org,alexilin@chromium.org

Change-Id: I437cf7f93965858840170eb49b2d611b37e79b25
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 795291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929221Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717663}

cf96655e

Reland "Disable failing tests on android-go_webview-perf" · 3fb77161

Eric Seckler authored Nov 21, 2019

This reverts commit 5d686312.

Reason for revert: turns out this was caused by a different patch afterall. 

Original change's description:
> Revert "Disable failing tests on android-go_webview-perf"
> 
> This reverts commit 7a502f46.
> 
> Reason for revert: patch that caused the failures was reverted
> 
> Original change's description:
> > Disable failing tests on android-go_webview-perf
> > 
> > Disabling the following tests on android-go_webview-perf:
> > * system_health.common_mobile/browse:media:youtube:2019
> > * system_health.common_mobile/browse:news:nytimes:2019
> > * system_health.common_mobile/browse:news:cnn:2018
> > 
> > TBR=crouleau@chromium.org
> > NOTRY=true
> > 
> > Bug: 1026822
> > Change-Id: I2581e3c21158edff2563de628bfa41de7349271d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927216
> > Reviewed-by: John Chen <johnchen@chromium.org>
> > Commit-Queue: John Chen <johnchen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#717272}
> 
> TBR=crouleau@chromium.org,johnchen@chromium.org
> 
> Change-Id: I0cf407e4ec8f3a44afa229c9fae82c064d9bb9a0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1026822
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928322
> Reviewed-by: Eric Seckler <eseckler@chromium.org>
> Commit-Queue: Eric Seckler <eseckler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#717618}

TBR=crouleau@chromium.org,eseckler@chromium.org,johnchen@chromium.org

Change-Id: I0c6f3f761c335df3463564ba84946735b552c713
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1026822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928557Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717662}

3fb77161

Roll src/third_party/angle bf492e4910bb..1898c08274eb (1 commits) · a9c4b9a4

chromium-autoroll authored Nov 21, 2019

https://chromium.googlesource.com/angle/angle.git/+log/bf492e4910bb..1898c08274eb

git log bf492e4910bb..1898c08274eb --date=short --no-merges --format='%ad %ae %s'
2019-11-21 jmadill@chromium.org Roll third_party/android_ndk/ 89e8db0cd..27c0a8d09 (1 commit)

Created with:
gclient setdep -r src/third_party/angle@1898c08274eb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=courtneygo@google.com

Bug: None
Change-Id: I9732fd4cc1eeb8af13ec755b3ce0b558bcff8bc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928134Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#717661}

a9c4b9a4

Roll src/third_party/skia b4f854080375..b184e9654d26 (1 commits) · e5403178

chromium-autoroll authored Nov 21, 2019

https://skia.googlesource.com/skia.git/+log/b4f854080375..b184e9654d26

git log b4f854080375..b184e9654d26 --date=short --no-merges --format='%ad %ae %s'
2019-11-21 egdaniel@google.com Update failure calls in GrVkMemory and shader creation.

Created with:
gclient setdep -r src/third_party/skia@b184e9654d26

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=robertphillips@google.com

Bug: None
Change-Id: I22328bc7f04f65073f39c0fe40028c5377017898
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928139Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#717660}

e5403178

[weblayer] Keep a reference to the remote class loader. · 1140d32f

Tobias Sargeant authored Nov 21, 2019

This allows us to support starting code loading earlier, as well as
supporting APIs that may not need or want to fully initialize WebLayer,
but just make use of Java code from the WebLayer provider.

Also clean up calls to getApplicationContext to ensure that they happen
at the public API surface rather than internally.

Bug: 1027076
Change-Id: I16d7ce196c680722981883ed7d2be463d482b801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928779Reviewed-by: Pavel Shmakov <pshmakov@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717659}

1140d32f

Roll src/third_party/chromite 26c7fb61a9db..10146cfca138 (1 commits) · f118d962

chromium-autoroll authored Nov 21, 2019

https://chromium.googlesource.com/chromiumos/chromite.git/+log/26c7fb61a9db..10146cfca138

git log 26c7fb61a9db..10146cfca138 --date=short --no-merges --format='%ad %ae %s'
2019-11-21 mmortensen@google.com BuildAPI: Add unit tests and mocks for Image Service.

Created with:
  gclient setdep -r src/third_party/chromite@10146cfca138

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I5b6b2987393ff50989a8835279d7ed9acccd6014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928133Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#717658}

f118d962

Add is_coalesced to latency info trace event · 198be902

Ella Ge authored Nov 21, 2019

Currently, when recording in devtool performance tab, it will draw all
events even though some GestureScrollUpdate are coalesced into others.
In that case, coalesced GSUs are terminated earlier, and the slice are
smaller than what it should be and meaningless (as it's not really been
handled)

This CL adds a is_coalesced bit to latencyInfo trace event data, it will
be used for filtering out unnecessary GSUs in devtool performance
panel(crrev.com/c/1928916).

Bug: 956681
Change-Id: I9d999dd86e54f2b75d0a2527a4ba0e39f0e6ce9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924311Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717657}

198be902

Roll src/third_party/perfetto d17a8eeb608a..235c2525d2c0 (7 commits) · abf81916

chromium-autoroll authored Nov 21, 2019

https://android.googlesource.com/platform/external/perfetto.git/+log/d17a8eeb608a..235c2525d2c0

git log d17a8eeb608a..235c2525d2c0 --date=short --no-merges --format='%ad %ae %s'
2019-11-21 fmayer@google.com Fix dep path.
2019-11-21 ilkos@google.com Add missing group by for clarity
2019-11-20 ilkos@google.com Merge "Improve process to package matching"
2019-11-20 rsavitski@google.com Merge "traced_perf: basic producer scaffolding with logging of samples on Flush."
2019-11-20 rsavitski@google.com Merge "traced_perf: trivial config proto (PerfEventConfig) for further development."
2019-11-20 treehugger-gerrit@google.com Merge "Fix bazel build"
2019-11-20 treehugger-gerrit@google.com Merge "Add parser for proguard maps."

Created with:
gclient setdep -r src/third_party/perfetto@235c2525d2c0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I9b760e5b8e8aca638ca767bdab8e4efb022c01b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928135Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#717656}

abf81916

Fix comment in SecurityTokenPinDialogHost · 0f28078e

Maksim Ivanov authored Nov 21, 2019

The comment was still referring to the old name of one of the methods,
before it got renamed.

Bug: none
Change-Id: I4f539546581e20d5c244da425a220e0f8db7875b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919145Reviewed-by: Igor <igorcov@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717655}

0f28078e

Add prefix to empty param tests. · 42d0f589

Ilia Samsonov authored Nov 21, 2019

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=pastarmovj@chromium.org

Bug: 1023677
Change-Id: I5fe629d2b7e3725a41a53d0be763dfd3b9086ede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927017
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717654}

42d0f589

WebRtcVideoTrackSource: Scale UpdateRect with the frame · 0f51bd1e

Ilya Nikolaevskiy authored Nov 21, 2019

Bug: webrtc:11058
Change-Id: I75b68535a33978206acdbb27908167d323822fd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926142
Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org>
Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717653}

0f51bd1e

ash: remove deps on DialogClientView · 62494f8f

Elly Fong-Jones authored Nov 21, 2019

Bug: 1011446
Change-Id: Idf440f08fdfaa8ce44d879487aeae9567f68eecb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925750Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717652}

62494f8f

Move FrameMsg_Collapse to mojo. · bd1f027e

Dave Tapuska authored Nov 21, 2019

Remove Collapse from the WebFrame interface and move it directly
to the LocalFrame/RemoteFrame interfaces.

BUG=1008432

Change-Id: Ib8a7ce13b76a9618e075e175db8649f0c8ed7b71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920479Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717651}

bd1f027e

Remove explicit conversion from std::string to CoreAccountId. · 8e7a16f3

Mihai Sardarescu authored Nov 21, 2019

This CL removes the explicit conversion from (and to) std::string and
CoreAccountId.

Bug: 959157

Change-Id: Ibfc5ca50bf595a089e63ed1462361cbe8a316001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926482Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717650}

8e7a16f3

Add feature flag 'EnterpriseReportingInChromeOS' · 05ec582a

Anqing Zhao authored Nov 21, 2019

Similar to the existing flag 'EnterpriseReportingInBrowser', the new
feature flag is used for similar functionality, uploading usage data from
Chrome OS to DM server.

Bug: 1010213
Change-Id: I53b2e20535fccd2dd357cde42660832f6359df61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926489Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Anqing Zhao <anqing@google.com>
Cr-Commit-Position: refs/heads/master@{#717649}

05ec582a

Refactor Tab Groups part 1 · 551bd223

Connie Wan authored Nov 21, 2019

Pulled out TabGroupModel and TabGroup from TabStripModel. See the comments in each class for how they're used. See also the TODOs in the comments for how this can be further improved in future CLs (working on this next).

The API in TabStripController still remains despite my best efforts to get rid of it. For now that seems better because I have to touch fewer things while refactoring. Eventually I'm interested in seeing how we can avoid duplicating APIs across models and controllers, which is a bigger philosophical question.

Change-Id: I96130622ab939de7d986c7e3dd1b19b476658f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915194Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717648}

551bd223

Move browsertests to ui/ for Sharing · 825b9883

Himanshu Jaju authored Nov 21, 2019

Moves all browsertests to ui/views/sharing to add UI checks
in browsertests.

Bug: 1015850
Change-Id: I64062a8e1d89898fce7e8a3902d1eb1ea4c48d45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928707Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717647}

825b9883

Temporarily skip web test · 0b51b8a4

Clemens Backes authored Nov 21, 2019

This test is failing after a v8 change, we need to investigate.

R=ahaas@chromium.org
CC=nicohartmann@chromium.org

Bug: chromium:1027131
Change-Id: Ie8968916a477f6e0e802927b76540dcfbba24c2c
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929236
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Auto-Submit: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717646}

0b51b8a4

Add navigation header check to referrer tests · 299f756e

David Van Cleve authored Nov 21, 2019

Currently, the referrer browsertests check the outgoing request's
headers on subresource requests but just use JS to check the outgoing
referrer on navigation requests. This patch expands the check to
navigation requests, too, in order to cover more of the navigation
logic.

This patch also
- adds a test covering browser-initiated navigations' referrers
- resolves a few linter complaints (reset -> make_unique; default
constructors)

Change-Id: I804ca43632b881878df63cad33ffaf94b5db6741
Bug: 1021277
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924871Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717645}

299f756e

Revert "[base] Remove base::SharedMemory and base::SharedMemoryHandle" · 8c36510c

Tommy Martino authored Nov 21, 2019

This reverts commit fa7e8cc7.

Reason for revert: It looks like there was at least one missed instance of transitively including file_util. Sample build log: https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-google-rel/4373

Original change's description:
> [base] Remove base::SharedMemory and base::SharedMemoryHandle
> 
> There are no users of the deprecated shared memory left, so its code
> can safely removed.
> 
> To use shared memory in Chrome, please refer to
> base::WritableSharedMemoryRegion and base::ReadOnlySharedMemoryRegion
> classes.
> 
> This CL removes all remaining #includes of
> "base/memory/shared_memory.h" and
> "base/memory/shared_memory_handle.h". They are replaced by new shared
> memory includes when needed.
> 
> It also appears that "base/files/file_util.h" and
> "base/posix/eintr_wrapper.h" were transitively included in many places
> through the removed files. This CL includes them explicitly in all
> those files.
> 
> TBR: wfh@chromium.org
> Bug: 795291
> Change-Id: I97ecac4b529c0ad6498b6e5ccf01515f750448ad
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919152
> Commit-Queue: Alex Ilin <alexilin@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#717588}

TBR=dcheng@chromium.org,jochen@chromium.org,alexilin@chromium.org

Change-Id: I16c6e4c2ada01240d577706478cf739ce1061ee5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 795291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929252Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717644}

8c36510c

Move some animation interface from SVGSMILElement to subclasses · 6c7a793d

Fredrik Söderquist authored Nov 21, 2019

This moves the "animation interface", i.e the methods:

  ResetAnimatedType(),
  ClearAnimatedType(),
  ApplyResultsToTarget(),
  OverwritesUnderlyingAnimationValue() and
  UpdateAnimation()

From SVGSMILElement to SVGAnimationElement.
This means that we can make the SMILAnimationSandwich only care
about SVGAnimationElements which is slightly more logical.
The |attribute_name_| field is also moved to more logical place, namely
SVGAnimateElement.

Bug: 1017723
Change-Id: I870cca66b44d42288b40cb5d09cd06c04160420d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928775Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#717643}

6c7a793d

Build ssl_blocking_page_unittest.cc · 9a085676

Colin Blundell authored Nov 21, 2019

This test currently isn't being built and has bitrotted. This CL adds
it to the build and gets it to build. It also doesn't pass, which this
CL doesn't attempt to fix (see linked bug).

Bug: 1026557
Change-Id: I66ecc1e5344047092d7ed0f30963c44cec796950
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925057
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717642}

9a085676

Migrate PasswordCSVWriter test off of CSVReader · b4801041

Vaclav Brozek authored Nov 21, 2019

Currently the PasswordCSVWriter test uses CSVReader to check
serializations of passwords into CSV, the result of the tested code.

However, CSVReader will be soon removed together with its main client,
the PasswordCSVReader.

This CL replaces CSVReader use in PasswordCSVWriter test with the
replacement of PasswordCSVReader: the CSVPasswordSequence. This has an
additional benefit: CSVPasswordSequence both decodes CSV and
constructs a PasswordForm out of it, unlike CSVReader, which only does
the former. Therefore, the test must no longer include implementation
details of PasswordCSVWriter, and can instead just verify that
PasswordCSVWriter is the reverse operation of CSVPasswordSequence.

Bug: 934326
Change-Id: If010b42c7c46dd1ece8f6ef96e85eddbd49d09e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920122
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717641}

b4801041

Import wpt@7ea79b941fac41835b88006b20026c0c54868613 · 6fbac7d0

Chromium WPT Sync authored Nov 21, 2019

Using wpt-import in Chromium 678859e4.
With Chromium commits locally applied on WPT:
e83dd93c "Limit backtracking on regexp called from blink."
500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Id4f0c44fce11b9547b5b9b601bf68eaee2ab4d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929151Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#717640}

6fbac7d0

[tools/perf] Fix links to local traces in traceUrls diagnostic · ff3792e9

Mikhail Khokhlov authored Nov 21, 2019

Bug: 1027074
Change-Id: I077c164aaa59ee6644f9f05ee61a26944d6a23c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928701
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717639}

ff3792e9

[arraybuffer] Clean up typed_array.h · 58d83b49

Andreas Haas authored Nov 21, 2019

1) Remove stale comments.
2) Remove an unnecessary implementation of GetType().
3) Add stub bodies for instances of Set() that should not be called.
   * Unfortunately I couldn't find a way to prevent calls to these
     functions at compile time.

R=haraken@chromium.org

Bug: chromium:1008840
Change-Id: Id54bf83656e846670a9c6b249fdf62d64733003e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928785Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717638}

58d83b49

Factor WebRtcSessionDescriptionPrivate out of web_rtc_session_description.cc · 9d6819cb

Antonio Gomes authored Nov 21, 2019

... and rename it to RtcSessionDescriptionPlatform.

This is a preparation step to using RtcSessionDescriptionPlatform
instead of WebRtcSessionDescription throughout the code, and eliminate
the later altogether.

The object will back the modules/peerconnection counterpart
RtcSessionDescription.

BUG=787254
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I8f1aaaeb01b12f2b4c65d98da0730b7e5be0868b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925068Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#717637}

9d6819cb

Remove ContentRendererClient::CreateMediaStreamRendererFactory(). · d5505900

Guido Urdaneta authored Nov 21, 2019

Bug: 704136
Change-Id: I243aaaad02bf864251b036079ff85bce0a38b452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911740
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717636}

d5505900

Add prefix to empty param tests. · c6c84a6e

Ilia Samsonov authored Nov 21, 2019

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=drott@chromium.org

Bug: 1023677
Change-Id: I6bd105c97a1d0a6e0c9071cd172d7fcf24073b68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926883
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717635}

c6c84a6e

Roll src/third_party/devtools-frontend/src 7fa83680ccbb..c36744bff1ae (3 commits) · 1040695b

chromium-autoroll authored Nov 21, 2019

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7fa83680ccbb..c36744bff1ae

git log 7fa83680ccbb..c36744bff1ae --date=short --no-merges --format='%ad %ae %s'
2019-11-21 hablich@chromium.org [Docs] Add information on release management
2019-11-21 hablich@chromium.org [Docs] Add information on how to merge
2019-11-21 aerotwist@chromium.org Migrates coverage/ to esm

Created with:
gclient setdep -r src/third_party/devtools-frontend/src@c36744bff1ae

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1021467,chromium:1021467,chromium:1006759
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I9bbf651b91f4744d8eb3a20899f86e82aee82951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928169Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#717634}

1040695b

base/strings: Add more WARN_UNUSED_RESULTs · ee4707cb

David Van Cleve authored Nov 21, 2019

This adds WARN_UNUSED_RESULT to some methods in //base/strings
whose primary purpose is to return something useful (e.g. StrCat).
When the results of these methods go unused, it's usually caller error
and will be found by the caller later (for instance, when their tests
fail). WARN_UNUSED_RESULT makes this fail earlier, at compile time.

Precedent: Abseil's StrCat, etc., all use ABSL_MUST_USE_RESULT.
Change-Id: I8262b03bd844118c7337861f323417c2bb92ddda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925251Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717633}

ee4707cb

Add prefix to empty param tests. · 41fbcd6e

Ilia Samsonov authored Nov 21, 2019

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=kinuko@chromium.org

Bug: 1023677
Change-Id: I5402fab8e9fb1e50fa3f765f956f22feb57f62f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926802
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717632}

41fbcd6e

Reland: Suppress beforeunload and in-progress download prompts for forced restarts. · f9928d98

Greg Thompson authored Nov 21, 2019

This change introduces RelaunchIgnoreUnloadHandlers and uses it in
RelaunchNotificationController when the deadline for a forced relaunch
is reached. This new function is to AttemptRelaunch as
ExitIgnoreUnloadHandlers is to AttemptExit.

This also introduces browser_shutdown::ShouldIgnoreUnloadHandlers(),
which is a convenience for code that needs to know whether or not an
in-progress shutdown should ignore unload handlers.

(cherry picked from commit 2c98cab9)

BUG=958865
TBR=treib@chromium.org

Change-Id: I291543b924d7b249093297a952ffa5c48f5343fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924197
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717631}

f9928d98

Roll Fuchsia SDK from 889621105264 to 889618158459 · c8361697

chromium-autoroll authored Nov 21, 2019

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I9754ff5ac01931763d75e010459e6480f9d22e23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929133Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#717630}

c8361697

[cleanup] Remove unused ui::Compositor::SetLatencyInfo() · 4e59c58f

Mohsen Izadi authored Nov 21, 2019

Last usage of ui::Compositor::SetLatencyInfo() was removed in r564765.

Change-Id: I0f93e7bc5e5473040dc3e4c82dcf42cbded28daa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925817
Commit-Queue: kylechar <kylechar@chromium.org>
Auto-Submit: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717629}

4e59c58f

Roll src/third_party/dawn 4d15609d269e..0d4a7b0ba5b7 (1 commits) · 5f8084f8

chromium-autoroll authored Nov 21, 2019

https://dawn.googlesource.com/dawn.git/+log/4d15609d269e..0d4a7b0ba5b7

git log 4d15609d269e..0d4a7b0ba5b7 --date=short --no-merges --format='%ad %ae %s'
2019-11-21 cwallez@chromium.org Correctly reset mappedData in MapTwice buffer test

Created with:
gclient setdep -r src/third_party/dawn@0d4a7b0ba5b7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: I47b25a9ad7e72b89ce4afe64b1c000d905c1fc26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929131Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#717628}

5f8084f8

Roll src/third_party/webrtc 6dd488b2e551..e835fc01b1a9 (8 commits) · 5ed17a12

chromium-autoroll authored Nov 21, 2019

https://webrtc.googlesource.com/src.git/+log/6dd488b2e551..e835fc01b1a9

git log 6dd488b2e551..e835fc01b1a9 --date=short --no-merges --format='%ad %ae %s'
2019-11-21 henrik.lundin@webrtc.org Add UMA counter for audio interruptions
2019-11-21 titovartem@google.com Fix writing into closed FrameWriter when dumping video in PC framework
2019-11-21 mbonadei@webrtc.org Remove dependencies on Chromium's webrtc_overrides.
2019-11-20 mbonadei@webrtc.org Preventively fix missing braces warnings.
2019-11-20 jonaso@webrtc.org Split P2PTransportChannel
2019-11-20 kuddai@webrtc.org Add absolute capture time property to rtp sources.
2019-11-20 henrika@webrtc.org Clarifies identification of default communication device in ADM2
2019-11-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8b5b046f..022da7ca (715044:716991)

Created with:
gclient setdep -r src/third_party/webrtc@e835fc01b1a9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None,chromium:None
Change-Id: If0b5bf82f2aabf584ff25d8be29548f267373265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929132Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#717627}

5ed17a12

[signin] Delete ForceDiceMigration feature · b20bc395

David Roger authored Nov 21, 2019

This is now enabled by default and can be removed.

TBR=jwd

Bug: 777774
Change-Id: I6a77e9c160553ea4361be7794ae5a09b7f8f83b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919931
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Auto-Submit: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717626}

b20bc395

webauthn: support requests in cross-origin iframes. · cb3122f1

Ken Buchanan authored Nov 21, 2019

By supporting the “publickey-credentials” feature policy[1][2],
registrations and assertions can now be obtained in cross-origin
iframes if the parent frame explicitly delegates that authority.

This is gated on a feature flag in order that the UX can be updated
prior to this being generally available.

[1] https://w3c.github.io/webauthn/#sctn-iframe-guidance
[2] https://w3c.github.io/webauthn/#sctn-feature-policy

Change-Id: I188731cdc65079ecf287fb62b264b69afe2f3229
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725211Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717625}

cb3122f1