- 08 Mar, 2018 40 commits
-
-
Sasha Morrissey authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4b0931917ec864739843a72d7de2dd430362db93 Reviewed-on: https://chromium-review.googlesource.com/952803Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#541708}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c29602466dc2..53014653d8eb $ git log c29602466..53014653d --date=short --no-merges --format='%ad %ae %s' 2018-03-07 ehmaldonado gclient: Give priority to URL over paths when specifying revisions. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic2f3f206a74848933a49ec124de4f28ab862f560 Reviewed-on: https://chromium-review.googlesource.com/953974 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541707}
-
Megumi Hattori authored
MessageCenterScrollView need not be focused. This CL also fixes a bug, tab focus missing on the UI. BUG=807534 TEST=manual Change-Id: I5427e84c49c2bbfbfa90944c334ffa5aa805d8d9 Reviewed-on: https://chromium-review.googlesource.com/946068Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Megumi Hattori <megumihattori@google.com> Cr-Commit-Position: refs/heads/master@{#541706}
-
Tommy C. Li authored
Per pkasting@ sugestion, DeleteAtEnd is dead code and can be deleted. TBR=jdonnelly@chromium.org Bug: NONE Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie1149a3f7b2aecd88252eeda7ff366e9504249da Reviewed-on: https://chromium-review.googlesource.com/954222 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#541705}
-
Ken Rockot authored
This test is timing out on Windows debug, where even on very fast devices it can take 35+ seconds to run. The runtime grows linearly with the size of the test message used, so this cuts that size to one tenth (512 kB instead of 5 MB). TBR=jcivelli@chromium.org Bug: 819046 Change-Id: Ib4598981856566dc8ae54de1060840b52e30b959 Reviewed-on: https://chromium-review.googlesource.com/954045Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#541704}
-
tzik authored
This updates //chrome/browser/extensions/activity_log to use base::OnceCallback instead of legacy base::Callback. No intended functional change is included. This reduces the number of 'base::Bind' in //chrome/browser/extensions/activity_log from 69 to 0 as tracked at http://goo.gl/LUVhDj Bug: 714018 Change-Id: I4fe44c7fada907f3a1c70971067c29f0d5492e8f Reviewed-on: https://chromium-review.googlesource.com/952953 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541703}
-
Shuotao Gao authored
TBR=penghuang@chromium.org Bug: 819778 Change-Id: I23e847c1bd5b1b3ffffb1679fd91bb67d36ec16d Reviewed-on: https://chromium-review.googlesource.com/954017Reviewed-by:
Shuotao Gao <stgao@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#541702}
-
Xing Liu authored
Currently we do a disk IO and network IO with large chunk of memory in ParallelDownloadTest, which cause stack underflow issues on certain platform. This CL fixed the disk IO by writing to file with 64KB buffer. The tests will be enabled after the network IO part is fixed. Bug: 817801 Change-Id: I49431cf0b66dc76ed893217126f189bb44f2e839 Reviewed-on: https://chromium-review.googlesource.com/952763Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#541701}
-
Kenneth Russell authored
BUG=chromium:811811 BUG=chromium:811905 BUG=chromium:811815 BUG=chromium:811796 BUG=chromium:811831 BUG=chromium:811789 BUG=chromium:811809 BUG=chromium:811821 BUG=chromium:811869 BUG=chromium:811866 BUG=chromium:811781 BUG=chromium:811799 BUG=chromium:811814 BUG=chromium:811864 BUG=chromium:811835 BUG=chromium:811834 TBR=estaab@chromium.org Change-Id: I8ddae02f706affb0198d12835baa421b74e8e462 Reviewed-on: https://chromium-review.googlesource.com/954416 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#541700}
-
Sorin Jianu authored
Bug: 819803 Change-Id: Ie40504523f779c3fcb1063f68445222aef837126 Reviewed-on: https://chromium-review.googlesource.com/953593 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#541699}
-
Emircan Uysaler authored
This test creates a WebRTC peer connection between two tabs and measures the trace events added on the tab receiving remote video. It does connection with different codecs to create the different scenarios of HW decode(texture) and SW decode(memory). Based on these events, it provides stats about the lifetime of a video frame that is played in a MediaStream backed <video> tag. The plan is to run this test on WebRTC Chromium bots and make it available for other projects that are very sensitive about display latency. Bug: 818352 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I023bea19c9e2271d153f1062d0ec73624c96148b Reviewed-on: https://chromium-review.googlesource.com/947418Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#541698}
-
tzik authored
This updates //rlz to use base::OnceCallback instead of legacy base::Callback. No intended functional change is included. This reduces the number of 'base::Bind' in //rlz from 3 to 0, as tracked at http://goo.gl/LUVhDj Bug: 714018 Change-Id: I4a016a47acfae635ff4ed0c3b2f22c0ca62b8f5c Reviewed-on: https://chromium-review.googlesource.com/952729Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#541697}
-
Michael Spang authored
Make each buffer management object responsible for holding a ClientNativePixmapFactory, removing the need for a global one. This simplifies a number of initialization and ownership scenarios. This makes it impossible for MUS to race to initialize the object, since each object that needs it will have its own (sharing the factory globally is not actually necessary). To make this work, this moves GpuMemoryBufferImpl factory to a new object GpuMemoryBufferSupport, since the majority of objects which should own a ClientNativePixmapFactory used it via GpuMemoryBufferImpl::Create(). Bug: 807781 Test: browser_tests Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icde20b247905555e80767b8c3eb77af6be9bbce1 Reviewed-on: https://chromium-review.googlesource.com/899949 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#541696}
-
Dmitry Gozman authored
This will make it easier to support multiple models in PerformanceMonitor. Bug: none Change-Id: I7ea678fba1e4f634cd26ef05638cac2a8ec3414b Reviewed-on: https://chromium-review.googlesource.com/953713Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#541695}
-
Pavel Feldman authored
Change-Id: I00e8c2f3a14e6adec6a85ccff2d68adcf41f1d6a Reviewed-on: https://chromium-review.googlesource.com/953964Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#541694}
-
Adam Langley authored
These are probably no longer useful. BUG=782084,771030,753209,722663,673605,673603,619807 Change-Id: Ic302e42508386ea7a4a01d937509a6ab29711ed1 Reviewed-on: https://chromium-review.googlesource.com/953482Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#541693}
-
Giovanni Ortuño Urquidi authored
Introduces BookmarkAppNavigationThrottle to handle out-of-scope navigations in app windows and puts BookmarkAppExperimentalNavigationThrottle behind kDesktopPWAsLinkCapturing. Changes kDesktopPWAsLinkCapturing to be on by default, so there should be no change in behavior for users. A follow up patch will change kDesktopPWAsLinkCapturing to be off by default. BookmarkAppNavigationThrottle and BookmarkAppExperimentalNavigationThrottle share some functionality that has been extracted into bookmark_app_navigation_throttle_utils.h [1] Specify that throttle and tests are for experimental feature (https://crrev.com/c/940824) [2] Extract tests that should run when link capturing is off (https://crrev.com/c/939883) [3] Handle out-of-scope navigations and stop link capturing by default (this patch) [4] Disable link capturing by default (https://crrev.com/c/950484) Bug: 814102 Change-Id: I7d394899d85922fce9e51831bf8705e31d8a53bf Reviewed-on: https://chromium-review.googlesource.com/942597Reviewed-by:Ben Wells <benwells@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#541692}
-
Nico Weber authored
Standard C++ doesn't allow implicit conversion between function pointers and void*. MSVC does allow that, so clang-cl also allows it but emits a -Wmicrosoft-cast warning. We want to enable this warning to make the compiler behave more similar on different platforms, so add an explicit cast to void*. Bug: 550065 Change-Id: Ib370ef07bf5f2df00814aa063833486e30ecde6f Reviewed-on: https://chromium-review.googlesource.com/954202Reviewed-by:
-
Sammie Quon authored
Animations into overview has changed so that non visible windows do not need to animation. Previous rounded edges code relied on animation end to apply mask, this cl applies mask to all cases, and removes before animations, and reapplies after animation. Test: ash_unittests WindowSelectorTest.RoundedEdgeMaskVisibility Bug: 817860 Change-Id: I9da0e2a56e991a7c3073a4c2c0de79d8e3799915 Reviewed-on: https://chromium-review.googlesource.com/953135Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#541690}
-
wutao authored
WindowGrid::PositionWindows is called at multiple places to animate windows in overview mode. Reset the should_animate_when_entering_ flag in order to animate in other situations. Bug: 817888 Test: WindowSelectorTest.WindowItemCanAnimateOnDragRelease Change-Id: I14a773033982c47823e6a0e331b7b8df4baa1791 Reviewed-on: https://chromium-review.googlesource.com/952671 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#541689}
-
Becky Zhou authored
+ Using material icon for expand/collapse + Remove 10dp top padding from header view Bug: 818368 Change-Id: I7d9318e1a8c9b1edcf7b51aa9e4804eb82f38ea9 Reviewed-on: https://chromium-review.googlesource.com/952542Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#541688}
-
Sunny Sachanandani authored
This broke because the direct composition path doesn't use swap interval set by eglSwapInterval in ANGLE. Since we only care about disabling via command line, it's ok to just handle that instead of SetSwapInterval. This will still not work when we use a direct composition surface instead of swap chain but that only happens when we use overlays. There may be no way to make this case work since the swap chain is not controlled by Chrome. Tested with vsynctester.com on my home desktop. R=kbr,piman BUG=480361,787485 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ife5804b4e9bcede41bb29cd01e54e81f0d278b62 Reviewed-on: https://chromium-review.googlesource.com/954020Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Jeffrey Kardatzke authored
This is for automated testing. During testing, we need to automatically click on approval in the permissions dialog. This allows Android to have a mechanism by which it calls into Chrome and requests that it accepts the permission. This is ONLY allowed when the build is of type 'testimage'. This then allows the automatic test to proceed. It also disables showing the notification that screen capture is activate since during Android testing that is also not expected to be part of the screen. Bug: b:38452042, b:73045468 Test: CTS tests pass now Change-Id: I87d46b1d4859e3fe6b1b034e6a020ceafc9b7357 Reviewed-on: https://chromium-review.googlesource.com/909299 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#541686}
-
Han Leon authored
As opposed to WebKit/public/mojom:mojom_platform, the gn target WebKit/public/mojom:mojom includes mojom interfaces which do use types that are typemapped to a type in Source/core, and its C++ bindings for Blink variant is embedded inside blink_core component. So, to avoid any confusion, this CL renames it to WebKit/public/mojom:mojom_core to announce explicitly the close relationship with Source/core. BUG= Change-Id: I3a9e68e8f7da5bf0c085d11e9a8cbd273247c638 Reviewed-on: https://chromium-review.googlesource.com/952113Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#541685}
-
David Tseng authored
Rich editables should be skipped entirely (and not fall through to output). Original change: - value change events often fire on richly editable text fields. We do not really use this in the state machine for rich text, so ignore it. It often causes poor state transitions e.g. speaking "deleted" in crosh when typing. - use the AutomationRichEditableText class in more cases. This acknowledges the usage in the wild where a page author can set role textbox on any node. When they do this it is assumed they manage a DOM selection unless they set the role on either an input or textarea where the browser does this on their behalf. TBR=dmazzoni@chromium.org, dtseng@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If555f157a7eeafe836929e9433891b2e7ae181df Reviewed-on: https://chromium-review.googlesource.com/953980 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#541684}
-
Ken MacKay authored
This fixes DSCP flags for dual-stack IPv6 sockets (ie, IPv6 sockets that can also send/receive IPv4 packets). Otherwise, the DSCP flags are not set correctly when sending to IPv4 destinations. Test: set DSCP flags, observe set packet flags with tcpdump. Change-Id: I83619dfc44b764bfeab069e09e0026369882f1bb Reviewed-on: https://chromium-review.googlesource.com/953341Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#541683}
-
Nico Weber authored
Standard C++ forbids implicit conversion of function pointers to void*, so logging a function pointer to a stream normally picks the operator<<(bool) overload of the stream and prints '1' in practice. MSVC allows implicit conversion of function pointers to void*, so there the function's address is printed instead. This change makes behavior consistent between MSVC and non-MSVC. On Windows, clang-cl emulates MSVC behavior but emits a -Wmicrosoft-cast warning, so this change also allows building ui/gl with -Wmicrosoft-cast enabled. Also add a few comments ot the log parameter transform code and order the special types alphabetically. Bug: 550065 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I78e25467bfb069bf84216ded00ab20450b98ea40 Reviewed-on: https://chromium-review.googlesource.com/953385Reviewed-by:
-
Kent Tamura authored
Bug: 578345 Change-Id: I8b3013add389ea5ee5bce31e39b49284a1ab57ba Reviewed-on: https://chromium-review.googlesource.com/952743Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#541681}
-
rajendrant authored
Bug: 818520 Change-Id: I6a5c98239f05caf3499ac6eb5de520160ae1bed0 Reviewed-on: https://chromium-review.googlesource.com/953202Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
lgcheng authored
Stores and restores persistent USB permission with Chrome prefs. Bug: 776476 Bug: b:24572867 Change-Id: I008166a32d47cba2edbdc54858b807491add6858 Reviewed-on: https://chromium-review.googlesource.com/944249 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#541679}
-
Koji Ishii authored
This is a cleanup refactoring without behavior changes. Line box fragment used to use line height as its height, and that when NGContainerFragmentBuilder was introduced as the super class of NGFragmentBuilder and NGLineBoxFragmentBuilder, Size() became virtual function. Currently, line box fragments includes floats in its height under some conditions, and that the block size of the line box fragment may be different from line height, but Size() still returns line height. This patch cleans this up, and make Size() always return the fragment size. Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I3f01b2c8810923fe64e1abb81d6af2c33f40bd4a Reviewed-on: https://chromium-review.googlesource.com/953026Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#541678}
-
Pete Williamson authored
Since it is used by both downloads and offline_pages, moving it to a common namespace and directory Bug: 814492 Change-Id: I8781730c3025087ff0ab0a5473f1ae4231dbf775 Reviewed-on: https://chromium-review.googlesource.com/939701 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Joy Ming <jming@chromium.org> Reviewed-by:
-
Weidong Guo authored
After screen magnification is enabled/disabled, the preferences for the active profile have not been updated when the cursor compositing is being updated. Use MagnificationController::IsEnabled() instead. BUG=814634 Change-Id: Id72c579bd3395ae2e9748858622df37086bc4220 Reviewed-on: https://chromium-review.googlesource.com/951639Reviewed-by:
-
Ryan Sturm authored
Change-Id: I3c861fa6a83c862cfacef9393c64c23153eb72ba Reviewed-on: https://chromium-review.googlesource.com/954243Reviewed-by:
-
Aaron Leventhal authored
When a download starts or finishes, notify screen reader users with a friendly message that contains useful information such as the size and name of the file to be downloaded. In addition, for long downloads, provide screen reader update notifications every 30 seconds, and include the time or % remaining. Bug: 787139 Change-Id: I903dd626fddad16504079c69d4e1f3edd88d8052 Reviewed-on: https://chromium-review.googlesource.com/947769 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#541674}
-
Peter Kotwicz authored
This CL refactors ReplacePlaceholders() to make it clearer that only placeholders in the url_template query and fragment are replaced. BUG=694380, 788191 Change-Id: I62672ae9e8386ef53ff532cf20a0d312fcba600f Reviewed-on: https://chromium-review.googlesource.com/925648 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Made GestureListenerManager a bit more responsible and take over update using the frame metadata from renderer. GestureListenerManager was already handling scroll/scale limit changed through frame metadata update, which I believe gives justification to the refactoring. This also helps reduce the layering-violating reference to ContentViewCore from RenderWidgetHostViewAndroid. Bug: 626765 Change-Id: Iaa63e2ccd2e3e3b87c8c06b140ff93687f6601a1 Reviewed-on: https://chromium-review.googlesource.com/950526 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#541672}
-
Shuotao Gao authored
TBR=penghuang@chromium.org Bug: 819851 Change-Id: I79a372df597d64d4a0d1e5294c4f961e79e2d9f9 Reviewed-on: https://chromium-review.googlesource.com/954288Reviewed-by:
-
Ian Vollick authored
We have plumbed knowledge to blink that we are in immersive mode, but a spot was missed: when the preferences are updated, we failed to poll whether we were in immersive mode. The result is that we would often clobber the immersive mode setting. Bug: 817412 Change-Id: I402346a43d3d2214475d93a14208a92cfedfa00d Reviewed-on: https://chromium-review.googlesource.com/953168Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#541670}
-
John Z Wu authored
This is in preparation for a FakeWebViewTranslateClient so unit tests can be written for the rest of the public methods. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7bb15cf38467b5a2b388fee7849599c1876ffa6c Reviewed-on: https://chromium-review.googlesource.com/953824Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#541669}
-
