GitLab

This reverts commit da531d49.

Reason for revert: I think this is the source of tast failures on the waterfall. See https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/29675 for one. I think the issue is that it looks like tast tests have hard coded the string to search for, and since you're renaming it the string is no longer found:
https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/platform/tast-tests/src/chromiumos/tast/local/crostini/ui/settings/settings.go;l=52?q=tast-tests%20Linux%20(Beta)&ss=chromiumos%2Fchromiumos%2Fcodesearch:src%2Fplatform%2Ftast-tests%2F

Original change's description:
> Crostini settings string changes.
>
> Instead of "Linux (Beta)", now shows as "Developers"
>
> Bug: 1140370
> Change-Id: Id4e076b5d918e41e22e5c59d65958da9e75a3f55
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486528
> Commit-Queue: Nicholas Verne <nverne@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Reviewed-by: David Munro <davidmunro@google.com>
> Auto-Submit: Nicholas Verne <nverne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#820205}

TBR=khorimoto@chromium.org,nverne@chromium.org,davidmunro@google.com

Change-Id: I6aa9216749d2d175b145821bf514c1642496e0e0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1140370
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495327Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820262}

This change introduces a new UKM for counting navigation redirects in
the pop up tracker. Redirects are commonly used for navigaing abusive
pop-ups to ad content from elements not tagged as ads by the ad
tagging framework. Using redirect counts as a new filter will help
us refine our abusive popup identification.

BUG=1044601

Change-Id: I68ad28a1b2965a8c1e844ec06eb42b487c6ef717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438669Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Justin Miron <justinmiron@google.com>
Cr-Commit-Position: refs/heads/master@{#820261}

Using matchers (instead of multiple, simpler expectations) is more
declarative, less repetitive, and allows the test to give better error
messages in case of failure. In this test in particular, the matchers
allow us to avoid crashing the test if `secure_dns_config.servers()`
contains the wrong number of elements; and allows us to delete the
`ContainsSubstring` helper.

Change-Id: Ia0f274bbe19a009e7cefbea43ff7fb33c31463be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488220
Commit-Queue: Chris Fredrickson <cfredric@google.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Auto-Submit: Chris Fredrickson <cfredric@google.com>
Cr-Commit-Position: refs/heads/master@{#820260}

base::Bind and base::Callback are deprecated and should be replaced with
the more explicit base::Bind{Once,Repeating} and
base::{Once,Repeating}Callback.

Bug: 1141533, 1007642
Change-Id: Iae0a64868e4e63743cf5743b1c1f897260059078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492561Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820259}

After recent cleanups, this method did nothing except maintain
|associated_types_| - which itself wasn't used at all, except for some
DCHECKs, so it's removed now as well.
While we're here, also remove ModelAssociationManager::state_ which
wasn't used (or useful) either anymore.

Bug: 1102837
Change-Id: Id62edd0f4be324fd4449dfd16e2a98530ee0c3d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494867Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820258}

This rolls up to sha d004bddde373550fe9a563487adda3e17fc4c697

Bug: None
Change-Id: I7b92df20ea3462512ff1978a766cf84a09d9e358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480143
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820257}

When the render thread encounters GPU context lost, we need to re-create
the SharedImage resources to recover the video capture stream.

This is a reland of crrev.com/c/2455328 with a fix to address the MSAN
test failure

Bug: 1131998, b:169429427
Test: Manually with chrome://gpuclean on soraka

TBR=jcliang@chromium.org,ccameron@chromium.org,kbr@chromium.org,dcastagna@chromium.org,guidou@chromium.org,ccameron@google.com

Change-Id: I872a06a37dbce1eefadf6b0f256b80d0f87ecac0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494297Reviewed-by: Ricky Liang <jcliang@chromium.org>
Commit-Queue: Ricky Liang <jcliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820256}

This relands [1] but removing the test
RegisterProtocolHandlerAndServiceWorkerInterceptor.DoNotRegisterFetchListener
which is flaky on mac and not essential for testing the bug fix.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2379672

Original change's description:
> [Sheriff] Revert "Make custom protocol handlers work with service workers' fetch event"
>
> This reverts commit c007dfe1.
>
> Reason for revert: RegisterProtocolHandlerAndServiceWorkerInterceptor.DoNotRegisterFetchListener is very flaky on mac (and possibly elsewhere).
>
> Sample failure:
> [ RUN      ] RegisterProtocolHandlerAndServiceWorkerInterceptor.DoNotRegisterFetchListener
> [23479:30231:1019/055809.421386:WARNING:notification_platform_bridge_mac.mm(374)] AlertNotificationService: XPC connection invalidated.
> [23479:775:1019/055809.917320:ERROR:device_event_log_impl.cc(211)] [05:58:09.906] FIDO: touch_id_context.mm:127 Touch ID authenticator unavailable because keychain-access-group entitlement is missing or incorrect
> [23479:96771:1019/055810.044487:WARNING:embedded_test_server.cc(667)] Request not handled. Returning 404: /favicon.ico
> [23479:775:1019/055810.218450:INFO:CONSOLE(0)] "Failed to launch 'web+html:path' because the scheme does not have a registered handler.", source:  (0)
> ../../content/public/test/browser_test_base.cc:702: Failure
> Failed
> RunLoop::Run() timed out.
> Stack trace:
> 0   browser_tests                       0x0000000110d3e9c2 _ZN4base8internal7InvokerINS0_9BindStateIZNS_4test20ScopedRunLoopTimeoutC1ERKNS_8LocationENS_9TimeDeltaENS_17RepeatingCallbackIFNSt3__112basic_stringIcNSA_11char_traitsIcEENSA_9allocatorIcEEEEvEEEE3$_0JS5_SI_EEEFvvEE3RunEPNS0_13BindStateBaseE + 290
> 1   browser_tests                       0x0000000110c5916f base::(anonymous namespace)::OnRunLoopTimeout(base::RunLoop*, base::OnceCallback<void ()>) + 31
> 2   browser_tests                       0x0000000110c5a1a3 base::internal::Invoker<base::internal::BindState<void (*)(base::RunLoop*, base::OnceCallback<void ()>), base::internal::UnretainedWrapper<base::RunLoop>, base::RepeatingCallback<void ()> >, void ()>::RunOnce(base::internal::BindStateBase*) + 67
> 3   browser_tests                       0x000000010cf23a83 void base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> >::ForwardOnce<>() + 35
> 4   browser_tests                       0x000000010cf23b34 base::internal::Invoker<base::internal::BindState<void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> >::*)(), base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> > > >, void ()>::RunOnce(base::internal::BindStateBase*) + 148
> 5   browser_tests                       0x0000000110c7a946 base::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 310
> 6   browser_tests                       0x0000000110c8fb55 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*) + 405
> 7   browser_tests                       0x0000000110c8f858 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() + 168
> 8   browser_tests                       0x0000000110ce29a1 ___ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv_block_invoke + 49
> 9   browser_tests                       0x0000000110cdb662 base::mac::CallWithEHFrame(void () block_pointer) + 10
> 10  browser_tests                       0x0000000110ce223f base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 63
> 11  CoreFoundation                      0x00007fff38600884 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
>
> Original change's description:
> > Make custom protocol handlers work with service workers' fetch event
> >
> > When a service worker intercepts a page that is later registered as a
> > handler for a custom scheme via navigator.registerProtocolHandler, and
> > if one clicks a link with this custom scheme, then the service worker
> > is only able to intercept the page after reload. This CL fixes that
> > bug by allowing the service worker to intercept the page after
> > registering the custom scheme.
> >
> > A new browser unit test is added to verify this fix. This also makes
> > the following manual WPT tests pass (*):
> >   protocol-handler-fragment-manual.https.html
> >   protocol-handler-path-manual.https.html
> >   protocol-handler-query-manual.https.html
> >
> > (*) https://w3c-test.org/html/webappapis/system-state-and-capabilities/the-navigator-object/
> >
> > Bug: 522370
> > Change-Id: I95eda9025885838665e9735ac9f47a3d65d89aa8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379672
> > Commit-Queue: Frédéric Wang <fwang@igalia.com>
> > Reviewed-by: Dominick Ng <dominickn@chromium.org>
> > Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#818416}
>
> TBR=falken@chromium.org,fwang@igalia.com,dominickn@chromium.org
>
> Change-Id: I026705f0116f3e0d684c8b1d80847aec85ec36db
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 522370
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485837
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#818511}


Bug: 522370
Change-Id: Id30235a64a5a6a5c5d783ee686df321c7c853b16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487107Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#820255}

To the Views-based user adding screen.

Bug: 1066489
Change-Id: Ib8e96ef0ed08cb3779681088fd27d6c9d5301a45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470632
Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Thomas Tellier <tellier@google.com>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820254}

https://chromium.googlesource.com/angle/angle.git/+log/5641e3c185a8..4791cf2cde52

2020-10-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from ea52b3c2d270 to 3b334b2b8e1a (1 revision)
2020-10-23 jmadill@chromium.org Temporarily duplicate standalone tests.
2020-10-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e02d8938821a to 8012e62471be (1 revision)
2020-10-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 6fac705e7616 to 69f07da41b3b (24 revisions)
2020-10-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from cb0c1533 to e203e4bc (25 revisions)
2020-10-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 8832c373 to cb0c1533 (272 revisions)
2020-10-23 courtneygo@google.com Vulkan: Fix segv referencing contextVk
2020-10-22 ianelliott@google.com Add run-time check in EVENT() to disable debug markers
2020-10-22 sugoi@chromium.org Allow rendering to half float in ES2 contexts when possible
2020-10-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 72a62c65 to 8832c373 (1033 revisions)
2020-10-22 cnorthrop@google.com Revert "Tests: Add FIFA Mobile trace"
2020-10-22 syoussefi@chromium.org Vulkan: Validate SPIR-V transformer at link time
2020-10-22 xiaoxuan.liu@arm.com Fix end2end tests VertexAttribute* failure
2020-10-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 970c132746b1 to 91ce213a1d88 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: jonahr@google.com
Test: Test: angle_perftests -v --local-output --gtest_filter="TracePerfTest.Run/*nba*"
Change-Id: I93bf7d16b36bd14e76ac3ed82c984bbb0daec99c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495113Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820253}

BUG=None
TEST=build.

Change-Id: I0c825259f32c6edc07cf1ca089c02fda97b33579
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491760Reviewed-by: Michael Ershov <miersh@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Leo Lai <cylai@google.com>
Cr-Commit-Position: refs/heads/master@{#820252}

In the regular async multi-threaded setting, the compositor submits a
CompositorFrame 'during a frame', i.e. between BeginImplFrame() and
FinishImplFrame().

In the sync setting for webview, the CompositorFrame is submitted 'after
a frame', i.e. after both BeginImplFrame() and FinishImplFrame() has
been called. This change defers the FinishImplFrame() to happen after
the CompositorFrame is submitted (when a draw is anticipated). This
change brings the webview configuration a little closer to the regular
configuration. In the process, it also fixes the PercentDroppedFrames
metrics for webview.

BUG=1136519

Change-Id: I924c772d57cf2b5210d324e4da7acbe877aa298f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469779Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820251}

Change-Id: I5dbcb6c06c98862facd34376c8b43abe557f4b9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493375Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820250}

Removed matcher is unused.

Bug: 1105388
Change-Id: Iafc5a2236873c1bc02ea1f1c7500647d714553de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494870
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#820249}

This feature launched in M84.

Bug: 1053510
Change-Id: I2351e31665d135fd39f8219ce5002dff8c8109cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493484Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820248}

Add button accessiblility label to items when they are clickable.

Bug: 1078782
Change-Id: I07fb2e6b965218aefd4fb5ff0627ccfa5c202834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490108
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820247}

This is a reland of b9d174e5

There were issues uploading to the Play console which should now be
fixed, see crbug.com/1141430 for more details.

Original change's description:
> Enable isolated splits in canary
>
> All known issues have been fixed so enabling this in canary to see if
> there are any major problems.
>
> Bug: 1126301
> Change-Id: I0c3bc7443fcca8b81f7c2652d90b982872f7ea08
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478144
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#819200}

TBR=agrieve@chromium.org

Bug: 1126301
Change-Id: Idff90dadf9a5b1ec3cf047db1ce25d85cf8faf2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493460Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820246}

https://android.googlesource.com/platform/external/perfetto.git/+log/6b3c8d667a5f..4cd11945c5a1

2020-10-23 fmayer@google.com Fix CI.
2020-10-23 fmayer@google.com Update traceconv and trace_processor.
2020-10-23 mast@google.com Merge "Rename ART release APEX to com.android.art."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: chromium:169148096
Tbr: perfetto-bugs@google.com
Change-Id: I6f3b4bf6ad2069ad764ce0993482f39d9f3f12bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495114Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820245}

https://dawn.googlesource.com/dawn.git/+log/ade9a5235c73..24e636926107

2020-10-23 cwallez@chromium.org Slightly improve a RenderPipeline error message.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: dsinclair@google.com
Change-Id: I4657d5ed6cc8e3ae90ecd90049423133dbd92cc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495112Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820244}

Roll Chrome Linux PGO profile from chrome-linux-master-1603426036-fdbbb30b2e93e949277645ff11f5cf593a24568b.profdata to chrome-linux-master-1603454266-512aeaba1be85f32943004abfaab59393bece0f1.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I475fb451d735ed8e5fb5c08bb6746b9ccc226c0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495118Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820243}

https://webrtc.googlesource.com/src.git/+log/871500da9041..213fa85f73cd

2020-10-23 nisse@webrtc.org Internal-only visibility for rtc_base:macromagic

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I842bbda90347537f18e3e8378cad611476b4c397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495109Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820242}

This simplifies further policy removing changes to be done in
crbug.com/1103390 by refactoring all affected tests in 1 CL.

Bug: 1103390
Change-Id: Ieaf7270cfee4fac9cd52e1834583184dc2d71a89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463942
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820241}

Bug: 1141583
Change-Id: I4ae4990ccafec8585aa91000b69a0f99ba06fed5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493123Reviewed-by: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Sophey Dong <sophey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820240}

Bug: 1104264

Change-Id: I6f4a25d7f26a716d45978feaa9281d77064996f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463825
Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820239}

This patch adds a sync integration test that exercises a problematic
scenario: the deletion of a search engine via sync while the engine is
the default one locally.

This is possible because the default search engine is sync-ed via
preferences, that is, syncer::PREFERENCES, whereas the actual list of
search engines is sync-ed via another sync datatype, namely
syncer::SEARCH_ENGINES.

Ordering across different sync datatypes is not guaranteed and
therefore, if a user changes the default search engine and deletes the
old one, it is possible that a remote sync-ing device observes this
changes in the opposite order.

There is logic in TemplateURLService to special-case this scenario to
append underscores, and this patch simply documents this behavior using
a two-client sync integration test. Because reproducing the precise
problematic ordering is not feasible, the test leverages a
newly-introduced functionality in FakeServer that allows throttling
sync datatypes (resembling a very slow sync for preferences).

Change-Id: Ia0929717d0ea99a38969298b94f68a1c1ab44364
Bug: 1022775
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471398
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#820238}

For security reasons, resources of extensions from the Chrome Web Store
are verified when used. For that content verifier uses hashes of the
resources, signed by Chrome Web Store. These hashes might or might not
be included in the extension archive. Therefore sometimes they are
fetched from the Chrome Web Store only when needed.

If fetching of the hashes fails, extension is disabled because content
verifier cannot ensure that it is not corrupted. Unfortunately, this may
lead to false-positive disabling of the extension: if fetch of the
hashes failed, for example, because of bad network. To investigate
whether this happens frequently, this CL adds a new histogram:

 * Extensions.ContentVerification.FetchNetError : network error code
when fetch of the content hashes failed.

Bug: None
Change-Id: I03ff9c104a591579d713a5c939853645bea8ec71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426583
Commit-Queue: Oleg Davydov <burunduk@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820237}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53ee505d93e1..91ad80de0e11

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC bsep@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1141382
Tbr: bsep@google.com
Change-Id: I0a92faa6beff9796010e7daf32945aec98255481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495107Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820236}

These SameSite features are enabled by default so we can clean them
up here.

Bug: 961439
Change-Id: I2a13a8abda97c3afcbb29f48e8d732e7a907f4d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493262
Commit-Queue: Steven Bingler <bingler@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820235}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cdd7e6fa..e323f012

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia31b55308ec81c979cde33efca1c25c5828409e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495240Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820234}

IncognitoTabModelImpl creates a proper tab model and related OTR
profile, iff there is at least one incognito tab. This CL changes this
logic as creating tab model when switching to incognito mode, even
if there is no incognito tab. |setActive| function will be triggered
when the current tab model is changed by TabModelSelectorBase.

By this CL;
- Incognito profile will be created whenever the incognito mode
becomes active.
- TabSwitcherModeTTCoordinatorPhone will use IncognitoTabModelObserver
instead of TabModelObserver to update the visibility of new tab
variation.
- TabModelSelector will have removeIncognitoTabModelObservers function.
- BookmarkBridge will be destroyed whenever the profile is destroyed.
- New test are added to IncognitoProfileDestroyerIntegrationTest.

Bug: 1126532, 1060940
Change-Id: Ibd38b7a6bbaac955853ac298b29d705d5f889533
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429766
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820233}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4c63602bdb60..0fef99f5c756

2020-10-23 alcastano@google.com Typecheck elements/StylePropertyHighlighter.js with TypeScript
2020-10-23 bmeurer@chromium.org [wasm] Speed up inline function and source scope resolution.
2020-10-23 szuend@chromium.org Fix scrolling in Network log
2020-10-23 andoli@chromium.org [ts] Typecheck settings/FrameworkBlackboxSettingsTab.js with TypeScript
2020-10-23 alexrudenko@chromium.org Enable TypeScript for XHRBreakpointsSidebarPane.js

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1140900,chromium:1141781
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: If3f6d018cce31076a61597c0d5e5cfd0f9abbcfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495106Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820232}

R=vsemeniuk@google.com

Bug: 927473
Change-Id: I1eb1e58345ab89c7699187bfd6f5680d9f408539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494942
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820231}

After crrev.com/c/1554760, the NavigationRequests are recreated if the
URL doesn't match. We should just reset the NavigationRequest instead of
moving it to same_document_navigation_request_.

Bug: 963396
Change-Id: Ib3a9d8c6432796bfa3b400ffd2dece760da1fb30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494206
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820230}

This is a new crash with the DestroyProfileOnBrowserClose experiment
(go/destroy-profile-on-browser-close). The BookmarkSyncService uses a
ProxyModelTypeControllerDelegate, with the UI thread as the model
thread. This causes issues, where posted tasks run _after_ the
BookmarkSyncService gets deleted.

This patch switches it to a ForwardingModelTypeControllerDelegate,
so the tasks run synchronously instead of posting to the UI thread. This
fixes teardown order.

Bug: 1140232, 88586
Change-Id: I0802334ce3da56326c167f7951d512fe045ddece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487222
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820229}

navigation_token is only needed for browser-initiated same-document
navigations, which is handled in DidFinishSameDocumentNavigation.

See discussion: https://groups.google.com/a/chromium.org/g/navigation-dev/c/N_QfNAB3x44/m/ABGSPq6OAgAJ

Bug: 1131832
Change-Id: I9c5ae4eb76bc361473b4ea833eee0ed6fb1d0887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478744Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820228}

Change-Id: I4187fdbbb265aab9d679781130c923936a4ad9b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494884
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820227}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6a2b3e4007e7..007c109b4594

2020-10-23 bungeman@google.com * src/sfnt/pngshim.c (Load_SBit_Png): Fix memory leak (#59322).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Tbr: bungeman@google.com,drott@google.com,thestig@google.com
Change-Id: Ic9be7c23a5208802888f7d10295f6f5d1ed3197e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493738Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820226}

BUG=1082882
TEST=N/A

Change-Id: I167483e76cbc216ef1d5c9654f2b8a2e8bd85671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492968
Auto-Submit: Mark Yacoub <markyacoub@google.com>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820225}

Calling StartWorkerInternal() can end up in OnStartSend() which
 deletes `this` in case of error. This code path became real
 after the service worker context thread became the UI thread.

R=falken@chromium.org

Bug: 1141413
Change-Id: Iec9172567aab3dcc62323f358bab9fc751551d5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490113
Commit-Queue: Konstantin Ganenko <ganenkokb@yandex-team.ru>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820224}

This CL uses adaptive colors for the incognito filled icon in the
incognito interstitial. It uses modern_grey_300 for dark mode and
modern_grey_800 for light mode.

Screenshot: crbug.com/1137339#c4
Bug: 1137339
Change-Id: I659faac43841c27007b54e85e194e816e1648826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468116Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Lijin Shen <lazzzis@google.com>
Reviewed-by: Alice Wang <aliceywang@chromium.org>
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820223}