- 23 Jul, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b7dad440407e..f0c11b3aa2a7 git log b7dad440407e..f0c11b3aa2a7 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-23 reed@google.com add 'r'epeat option sans the HUD (to not complicate the profile) 2019-07-23 mtklein@google.com hoist tbl masks 2019-07-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-22 rmistry@google.com Fix G3 compile bot 2019-07-22 mtklein@google.com let JIT code hoist when possible 2019-07-22 csmartdalton@google.com ccpr: Unblacklist Radeon in MSAA mode Created with: gclient setdep -r src/third_party/skia@f0c11b3aa2a7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Change-Id: I86cd39351e06a803677b7a90fb8b853d4443ee38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714046Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679841}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/79b937fc949d..687f5a81a807 git log 79b937fc949d..687f5a81a807 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 eashanbhatt@google.com cros_test_unittest: Add Fetch Results Unittest 2019-07-23 vapier@chromium.org vm_unittest: disable flaky testSystemQemuPath 2019-07-22 alexlau@chromium.org cbuildbot: Add target to Android metadata Created with: gclient setdep -r src/third_party/chromite@687f5a81a807 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Id45bc74840e3e5aa33a96a062a5f2df5c8b2fafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714171Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679840}
-
ShihYing Chen authored
Currently there is failed to load resource error when opening a new tab in chromeos guest session. The root cause is NTPResourceCache is hardcoded to not return new tab css resource for guest mode. This change remove incognito_new_tab_theme.css in NTP page. Bug: None Test: Manual Change-Id: I1e900b6e3a2e9614bf0dd175e34355cb6e66e851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712509Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: ShihYing Chen <shihyingchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#679839}
-
Noel Gordon authored
The eject button should be 3px left of the splitter (not 0px), and the label width computation should include that 3px splitter gap + the 6px margin either side of the label. See crbug.com/979162#c20 and crbug.com/979162#c21 for the computations of the values. The result would look like this: ____________________________________|‾‾‾‾‾| ;; |..6px..|____label_width____|..6px..|
⏏ | < 3px > ;; < splitter |_____| ;; However after CL:1617041, removable volume labels and the eject button are position: absolute. And the splitter bar can be used to reduce the width of the directory tree. Doing that causes the label text to '...' elide: removable volume labels are the only directory tree labels that do that (... elide) in Files app at this time! Including the 6px margin either side of the label in the width, causes the label text to completely elide (disappear) when the directory tree width is small. To avoid that and at least show some characters of the label text when elided, we _do not_ include the 6px margin either side of the label in its width computation, but do account for the 3px gap, width: calc(100% - 48px - 40px - 3px); which gets added in this CL (using right: 3px) to the eject button. If future developers wonder about it, this long-ish change log might help them understand the intricate CSS minutiae of the eject button. Bug: 979162 Change-Id: I73a9cd89ba5b88ba603301ba3187c86cb4875670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712350Reviewed-by:Noel Gordon <noel@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#679838}
-
Kyle Milka authored
When backspace is press on the image selection submenu it should return to the main backgrounds menu. Bug: 937570 Change-Id: I6f220a851966ee62eaf9b1f52f9ab2e9f9cc0d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709759 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#679837}
-
Julian Watson authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/7fce758d6770..80a8441a9d67 $ git log 7fce758d6..80a8441a9 --date=short --no-merges --format='%ad %ae %s' 2019-07-19 juwa vm_tools: plumb through export import cancellation messages 2019-07-08 ahassani system_api: Add Operation Enum to protobuf Created with: roll-dep src/third_party/cros_system_api Bug=chromium:978318 Change-Id: I6d5e141f51689b623444ff67106f80fa67286dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714191 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#679836}
-
Brian Sheedy authored
Removes the uploading of images to a GS bucket on failure in the GPU pixel tests, as it was only meant as a temporary measure to help debug an issue. The uploading code is still kept around for future use, but it is not called from anywhere. Bug: 983600 Change-Id: Id8d8158487d2f7dd79f944689f50c46a0d7d8cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714148 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#679835}
-
Stephen Chenney authored
Bug: 984223 Change-Id: I8cb6a3c661a7a56f52fe34d8a78f76eb32f6fdc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706582 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#679834}
-
Darwin Huang authored
No logic changes. (Many affected Windows type "objects" are really just struct pointers.) Reference: https://cs.chromium.org/chromium/src/base/win/windows_types.h?l=79 Change-Id: Ib7ab8cd5f36f57c053f47d49dfde1597ba05d553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710784 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#679833}
-
Sunny Sachanandani authored
DWM composition is limited to primary monitor's refresh rate. Prior to GPU vsync we would use DWM composition rate to drive begin frames. With GPU vsync we started using per monitor vblank to limit begin frames in case primary monitor had higher refresh rate, but this might be causing draw duration and omnibar latency regressions. MS platform team also suggested syncing to primary monitor only. In any case the correct approach would be to further limit begin frames based on event queries from 2 frames back. This CL makes the GPU vsync begin frames sync to primary monitor, and also makes the vsync thread a singleton since it doesn't have per-window state any more. Bug: 953970 Change-Id: Id3d3f043cb847172b1d6ba4bd38b087ceb2d8631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711215Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#679832}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 78b1d963. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" ee7626e7 "Fixing tranferFromimageBitmap-toBlob-offscreen.html to not be flaky" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I062e20312b171ddac719ce7833f2a30eff1e518b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713597Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679831}
-
Andrii Sagaidak authored
Currently, every experiment description div element receives an onclick event, which will do an action only if a condition holds. This PR will make a change to not add the onclick event if it's no-op. Bug: 986535 Change-Id: I2cde879823faa19f700b18e97c20e4e28dffd84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713599Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Andrii Sagaidak <ansagaid@microsoft.com> Cr-Commit-Position: refs/heads/master@{#679830}
-
Darin Fisher authored
A significant part of this CL is moving code off the IO thread and avoiding a number of thread hops as a result. Bug: 967834 Change-Id: I7d1ee6f82f07f74793ad80ab54da2dfb458e2796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672111 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#679829}
-
Aleks Totic authored
LayoutNGMixin is supposed to be a mixin base class for NG layout objects. It implements functionality common to NG layout object subclasses. LayoutNGMixin assumed that its base class was a subclass of LayoutBlockFlow. This is not always true. Some NG classes are a subclass of LayoutBlock. This CL splits LayoutNGMixin into 2 classes: - old LayoutNGMixin is renamed to LayoutNGBlockFlowMixin. It contains code shared between LayoutNG subclasses of LayoutBlockFlow - LayoutNGMixin is a brand new class that contains code shared between LayoutNG subclasses of LayoutBlock The original motivation for this change was need to share UpdateOutOfFlowBlockLayout between LayoutNGBlockFlow and LayoutNGFlexibleBox. This CL moves this method to LayoutNGMixin. LayoutNGFlexibleBox is now a subclass of LayoutNGMixin. There was also some minor cleanup. Most of it fit the pattern: if (IsLayoutNGMixin() || IsLayoutNGFlexibleBox()) and got simplified to if (IsLayoutNGMixin()) Bug: 958381 Change-Id: I5f2254c8d4fab9f4518e048564c867c436855a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711021 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#679828}
-
Yi Gu authored
The test is flaky on Win. See https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyZgsSBUZsYWtlIltjaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUBodHRwL3Rlc3RzL2RldnRvb2xzL2VsZW1lbnRzL2VkaXQvZWRpdC1kb20tYWN0aW9ucy0xLmpzDA TBR=luoe@chromium.org NOTRY=true Bug: 985811 Change-Id: Ie224b703dc1b6c45765ff52f54e793aa46d9af87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714327Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#679827}
-
Gayane Petrosyan authored
Bug: 960982 Change-Id: I308196d1210ab9d3e45ea79c68a754cf1789660b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713276 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#679826}
-
Jeremy Chinsen authored
Currently draw_utils::GetPageInsetsForTwoUpView() checks that the |page_index| is greater than or equal to 0. Since |page_index| is size_t, it can never be less than 0. Change-Id: Ied708bec3f5bbfa8861b97e10ba584b66fbb59fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714207Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Cr-Commit-Position: refs/heads/master@{#679825}
-
Xing Liu authored
This CL adds a time randomizer for notification scheduler background task. Bug: 963283 Change-Id: I79f255733b01f6257fb39e603270345c2f08d706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708014 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#679824}
-
Hiroki Nakagawa authored
Bug: 986019 Change-Id: Ie0033961c6e4b00eec638006a580a86c81f695dc Notry: true Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714193Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#679823}
-
Yuly Novikov authored
Reflecting the upgrade from Android P to Q. TBR=kbr Bug: angleproject:3340 Change-Id: I49b35fe898f4b5b0a877d02a267b7684d337d62a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714287Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#679822}
-
Julian Watson authored
This change refactors the export import notification, such that all string handling is internal, and such that there is a more defined API for setting the many status variants. This change facilitates two incoming changes: one that adds the status CANCELLING and CANCELLED to the notification, and another that adds another variant on the failed status to do with concurrent operations. BUG=chromium:978318 Change-Id: Icc101378ce2f6650f1dc646d06af868684bd56b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702346 Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#679821}
-
Patrick Monette authored
Bug: 943303 Change-Id: I7bcc5b787851409dc488811446cbbdca51963f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712947Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#679820}
-
Lei Zhang authored
https://crrev.com/675319 added more std::unique_ptr usage, but did not always #include <memory>. As a result, the CL only builds due to luck. When one sets use_custom_cxx=false, they no longer build, as seen in this thread: https://groups.google.com/a/chromium.org/d/topic/chromium-packagers/UyJsVJ5QqWo/discussion Change-Id: Ib9812b3210dac60176128b22c3881f7f33d785f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713037Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#679819}
-
Meilin Wang authored
This change fixes the incorrect clickable zone of |zippy-additional| on the assistant third party oobe page. In this way, a modal dialog only shows up when user clicks the link (the <a> element). Clicks on any other parts besides <a> in |zippy-additional| will have no effect on the page. Bug: none. Test: manually. Change-Id: Id5f2f136afcb2fdc677f79cae597c0909d44f141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713945 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#679818}
-
Josh Nohle authored
Change the Sync() input from RequestContext to ClientMetadata and ClientAppMetadata. The RequestContext will be built internally from these components. The ClientAppMetadata is also needed to build the local device's BetterTogetherDeviceMetadata. We also update comments and add a "private" access specifier. Bug: 951969 Change-Id: Ib58128ba706aa8ba3d6a027f987e6cc221a7987d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711144 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#679817}
-
Miyoung Shin authored
This is a reland of cc61e814. The origin CL has twice reverted behavior. The first one caused by the build broken of Linux chromium.fuzz and the breakage had been fixed at 1b39b8b1 with updating including the path. And the second one caused by failing autofill tests in chrome_public_test_apk but autofill tests had still failed even after reverted the CL and it wasn't related to that failures. So there is nothing change from the origin CL at this time. Original change's description: > Reland "Rename traits and mojo directory in //components/autofill/" > > This is a reland of 1b39b8b1 > > Original change's description: > > Rename traits and mojo directory in //components/autofill/ > > > > This CL renames interfaces to mojom and *_struct_traits.* > > to *_mojom_traits.* in //components/autofill/. > > > > *_struct_traits.* => *_mojom_traits.* > > components/autofill/content/common/ => components/autofill/content/common/mojom > > > > Bug: 806965 > > Change-Id: Ie24626259372bacf83399c48f2c1fadbef66aabc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703477 > > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#678167} > > Bug: 806965 > Change-Id: I0f6e5a33d7963d5384066a88367744eb385fe742 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705914 > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678567} Cq-Include-Trybots: luci.chromium.try:android_mojo Bug: 806965 Change-Id: I7d57a878954c58a1938d07674f81ae846dad314a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709316 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#679816}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/32b89794cac6..4fbd1e670284 Created with: gclient setdep -r src-internal@4fbd1e670284 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tinazwang@google.com,horo@google.com,yigu@google.com Change-Id: I50d9e23e22e924ecb2aac89066a22babb66ce616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712611Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679815}
-
Kristi Park authored
CustomizedFeature.CUSTOMIZED_FEATURE_SHORTCUT was logged each time the tiles were reloaded, which could happen multiple times per page load (e.g. after editing a shortcut, when the list of Most Visited sites was updated, etc). This is potentially causing inflation in the number of customized NTPs. Log CustomizedFeature.CUSTOMIZED_FEATURE_SHORTCUT when the NTP metrics are emitted on page load, instead of through LogEvent. Bug: 985130 Change-Id: I7ca22b8c11b1d5f3464299c375a2c0f4e6173a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707570 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#679814}
-
Will Harris authored
This is a reland of 7d5fe940 Original change's description: > Reland "Sandbox: Add support for CIG pre-launch." > > This is a reland of 9e89ae37 > > Original change's description: > > Sandbox: Add support for CIG pre-launch. > > > > This CL allows MITIGATION_FORCE_MS_SIGNED_BINS to be > > enabled pre-launch for targets even with dependent DLLs > > It achieves this by adding a sandbox intercept for > > NtCreateSection and permitting sections backing modules > > that match a whitelist to be created in the broker > > and mapped into the target for the load to succeed. > > > > BUG=750886 > > > > Change-Id: Iac22e206f77f99d9c2253e906780f1bcf5e8e3e6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660097 > > Commit-Queue: Will Harris <wfh@chromium.org> > > Reviewed-by: James Forshaw <forshaw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#676665} > > Bug: 750886 > Change-Id: I0de3189df0e5435fb33717fcaa3f82768d4504f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699271 > Reviewed-by: James Forshaw <forshaw@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#677510} Bug: 750886 Change-Id: Ib77c5590e58c395d8cedef12be46896919c457ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709798Reviewed-by:
James Forshaw <forshaw@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#679813}
-
Caitlin Fischer authored
This happens with and without the AutofillUseImprovedLabelDisambiguation feature enabled--but in different situations. See the bug for specific examples. Bug: 984957 Change-Id: I75e297f384f7883db0409d40af7995acc92cacdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706579Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#679812}
-
Stephen Martinis authored
Bug: 863028 Change-Id: Ie44f7eb962a76b3eb0fa58de4b6b32d2a11c3685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713709 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#679811}
-
Thanh Nguyen authored
Add codes in ash that notify chrome about the list of items being shown to users if any items got clicked. The data processing and logging parts in chrome will be implemented later. Bug: 972817 Change-Id: I4a311a4f00838a2966ee813e9606dc1b5eb24ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677807 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#679810}
-
Jordy Greenblatt authored
In my fix [1] for our bug to change the OS Settings 'downloads' section to a naming pattern based around the term 'files' to match UX specs [2], I didn't add a separate route for files for OS-Settings. This CL adds that section in. I manually ensured that clicking 'Files' item in os-settings-menu scrolls to the 'Files' section [3]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1696180 [2] http://crbug.com/978648 [3] http://screen/9QpZtnw8TS0 Bug: 986466 Change-Id: I7d255a41015b307c674bf231878dffa72066ca5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713909Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#679809}
-
Kristi Park authored
Log when the user changes their shortcut settings (i.e. type and visibility) as a CustomizeShortcutAction. Also log the current user shortcut settings on page load for Google NTPs. This will be emitted once per page. Bug: 953822 Change-Id: Iba8ae4e7a0773967bb388535dd6650423b2a56ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704034 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#679808}
-
dpapad authored
Bug: 965770 Change-Id: I393be10bdb7b9621ab723d15aa04aed5d5993729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713255 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#679807}
-
Aaron Leventhal authored
This reverts commit e5ab7cc7. Reason for revert: The DeleteClientSubtree() changes can lead to crash. Original change's description: > Make AXTreeSerializer safer > > The tree serializer should not crash even if the given tree has invalid > nodes. These changes don't alter behavior but removed possibilities for > accessing dangling pointers. > > Bug: 981311 > Change-Id: I8f2e55771c12a03955f7632335bea347b6a5af30 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707949 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678670} TBR=zork@chromium.org,nektar@chromium.org,aleventhal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 981311 Change-Id: I1d00c05fb0af2ec48d645e475cfcceb9421bd5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713813 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#679806}
-
Xi Han authored
The bug was introduced in: https://crrev.com/c/1702862. The startup mode should be obtained in handlePostNativeStartup(), rather than in the deferred task. This CL fixes the issue and we continue to use Servicification.Startup3 since it is only in canary for few days. Bug: 984559 Change-Id: I8c630d8ef267955e2b71aaae1199170980b1daf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710002 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#679805}
-
Katie D authored
TBR=anastasi@google.com Change-Id: I181013d765b32146033348186008e02e03f3da74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714209Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#679804}
-
Tina Wang authored
The test became flaky recently. See bug for details. TBR=guidou@chromium.org Bug: 986470 Change-Id: Ibab83e4393ba8e305340b21d01e2716dd4afb07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713366 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#679803}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/da50ef4e8d15..2fb54ea4618d git log da50ef4e8d15..2fb54ea4618d --date=short --no-merges --format='%ad %ae %s' 2019-07-22 simonhatch@chromium.org Dashboard - Add jinja2 dependency to api Created with: gclient setdep -r src/third_party/catapult@2fb54ea4618d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:985917 TBR=zhanliang@google.com Change-Id: Iaed86948c49fd1b3ada7da1a811007abc3fe136f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713572Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679802}
-