- 13 Aug, 2018 40 commits
-
-
Katie D authored
Bug: b/112360716 Change-Id: I5f082ac425e9f8ac740d4af81059b3c379c04d12 Reviewed-on: https://chromium-review.googlesource.com/1168025 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#582629}
-
Scott Violet authored
WindowTreeClient has code for it, so no need for the same code to exist in MusClient as well. BUG=none TEST=covered by tests Change-Id: I50c18a0a2b08f045251a94c15472b0289a2cd7bf Reviewed-on: https://chromium-review.googlesource.com/1172734Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582628}
-
Jacob Dufault authored
SaveScreenTimeProgressBeforeExit gets called after the lock screen was shown, which cancelled all running timers, including those that updated the lock screen state. If some other event fired, ie, timezone change, then the timers would get rescheduled. As a fix, don't cancel the timers which update lock screen state; only cancel in-session timers for the notification and recording actively used screen time. Bug: 872689 Change-Id: Ibbead3c2e455866fc09ced036c5c78a81e05357b Reviewed-on: https://chromium-review.googlesource.com/1171811Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#582627}
-
Mohsen Izadi authored
Platforms other than Android, use selection sent in RenderFrameMetadata rather than the one in CompositorFrameMetadata. There is no need to serialize/deserialize and send the unused data on each frame. BUG=859969 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibfde9270deae40ebc57e15251b70597fd3e6a0f7 Reviewed-on: https://chromium-review.googlesource.com/1172142Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582626}
-
Raphael Kubo da Costa authored
Due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84849, having base::NoDestructor<T<U>> and passing an initializer list of Us does not work. Just explicitly create a base::flat_set in the constructor. See also: https://chromium-review.googlesource.com/1165360 Bug: 819294 Change-Id: I24593dc199df47c2f8fd316436517704d159e4fa Reviewed-on: https://chromium-review.googlesource.com/1170905 Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#582625}
-
David Black authored
Motion spec still being delivered by UX but this should be a step in the right direction and removes a lot of our existing jank. Note: We still have yet to crossfade between mini/main/web states. Also revised some AssistantMiniView metrics per the spec. See bug for demo. Bug: b:112487675 Change-Id: I9cecb3afdd7d5e85e04d8ef95a25e5dfdd263c91 Reviewed-on: https://chromium-review.googlesource.com/1171952 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#582624}
-
Sahel Sharify authored
With this change wheel event listeners that are registered on a window, window.document, window.document.body will be treated as passive if not specified otherwise. Intent to impl: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/53q-wRk5QkA Bug: 626196 Change-Id: I1561cd86ddd381e0405c84ba8f48ea7274d8906c Reviewed-on: https://chromium-review.googlesource.com/1162302Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#582623}
-
Raphael Kubo da Costa authored
This fixes the libstdc++ build after commit d540c125 ("New implementation of MessagePopupCollection"). Bug: 819294 Change-Id: Ibf45feee935b25d48564f84326b95f33529ab879 Reviewed-on: https://chromium-review.googlesource.com/1172784Reviewed-by:
-
Kevin McNee authored
Bug: 803274 Change-Id: If56ee6ad0220b429b4497ccecef90eb257265478 Reviewed-on: https://chromium-review.googlesource.com/1170989 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#582621}
-
Paul Meyer authored
This crash was caused by incorrect wrapper tracing with ReportingObserver. This CL fixes this by making ReportingObserver ActiveScriptWrappable. Bug: 870930 Change-Id: Ie46db964c98b028c96d9deb2066c7db9ca0d449f Reviewed-on: https://chromium-review.googlesource.com/1169434 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#582620}
-
Dave Tapuska authored
The current pull request against the HTML spec is here: https://github.com/whatwg/html/issues/3799 Rename the RuntimeEnabledFeature from WindowPostMessageOptions to PostMessageOptions BUG=861735 Change-Id: Ia7980a85c10535f6d531c87f3790efcf6ed2d54d Reviewed-on: https://chromium-review.googlesource.com/1169304 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#582619}
-
Lucas Furukawa Gadani authored
This CL exposes a Portal mojo interface when the Portals feature is enabled. Bug: 865565 Change-Id: I882070fd3225a42a7ab64c01c8ac4bbce156ae5a Reviewed-on: https://chromium-review.googlesource.com/1145710 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#582618}
-
Katie D authored
Bug: b/77884324 Change-Id: If48e2d244446db26f17d1943b322dd0dce43cdb6 Reviewed-on: https://chromium-review.googlesource.com/1165847Reviewed-by:
-
Ivan Sandrk authored
Enable Managed Session by default when the policy controlling the behaviour is not set. Bug: 865947 Change-Id: Ie674d18b4a07ee5ebe6134f26b0f3c088dca5cf7 Reviewed-on: https://chromium-review.googlesource.com/1172602Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#582616}
-
Reza.Zakerinasab authored
Refactor blob mime types to avoid using string literals in the code. TBR=dgozman@chromium.org Bug: 846441 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I290808b25e7775931d838464f9470da36d0948bd Reviewed-on: https://chromium-review.googlesource.com/1169524 Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582615}
-
sczs authored
Previously the Choose Folder Bookmark VC NavigationBar had a gray background. This was caused because the NavigationBar clear background didn't have content under because setEdgesForExtendedLayout was trimming the tableView. This CL also prevents a largeTitle to be displayed whenever this VC is pushed, following the mocks. Bug: 855323 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I45917d2cf467dcd793ac6dfc335e10b4d1ef2eb5 Reviewed-on: https://chromium-review.googlesource.com/1171791Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#582614}
-
David Davidović authored
When visiting chrome://sync-internals, a checkbox labeled "Capture Specifics" is available. It controls whether the specifics of each sync event are captured in the log displayed on the page. Every time the page is refreshed or reopened, this checkbox is reset to its initial, unchecked state. The flag is immensely useful for debugging, but having to check the checkbox after each browser restart or reopen of the page is cumbersome. To that end, add a command-line switch "--sync-include-specifics" which will set the initial value for the "Capture Specifics" flag on chrome://sync-internals page load to true. Bug: 859878 Change-Id: I43b04e2d3aabdda2e8f3bc64cb80f906f56c78b2 Reviewed-on: https://chromium-review.googlesource.com/1147221 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#582613}
-
Konstantin Ganenko authored
The short crash stack: 6 libsystem_c.dylib 0x00007fffb1a889ed reallocf + 21 7 libsystem_notify.dylib 0x00007fffb1bf962f notify_retain_file_descriptor + 160 8 libsystem_notify.dylib 0x00007fffb1bf94c3 notify_register_file_descriptor + 1091 9 libnet.dylib 0x0000000111832021 net::NotifyWatcherMac::Watch(char const*, base::RepeatingCallback<void (bool)> const&) + 241 Crash happens on OS X 10.12.X. The fall occurs in the libnotify library. For macos 10.12.X libnotify library version 165 is used. https://opensource.apple.com/release/macos-1012.html By source code: https://opensource.apple.com/source/Libnotify/Libnotify-165/notify_client.c.auto.html the fall occurs in globals->fd_clnt = (int *)reallocf(globals - >fd_clnt, globals->fd_count * sizeof(int)); , or the same with fd_srv, fd_refcount. Global pointers to file descriptor tables are reset only when global is initialized and nowhere else. On releasing the last file descriptor free is called for these pointers without zeroing them. (see notify_release_file_descriptor in same file). Accordingly, when creating one file descriptor (notify_register_file_descriptor) with subsequent its destruction (notify_cancel), the creation of the next will lead to a crash - realloc on freed pointer. Here introduced simple approach to repair issue. We need to hold one stub file descriptor to avoid freeing globals in libnotify. For earlier implementations of the libraries (looked 10.11.X - version of library is 149) the problem is also there. More detailed crash stack is added in issue. R=agl@chromium.org Bug: 783148 Change-Id: I23396372bf6fdff78c70bf6a53a4183795677b02 Reviewed-on: https://chromium-review.googlesource.com/1168490 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#582612}
-
Weidong Guo authored
Changes: Adjust the folder bounds to fit in AppsGridView instead of AppsContainerView to avoid overlap with search box. Bug: 873420 Change-Id: I54d721d684d17ca9f184b8f71e1917ce612e932a Reviewed-on: https://chromium-review.googlesource.com/1171905Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium cc4cd897. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." 3364c233 "[css-properties-values-api] Reify values from attributeStyleMap.get." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22692 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources timvolodine@chromium.org: external/wpt/battery-status NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I1e2e1f2c301da8d05d4c5aad485ea3a6e7c44d18 Reviewed-on: https://chromium-review.googlesource.com/1172444 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#582610}
-
Weidong Guo authored
Changes: This is a revert of go/cgcl/1103151 due to expected behavior change. Bug: 872354 Change-Id: I5d96b16b446a75c17a8e493e258dcc1588a3440b Reviewed-on: https://chromium-review.googlesource.com/1172073Reviewed-by:
-
Gauthier Ambard authored
This CL modifies the URLLoader protocol to use OpenNewTabCommands instead of passing the arguments in the method. Follow-up from crrev.com/c/1127949. Bug: 843576 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I45635617a8e697ebccfc0c524f076176eacb5bb0 Reviewed-on: https://chromium-review.googlesource.com/1131511Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#582608}
-
Dominik Röttsches authored
SafeToBreakMissingRun was a Mac only failure, SafeToBreakArabicCommonLigatures were Mac and Android only failures, ShapeArabicWithContext was waiting for range shaping to be implemented, which had been fixed in the meantime for non-Mac.. Bug: 689155, 870712 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I5ce017be3417ef24720cfb5a9818384ebd148b6c Reviewed-on: https://chromium-review.googlesource.com/1162177 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#582607}
-
Aldo Culquicondor authored
Having an undefined source triggers warnings in the logs. SOURCE_CLASS_POINTER is the minimal requirement for producing touch events, and it is general enough. Passing the source as an argument to `inject` was causing perf regressions. BUG=855626, 867438 Change-Id: I05458c9c98776a2af99b570aba5760adfd0381d5 Reviewed-on: https://chromium-review.googlesource.com/1167207 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#582606}
-
Rouslan Solomakhin authored
This is a speculative fix to flakiness in TwoClientPreferencesSyncTest.SingleClientEnabledEncryptionBothChanged_E2ETest. https://crrev.com/c/1152068 introduced AutofillJapanCityFieldMigrated as a syncable preference that starts out as "false" by default, but then is flipped to "true" upon the start of syncing of autofill profiles. The speculation is that a non-syncable preference should not interfere with a preferences sync test. Bug: 872614 Change-Id: I84cc91c8e11aeaba6a02ea178a5b38ebde97882a Reviewed-on: https://chromium-review.googlesource.com/1169309Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582605}
-
Chris Lu authored
Change-Id: Iccb6078d9dba025791424a6fe1c49e1cc98c7652 Reviewed-on: https://chromium-review.googlesource.com/1171787 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#582604}
-
Helen Li authored
This CL is split off rdsmith@'s CL at https://chromium-review.googlesource.com/c/chromium/src/+/925181 This CL only adds the logging code for events, but uses a null NetLog. A followup CL will modify the CookieStore constructor to pass in a non-null NetLog. Bug: 801910 Change-Id: Icd40aa206055c82a4e84ddb66c8547b69ec662ff Reviewed-on: https://chromium-review.googlesource.com/1170594Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#582603}
-
Robert Ogden authored
Moves choosing the color of text and separator of the Omnibox verbose status from LocationbarLayout to TDP based on the currently displayed page. Bug: 871839 Change-Id: I484cd402e6d7db863d3e5301451ed5f2b8db942d Reviewed-on: https://chromium-review.googlesource.com/1167983Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#582602}
-
Elad Alon authored
content::WebRtcEventLogger was created to allow code in content/ to reach WebRtcEventLogManager. Code in chrome/browser/ can, and should, access WebRtcEventLogManager directly. As a drive-by, add DCHECKs over WebRtcEventLogger being created and destroyed on the UI thread. Bug: 775415 Change-Id: Idb5109d2fdfc0ce0feeb6aa6655914f8ea4905cd Reviewed-on: https://chromium-review.googlesource.com/1172435Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
This CL implements the functinality of not syncing managed bookmarks (e.g. installed by policy) Bug: 516866 Change-Id: Ibdcbb7593ad976670e883c115a847e6994951bae Reviewed-on: https://chromium-review.googlesource.com/1163241 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#582600}
-
Gauthier Ambard authored
Cleanup for the ActivityService. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7feb4acc2711172dfb9829c2b223e6f2c724fa33 Reviewed-on: https://chromium-review.googlesource.com/1172289 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#582599}
-
Fredrik Söderquist authored
The test has a red version of the reference painted under the actual test content. Because of how alpha/coverage often work (at least in software rasterizers), this can lead to the read bleeding through and thus affecting the comparison with the reference image. Disable the red reference shapes by adding a CSS rule. This way, if someone feels it's useful for debugging they can easily re-enable it. BUG=872697 Change-Id: Id47757c9dd112ead0db9c2dcd1adc74d5a52e55d Reviewed-on: https://chromium-review.googlesource.com/1172622Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#582598}
-
Rouslan Solomakhin authored
This is a reland of 33a1a4b02fd1c7d7c623513274c24692d6602d8d Original change's description: > Add tests for JIT installable payment handlers. > > Bug: 872305 > Change-Id: I992e534ab0ca48affc14464c23af41a495209c58 > Reviewed-on: https://chromium-review.googlesource.com/1168084 > Reviewed-by: Ganggui Tang <gogerald@chromium.org> TBR=gogerald@chromium.org Bug: 872305 Change-Id: Icdf80a7bb92b53b85c09648bf483f1671fcfa662 Reviewed-on: https://chromium-review.googlesource.com/1172542Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582597}
-
Fernando Serboncini authored
This CL refactors the existing code path for uploading canvas element to a WebGL texture by generalizing it to work with CanvasRenderingContextHost, which is a common base class of HTMLCanvasElement and OffscreenCanvas BUG=753483 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6c1cf783774ff8f8edc4604c10056ba57b0b9ae7 Reviewed-on: https://chromium-review.googlesource.com/1154988Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582596}
-
Jérôme Lebel authored
This patch enables to open "Google Activity Controls"[1] and "Encryption"[2] from the Google services settings[3] [1]: https://drive.google.com/open?id=1VenMSZPfe-7cM9trtLJgIJvQopqpdDWk [2]: https://drive.google.com/open?id=1jrAQwjCcV3o_UnPjCasmisDPtmyWsE1u [3]: https://drive.google.com/open?id=15GJUEJrTAgsREZ5zHjf6xO0ivwLhil8Q Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I000c348334242e6274b0de7cbd59b0eee23dd521 Reviewed-on: https://chromium-review.googlesource.com/1169163 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Balazs Engedy authored
While the layout of both the button row and the |content_view|, showing the sheet-specific content, inside the |client_view| was correctly invalidated, the |client_view| was never re-laid-out, so the newly added controls were never sized and positioned. This visually resulted in missing controls in the content area as well as missing buttons on the bottom row in 99% of cases, the remaining 1% being when we got lucky and the height of the dialog changed as a result of the step transition, in which case resizing the Widget triggered a Layout of its view. Bug: 849323 Change-Id: Ie615d467ea9ab7f95d5af0a44181ab172409672b Reviewed-on: https://chromium-review.googlesource.com/1172441Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582594}
-
Peter Mayo authored
With --enable-blink-gen-property-trees we don't repaint invisible nodes on the compositor, so we don't need to animate it, and so the console output is not present, nor are other animated changes. This is arguably better, but was being tested for naively. This is a reland of 8e33e9d2a04d284b061e024103dd36ba07daa32d > Change-Id: I625f85710ec803eb5f3515a95d84b4cf7d6ac2d1 > Reviewed-on: https://chromium-review.googlesource.com/1162075 > Commit-Queue: Robert Flack <flackr@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> Bug: 855691 Change-Id: Idea876e956be546c1b35a0646de9260b9450592e Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1169932 Commit-Queue: Peter Mayo <petermayo@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582593}
-
junweifu authored
Shape Detection runs on gpu process, so the Register in utility isn't necessary. BUG=646035 Change-Id: I3633650f2173ff566ce474f3b35e48658e99f785 Reviewed-on: https://chromium-review.googlesource.com/1170439Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Scott Violet authored
BUG=none TEST=none, comment only change Change-Id: Id7e78d9e36cacb125a030b9e1e9bfa17d5365e74 Reviewed-on: https://chromium-review.googlesource.com/1172724Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582591}
-
Gauthier Ambard authored
The FindInPage activity should only be shown when the FindInPage action is doing something. This CL adds a BOOL to know if the page can be searched. It is used to display the activity or not. Bug: 871260 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I514b67e4b7e0f00258c0c1a8310975394ac3468c Reviewed-on: https://chromium-review.googlesource.com/1172287 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
