- 22 Jul, 2020 40 commits
-
-
Scott Violet authored
This will make it easier to move the database into the favicon directory. BUG=1076463 TEST=covered by tests Change-Id: I98c64f1794530771ebcee70928b5d1e2f3d5445e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308933Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#790647}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f6d3a035..15011595 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7e34ede9b760fdf6cd0a2ce237b73625128eba44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311329Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790646}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d9e64e11. With Chromium commits locally applied on WPT: a02f2df5 "Implement Storage Access commands for TestDriver" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I150e6fd1ff03501edf18ffcbf7a389127fa0cb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311012Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790645}
-
Dale Curtis authored
PaintImage::GetContentColorUsage() and gfx::ColorSpace construction both use ad hoc methods for determining if the transfer function is PQ or HLG, instead use the new sanctioned Skia methods. R=ccameron Fixed: 1106417e Change-Id: Ia515c60d92d1733e4edfba369071050dd6805ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311123 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#790644}
-
Richard Knoll authored
This adds a mojo interface for the discovery page to find nearby devices and connect to one. For unknown devices we require an additional confirmation step to verify a connection id. The user has the option to accept or reject on the nearby-confirmation-page. Bug: 1099710 Change-Id: I308a7926efef61a3fa872051b00fcf35e62a8287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235516 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#790643}
-
Sangwoo Ko authored
This helps clients to decide when to rasterize ui::ImageModel. For instance, if a new ImageModel is same with the old one, they can skip rasterization. Bug: 1048901 Change-Id: I72ba2bdc71d9cde576f99fe5cbf3db994a8b6837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303747Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#790642}
-
Mike Dougherty authored
The page at the previous url was much more complicated than necessary for a network check so it could more easily fail for other non-network related issues. Bug: None Change-Id: I9f79cb9f948b090c065cf6b9f9331217e65b380d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311043 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#790641}
-
Ben Pastene authored
The bots no longer need to be in their own pool. After crrev.com/i/3177503 lands, they'll also be in the standard test pools. Bug: 1057152 Change-Id: I0d0f335a036156683d1f53334860569f427800d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311271Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#790640}
-
Ben Joyce authored
Temp filter to use to restore code coveage while working on a solution to combine all code coverage. Bug: 1107004 Change-Id: I3b011e038cc60b6692858d4e4179807fd43061fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311057 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#790639}
-
Alexander Cooper authored
Converts shell_integration::DefaultWebClientWorkerCallback to a RepeatingCallback, since it is used to pass the result of state queires. Converts callbacks for shell_integration::win::GetIsPinnedTaskbarState to Once callbacks, given that exactly one of them is called once. Converts the sole caller of GetIsPinnedTaskbarState to base::BindOnce. Converts the shell_integration::win::DefaultBrowserActionRecorder to use a OnceClosure, wince this matches it's usage. Updates a missed comment in process_resource_usage.h Switches the ChromeContentBrowserClient UnitTest to use a NullCallback. This matches the intention of the test, and can be used independent of updating the underlying API. Finally, with all top level usages of base::Bind/Callback cleaned up, modifies PRESUBMIT.py to replace chrome/browser with the children that still need to be converted. Where a directory has only one file that needs conversion, that file is listed. Otherwise, the deepest subdirectory under chrome/browser that has files that need to be converted is listed. Bug: 1007635 Change-Id: I2cbdcd37cd0da411e106c0f3b14b8f6e92d7209f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304129Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
-
Eliot Courtney authored
WaylandBufferManagerGpu assumes that it will always be called from the main GPU thread and only saves the task runner for the thread of the first caller. However, WaylandCanvasSurface runs on VizCompositorThread, so it's necessary to save multiple task runners. Bug: 1103101 Test: Launching chrome no longer DCHECKs per the bug Change-Id: I8277ca17a1bbbe572c6471fb86df42046efb3be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306128Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#790637}
-
chrome://media-appDavid authored
Wraps calls to the crash reporter in reportCrashError that is called whenever there is a console.error, in doing so we need to build up the error from any number of arguments since console.error can be called with (...*). Also adds this for onerror & unhandledrejection handlers in trusted context & tests. I think there might be some errors in the trusted context we aren't picking up on because I don't think we guarantee the app initializes before these errors occur and so the error reporter (in index.ts) wouldn't be initialized. This cl makes console.error use crashReportPrivate.reportError() so we can keep track of such errors. This may lead to launch code such as LaunchWithDirectory not erroring which may be related to b/160104958. Bugs: b/156205603 Change-Id: I404e870a9786ebe5371409c963a5140381d59126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301652Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#790636}
-
Nathan Zabriskie authored
Recently SharedImageInterface::CreateSharedImage was changed to accept the surface origin and alpha type of the shared image. This change passes along |is_origin_left| for canvas resources which is necessary for OOPR Canvas. Bug: 1034086 Change-Id: I901b361bf6ad400d23cf9616a76df16afd94d0b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310609 Auto-Submit: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#790635}
-
K. Moon authored
Switches PaintReadyRect from a struct to a class, since this type can enforce invariants like most members being immutable. Bug: 1099020 Change-Id: I79ed7dcb60273c3db0d5223a64fd5e7cdeb0e633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311069 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#790634}
-
Jeff Yoon authored
Change subprocess.call to check_call such that the non-zero exit codes are throwing subprocess error accordingly. Change-Id: I71597e3e48c0908ea10e98281f6843ae23308250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310894 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790633}
-
Xinghui Lu authored
Bug: 1041912 Change-Id: Id2ff5e55264f66767e144fbc288ae888c22ba26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303856 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790632}
-
nancylingwang authored
This is the follow up for CL:2251600. Modify the ARC code to use the new mojom interfaces and structure RawIconPngData. TODO: Add some test cases for the adaptive icon. Design doc: go/appservice-adaptive-icon BUG=1083331 Change-Id: I1600d11af9a6477e6923f8e1f43d79fa52cf79f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286251 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790631}
-
Chris Cheng authored
The 'android_lollipop_marshmallow_coverage_gtests' copied every tests in "android_lollipop_marshmallow_gtests" and added two WebView tests on top of it. The CTS test and UI instrumentation test are recommended by WebView developers, which believe will greatly increase Android Code coverage on the WebView side. This the same as https://chromium-review.googlesource.com/c/chromium/src/+/2224832 but re-submit to fix auto merge conflict from presubmit Bug: 796389 Change-Id: I9a2038ff898d8684d6f65aadc3eaf73655a8f1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224832 Commit-Queue: Chris Cheng <chriscycheng@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#790630}
-
John Lee authored
Since there are no plans on launching the two up view for the old PDF viewer, this CL removes the original flag for it and updates usage to use the flag for the new viewer. Bug: 51472 Change-Id: I8245d641748bb6a7d8799688f34e8e0d5cfb0674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311130 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
Darwin Huang authored
The tests were failing at a lower rate on other OS's, but it seems they were indeed failing on other OS's. Generalize the [ Pass Failure ] TestExpectations from [ Mac ] to all platforms. Bug: 1104024 Change-Id: I78461aa43041776799930416f261f7271ca52ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311312Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790628}
-
Xianzhu Wang authored
Bug: 1104064 Change-Id: Idae3d296992c08ed9c2af032e345e57795b8fe34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309753 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#790627}
-
Dave Tapuska authored
To move the implementation into blink we first move the emulation messages. BUG=1093963 Change-Id: Ib87e8da814cd1756a2a4136515df1688763d221d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303367 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#790626}
-
John Delaney authored
This CL attaches impressions to context menu navigations that occur from anchor tags with impression attributes. This also declares the frame the context menu occurred in as the initiator routing frame for the navigation, which was previously null. Bug: 1049674 Change-Id: I7a2031b41865d44bc926c87af1fba86aa72048f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240198 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790625}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4181.3-1594638142-benchmark-86.0.4205.0-r1 to 86-4183.25-1595242326-benchmark-86.0.4207.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If7719142d813b4919b31610d597d522f72839af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310959Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790624}
-
Clark DuVall authored
This also removes the public_android_sdk check from the system WebView and trichrome versions, since those are now defined even when !public_android_sdk. Also a small cleanup to the --switch-webview-to arg, so we don't have to re-specify the package name, and can just pass the APK directly. Change-Id: Ib408c5db892cf51763684aca2f92d70f99366ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310876Reviewed-by:
-
Alex Gough authored
The active process limit is only checked on process creation so can safely be dropped to zero. This prevents reuse of the process handle to launch another process in the job after the contained process has terminated. Tested by existing tests. Bug: 1050359 Change-Id: I803ca74e6a654b46484a945925085e4444a1df07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308174Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#790622}
-
Katie D authored
TBR=tmartino@chromium.org Bug: 1084931 Change-Id: Ic89e67ad2f87e972aab271e3fb208bdd808920d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310808Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#790621}
-
Alan Cutter authored
Ampersands are used to indicate mnemonics in menu items. We must escape real ampersands before using them in menu item labels. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=457370&signed_aid=NdbKLbBf4ZUuOW9VvGbKOQ==&inline=1 https://bugs.chromium.org/p/chromium/issues/attachment?aid=457372&signed_aid=kcRyF6PZEi7SyoW3L6hG8A==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=457369&signed_aid=AIbAsCPsbM2MYSHtCskv7g==&inline=1 https://bugs.chromium.org/p/chromium/issues/attachment?aid=457371&signed_aid=NJP9QClLhZVOh5d-lP4piQ==&inline=1 Bug: 1106668 Change-Id: Ia3fe2950218ba3e227c588c74e4031a5edb210e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309830 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#790620}
-
Will Harris authored
WinCFG can be Enabled or Disabled depending on whether the CFG dispatch guards are compiled into the binary or not. BUG=584575 Change-Id: Ib4b76208ae839ddb8c5be264f741dee4eb389de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308030 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#790619}
-
Vasiliy Telezhnikov authored
GLRenderer/Webview use (Begin/End)BatchReadAccessSharedImage commands to mark begin/end frame in SharedImageBatchAccessManager. Currently it's tied to ScopedBatchedReturnResources which issues EndBatchReadAccessSharedImage after DrawAndSwap was done and so the command won't be flushed till next frame which leaves SharedImage in state where EndRead was called, but no fence was produced. To fix it and avoid extra flush move it to GLRenderer BeginDrawingFrame and FinishDrawingFrame, so it will be flushed with SwapBuffers call. Change-Id: I4452213c3081a700a991349d40aa65ea00a49dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302414Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#790618}
-
Erik Chen authored
This CL adds a new mb config that will be used by both the official and try codesearch builders for lacros. It also updates the try builder console. Bug: 1105242 Change-Id: I5e970b7213730c3bdf54ea786df252ed40200182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311035 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Edward Lesmes authored
gn check failed because util/status_builder.h doesn't exist. Change-Id: Ie0f2e2a93c61769854879dffb0f7327a2f837b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311031Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#790616}
-
Lan Wei authored
We should use gpuBenchmarking.smoothScrollByXY in fast/events/hit-test-counts.html instead of eventSender to simulate mouse wheel scroll. After scroll unification, we can scroll on compositor, that eventSender only scrolls on main thread. Bug: 1047176 Change-Id: Ic2bee891e89a25dd6622843beea1f9dc1c2f5821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270337Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#790615}
-
Becca Hughes authored
This is a reland of a1374a65 TBR=steimel@chromium.org Original change's description: > [Kaleidoscope] Public side of the color code > > Change-Id: I98b421dfac9adda34448c645c0432d7a9ad2455c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303854 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790186} Change-Id: I174e12ca3b61a1aecc5ed2838cde6d7b47d0319f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310897Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#790614}
-
Ken Rockot authored
Bug: 1059389 Change-Id: I09e70640a74fcfd3c10f278e8a777fe73ee87305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304540 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#790613}
-
Lei Zhang authored
They got added in https://crrev.com/787824 Bug: 1009837 Change-Id: Icd572904d3f9acde45a7220503f7b04a2a6b1019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310970Reviewed-by:
-
Tom Anderson authored
This fixes a regression I introduced after [1] which removed colormap creation code. It turns out the colormap is still necessary for transparent visuals, so this CL adds it back. [1] https://chromium.googlesource.com/chromium/src/+/ae0a09cefaca3445bf43b0abefe3d068794388c0 R=sky Change-Id: I3d29ced609ab3f915f9b7cdbdce6f4e8b2a5dce1 Bug: 1106334,1107385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311070 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
Modern kdialog versions support passing in filters in the format SelectFileDialog has them, avoiding the need for a lossy conversion via mime types. Detect the kdialog version and make use of this. A downside of this is that is now much more obvious that always passing 1 as "selected filter index" to select file callers is wrong. But unfortunately kdialog does not provide a way to figure out which filter was selected when multiple filters could match the returned file. At least this isn't more broken than it was before. Bug: 1108060 Change-Id: Ie39baf0dfb0664e366d7ae1574303a66ab8e2de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311056 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#790610}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5933d7d54fb8..324578b5537d 2020-07-21 tdenniston@google.com Add toy stroker sample 2020-07-21 adlai@google.com Revert "Migrate SkImage::makeWithFilter to GrRecordingContext" 2020-07-21 johnstiles@google.com Remove support for multiple coverage processors from GrPaint API. 2020-07-21 michaelludwig@google.com Reland "Support moving blocks from one allocator to another" 2020-07-21 fmalita@chromium.org [skottie] Cleanup post https://skia-review.googlesource.com/c/skia/+/303997 2020-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from f73242142ce5 to fc0d614b6313 (1 revision) 2020-07-21 robertphillips@google.com Rename GrRenderTargetContext::getContext to recordingContext 2020-07-21 reed@google.com make more constructors constexpr 2020-07-21 bsalomon@google.com Rename GrTexture/Proxy/Priv mip map members/functions 2020-07-21 adlai@google.com Migrate SkImage::makeWithFilter to GrRecordingContext If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Ifa7fba68836bb83fe3ac4f5211ae475ac76bc7d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311132Reviewed-by:
-
Yann Dago authored
Bug: 1095223 Change-Id: Ic9d3ceb5eba994b9c0328aa7a8661fb8492ae5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303909 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790608}
-
