- 19 Oct, 2020 40 commits
-
-
Dave Tapuska authored
The WidgetHostMsg_Close_ACK message was overloaded to keep view state around until the widget (which is owned by the view) was fully destroyed. This can be accomplished by using a callback on the DestroyView mojom message instead of waiting around for the Widget to be destroyed. BUG=1097816 Change-Id: Ibbb92eaaba7e8c4a6b05217072a5367355fac708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471260 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#818609}
-
Charlie Hu authored
This CL copies existing feature policy WPT tests to a permissions-policy directory with permissions policy header syntax. PS1 is the exact copy, reviewer can compare latest PS with PS1 to view the actual changes. Bug: 1095641 Change-Id: I56b767a7f2372f58ab086b3cc4f945398d2877c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432665Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#818608}
-
Adrienne Walker authored
IndexedDBPreCloseTaskQueue runs compaction tasks that block shutdown. This didn't used to happen in the past when it was run on a separate thread, but now that these are run via the task scheduler they are causing hangs during shutdown. During shutdown there is (presumably?) a race between ~IndexedDBContextImpl and ~IndexedDBOriginStateHandle. If the context is destroyed first, it calls IndexedDBOriginState::ForceClose which prevents the pre close tasks from running. If the handle is destroyed first, it starts a 2 second timer in origin state, and then starts running the pre close tasks. Although the compaction tasks cannot be interrupted, this patch makes it so that if the last handle is destroyed first, and the context is destroyed before the compaction starts, then it will not run the pre close tasks and will stop any running timers. Future follow-ups to consider include making the grace period timer longer than 2 seconds. Bug: 1086185 Change-Id: I9f9276c6e18d00f43a43d5d002ce85c7cf5240ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476721Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: enne <enne@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#818607}
-
Eric Orth authored
Unless |fast_timeout| is used (which will maintain previous behavior of timing out immediately after the last attempt), on fallback of the last attempt, a timer is run to time out the transaction. Also doing the same on errors with the last attempt as long as at least one previous attempt is still pending. And the transaction will also return errors immediately if it was from the last pending attempt. Bug: 1109792 Change-Id: Ibc8ed54428fcba247ed3526fa41584e27a118e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464068 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#818606}
-
Alexander Surkov authored
the formatted tree Correct implementation of https://chromium-review.googlesource.com/c/chromium/src/+/2412192: * optimal since children are not populated and not appended into a tree dictionary structure * clean because all logic is kept by tree formatter Bug: n/a Change-Id: Ic4108c407d6f6d9b4786dd188efbd57b4648684d AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481762Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#818605}
-
Eric Orth authored
Convert and simplify all the type-specific builders to use them. Also convert integrity tests to just use a generic builder because the integrity-specific builder only ever took raw bytes anyway. Change-Id: I1972c9aaf79b749ed82516fccd473547b2c931ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477535Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#818604}
-
Justin Miron authored
Introduces a browser test with nested cross-origin (out of process) iframes that transforms the child iframe into the viewport. The test then verifies that the intersection observer reports that the frame intersects the viewport. This test catches the breaking behavior in https://crbug/1084786. BUG=1088458 Change-Id: I2ec2f9635cad2ab54d07e5f04757348042b30597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231498Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Justin Miron <justinmiron@google.com> Cr-Commit-Position: refs/heads/master@{#818603}
-
Mark Yacoub authored
#1 Rather than assigning the atomic plane props and setting them on property_set, split the operation into 2 disctinct actions: 1. Assign the props into local properties pending to be committed. 2. Set the properties on the property_set. This means, to set the plane props, we assign the properties in SetPlaneData then SetPlaneProps on property_set right before we're about to atomically commit. (operations can happen at 2 different times) #2. Also. always set fence_fd even if the value is invalid as long as the prop ID is valid. BUG=1082882 TEST=planes are visible on displays. Change-Id: If12b15025e3fcabb72d26959a77c695f63a6388b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481523Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#818602}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c45ca0dd90a..792630c498fc 2020-10-19 tandrii@google.com git cl try-results: show running jobs in YELLOW color. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ic65815bafdd39f44bdbea21979759d74766a6da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485599Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818601}
-
Ahmed Fakhry authored
The video file handler is responsible for creating the webm file in preparation for appended the successive video chunks as they get received from the recording service. Since there can be hundreds of chunks received per second, it also takes care of buffering those chunks to save on file IO operations. It guarantees all IO operations are done on a blocking thread as well as its destruction to assert that all cached contents are flushed to the file. BUG=1126586 TEST=Manually, added new tests. Change-Id: I304f3abdb0b225b24ccbbdb0db8e3cc877512bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463457Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#818600}
-
My Nguyen authored
There's no reference to these methods. GetAcceptLanguageList() Added in https://crrev.com/397723002 Usage removed in https://crrev.com/c/602884 (file deleted) GetCurrentKeyboardLayout() Added in https://crrev.com/417103003 Usage removed in https://crrev.com/c/907973 Bug: none Change-Id: I068165ffb17f3e024027e03263476d0acd4a595c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473859Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#818599}
-
manukh authored
Test was added on 10/12/20 with crrev.com/c/2464202. Bug: 1138113, 45260 Change-Id: I7621a5316a4bc14be55f63cd9716c12ffb772aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485844Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#818598}
-
Peter Kotwicz authored
This CL: - Generates monochrome_python_tests.pydeps using --gn-paths flag - Adds run_isolated_script_test.py data deps to monochrome_public_apk_checker.py - Adds //testing:run_isolated_script_test target to collect the data deps for monochrome_public_apk_checker.py BUG=1138758 Change-Id: Ifffa033368980923e2587e52ff50d35eeae2f271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483664Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818597}
-
Steven Bennetts authored
This removes the remaining DictionaryValue usage from shill client and fake client classes. For minor apitest.cc change to c/b/e/api/vpn_provider: TBR=emaxx@chromium.org Bug: 1137487 Change-Id: Id3a84f1392f0d1586342b4441ad200f0a41110e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466931 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#818596}
-
Evan Stade authored
action-link no longer exists on the NTP. Bug: none Change-Id: I4df61932f6b1885bd98a56f4963aead4dafe352c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480889Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#818595}
-
Christopher Cameron authored
Change AppShimManager::AppState::ShouldDeleteAppState to return true if the app is not installed for any profiles. Previously, the app would continue running even after it had been deleted, resulting in all sorts of cool behaviors. This winds up being hit in two paths. First path is the AppShimManager::OnAppDeactivated call that is made when a profile closes its last app window. This fixes crbug.com/1139254 where an app kept running even after it was uninstalled. Second path is AppShimManager::OnProfileMarkedForPermanentDeletion, for when a profile is deleted. This is for crbug.com/1132223 and is a bit more involved. * Listening for chrome::NOTIFICATION_PROFILE_CREATED/DESTROYED has been deprecated for a half-decade, so change AppShimManager to be a ProfileManagerObserver instead. * Inline AppShimManager::CloseShimsForProfile to be a lambda inside of OnProfileMarkedForPermanentDeletion. * Of note about ProfileManagerObserver is that closing app shims inside OnProfileMarkedForPermanentDeletion can cause crashes because it is not expected that Browser instances will be closed inside that call. For that reason, post a task to do the work. Update tests (because now they're affected by the AppShimRegistry) and add tests for both paths (shim installed vs uninstalled). Since AppShimManager is now a ProfileManagerObserver we have to make sure that the AppShimManager stops observing the ProfileManager before the ProfileManager is destroyed. To do this, a new call, BrowserProcessPlatformPart::BeginStartTearDown, which happens at the beginning of BrowserProcessPlatformPart::StartTearDown. Bug: 1139254,1132223 Change-Id: I19990f6ae5ff8d8727e1fb0ecf46d1142b543764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481790Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#818594}
-
Devlin Cronin authored
This reverts commit 78b97c89. Reason for revert: causes TSAN failures in: RenderViewBrowserTest.ConfirmCacheInformationPlumbed DomSerializerTests.SerializeHTMLDOMWithEmptyHead DomSerializerTests.SerializeHTMLDOMWithoutDocType Manual revert to due (small) merge conflicts Originally reviewed on: https://chromium-review.googlesource.com/c/chromium/src/+/2378763 TBR=bungeman@chromium.org Bug: 1126992 Change-Id: Id3c1460de179d333710d4438fd81563548eed4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485557Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818593}
-
Brandon Wylie authored
Change-Id: Id23ebabc4f86c5b2a2bc6b88d69877aad9c8bcf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425030 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#818592}
-
Richard Chui authored
Change the cursor type based on capture mode state and cursor location in screen. Test: manual, added test Bug: 1135700 Change-Id: I57af8b672bf6f0e04a422ed5be4fe40468fcc3ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454838 Commit-Queue: Richard Chui <richui@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#818591}
-
Sammie Quon authored
Users have reported a subtle flash during the overview animation. This is because the current cross fade animation fades out the old layer while fading in the new layer. This will cause the combined opacities of the two layers to be 1 at the endpoints, but less than 1 in between, resulting in the middle of the animation being slightly dimmer. Discussed with UX in the bug, and make the only the old layer fade out. This will result in the combined opacity always being 1. Test: manual Change-Id: Iacc7adcbc424f59656d7876bfecf32e3cb048b2d Fixed: 1124947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481002 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#818590}
-
Olga Gerchikov authored
Currently existence of non passive wheel event handler is tracked on a frame level on cc. This requires main thread to process all wheel events before scroll may begin on cc thread regardless if the scroll was performed outside of a wheel region. This change computes blocking wheel handler regions on main thread and passes this information to cc, thus enabling starting composited scrolls, when outside the blocking handler region, without querying the main thread Changes made: - The feature is implemented behind cc feature flag, WheelEventRegions. - Track if a given LayoutObject has a non-passive wheel event handler on itself or an ancestor that the wheel event could bubble to. To implement this tracking, we update a bit on the LayoutObject, InsideBlockingWheelEventHandler, during the PrePaint walk. This bit will be used during invalidation and painting to update hit-testing information on the generated paint chunks later in the pipeline. Additionally, support for this bit is added to the display locking code to keep wheel event handler updates from updating content in locked sections of the dom until the unlock occurs. - Blocking wheel event regions are generated in the same manner as touch action regions. First, paint adds blocking wheel event rects to the HitTestData's wheel_event_rects associated with the relevant PaintChunks. Later, these PaintChunks are iterated through in PaintArtifactCompositor::UpdateWheelEventRects to create a region that is passed to the Layer. - Blocking wheel event regions are passed from cc::Layer to cc::LayerImpl as part of PushPropertiesTo mechanism. This allows cc's wheel event routing to avoid sending wheel events through the renderer's main thread when they do not intersect with a rect that has a wheel event listener present, leading to improved latency. See design doc: https://docs.google.com/document/d/1ar4WhVnLA-fmw6atgP-23iq-ys_NfFoGb3LA5AgaylA/edit#heading=h.4wyzpk30wixv Bug: 841364 Change-Id: If9291332fcb49127d6defd4c7d324568597931c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419718 Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Sam Fortiner <samfort@microsoft.com> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#818589}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I24e743ef969cc30668d8be7a550b10e88c3d1170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486051Reviewed-by:
-
Joon Ahn authored
https://screenshot.googleplex.com/5ywKyKorL3QKeCj Bug:1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I9c8641b7ddfeebefede0984fdeb0248d7bcec8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477660Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#818587}
-
Anders Hartvoll Ruud authored
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/Wodp9dSSdL8/m/OZo2vJqTAwAJ Fixed: 568705, 808904, 1127343, 1127347 Change-Id: Ib81bf8243cc57124ac5e781e5d6da5d4b09d7edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484600Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#818586}
-
Henrique Nakashima authored
This reverts commit 7002dd78. Reason for revert: Causes test flakiness: crbug.com/1139549. Unintended behavior change. Original change's description: > Log tab switch latency histograms through RecordHistogram > > Remove JNI calls that do only that and record through the Java API. > > Bug: 1139081 > Change-Id: I6f22bca96f8e3bd2de125d6e302d12eadb5e4301 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473042 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818043} TBR=dtrainor@chromium.org,hnakashima@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1139081, 1139549 Change-Id: I7239091d6f7bb2fefd959b120625b834921d1881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485637Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#818585}
-
Joe Downing authored
This fix is a result of an investigation to find out why KeyboardLock stops working after approving the microphone permission on another website (even after it has been navigated away from or the tab closed). I tracked the issue down to this class as it registers a RawInputDevice to listen for keyboard input but failed to unregister it properly when the monitor was stopped. Per MSDN, the HWND param should be NULL when unregistering the device: https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-registerrawinputdevices Change-Id: Icf54f3ac61fe5020b00472e6680e4e533b1fd256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482044Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/master@{#818584}
-
Harry Cutts authored
As khorimoto@ pointed out on crrev.com/c/2471900, each assertion (or expectation) looking at `offsetHeight` directly is rather hard to read, and doesn't make it clear what's actually being tested. This CL changes all visibility assertions and expectations to use the same `isVisible` method. Bug: none Test: check the tests pass, and fail if `hidden` is added to an element Change-Id: I21dacaca741324c20b671748cea71e4c885b9d7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484931Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#818583}
-
Brian Salomon authored
Bug: 1139118 Change-Id: I93ac21edbeb2317f677770b32dfe482715e44c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481355Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#818582}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Iad5b936d495d48cae46e6c119a542c1d650d592d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485136Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#818581}
-
Martin Kreichgauer authored
This removes logic for obtaining a pinUvAuthToken in MakeCredentialRequestHandler in favor of using AuthTokenRequester. There should be no behavior changes as to whether PIN or internal UV is requested for a given makeCredential request. (And existing PIN/UV-related test cases in authenticator_impl_unittest.cc provide decent coverage to ensure that this is indeed the case.) There is a small change in handling authenticator removal mid-request: This would previously only abort the request if the handler was waiting for a PIN. It now generally aborts the request as long as an authenticator has been chosen, but the request hasn't finished (e.g. because a it is waiting to enroll a biometric template). Also changes VirtualCtap2Device to return CTAP2_ERR_UV_BLOCKED if a failed UV attempt locks the authenticator, as the spec prescribes. Bug: 1139111 Change-Id: I4c07b16294ffba4a15ea813e182ad669645bf703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469445 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#818580}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e6d60bea7801..46e1bcace932 2020-10-19 tvanderlippe@chromium.org Remove pre_generates_legacy from module.json files 2020-10-19 tvanderlippe@chromium.org Unconditionally use object notation for dispatchers 2020-10-19 tvanderlippe@chromium.org Remove rollup_module from build_release_applications 2020-10-19 tvanderlippe@chromium.org Remove Dispatcher protocol types 2020-10-19 karntino.c.areros@gmail.com enable CTRL key operation on value widget/decoration 2020-10-19 sigurds@chromium.org Add API section to frame details view 2020-10-19 pfaffe@chromium.org Fix two minor issues in node.py 2020-10-19 aerotwist@chromium.org TypeScriptify AnimationTimeline.js 2020-10-19 alexrudenko@chromium.org Fix grid labels rendering 2020-10-19 sigurds@chromium.org Add more information to error reporting on connection close If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1090846,chromium:1131500,chromium:1138492,chromium:1139897,chromium:1139899 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I32f6e230e96465f5eff9f6614a2039392410582e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485600Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6883db53569f..6d3d381e7251 2020-10-19 geofflang@chromium.org GL: Update BufferGL to use ANGLE_GL_TRY. 2020-10-19 jmadill@chromium.org Test Runner: Disable watchdog when debugger attached. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I0588d2df0313d197d59fa74ac9be23f4fb9a8357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485601Reviewed-by:
-
Devlin Cronin authored
TBR=jdonnelly@chromium.org Bug: 11401539 Change-Id: Ia9963196b784a1e1b923d488af722df2bff000de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485440Reviewed-by:
-
Alison Maher authored
This change adds support for the prefers-contrast media query and adds PreferredContrast to settings. The logic for updating PreferredContrast from its default state based on the OS will be implemented in a follow-up change. Spec: https://drafts.csswg.org/mediaqueries-5/#prefers-contrast Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/I0e2_nAwW7E Bug: 1107431 Change-Id: Ie09df9069c979caf944d8af1d5f6bde80f40e8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410646 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#818576}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/abdfd39bb64e..bcd1fc030a2b 2020-10-19 johnstiles@google.com Avoid changing built-in symbol tables during lookup. 2020-10-19 kylechar@chromium.org Add context option to disable mipmap support 2020-10-19 johnstiles@google.com Add builtin flag to SymbolTable. 2020-10-19 mtklein@google.com fix forward/backward jump logic If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1138979 Tbr: egdaniel@google.com Change-Id: Ieace4fcdc667f15bf303181cc235039a3d0752b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485611Reviewed-by:
-
John Delaney authored
Uncomments per-file owner now that alexmt@ is a committer Change-Id: I501de30a9afde3c7a758c8957a6923dd3149829a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481703Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Commit-Queue: Ravi Mistry <rmistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#818574}
-
Theresa Wellington authored
BUG=1138236 Change-Id: Ice5140053b6216c6a2f9300a9da71f6d079f4550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482182 Auto-Submit: Theresa <twellington@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#818573}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I6ce4cd4c98d1c689d1526d5877d803cab31ac5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485638Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#818572}
-
Owen Min authored
The extension request will be uploaded to DM server right after user request it. This may significantly increases the DM server traffic. Put this functions behind feature flag so that we could turn it off just in case. Bug: 1137964 Change-Id: Ia056ddd356d068680c63d1e7650b4f1ea3a923be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472459 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#818571}
-
Daniel Murphy authored
This fixes an issue I introduced in m85 here: https://chromium-review.googlesource.com/c/chromium/src/+/2181827 during our migration of all "bookmark apps" off of the extensions system and onto the WebAppProvider system. Making YouTube no longer a 'bookmark app' (and back to a hosted app) had the side effect of making its storage protected, because apparently all hosted apps have their storage protected. This change marks all potential default hosted apps as no longer receiving protected storage. The long term fix for this issue is to have the WebAppProvider system support default apps, and migrate these old hosted apps (which is a double-deprecated system) onto the WebApp platform: https://bugs.chromium.org/p/chromium/issues/detail?id=1140122 R=cmp@chromium.org Bug: 1139902 Change-Id: I0d09eed3bf232407192fd07e621b82bcac4263f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485436Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
-
