GitLab

Cr-Commit-Position: refs/heads/master@{#415550}

This lets us avoid all of the string copies and externalization costs for the
key names when getting properties.

BUG=615174

Review-Url: https://codereview.chromium.org/2285183005
Cr-Commit-Position: refs/heads/master@{#415549}

BUG=641851
R=dgozman

Review-Url: https://codereview.chromium.org/2297443002
Cr-Commit-Position: refs/heads/master@{#415548}

BUG=641643
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2291753002
Cr-Commit-Position: refs/heads/master@{#415547}

This small refactoring removes device scale factor from AwContents
cache and uses the value from ContentViewCore.
The device scale factor in ContentViewCore is defined after
ContentViewCore native initialization, therefore this CL also
moves the device scale propagation until after that.

This is a prerequisite for https://codereview.chromium.org/2300463002

BUG=632461

Review-Url: https://codereview.chromium.org/2288273003
Cr-Commit-Position: refs/heads/master@{#415546}

EventListeners array hold references to the objects which
they were listening to, preventing them from being
cleaned up.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2298473003
Cr-Commit-Position: refs/heads/master@{#415545}

As CachedMetaData::m_serializedData is set only at the initialization timing,
we can call Vector<char>::reserveCapacity to save memory consumption without
loosing performance.

This CL includes other cleanups:

 - Renaming methods,
 - Replacing error handling logic with DCHECKs,
 - Replacing unsigned with uint32_t.

BUG=636462

Review-Url: https://codereview.chromium.org/2258743002
Cr-Commit-Position: refs/heads/master@{#415544}

- Adds a bunch of conversion functions between physical and logical offsets and sizes.
- The NGAlgorithm now outputs a NGPhysicalFragment (NGFragment output doesn't make sense in this instance as would immediately get unwrapped and destroyed).

BUG=635619

Review-Url: https://codereview.chromium.org/2282213002
Cr-Commit-Position: refs/heads/master@{#415543}

WebView's text selection handles(TouchHandleDrawables) should be
notified when their container view gets swapped out to be
repositioned accordingly. This is now being done through
|ContainerViewObserver| in |ContentViewCore| which is slated for
removal as a part of content layer refactoring.

This CL makes use of a new interface method in
|SynchronousCompositorClent| to let AwContents manage the handles
directly, and notify them of the event of the container view switching.

BUG=624977

Review-Url: https://codereview.chromium.org/2263043002
Cr-Commit-Position: refs/heads/master@{#415542}

This patch:
- introduces WI.IsolatedFileSystemManager.fileSystems() method. This allows
  to avoid type casts.
- splits out WI.NetworkMapping._addMappingsForFileSystem to avoid creating
  artificial event.

BUG=none
R=dgozman, pfeldman

Review-Url: https://codereview.chromium.org/2295693003
Cr-Commit-Position: refs/heads/master@{#415541}

Revert of Clean up paint expectations. (patchset #2 id:20001 of https://codereview.chromium.org/2286393002/ )

Reason for revert:
In spite of the CL description this CL changes the expectation.

Original issue's description:
> Clean up paint expectations.
>
> No change, just re-ordering.
>
> TBR=chrishtr@chromium.org
> BUG=636475
>
> Committed: https://crrev.com/079b912c02a8838fbf2f246c3215d359d50df7a5
> Cr-Commit-Position: refs/heads/master@{#415422}

TBR=chrishtr@chromium.org,schenney@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=636475

Review-Url: https://codereview.chromium.org/2299503002
Cr-Commit-Position: refs/heads/master@{#415540}

Review-Url: https://codereview.chromium.org/2295673002
Cr-Commit-Position: refs/heads/master@{#415539}

Highlight JavaScript booleans, null, undefined, etc as pink

BUG=none

Review-Url: https://codereview.chromium.org/2294113002
Cr-Commit-Position: refs/heads/master@{#415538}

This CL makes mojo::Watcher run on the correct task runner instead of the
default task runner of the main thread.

BUG=603396

Review-Url: https://codereview.chromium.org/2274833002
Cr-Commit-Position: refs/heads/master@{#415537}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/4d356cb6646e17da23a490ec3b1dea4577e24283 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/06e2710700b619355253228d7c2caa1bc76e13bc Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/a93ebc8b69c18bce873f4df1979b6534f3c13e68 Organize environment whitelist, add PYTHONUNBUFFERED. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=635641

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2289303003
Cr-Commit-Position: refs/heads/master@{#415536}

Remove abstraction for PlatformKeyboardEvent and use WebKeyboardEvent
directly inside core.

BUG=625684

Review-Url: https://codereview.chromium.org/2290313002
Cr-Commit-Position: refs/heads/master@{#415535}

BUG=493815
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2293833003
Cr-Commit-Position: refs/heads/master@{#415534}

Some gl functions have not been bound,if no context created before.

BUG=

Review-Url: https://codereview.chromium.org/2273483004
Cr-Commit-Position: refs/heads/master@{#415533}

Currently, if CreateBlimpContents() is called more than once, multiple
BlimpContents are created with the same kDummyTabId. In this CL,
1. BlimpContentsManager will return nullptr if CreateBlimpContents() is
called when there's an existing BlimpContents.
2. If BlimpContentsManager returns nullptr, BlimpClientContextImpl won't
set the delegate.
2. TabBlimpContentsObserver won't be added in Tab.java

BUG=642216

Review-Url: https://codereview.chromium.org/2299453002
Cr-Commit-Position: refs/heads/master@{#415532}

Revert of Switch context_lost test to gpu_integration_test harness. (patchset #4 id:60001 of https://codereview.chromium.org/2297623002/ )

Reason for revert:
Broke context_lost tests on Android as seen on https://build.chromium.org/p/chromium.gpu.fyi/console .

Original issue's description:
> Switch context_lost test to gpu_integration_test harness.
>
> BUG=352807
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> TBR=zmo@chromium.org
>
> Committed: https://crrev.com/d89cde2c1cfa24e74c97efa88170ed80637f2ae5
> Cr-Commit-Position: refs/heads/master@{#415456}

TBR=zmo@chromium.org,vmiura@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=352807

Review-Url: https://codereview.chromium.org/2292323003
Cr-Commit-Position: refs/heads/master@{#415531}

type_traits adds std::is_arithmetic which is used in
safe_conversions_impl.h, however this header was not
included.

This is reported as an error by flycheck-clang (using my
system clang version 3.4, system headers, and --std=c++1y),
and is causing every source file that has
safe_conversions_impl.h as a dependency (about 13,000 of
them) to fail to syntax check anything after the include.

Review-Url: https://codereview.chromium.org/2295903002
Cr-Commit-Position: refs/heads/master@{#415530}

Before, it was not set anywhere for Android builds, so it was
defaulting to 0, which made the Google Cast app think that it
was a Cast TV.

BUG=Internal b/31097743

Review-Url: https://codereview.chromium.org/2282263002
Cr-Commit-Position: refs/heads/master@{#415529}

R=dgozman@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2293253002
Cr-Commit-Position: refs/heads/master@{#415528}

Review-Url: https://codereview.chromium.org/2298593002
Cr-Commit-Position: refs/heads/master@{#415527}

There is code in MimeHandlerViewContainer::OnReady to make a http request for
the PDF if it is loaded in an embedded context. This code was errorneously
being run for top level PDFs as well, causing two requests to be made. In most
cases this second request would be cancelled straight away but it actually
isn't needed at all.

BUG=587709

Review-Url: https://codereview.chromium.org/2287213002
Cr-Commit-Position: refs/heads/master@{#415526}

BUG=

Review-Url: https://codereview.chromium.org/2270083002
Cr-Commit-Position: refs/heads/master@{#415525}

BUG=internal b/30114788

Review-Url: https://codereview.chromium.org/2294093003
Cr-Commit-Position: refs/heads/master@{#415524}

This CL allows polymer-based OOBE to continue on chrome restart.

BUG=604119
TEST=none

Review-Url: https://codereview.chromium.org/2289643003
Cr-Commit-Position: refs/heads/master@{#415523}

WebSocket implementation in content/browser was moved from
content/browser/renderer_host to content/browser/websockets. This change
updates the OWNERS information.

BUG=None

Review-Url: https://codereview.chromium.org/2288943003
Cr-Commit-Position: refs/heads/master@{#415522}

BUG=637923

Review-Url: https://codereview.chromium.org/2295923002
Cr-Commit-Position: refs/heads/master@{#415521}

BUG=chromium:633253

Review-Url: https://codereview.chromium.org/2295803002
Cr-Commit-Position: refs/heads/master@{#415520}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/625c7670..af009a36

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2298573002
Cr-Commit-Position: refs/heads/master@{#415519}

Change ExtensionService::AddProviderForTesting() to take
unique_ptr instead of raw pointer.

BUG=556939
Test=None, internal only change.

Review-Url: https://codereview.chromium.org/2294653002
Cr-Commit-Position: refs/heads/master@{#415518}

BUG=3333

Review-Url: https://codereview.chromium.org/2288353002
Cr-Commit-Position: refs/heads/master@{#415517}

This is on by default and appears to have stuck.  Removing this flag
allows for followup patches to remove old code that will then be dead.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2297923002
Cr-Commit-Position: refs/heads/master@{#415516}

I'm working on improving our build process so we can use npm modules
on buildbots (e.g. linting, type checking).

I copied these two python scripts from the infra team which will be used
by our buildbot recipe to install and run a local installation of node.js.

Original code here:
https://cs.chromium.org/chromium/infra/node/

BUG=642046

Review-Url: https://codereview.chromium.org/2278803004
Cr-Commit-Position: refs/heads/master@{#415515}

https://pdfium.googlesource.com/pdfium.git/+log/8c54182aba44..77be04971c13

$ git log 8c54182ab..77be04971 --date=short --no-merges --format='%ad %ae %s'
2016-08-30 npm Clean up CPDF_CMap declaration

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2292413003
Cr-Commit-Position: refs/heads/master@{#415514}

To permit reuse in mus, relocate the reuseable portions of
ash/display/display_util.cc and ash/display/display_util.h into ui.

BUG=581462

Review-Url: https://codereview.chromium.org/2286523002
Cr-Commit-Position: refs/heads/master@{#415513}

In addition, this picks up a change to the Dropbox Expect-Staple
report URL. Looks like this change was made in the json file in
https://codereview.chromium.org/2129543003/ but not in the generated .h.

BUG=642550
R=lgarron@chromium.org

Review URL: https://codereview.chromium.org/2293283002 .

Cr-Commit-Position: refs/heads/master@{#415512}

1. Integrate connect call into Blimp settings UI.

2. Polish the connect functions in java and c++, now identity_source is
responsible for handling GoogleServiceAuthError::REQUEST_CANCELED, since
the Java approach(AccountTrackerService listener) didn't work with
non-startup connect attempts. And code structure is cleaner in this way.

3. Removed BlimpSettingsCallback, and moved embedder functions into
BlimpClientContextDelegate. Also added testing classes for
BlimpClientContext and BlimpClientContextDelegate, but these classes can
only test shim Java layer.

4. Created BUILD.gn for core/settings, and put jni files there. Java
file is still in core/, for easier review diff. There will be future CL
to move these Java files.

5. Added BlimpClientContextInternal Java interface to decouple internal build
targets.

BUG=624457

Review-Url: https://codereview.chromium.org/2261273002
Cr-Commit-Position: refs/heads/master@{#415511}