- 12 Aug, 2020 40 commits
-
-
Tomasz Wiszkowski authored
Bug: 1085184 Change-Id: Idcaa9416a06fa8f08ab52aeb4c9ab89b4a4e94fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347406Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#797367}
-
Yusuke Sato authored
BUG=None TEST=None Change-Id: Iffca1cb97e79d336a3b41bdbefdf441f98cca6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350237Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#797366}
-
Marc Treib authored
This CL adds the plumbing in ConsentAuditor[Impl] to record this new type of consent, and the corresponding sync proto messages. It's not used so far; that will follow in another CL. Bug: 1111252 Change-Id: Ib528273e88bfbd6546e6d1fc26c0884fef1e6e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351923 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#797365}
-
Michael Crouse authored
This addresses attempting to clear a nonexistent blocklist on history clear. This also adds a nullptr check for the HintsAgent before determining if a hint is available. Bug: 1115360,1115362 Change-Id: I2513c966d5a81eedd260363c28e328e97e08cab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351372 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#797364}
-
Stephen McGruer authored
This reverts commit af7117b8. Reason for revert: Tentative revert as suspect of https://crbug.com/1115630 . Will monitor + re-land if this doesn't fix the bot (with my apologies :)) Original change's description: > Remove refcount thrashes of value in setAttribute. > > This removes the refcount thrashes in Element::setAttribute() avoiding > nearly 13% of regression in blink_perf.bindings set-attribute.html story > when StringImpl is made threadsafe. > > Bug: 1083392 > Change-Id: Ia5fe7193c24ae8baa4f16a21a2a79f80e7dc0b5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351950 > Auto-Submit: Albert J. Wong <ajwong@chromium.org> > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797240} TBR=ajwong@chromium.org,jbroman@chromium.org Change-Id: I672f63ec54742db85ee1f699849eac24806d9af0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1083392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353115Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#797363}
-
Mark Pearson authored
Change-Id: I7e365794b24f3ca6879114371e6ce500d0ccd2dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350142 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#797362}
-
evliu authored
This CL updates the SODA component to be platform-specific. Bug: 1033227 Change-Id: I41bd61affc673b38d6029c83a3b7468121dc8c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348015Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#797361}
-
Yuwei Huang authored
The Chromoting team was the owner of //third_party/grpc, as we first introduced the gRPC dependency in Chromium. However, we have recently migrated our app from using gRPC to just using plain Protobuf requests over HTTP due to some network security concerns and the burden of maintaining the dependency in Chromium third_party. It appears that chromecast and libassistant is currently the only other users of //third_party/grpc. As previously discussed in the email and code review comments, this CL transfers the ownership of //third_party/grpc to chromecast and libassistant. Bug: 1103416 Change-Id: I07ae66ab05b7fc57d3b4fc3e6222585dacbad530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350189 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#797360}
-
Etienne Pierre-doray authored
Add JobHandle::IsComplete and pass worker_count as argument to max_concurrency_callback. To make better use of worker_lock, and accommodate worklist use case by exposing worker count: - worker_count is used in max_concurrency_callback in cases where the return value is inferred from it. In the worklist case, each active worker keep a local segment not visible globally, so worker_count is added to the global queue size. - IsComplete is used to make sure that no work is pending. In the worklist case, checking that we're done involves checking that the global queue is empty AND that worker_count == 0 (atomically), which is a lot easier when |worker_lock| is taken. This is used e.g. in marking to switch phase (we don't want to cancel or join) where we stop creating work. Bug: 1114823 Change-Id: I5efc5622aa70e731981a958a066ab56567c603ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304972Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#797359}
-
James Long authored
Two features have been added to the filter list: * Entries in the class filter list now have the package displayed below them in a smaller, lighter font. * A "delist unchecked" button has been added to the filter list, allowing users to quickly delist multiple elements. Bug: 1102546 Change-Id: I0815c789b6a11b657685ade4b0a1dea193c74e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350800 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#797358}
-
Elly Fong-Jones authored
Bug: 1046784 Change-Id: I7d9cb3b6cfdc44227d48764059cba366d3ab59ec Tbr: dgozman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346972 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#797357}
-
Rohit Agarwal authored
This CL changes the CCT overflow menu as follows: 1. The top action icon buttons in the toolbar would be always fixed i.e non customisable to: a) Forward b) Page Info c) Refresh only d) Bookmarks 2. The menu items in the toolbar would be always fixed i.e non customisable to: a) Find in page b) Desktop site c) Translate d) Share (this would be hidden by default, unless specified.) This CL also adds instrumentation tests and refactors some code out from CustomTabActivityTest to CustomTabsTestUtils which was needed to avoid duplication in the CustomTabActivityIncognitoTest. Bug: 1104180 Change-Id: I6c3d44cd3a32b7437a67bac0c66f894e4d2d62ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338935 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#797356}
-
Sam Fortiner authored
This feature is enabled by default for m85 builds and is on at 100% via finch for m84. There is no need for this feature flag any further in m86+ builds. Bug: 1058987 Change-Id: Ic210d55596cbacfaef928824b470e878a8132a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349968Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#797355}
-
Xiaohan Wang authored
Use //media/OWNERS instead of videostack-eng. Change-Id: I78b14cc17159383df9af51ce3c1ffc02008d770c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352690Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797354}
-
Rune Lillesveen authored
We computed ::first-line style to figure out if we needed to paint invalidate for ::first-line. Instead just use the cached style, and if the ::first-line style is null and we need the image for ::first-line, other mechanisms should have marked necessary bits dirty for ::first-line in the first place. This fixes a crash when active style is not up-to-date when ImageChanged is called for a LayoutBlock with ::first-line. Bug: 1115377 Change-Id: I8039bc67ddafc142fdc7582526a8ef623bbd1e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352890Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#797353}
-
Brandon Jones authored
The extensions attribute is a recent addition to the GPUDevice. Additionally, according to the WebGPU spec the name for the BC compressed texture extension should be "texture-compression-bc", while Blink had it exposed as "textureCompressionBC". Bug: 996713 Change-Id: I30e48a0ec4f8e3a3e492a96f2343f27b78d7d59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350123 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#797352}
-
Kevin Ellis authored
This reverts commit 008d0a49. Reason for revert: Decision on https://github.com/w3c/csswg-drafts/issues/5400 Original change's description: > Fix Animation::playState > > https://github.com/w3c/csswg-drafts/issues/5400 > > There is the issue that led to the spec change for play state: > > https://github.com/w3c/csswg-drafts/issues/2066 > > The issue addresses undesirable toggling of the play state due to > inactive timelines, but does not seem to adequately address having an > unresolved (null) timeline. > > > Bug: 1113382 > Change-Id: I33032ee1e9de10d3dce4958fce599bd98391328f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339676 > Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> > Commit-Queue: Kevin Ellis <kevers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796403} TBR=kevers@chromium.org,andruud@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1113382 Change-Id: I24aa0ef5c62f839573a70f063c1f25ce4281b2e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352513Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#797351}
-
Nick Diego Yamane authored
Hopefully a better (and not so generic) name for wm_* handlers sub-directory. R=sky@chromium.org Bug: None Change-Id: I7ba70777fd7f43b50d452913bc54f032424b21d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351459 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#797350}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/07b2e8df6cc8..3f2c3d7f4b2a $ git log 07b2e8df6..3f2c3d7f4 --date=short --no-merges --format='%ad %ae %s' 2020-08-11 renjietang Add 0-RTT related client events in QuicSpdySession::DebugVisitor so that Chrome will be able to net log. 2020-08-11 fayang In QUIC, do not send PING when PING alarm fires but ShouldKeepConnectionAlive returns false. Client side only, protected by ENABLED gfe2_reloadable_flag_quic_fix_on_ping_timeout. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src add new flag R=dschinazi@chromium.org Change-Id: Ia77cb6156ef8dcac937ccff8188de32cb9d37622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352434 Commit-Queue: Dan Zhang <danzh@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Dan Zhang <danzh@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#797349}
-
Dale Curtis authored
R=rsesek Fixed: 1113936 Change-Id: If9838c0a508efc5593dfd7170ec287021a945279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346852 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#797348}
-
Mario Bianucci authored
Flesh out the delegated ink renderer class a bit more, including a specific Skia flavor of it, with the expectation that others (software, GL) may come in the future. Storing the delegated ink points in this class as they arrive from the browser process, forwarding the metadata to this class from the aggregated frame, and filtering the points in the function that will eventually contain the drawing code. Bug: 1052145 Change-Id: Ic86e37d9ed1d24b6427fa6896b668de8d0402b8e Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296567Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#797347}
-
Henrique Ferreiro authored
A network.mojom.ReferrerPolicy field is added to DragData and blink::WebDragData, in the same way content::DropData has one. This prepares for a future in which DropData is replaced by DragData and allows the migration of DragHostMsg_StartDragging without adding an extra parameter for the policy. Bug: 1039255 Change-Id: Ief3493d8fad384dec8df58cb9c38602e29cd4413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339742Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#797346}
-
Mehrdad Hessar authored
This change enables experimenting with executing TFLite models during normal browser operation. The experiment's goal is to measure the performance of machine learning models using TFLite and Chrome's ML service. This will also enable us to measure any potential impact on the browser behavior when executing more sophisticated ML models, such as Language Identification and Translation, on-device. This creates a Keyed Service that handles construction of the TFLite model that navigations can query. This change also creates a WebContents Observer to allow experimenting with executing the model at various events during browser use, including navigation start, commit and load. This events will be added in later changes. This change also includes logging functionality so the necessary model execution metrics can be recording during local testing. Bug: 1115290 Change-Id: I4319065120bd8ff3952e770a24697e0bc7f478ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329162 Commit-Queue: Mehrdad Hessar <mehrdadh@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#797345}
-
Clark DuVall authored
We no longer support M80 so should be safe to remove this old loading code. This removes some complexity around loading and how we get the remote context. Bug: 1110811 Change-Id: Ied726f21682504c1ca5d8e93c07807a35c1af9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350023 Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#797344}
-
Omer Katz authored
Bug: 1030176 Change-Id: Ib820033632bbf107bf33710eadc343a7c48d5cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352929Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#797343}
-
Kalvin Lee authored
This change modifies several call sites in printing code to avoid constructing base::StringPiece instances from nullptr. This change is a reland of https://crrev.com/c/2313978 with some corrections. Bug: chromium:1110546 Fixed: chromium:1110546 Test: autoninja ... chrome printing_unittests Test: visually inspect printer status in print preview Change-Id: Ib6b903b5e4b6b4e44c2a79ef8b0bcc4703c6fb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347966 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#797342}
-
Xida Chen authored
This CL cleans up related code for the experied flag: disable-touch-adjustment Bug: 1110624, 304895, 417534 Change-Id: I36515f1f724fcaf6f09c1aa92d342bb742e3f933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346915Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#797341}
-
Richard Knoll authored
This introduces a base class for Outgoing and IncomingShareTargetInfo classes to hold common fields and make it easier to set them based on incoming vs outgoing contexts. Bug: 1085067 Change-Id: I120a291bd6d29e6d11cfbe0170bb23ba41570504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351990Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797340}
-
Roger McFarlane authored
Bug: 1073600 Change-Id: I7380518189c37eb6f396024da65b55a675f4e677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339798Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#797339}
-
Guillaume Jenkins authored
Add unit test coverage for the browser DM token storage delegate implementation on iOS. Bug: 1114853 Change-Id: I3c1421a47bfb6c55f516c08d493d488d0db66752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346920 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#797338}
-
Yifan Luo authored
This CL adds everything in TrustedTypePolicyFactory that changes were made to the spec that weren't reflected in the IDL tests description in `trusted-types.tentative.idl` test file. Change-Id: Iac7c68439a449d5437783daa7640ffcb1d3694a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290090 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#797337}
-
Marc Treib authored
This reverts commit dfb96619. Reason for revert: Likely made some Android tests flaky, see crbug.com/1115258 Original change's description: > Sync: Clean up remaining site of unnecessary deferred startup > > Followup to https://crrev.com/c/1989533 > > Sync supports delaying the engine startup by 10 seconds. This is meant > for avoiding contention during browser startup. > Before this CL, the 10-second delay would also apply in one other > (rare) situation, for no good reason other than some tests depending on > this behavior. Two of these tests were recently fixed (in > crrev.com/c/2339986), and the one remaining one is fixed in this CL. > With that, the delayed startup can now go away! > > Bug: 1035874 > Change-Id: I865d0bc3caac4d8f0712489ccbad526f912ccdce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343036 > Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796819} TBR=treib@chromium.org,mmoskvitin@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1035874, 1115258 Change-Id: Idde272bf1bd4325160346bd5d74c49bdf3f384a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352909Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#797336}
-
Ting Shao authored
This change implements the FetchEvent.handled API which gives developers the ability to intercept when the event is handled. Chrome Status: https://chromestatus.com/features/5654467158474752 Bug: 1039558 Change-Id: I8033d85d57ea6c331401006789713c0cb899aeac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114932 Commit-Queue: Ting Shao <ting.shao@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#797335}
-
Jeffrey Young authored
Set height of radio button to 100% to capture click events. BUG=b:162456206 TEST=click on top pixels of ambient mode photo gallery radio button Change-Id: I5a536e903768e606e29fef6658c9733549f53bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351553Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#797334}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5697d3550bc8..09afd88dfed8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie415008a41412c66f09bd3eefc63c1b471d6869f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352021Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797333}
-
Nick Burris authored
To run an origin trial, we need a UseCounter metric that simply counts every time the API is used. This patch adds a use counter to count when the payment request API is used with the "secure-payment-confirmation" payment method. Bug: 1110320 Change-Id: Ie72a3fbd27c7928e858d8e7b8f059dd915af3bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350247 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#797332}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/51d97b104f79..fc2bd2179672 2020-08-12 sigurds@chromium.org Offer to filter for offending request for error pages 2020-08-12 szuend@chromium.org [ts] Type-check ui/HistroyInput.js with TypeScript 2020-08-12 szuend@chromium.org [ts] Type-check ui/Glasspane.js with TypeScript 2020-08-12 jacktfranklin@chromium.org Rename newBreadcrumbs => breadcrumbs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093247 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I663e858feabb55290e2bfff17363c243abf8182d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352366Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797331}
-
David Maunder authored
We should only acquire Title if the Tab is initialized. Now with some attributes such as Title being moved to UserData objects we enforce this. Bug: 1114564 Change-Id: I876603c4126a24a1e6e8579f90cf7beb32e9871b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352511Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#797330}
-
Elly Fong-Jones authored
These tests were asserting that, when Views damages a specific rect within the BridgedContentView, AppKit was propagating the damaged rect all the way back to [BridgedContentView drawRect:]. There are two issues with this: 1) BridgedContentView does not implement drawRect:, and 2) Since BridgedContentView is layer-hosted AppKit is not supposed to track damage to it and is *supposed* to always call drawRect: on the entire thing It appears that AppKit in <= 10.15 did bother to track the damage and invoke drawRect: only on the damaged area even for layer-hosted views, presumably as an optimization for misguided code that was improperly using layers. As of 11 AppKit does not do this, so the test (which was asserting behavior that was both incorrect and irrelevant to us) is broken. This change deletes these tests. Bug: 1114240 Change-Id: I22ede812cdf98707cc22bca1238f59856a371d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352431 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#797329}
-
Matthew Mourgos authored
This change ensures that circular icons are scaled down when needed so that they do not exceed a maximum size relative to the size of the bitmap. Before this change, when circular icons were standardized they are returned without any changes, even when the size of the icon is too big. Also in this change is an additional unittest, to ensure that a large circular icon is scaled down to the maximum size when standardized. Bug: 1110496 Change-Id: I032da9422d078db8ae8e5d1d1198c8e12f3dec76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347318Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#797328}
-