- 20 Jan, 2021 14 commits
-
-
Michael Thiessen authored
Change-Id: I5451d561fb455956bb876683e5784a296419c199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637085 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#844985}
-
Meilin Wang authored
This CL is the part 1 of moving |SendVoicelessInteraction| calls to Libassistant Mojom service. It defines and implements four more APIs (listed below) under |ConversationController| Mojom service, and hooks them up in the browser process by replacing |SendVoicelessInteraction| calls in |AssistantManagerServiceImpl| with the corresponding Mojom method. * StartEditReminderInteraction * RetrieveNotification * DismissNotification * SendAssistantFeedback Note that in the CL, |ConversationControllerProxy| will forward all calls through Mojom to the service implementation, where the actual proto message gets encoded. In this way, we can remove Libassistant dependencies from the Assistant service side (classes under /chromeos/services/assistant). Bug: b/171748795 Change-Id: I350cf49b898fffa798b73bb7720ae1583ce84ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625327Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#844984}
-
Xing Liu authored
When the more icon in BookmarkRow is disabled in selection mode, let talkback ignores this view. Bug: 1166730 Change-Id: I657892b0c7c297b5bf5254440ab41ff0d20453a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637082Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844983}
-
Olivier Robin authored
When using loadData, the html has access to the cookies of the URL. It is necessary to pass the URL of the distilled page to avoid cross domain leak. This CL breaks the workflow of user following a new redirection on reloading the page. Bug: 1167901 Change-Id: I6cb01a6580ed511de19f55b35acf91f7f3c7493d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637584 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#844982}
-
Sorin Jianu authored
This is a reland of e1f49aca Original change's description: > Move installer.cc file to updater/win directory. > > The installer API code is Windows-specific and it would be desirable > to isolate //chrome/updater from its implementation details. > > This change uses public_deps and visibility to make > updater:lib and updater/win:lib act as a unit, to resolve the issue > of the circular includes as suggested by the GN documentation. > > Bug: 1014630 > > Change-Id: Ib47dc9041af08651549d0feaf35790f336dfe193 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588508 > Commit-Queue: Sorin Jianu <sorin@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842765} Bug: 1014630 Change-Id: I84d717aad974254f5daf24547888c8bf880cf9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635202Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844981}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611068186-6acea0a5e8e4dcb5129946657add72ff4aa0a2a2.profdata to chrome-win32-master-1611078768-a6f5b9bbbe47c14760aa754313a33dbc3d6dd128.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6da16ae022c812e736c4f9039c67f38ea8c094ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637078Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844980}
-
Takuto Ikuta authored
This scripts needs json conversion similar to https://source.chromium.org/chromium/chromium/src/+/master:testing/trigger_scripts/base_test_triggerer.py;l=316-334;drc=e4b6e9349b783a53e3efcc45e54e6632f874ca62 when using go client. This is fix for breakage like https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/12159 Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome Bug: 1127205 Change-Id: Ibf980d44b4b30855ed61e3d487bd683adf948003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635275Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#844979}
-
Caitlin Fischer authored
The server-side config shows that this study ended. Bug: 1126640 Change-Id: Ib731ca75db831a4a54b9ba3bcd7b63391723f056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631934Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844978}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3087d8297fe..b7e836cee99b 2021-01-19 mtklein@google.com Revert "Support indexing by loop variables in SkVMGenerator" 2021-01-19 bsalomon@google.com Reland "Test all YUVA image factories with different encoded origins." 2021-01-19 brianosman@google.com Support indexing by loop variables in SkVMGenerator 2021-01-19 csmartdalton@google.com Extract some GrPathTessellatoOp logic into virtual helper classes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I9d52bbdffdc4c0547f4d4c8fc6163b8e2d1fdc3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638555Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7bcb61f96b8c..b6bed55becc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dbertoni@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: dbertoni@google.com Change-Id: Ia95cf7379a7c7217e8a0ef114d5f03a56696bd3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638116Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844976}
-
Rune Lillesveen authored
The current rules for media controls should only apply to elements in the UA shadow dom for media elements, but were added to the ruleset for all html UA style. Since the media controls styling adds a bunch of rules in the universal tag bucket, once we add a media element to our renderer, we were stuck with having to reject a bunch of these rules for every html element. Instead, create a different set of styles for media controls and only try applying rules from that set for elements inside the UA shadow tree for media elements. Bug: 1166198, 1032957 Change-Id: I5b2fa635558a28a29bf69538f94763d158c7d2ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631490 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#844975}
-
David Black authored
Previously relied on intrinsic icon size which was sometimes correct, sometimes wrong. Bug: 1167365 Change-Id: Iaf2b3454bde9eb340913fc552f936d59d204f0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638519Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#844974}
-
Xing Liu authored
BookmarkBridge.addToReadingList is not covered. This is also part of a reland for: https://chromium-review.googlesource.com/c/chromium/src/+/2625276 Bug: 1166251 Change-Id: Ib6ad34b4daa935151c4895d43fc0eee292727787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627771 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#844973}
-
Abigail Klein authored
Bug: 1055150, 1167349 Change-Id: I4c321cdfa6e00c3a8002cbea02e89fc2689e3ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633375Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#844972}
-
- 19 Jan, 2021 26 commits
-
-
Dale Curtis authored
cli_output.splitlines() needs a decode('utf-8') now. Bug: 941669 Change-Id: I8c5241483dac9d77655501aa6e560e679df16dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638534 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:Abhishek Arya <inferno@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#844971}
-
Ali Juma authored
When launching an ASan build of CWTChromeDriver, libclang_rt.asan_iossim_dynamic.dylib needs to be included in DYLD_INSERT_LIBRARIES. This CL updates launch scripts to include this value when using ASan. This is needed as part of adapting CWTChromeDriver for fuzzing. Bug: 1158540 Change-Id: I924f865027ac8c50deeec2eaa401647efff62452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633681Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#844970}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e670fc72a5ae..2e0490eedcc8 2021-01-19 jmadill@chromium.org Capture/Replay: Serialize float states properly. 2021-01-19 syoussefi@chromium.org Suppress failing tests on mac ARM 2021-01-19 jmadill@chromium.org Vulkan: Support GL_EXT_tessellation_shader. 2021-01-19 m.maiya@samsung.com Vulkan: Add integer type incomplete texture tests 2021-01-19 cnorthrop@google.com Tests: Add Asphalt 8 trace 2021-01-19 syoussefi@chromium.org Fix image bindings with an image after an image array of array 2021-01-19 jmadill@chromium.org Test Runner: Prevent race by not resetting timeout. 2021-01-19 cnorthrop@google.com Capture/Replay: Use glUniform1iv on samplers, ignore images If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1167763 Tbr: cnorthrop@google.com Test: Test: Fortnite MECTest: Test: angle_perftests --gtest_filter="*asphalt_8*"Test: Test: dEQP-GLES31.functional.tessellation.* Change-Id: I33597fd39018c548229ab7528e54df74b52ec09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638109Reviewed-by:
-
Yaron Friedman authored
According to flakiness dashboard this is our slowest test and generally taking at least 45seconds and sometimes up to 4 minutes. Change-Id: Ie4d0f17eced89adebe1ffe1dff17db74395776a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635075Reviewed-by:
-
Bailey Berro authored
This change introduces the SessionLogManager class. The SessionLogManager owns the various logging classes and will be responsible for constructing the session log when requested by the user. Bug: 1128204 Change-Id: I4c41effce7d1faf99f2c68c773642e44aec18dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632870 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#844967}
-
Rohan Pavone authored
Builder is not currently active, but exists in another repo. Bug: 1128105 Change-Id: Ic4de73c066751c7973e270bbda5358e31fb73408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628343Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Cr-Commit-Position: refs/heads/master@{#844966}
-
Tommy Steimel authored
This CL refactors the MediaKeysListenerManager to use the SystemMediaControls directly instead of through a MediaKeysListener. This will allow us to fix a few different bugs that were stuck on this refactor, such as providing a content-specific name to the SystemMediaControls and properly destroying it when there are no active sessions. This CL also renames the HardwareKeyMediaController to make more sense. Bug: 974035 Change-Id: I1818fdc8849e679c5a7791a0516ba051ee8eefbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606785Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#844965}
-
Alice Gong authored
BUG=1157672 Change-Id: Iffd50344615d56c2b2a4a843e8a22eab9f4306f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621923Reviewed-by:
Marc-André Decoste <mad@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Alice Gong <alicego@google.com> Cr-Commit-Position: refs/heads/master@{#844964}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8da0f82baf35..89fd1480b47e 2021-01-19 digit@google.com vulkan: Support VK_KHR_external_memory_fd on OS X. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1366a05d78896c54fa35070fbd171b2093fd5ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638240Reviewed-by:
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chromeos/components/tether. Bug: 1007654 Change-Id: I8aa947682d8ba5f2864d6dc9a1ed153d5ba90416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637929 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#844962}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611068186-b36b631e8b34e83450d9bdf5237d6c35b34952b4.profdata to chrome-win64-master-1611078768-7ecf7fe9cdf533d2ba0fd4fcea641cfa29b8dba9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0def19a6624fa0dc61837b4b524be596d6d2f8e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638245Reviewed-by:
-
Jeroen Dhollander authored
This caused linking issues on a debug build (I do not know why it doesn't cause issues on a non-debug build). [0/1/1] SOLINK ./lib_libassistant_service.so FAILED: lib_libassistant_service.so lib_libassistant_service.so.TOC python "../../build/toolchain/gcc_solink_wrapper.py" <snip> ld.lld: error: undefined symbol: NewLibassistantEntrypoint >>> referenced by libassistant_entrypoint_client.cc:40 <snip> Bug: b/171748795 Test: compiled Change-Id: Id302592f9bd1623656403da530c05899a22cfc7d Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636682 Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Aaron Krajeski authored
Part of the greater effort to migrate cc and the paint_op_buffer away from SkMatrix, which is 3x3 and relatively slow, compared to SkM44. Two functions were added to paint op buffer in previous Cls, Concat44 https://chromium-review.googlesource.com/c/chromium/src/+/2577704 SetMatrix44 https://chromium-review.googlesource.com/c/chromium/src/+/2562783 Each of these take an SkM44 as an argument instead of an SkMatrix. This CL changes the implementation of RecordPaintCanvas::concat so that it always ends up sending an SkM44 to the paint op buffer and removes the older implementation of ConcatOP (that used an SkMatrix). Now there is only one concat operation in the paint op buffer. The next and hopefully final step of this project will be to do the same thing for SetMatrixOp. Bug: 1155544, 1167153 Change-Id: I7a3b3a168e91ec37151e5f95897abadc5bc05542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626051 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#844959}
-
Andy Perelson authored
Bug: 1167291 Change-Id: I124d073c609d1fdcdd9e5872cc19e6b43339d7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637079 Auto-Submit: Andy Perelson <ajp@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#844958}
-
tby authored
This removes these two histograms and the logic related to them: Apps.AppListResultLaunchIndexAndQueryLength Apps.AppListResultLaunchIsEmptyQuery Bug: 1160781 Change-Id: Ifcd61df6a40dc6bb910bc7c2a6d27e83a0f84cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628869Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#844957}
-
Yusuke Sato authored
BUG=None TEST=try Change-Id: I2c9220ff56432b946982685d22bec74b6307d027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631628Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#844956}
-
David Schinazi authored
This will allow us to query new records such as HTTPS. More details of the experiment are available internally at go/chrome-dns-concurrency. Bug: 1134205 Change-Id: If849689da3086290a3b61e33f42631db16398bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636880Reviewed-by:
Renjie Tang <renjietang@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844955}
-
tby authored
Launcher search results report a SearchResultType enum used for metrics. Some kinds of omnibox search result are being recorded as SEARCH_RESULT_BOUNDARY because they don't have their own value. AFAICT we never expected to see these results, as they used to trigger a NOTREACHED. From some testing, we see at least two of them in practice: - SEARCH_SUGGEST_ENTITY - NAVSUGGEST I've added enum values for these. I've also taken out the TODO saying to re-add the NOTREACHED, because I don't think we'll ever be confident we've covered all cases. Bug: 1121386 Change-Id: I4b8b1eaa696d84ad4752956fde925526777ab8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631868 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Curt Clemens authored
The placement of the invisible IronA11yAnnouncer element was causing trouble on the high visibility page with the apparent ordering of the elements. Since it is a replacement for the page subtitle, it needed to be located next to the subtitle in the html so that the node in the accessibility tree gets placed correctly. IronA11yAnnoucer was never designed to be used with modal dialogs. Explicitly placing an IronA11yAnnouncer on the page was a hack to get around the way modal dialogs are treated in the accessibility tree. While this mostly worked, the iron-announce event continued to bubble past the dialog and set the text on a second IronA11yAnnouncer element on the underlying settings page causing some strange behavior after the dialog is closed. Switching to a plain aria-live region fixes that. Another issue with invisible stand-in elements was that the visual highlight was not placed over the corresponding text when using search + arrow keys. Using absolute positioning to place the aria-live region on top of the subtitle it replaces achieves the desired highlight: https://screenshot.googleplex.com/6dHPQMDYaMBYsQ3.png When the page would initially load, Chromevox would read a few elements that weren't on the currently active view of the cr-view-manager. This turned out to be because elements with aria-hidden="false" were overriding the "display: none" applied by the view manager. Use "undefined" instead of "false" to fix. Also correct an issue where the interval timer wasn't getting cleared in the detached() event. Fixed: 1165982 Change-Id: Ia31dd52629fc27db55906d88de2160d908e4fccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632085Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#844953}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I0a8e4c80233244f46dd6e4e7f58d9dafe012561c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636878Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844952}
-
Miguel Casas authored
crrev.com/c/2628069 introduced to the V4L2VideoDecoder a limitation on the maximum number of decoder instances at a given time, making it behave like the legacy V4L2VideoDecodeAccelerator. That provision avoided the OOM observed on MS Teams (see bug). But the max number of instances (10) is too restrictive. A deeper look showed that every instance allocates all the necessary input buffers (i.e. those for the encoded chunks that go into the v4l OUTPUT q). V4L2VideoDecoder allocates 16 [1] whereas the legacy one only 8 [2]. FTR each buffer is relatively large: 4MB for platforms that support more than 1080p decoding, 1MB otherwise; MS Teams can successfully allocate 32 decoders on kukui, which gives us 32 * 16 * 1MB = 512MB of allocated memory; on trogdor this would be 2GB (!!). This CL tweaks a bit ToT numbers so we can allocate more decoder instances (32, good for kukui) and have a smaller number of input buffers allocated, aligning V4L2VideoDecoder with the legacy. [1] https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/v4l2/v4l2_video_decoder.cc;l=34;drc=1bba741f920278b78341175ef888c19a6affd664 [2] https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/v4l2/v4l2_video_decode_accelerator.h;l=145;drc=82e2036e3aadce02f587769c7ab6fc644953e008 Bug: b/170870476 Change-Id: If610ffe7c339ae3d883d893e41c92cc725e6fdaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633784Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#844951}
-
Philip Rogers authored
This patch removes the kHasNonLayerViewportConstrainedObjects main thread scrolling reason because there are no longer any non-layer viewport constrained objects that scroll. All viewport constrained objects (fixed, sticky) are now composited if they scroll, and we do not need a main-thread scrolling reason if they do not scroll. Bug: 649096 Change-Id: Ia2c256a6b39983ef37b78a86aa761cbf33d5efe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622516 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844950}
-
Siyu An authored
Bug: 1082013 Change-Id: If75e11b3b0c569bfda4bb0d178499e5488f00b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623421 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#844949}
-
Igor Ruvinov authored
Adjust new policy description to remove incorrect uses of PRODUCT_NAME which were applied to "Chrome" but should only be applied to "Google Chrome". This is a reland of 70b75301 Original change's description: > Update BrowsingDataLifetime policy description > > Update policy description of BrowsingDataLifetime policy to make it more > informative while cutting down on the technical details and complexity. > > Bug: 1163584 > Change-Id: I2764fbf7651625667b9199136f17ea6dc709ae41 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630865 > Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844217} Bug: 1163584 Change-Id: I67d30f2a434b774b71262c7b48e02942ac10cc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638101Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Cr-Commit-Position: refs/heads/master@{#844948}
-
Bailey Berro authored
Bug: 1128204 Change-Id: I8801ebb4f65f5b867f084b5a55fbf4b81b13213c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634061 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
-
Theo Johnson-kanu authored
- This feature was never launched and the flag expired in M89. Extending expiry so that this flag can be re-used for a new unified cellular setup UI. - Updated team owner to cros-connectivity Bug: 1093185 Change-Id: I6edea8d789edf3d56c3142e2884ef11406ab4ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638358Reviewed-by:
-
