- 17 Jan, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4efa82edacaa..3cbeaba4eb9d git log 4efa82edacaa..3cbeaba4eb9d --date=short --first-parent --format='%ad %ae %s' 2020-01-17 syoussefi@chromium.org Remove suppression of passing test 2020-01-17 ianelliott@google.com Sort GLES 3.1 expectations to show conformance blockers Created with: gclient setdep -r src/third_party/angle@3cbeaba4eb9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jonahr@google.com Change-Id: I5f0336130746309c553070653bb90e5b4adece70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008179Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733020}
-
Jeremy Roman authored
Since this pathway is triggered by tab helpers, they are now registered in Chrome/Android much as they are already in Chrome/Desktop (by Browser). A test is included which works mostly the same way as the desktop browser test equivalent. Some plumbing was required to expose inner web contents to Java, via JNI. Bug: 1038584 Change-Id: I3127b0a392774c528f620220934283c4affe6643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986341Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#733019}
-
Sajjad Mirza authored
TabCapturePerformanceTest.Performance is flaky across multiple CQ builders. Bug: 1042457 Change-Id: I7fd59ac696c6bac0fcb27a860a06664016217749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003910 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Auto-Submit: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#733018}
-
Roger McFarlane authored
Bug: 978849 Change-Id: Ide816851b13c00fb5068174f86d2d21a674a6494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007971Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#733017}
-
Natalie Chouinard authored
LocationSettings is now a static-only class of helper methods for native, so make its constructor private and remove singleton logic. Bug: 1043229 Change-Id: I35fc673368ec7a2b510be0aa2eaaae4cbc054cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007869Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#733016}
-
Connie Wan authored
Part 1 of many. In this change: - Group headers become focusable in accessibility mode. - Group headers have rudimentary accessibility labeling. - Group headers have focus rings that match the shape of the title chip. - RETURN and SPACE trigger the group header editor bubble. Much of this is borrowed from Tab focus behavior, e.g. https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab.cc?l=226&rcl=5f3328931da554b037f7a9fd008d1d0216246a95 Still in progress: For group headers: - The focus order is wrong (group headers are ordered last, after the New Tab Button). - The voiceover readout is likely wrong (currently untested). - The keyboard controls for reordering groups is missing (TODO added inline). For tabs: - The voiceover readout does not include what group it is in. - The keyboard controls for reordering groups doesn't respect group boundaries. Almost all of the above efforts are non-trivial, unfortunately. I'll be breaking them up into separate CLs as much as possible. Bug: 1039921 Change-Id: I5a831c196dd51ede2a48b16ccf4ffc8acb0dd1de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998146 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#733015}
-
Alison Maher authored
In a previous change, we had ignored background images for all inlines to prevent background images from being painted on top of the readability backplate in forced colors mode. https://chromium-review.googlesource.com/c/chromium/src/+/1757685 However, it turns out that atomic inlines paint their backgrounds before the backplate is painted. As such, we do not want to ignore background images for these inlines in forced colors mode. Bug: 970285 Change-Id: Iee2463775e67a1661cbb85f0a51b5bb8f01566cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998976 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#733014}
-
Josh Nohle authored
Bug: 951969, 936273 Change-Id: Ia8e411383b7ee38914aeee1097f29282c614283c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987862 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#733013}
-
Miguel Casas authored
DmabufVideoFramePool::RequestFrames() does not request frames, but sets it up so that GetFrames() can allocate them later on, so s/RequestFrames/Initialize/ in bulk where applicable. Bug: 1040291 Change-Id: I327c9fdac308dcd3d0a52c1319f677df1e1ce74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002934Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#733012}
-
David Black authored
This CL: - Removes AssistantCardElement one-off logic from AssistantResponse so that it will scale to new AssisantUiElement types. - Moves private classes into .cc to clean up .h Bug: b:145003512 Change-Id: If6a9c79a7a6a49c10d903762ac9c1d82a8267c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006137 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#733011}
-
Scott Violet authored
This better matches the new names. BUG=1033924 TEST=none TBR=bcwhite@chromium.org Change-Id: I2341b6c1fcb680723d7794be5197ba70bb25b09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007651 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#733010}
-
Xianzhu Wang authored
Previously, when an <object> failed to load the remote frame content, and used fallback content, we still got the cc::Layer of the remote frame and set it as the contents layer of the GraphicsLayer of the fallback content. When the fallback content had multiple GraphicsLayers (e.g. when the object is inline containing block child), the GraphicsLayers would reference the same cc layer, causing duplicated cc layers in the layer list. Now get cc layer of the remote frame only if the LayoutObject is LayoutEmbeddedContent (i.e. not fallback). Bug: 1033459 Change-Id: I95c1eb1e1a22f57e6ac12a2a10339230e3f4c90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006970 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#733009}
-
jonross authored
A lot of work has been happening with SkiaRenderer, and the expectations files for blink_web_tests are out dated. This updates them to reflect tests that are now passing. TBR=backer@chromium.org TEST=blink_web_tests Bug:1027772, 1026375, 935970, 1002547, Change-Id: Ie75b76b507613350099052f8959ebfc1832a7bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006132Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#733008}
-
Thanh Nguyen authored
This CL enables fuzzy app search by default. Bug: 990684 Change-Id: I934aeb5f4290a4a4849936d53ba44567f2a69ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006988 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#733007}
-
Johannes Kron authored
Bug: chromium:1012063 Change-Id: Iacecd17733bfb8ee1673fc322964d2a95b1497fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007388 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#733006}
-
Saman Sami authored
During the pageflip operation, we only need the CRTC IDs. The CrtcController objects themselves aren't needed. Bug: 1034559 Change-Id: I0259e9440a72a8f4e26346e306d4f648d27387fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008324Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#733005}
-
Evan Stade authored
One functional change: the find bar border color is updated to modern grey 300, which is much lighter than the grey previously used. This value comes from go/clankcolors. Bug: 1038415 Change-Id: I171eda126a59f3057adb62e3033e9cbda4af344d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001289 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c766f984..84710764 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6f981e951037ce5ca7a6fffbf140ccd303fbc540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007258Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733003}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a067a830b31a..c7d63f97f8d2 git log a067a830b31a..c7d63f97f8d2 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 John.Emau@microsoft.com WebAudio: Fix a11y web audio truncation at 200% zoom Created with: gclient setdep -r src/third_party/devtools-frontend/src@c7d63f97f8d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib7578432ff1814b27676168e751c9ac148055bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007736Reviewed-by:
-
Shimi Zhang authored
The IsIPAddress() was duplicated from GURL::HostIsIPAddress(), but the internal logic was extracted as url::HostIsIPAddress() in http://crrev/2562813003, makes IsIPAddress() not necessary anymore. We could replace IsIPAddress() with url::HostIsIPAddress(). In prepare of a refactor to ProxyBypassRules. Bug: 1030092 Change-Id: Ie20c17c52803a62782f6773202dc874a5e9aad43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006191Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#733001}
-
Kai Ninomiya authored
This brings WebGPU CTS into DEPS, and rolls the WPT copy to the same version. The new tools are NOT in this patch, and will land after this, in: https://chromium-review.googlesource.com/c/chromium/src/+/1919211 Bug: dawn:323 # for added expectations Change-Id: I334c51cc3b0a8473c77c486ea6293ba0500d4ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996140 Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#733000}
-
Yuke Liao authored
This CL starts experimentation of exonerating flaky failures on mac-rel builder. Bug: 838735 Change-Id: I8f3ac54d144b19d96c6d2cb4a7e4cb2a7c76787e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006128Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#732999}
-
Mitsuru Oshima authored
This also defines constants for repeating-decimal scale factors. Note: This will change the DP size of this device from 1333x888 to 1332x888. Bug: 946509, 1004784 Test: Change-Id: Iffb86a958c796acd3cf4a8e72e6ef6b75e6461b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999090Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#732998}
-
Mitsuru Oshima authored
Use PointF/float to calculate Y position, then use SubpixelPositionOffset to move the window to pixel position. Reset to DP position when moving to the specific state. requires a fix to event generator. Bug: 1042754, 1038998 Test: Maually tested. unit tests will be added in a separate CL as it Change-Id: I6157f46bc00929e03379a4b3e80e9b5b75ed72ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002863 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#732997}
-
Will Harris authored
This CL adds a basic detection for CB Protection to the AV product enumerator. This is needed as CB Protection does not register as an AV product in WMI. TEST=Run Chrome with bit9 installed, check for product name hash 0xa5b3b15e in system profile. BUG=1021701 Change-Id: I2996c06ca89a2791ff4be8908a239f90e1b1c149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008010Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#732996}
-
Scott Violet authored
This contains the backup or last session that is not needed for WebLayer. After this patch, I will rename *SessionBackend to *CommandStorageBackend next. BUG=1033924 TEST=none Change-Id: Ifb2bee2db7fc23bd0ee804ff83a053bed8444ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006481Reviewed-by:
-
Hiroshi Ichikawa authored
Change-Id: Ieef9a582007b963922931bc607289d7a300bddc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006439Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#732994}
-
Henrique Nakashima authored
Register them in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Add testing coverage for the return value of SharedPreferencesManager#incrementInt() that was missing. Bug: 1022108 Change-Id: I49a3b72b30dbfc0dfb7dd3c3747cb85523f2e4ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001222 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#732993}
-
Natalie Chouinard authored
Only a couple methods in LocationSettings were related to Clank Settings screens, so move them alongside the code that uses them in Site Settings. Further simplifications to follow, before the remainder of LocationSettings is moved to a more appropriate package location. Bug: 1043229 Change-Id: If8329b0aa9cd069ff8c6947801ca0e2eccc6bc40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008314Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#732992}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e094969c. With Chromium commits locally applied on WPT: 62f8d5f0 "Enable Scroll To Text by default" 363313c0 "Sort the registrations returned by getRegistrations() by registration ID." 8a985066 "[Trusted Types] Implement require-trusted-types-for" 67d99f23 "Deflake WPT test: required_csp-header.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/IndexedDB NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I13cf62a08ae6fb962eccc02f1571782b6caf76d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008149Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732991}
-
Hesen Zhang authored
- Implemented the flow when user clicked notification and launch Chrome Activity from background. Bug: 1013685 Change-Id: Ib9e96da59358fcc9f4016cf8a5ebcfe3ec043dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994240 Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#732990}
-
Adithya Srinivasan authored
Also simulates a click when clicking enter/space when a portal is focused (similar to buttons). Bug: 1043127 Change-Id: I0b1a35cd978c191a958dea0ed47bf737cac7292f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995940 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732989}
-
kylechar authored
If Display::DrawAndSwap() decides to draw but not swap SkiaOutputSurfaceImpl creates a task to draw the root RenderPass that is never used. This will either trigger a DCHECK or the task will be overwritten and destroyed next draw. This results in resources not being released on the correct thread and fences not being signalled. Add plumbing so that if Display::DrawAndSwap() skips the swap buffer call that SkiaOutputSurfaceImpl still draws the root RenderPass. Bug: 1043153 Change-Id: Ib33599331ff1524bbbcd0ad05574dc2e0175b7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008068Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#732988}
-
Olga Gerchikov authored
Scheduling frame for scroll linked animations regardless of the scroller updates makes scroll animations inefficient. This change schedules next frame only when scroll timeline current time changes. The change assumes that animation timeline scheduling runs (via DocumentAnimations::UpdateAnimations) at the end of any frame in which scroll timeline (i.e. its offset, range, overflow) is invalidated. Bug: 1039750 Change-Id: Ib87a298e6d09cbeb85276cea4c165022b76f3732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990003 Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732987}
-
Takumi Fujimoto authored
The button text changes its color depending on the background color to stay legible. This CL specifies the correct background color (that of ScrollView that the button is contained in) so that the text is rendered in a legible color. Bug: 1033670 Change-Id: Ib5c3f15a5e6512a2d259f5fd20dce7fb58ce13a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008057 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#732986}
-
Anders Hartvoll Ruud authored
Now that the underlying issues are fixed, let's enable these tests again. BUG=983728, 983608, 1042644 R=futhark@chromium.org Change-Id: Ide367e47806995c15c185f95f03b21524c1b7058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002586Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
Robbie McElrath authored
This CL makes the IVariationsSeedServer.getSeed implementation start (via Context.startService) the VariationsSeedServer on each call, and stop it when all pending calls have completed. Normally services would stay alive by being bound while handling IPCs, but VariationsSeedLoader unbinds from the service immediately after calling getSeed, so it's possible for Android to kill the service before getSeed has finished executing. Starting the service effectively makes it manage its own lifecycle and ensure it stays running until it has finished its work. See https://developer.android.com/guide/components/bound-services We have no evidence that the service is actually being killed prematurely in the wild since we have no way of detecting it, but this is still a potential bug that should be fixed. Test: out/aw/bin/run_webview_instrumentation_test_apk -f \ Test: 'VariationsSeedHolderTest#*' Bug: 1040625 Change-Id: I5c5b0fdfa4deb43bf69b5d56edf0273073d4b1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995768Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#732984}
-
Zhuoyu Qian authored
This CL update the functions InvalidateUsageCache and StickyInvalidateUsageCache of SandboxFileSystemBackendDelegate to use dedicated Origin type instead of GURL. Change SandboxQuotaObserver::SetUsageCacheEnabled also, because it only called in StickyInvalidateUsageCache. Bug: 598424 Change-Id: Ibd7edbef3b40dd48a14f63bb18d9cb1c357a86a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006902 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#732983}
-
Evan Stade authored
FindBar* classes including FindBarController and FindBarState aren't needed by WebLayer, so those are left behind. Bug: 1038415 Change-Id: Ied5f1d57162d174c18c835e239ad454ccb5188ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993904 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#732982}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/db6ca7f2d7fd..44509036060c git log db6ca7f2d7fd..44509036060c --date=short --first-parent --format='%ad %ae %s' 2020-01-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 862d9d7b..1ae08c8c (732747:732864) 2020-01-17 ilnik@webrtc.org RtpReferenceFrameFinder: protect against crashes due to large temporal idx value on the wire 2020-01-17 jsphchn@google.com Update RTCAudioSession isInterrupted state when audio session is activated while interrupted. 2020-01-17 danilchap@webrtc.org Move Offset constants from VideoSendTiming value to VideoTimingExtension class 2020-01-17 srte@webrtc.org Adds current thread to yielders in SimulatedThread::SendTask. Created with: gclient setdep -r src/third_party/webrtc@44509036060c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042933 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If944c76dacbc185ae7a2f94e44c31fda856101d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008170Reviewed-by:
-
