- 05 Aug, 2020 40 commits
-
-
Yicheng Li authored
In-session auth dialog controller needs a way to authenticate the user upon user interaction with the dialog. This client class is responsible for handling the authentication by talking to chromeos::ExtendedAuthenticator. Bug: b:156258540 Change-Id: Ibd0b9ddc0d8bad01580afc8d56edcb354e2ab72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337540Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#795248}
-
Khushal Sagar authored
R=sunnyps@chromium.org Bug: 976583 Change-Id: Ibf1de465a4094e3ce3d679552892731f3302c94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340110 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#795247}
-
Jonah Chin authored
Replace various PaintImage::GetSkImage() callers with direct PaintImage equivalents. More details about overall PaintImage effort: crbug.com/1023259 Info about the OOPR-Canvas2D project: crbug.com/1018894 Bug: 1031050 Change-Id: I0a673e7171c5162c58e5496662b73cd96e5072e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337677 Commit-Queue: Jonah Chin <jochin@microsoft.com> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#795246}
-
Eugene But authored
This CL workarounds the crash by not installing allocator shim only on iOS 13.4. The root cause of the crash is unknown, but the crash volume is too big to ignore the problem. Bug: 1108219 Change-Id: I44ce06d216c6dc51f66ab1ba7b047e4d1a48394a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335030 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#795245}
-
Li Lin authored
As we are enabling native PAC validation on the client, we will stop sending the GAIA flow URL param obfuscated_owner_id to skip PAC validation on GAIA frontend. GAIA frontend is using obfuscated_owner_id as the signal to do PAC validation. Bug: 921142 Test: Manual tests Change-Id: Icc9bb60186cc2b2299c47e72b78bd4f24d108005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338919Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795244}
-
Daniel Clark authored
I submitted a change at https://chromium-review.googlesource.com/c/chromium/src/+/2339377 to fix the mac-retina failure of this test. The test was disabled slightly after the fix went in. The test had started passing after my fix, e.g. see https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/32112 whose head commit 322be03c contained the fix but not the disable. So, re-enabling the test. TBR=masonfreed@chromium.org,rdevlin.cronin@chromium.org Bug: 1112111 Change-Id: I090525527448154493f2a74a126d1eff00f882a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339762Reviewed-by:
Dan Clark <daniec@microsoft.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#795243}
-
Josh Nohle authored
The HTTP result enum is not needed by the HTTP client, but the HTTP result enum requires knowledge of the HTTP error enum. So, it is necessary to move the HTTP error enum out of the "client" directory, and house all HTTP enums in the "common" directory. Change-Id: I5458d892f85b4045d2407954d16ef66f447139e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333871 Commit-Queue: Josh Nohle <nohle@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#795242}
-
Wenyu Fu authored
The main workflow on how we change FRE when launching through CCT for Enterprise clients. This CL also adds some generic integration tests for basic test coverage. Once policy is ready, we'll fulfill test cases with more detail. Bug: 1106987 Change-Id: I24530156f465ca7b8729e7dee5bdfb211a0ea664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320768 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#795241}
-
Fred Mello authored
https://docs.google.com/document/d/19UDqGiQnpkdjvvWpVG8TroXNK0MmhmccU0PkozS8IT0 Bug: 1112872 Change-Id: Id492ddd4d6f645397d22c1aeb96cdd1c1b0e8197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340060Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Greg Thompson authored
DeleteTmpFileWithRetry() must pass the histogram suffix as a std::string rather than a StringPiece when posting its delayed task. BUG=1112511 R=thestig@chromium.org Change-Id: I824e90e9e32b6587154de040c0da3cb7d30c8cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339737Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#795239}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I18d3b6c8ab89df3ac53aa1097b1e1c1edbff0c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339771Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795238}
-
Andy Lu authored
Bug:1066482 Change-Id: Icd89446475fd461fe3eb61a1079929b1dbe191b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337956 Commit-Queue: Andy Lu <andyhylu@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795237}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c547fda2a9c6..91bbd01aed3e 2020-08-05 ynovikov@chromium.org Rename roll_deps to roll_chromium_deps 2020-08-05 syoussefi@chromium.org Vulkan: Support ANGLE_external_objects_flags If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1104516 Tbr: geofflang@google.com Change-Id: I38f36e24ec26edc46ad865e97ac06813628f1db4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340108Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c97814f3adc..2b8940ee5e08 2020-08-05 mtklein@google.com remove SkRP-based runtime effects 2020-08-05 mtklein@google.com allow SkSpriteBlitter::setup() to fail 2020-08-05 jvanverth@google.com Switch GN defs on Mac and iOS to use frameworks, take 2. 2020-08-05 michaelludwig@google.com Specify aa type of draw to the GrClip 2020-08-05 johnstiles@google.com Update SymbolTable::takeOwnership interface to improve type safety. 2020-08-05 mtklein@google.com allow SkRP color filters to fail If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I0d33a50ba8fe741671cf8969f717bcc28e042a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339767Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b1b0980710f..9a19fe997b33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rdcronin@google.com,rogerta@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1113252 Tbr: rdcronin@google.com,rogerta@google.com Change-Id: I6df6dd1557955de618583870d1454fc53caaac3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338924Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795234}
-
Mike Wittman authored
Adds a test that checks module properties against the corresponding information in /proc/self/maps. Bug: 1004855 Change-Id: I1c5981dadaba2991ea1e50b46e77bf9ea027236d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314689 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#795233}
-
Ramya Nagarajan authored
Adds a new feature and a chrome://flags entry to surface repeatable queries in most visited tiles on the NTP. Bug: 1110077 Change-Id: I91906399aedcfa8d7c53d51f21186bdb74ac1478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335320 Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795232}
-
Adithya Srinivasan authored
This CL moves some portal related IPCs that were defined in content.mojom.FrameNavigationControl to blink.mojom.LocalMainFrame. This allows us to handle the IPCs directly in blink and remove some layering in public/web. There should be no behaviour change caused by this patch. Change-Id: I4dc41ca52cffa75590b889930aafeac06a211e6e Bug: 1110329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314420 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795231}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fb9c1110ef14..92e5a9299b38 2020-08-05 chanli@chromium.org [ResultDB] Update rdb version 2020-08-05 thestig@chromium.org Handle BUG_PREFIX correctly when populating Bug: lines. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1111955 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I36e631b71d33f331438b2576bc6b8f38d8db2e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339764Reviewed-by:
-
Nicholas Hollingum authored
In order to assist debugging efforts, we add several logging statements which identify the cause of lost pointer locks. Bug: b/162549144 Change-Id: Ib4cd283a864354aad9303ec23d355b2e25134201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336623 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#795229}
-
Xinghui Lu authored
If a user checks no protection, a dialog will pop up to double check if the user wants to disable Safe Browsing. screenshot: http://screen/jLDJGvZN4cy Bug: 1097310 Change-Id: Ib8008e4502dec8762785a84a7048123b5d224319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327320Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795228}
-
David Grogan authored
Previously, if a 300x300 flex item got a 700 main size after flexing, we'd assign a 300px cross size. LayoutReplaced doesn't pass the flexed size (delivered in one of the Override sizes) through the aspect ratio, so just add this logic directly in flex. There's a regression, external/wpt/css/css-flexbox/align-items-007.html that we'll have to fix before shipping, but I suspect the new behavior might be right. This CL adds a blink runtime flag, FlexAspectRatio, because this is the first of a few aspect ratio fixes I want to ship at the same time. The flag is set to experimental: enable-experimental-web-platform-features users will see this fix in Canary right away. I will set the flag to stable probably in time for M87. Bug: 721123 Change-Id: Ie01f8da1a95eb940f20ba3e9bbf960bd4624c71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333530 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#795227}
-
Regan Hsu authored
* 680px width in narrow mode if search is shown (matches settings rows). * 80vw width in extreme narrow mode so that search input is not cutoff. * The burger menu icon will not be hidden in narrow or extremely narrow. * Magnifying glass further away from edge of narrow OS settings window. Videos: https://nimb.ws/UzWsaG https://nimb.ws/ehD7iA Fixed: 1110200 Change-Id: I33ec3b42108c84b60cb27aac9914b759b9a6a627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337277Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795226}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/10ee7644..4f52dde7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4a5c8afcd9dc8e25332884131039816f00282268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340120Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795225}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9a43f48ed4cd..f52572f002a6 2020-08-05 aninditaghosh@google.com Add noop rule to BUILD to import init file correctly on g3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icc1dfa1a4dde773553d48f88dd66fb49a8922d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339552 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
My Nguyen authored
StyledLabel eats event, probably because it has to handle links. Explicitly sets this to false will fix hover issue. Refer to b/161754148 for before and after view. Fixed: b/161754915, b/161754148 Change-Id: I244814076c9afcc10d772301ed5780ac1e650ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339649Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#795223}
-
Devlin Cronin authored
Bug: None Change-Id: I6dbc46ce4fb6162904a5026d284cc20954ad0f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339791Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795222}
-
Changhao Han authored
Failing bot: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN Bug: chromium:1113314 Change-Id: If00935628d5ef204be4d4ecfec58ae7991d9de61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339657Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#795221}
-
Cammie Smith Barnes authored
For an Ad metrics project, we would like to gate adding an observer to a subclass of V8PerFrameMemoryRequestAnySeq on there being an ad frame detected on the page. Hence, we need to be able to check whether we added this observer so that we can safely remove it in the destructor. This CL adds a public bool method for checking whether the observer is there before we try to remove it. Change-Id: I2a212eb91edbb81e952d629b364652937e93c995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327814Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#795220}
-
John Lee authored
Bug: 973674 Change-Id: I235a1a95ebf760d175dc9800e041f0a1fd955036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336305Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#795219}
-
Anders Hartvoll Ruud authored
Instead of storing a ScrollTimeline that may be nullptr, store an AnimationTimeline that's already been determined to either be a ScrollTimeline or a DocumentTimeline. There should be no behavior change in this CL. It's a preparation that will make subsequent work on dynamically updatable @scroll-timeline rules a bit smoother. It's also needed in the future to differentiate between animation- timeline:auto and animation-timeline:none. Note: Apparently inspector_css_cascade_test.cc previously depended on some header transitively included via css_animation_update.h. Bug: 1074052 Change-Id: Ic9704f3a08859244163fd911b65bef98bc0b2d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332618Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#795218}
-
Mark Pearson authored
Extends History.InMemoryURLHistoryItems Removes History.InMemoryURLWords History.InMemoryURLChars History.InMemoryURLCacheSize Bug: 1104944 Change-Id: If7cc4fa350ae543f02f7d0b5c2c87558c257313f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337633 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#795217}
-
Monica Basta authored
This CL adds the 3 dotted menu shown per profile. The menu currently supports deleting a profile and the remove confirmation action menu shown afterwards. The remove confirmation has a warning message, profile statistics and remove confirmation button. Screenshot: https://drive.google.com/file/d/1jjYRgjXEcNArNvLdEkRDa3XMV-r87DTY/view?usp=sharing https://drive.google.com/file/d/1k20VUvBPysAVZrqbcXVtPgHsV6uAQZIm/view?usp=sharing https://drive.google.com/file/d/18spWU68LxO6KzuPc-PZi7NHeRv62I25c/view?usp=sharing Bug: 1063856 Change-Id: I06714382cd85d2142caae717ae526e7ee08e8e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329890 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#795216}
-
Fletcher Woodruff authored
* Add a function StartScan to the lorgnette_manager_client API that allows scanning images using lorgnette's StartScan function. - Clients of the API can pass a RepeatingCallback<void(int)>, which will be invoked whenever the scan progress has updated. * Implement StartScan for fake_lorgnette_manager_client. * Update document_scan_api and unittests to use StartScan instead of ScanImageToString. Bug: b:158504381 Change-Id: I6ca9e7645dc47a72d517d3d7480ea0f12e840e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332852Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Fletcher Woodruff <fletcherw@chromium.org> Cr-Commit-Position: refs/heads/master@{#795215}
-
Mugdha Lakhani authored
This is so WebLayer can reuse this code to support NoStatePrefetch. Bug: 1096088 Change-Id: Iead866201c684f3e349c67703171630508eb6c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336599 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#795214}
-
Maksim Sadym authored
Bug: 1113202 Change-Id: I63ad3e451b5421b2d4398731405d6b151e558506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339354Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Maksim Sadym <sadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#795213}
-
Jeffrey Kardatzke authored
This adds a flag, which defaults to enabled, which causes the H264Decoder to assume that a DecoderBuffer contains a complete picture and will output the frame to the accelerator after processing the DecoderBuffer, rather than waiting for a signal of EOS/AUD or the next picture in the bitstream. The flag is temporary so we can verify if this breaks anything. BUG=chromium:1105268 TEST=Verified decode latency is reduced with chrome tracing in apprtc Change-Id: I864337be34634960eacdeaa26d2811d21b8e142d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335338 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#795212}
-
Sammie Quon authored
When the feature is turned on, replaces the two screenshot related tools in the palette bubble. This uses the existing palette tool histogram recording. Removes some unused functions. Screenshot in linked bug. Test: manual Change-Id: I145dd875fac579955b17531c63b5bed2d2e48305 Fixed: 1113014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333824 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#795211}
-
Avi Drissman authored
https://crrev.com/c/2337734 was landed without the promised fixups because of user error. These are the fixes that were promised. Bug: 1112998 Tbr: ellyjones@chromium.org Change-Id: I3442658b2016e0b772a2201d1ded10c7da383a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339720Reviewed-by:
-
Emily Stark authored
When gfx::MultiAnimation exceeds its cycle time and isn't running continuously, it calls Stop(), but doesn't first call AnimationProgressed(). This means that the final animation state might not be reached, i.e. AnimationProgressed() is not guaranteed to run with a current value of 1.0. I've fixed that quirk in this CL by calling AnimationProgressed() before stopping the animation. This allows me to delete some code that was hacking around this quirk in the omnibox simplified domain field trial implementation. OmniboxViewViews::ElideAnimation was forcing the final frame to run by calling AnimationProgressed() from AnimationEnded(). This hack was causing a DCHECK failure when the simplified domain elision animation was cancelled after the underlying RenderText text contents changed. In other words, because ElideAnimation::Stop() really meant "run the final frame and then stop", there was no safe way to cancel the animation when its state had become stale. Now, with this MultiAnimation fix, MultiAnimation ensures that the final frame runs before the animation finishes, and ElideAnimation::Stop() just stops the animation without running any frames. Bug: 1103738 Change-Id: Idbf55bc2f326d3eaa9bf97a288e3ab467097953e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330613 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#795209}
-
