- 26 Jul, 2019 40 commits
-
-
kylechar authored
The tests pass so they can be enabled and the TODO removed. Bug: 622107, 916318 Change-Id: Iad24954f9d4648e42d870ab20a6df83eb31697f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721456 Commit-Queue: kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#681439}
-
Dave Tapuska authored
Extensions are allowed to talk to other extensions in other frames so they should have the same agent. BUG=970360 Change-Id: Ic16f5e4179ef1af67a9fbefa0679f56293200d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709095Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#681438}
-
Jordy Greenblatt authored
3 of the pageVisibility paths (search, androidApps, system) that are read by the settings-basic-page [1] are never defined and are not part of the PathVisibility typedef [2]. I think the dom-if they control were simply never removed when the paths ceased to be used. This CL cleans up settings-basic-page by removing the references to non-existent paths. [1] https://screenshot.googleplex.com/CPO8xHQ9WSx [2] https://screenshot.googleplex.com/nxGJbNy8vbx Change-Id: I25a99720a6f4df25a6e5b1ac64acd419bba15eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716338Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#681437}
-
Xiyuan Xia authored
This reverts commit 2c8bdfae. Reason for revert: https://crrev.com/c/1719447 makes the CL unnecessary. Original change's description: > cros: Fix ml::UserActivityManager shutdown crash > > SessionManager is released in PostMainMessageLoopRun that > happens before PostDestroyThreads. ml::UserActivityManager > is released with DbusServices PostDestroyThreads. Hence it > crashes on shutdown when trying to un-observe SessionManager. > > This CL adds a OnSessionManagerDestroyed to SessionManagerObserver > interface so that ml::UserActivityManager could clean up in time. > > Bug: 987010 > Change-Id: I05043a3e0b946bfb9e733ad476dacc35e9a9a3b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715401 > Reviewed-by: Jia Meng <jiameng@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680197} TBR=xiyuan@chromium.org,jiameng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 987010 Change-Id: I7fbd5cc8d3e693c7d6b1ceb169d10914040afa17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720999Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#681436}
-
Jordy Greenblatt authored
Bug: 987786 Change-Id: I6d2fd6049c2fd24d8de3a80311875ce533085b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719450Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#681435}
-
Nico Weber authored
Bug: 747727 Change-Id: I33f44e3f4011873e193088796483ecdc48f7f05e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720610Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#681434}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/378cae2543f5..170480122614 git log 378cae2543f5..170480122614 --date=short --no-merges --format='%ad %ae %s' 2019-07-26 yvesg@webrtc.org Prevent concurrent access to AudioSendStream's configuration. Created with: gclient setdep -r src/third_party/webrtc@170480122614 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I2cdac076edbf17fe7c1ace32e83c52ac9b4f0e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681433}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/506ce9bba43b..e69627f35ec5 git log 506ce9bba43b..e69627f35ec5 --date=short --no-merges --format='%ad %ae %s' 2019-07-26 natlee@microsoft.com Backdoor to get the number of texture lazy clears for testing Created with: gclient setdep -r src/third_party/dawn@e69627f35ec5 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I5d0d55ee216f47d8885fe8886cbea75c4a036efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720926Reviewed-by:
-
Matthew Cary authored
Add an UnsafeSharedMemoryRegion constructor for BitstreamBuffer. While BitstreamBuffer continues to represent its shared memory internally by base::subtle::PlatformSharedMemoryRegion due to being used sometimes read-only and sometimes writable, this constructor makes the bitstream buffer easier to use in the common case of client/tests which create a buffer backed by unsafe (writable) shared memory. Bug: 849207 Change-Id: I271bcd389e936ab2e7207bb2684fc6bcd8c2d529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695264 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#681431}
-
Malay Keshav authored
chrome_extensions.js: 313586d3a33182f2493f4440aae39847b689225e -> 66f8cf1fdb5799a63f72e6e054c12aae99152d64 Important changes: - clipboardData property of an Event class is different from the clipboardData property of the ClipboardEvent. The former is of type ClipboardData while the latter is of type DataTransfer. The API being used throughout file_transfer_controller.js for clipboardData is that of DataTransfer, but it was being marked of type ClipboardData, thus resulting in compiler errors. Specific examples: - clipboardData.items.add() - setDragImage() - Using HTMLElement instead of Element since DataTransfer API to set drag image requires an HTMLElement. - Changing calls to web_animations API so that the format being used is a supported one. This will need to be updated when the web_animations API is updated upstream in closure and the support for all formats as described in w3c standard are added. - As of now KeyframeEffectOptions is not in the closure extern. Until it is added KeyframeAnimationOptions needs to be used which is its base class. - KeyframeEffectReadOnly, KeyframeEffect and Animation are now a part of the closure compiler upstream and do not require externs on the chromium checkout. Bug: 987835 Change-Id: I869ee497ffd4017abca889f5767df1981781b80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715123Reviewed-by:Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#681430}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e3614ad6f574..c10743f873f3 git log e3614ad6f574..c10743f873f3 --date=short --no-merges --format='%ad %ae %s' 2019-07-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@c10743f873f3 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: I70be8575c0a62b14525b16106f9516cab3692afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721431Reviewed-by:
-
Will Harris authored
BUG=750886,988021 Change-Id: I01e07a3e36815d9f9f8081a9890976f9cefb9764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721509Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#681428}
-
Natalie Chouinard authored
This reverts commit a076c4e2. Reason for revert: Compile failure List of errors: ../../chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java:147: error: cannot find symbol Original change's description: > [StartSurface] Implement explore surface with feeds > > Screenshots: > https://drive.google.com/file/d/14ssIg6-tvLU_yAa8RTZEPHNsvbfGYgTa/view?usp=sharing > > This CL split the original FeedNewTabPage, FeedNewTabPageMediator and StreamLifecycleManager > into multiple classes, but we do not expect visible changes on FeedNewTabPage. > > This CL also fixed the dummy FeedNewTabPage which was broken by > https://chromium-review.googlesource.com/c/chromium/src/+/1709731 > > Bug: 982018 > Change-Id: I933cb01789d5eda8a196de00e4bf279bb7d6d785 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715410 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Sky Malice <skym@chromium.org> > Commit-Queue: David Trainor <dtrainor@chromium.org> > Commit-Queue: Ganggui Tang <gogerald@chromium.org> > Auto-Submit: Ganggui Tang <gogerald@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681412} TBR=dtrainor@chromium.org,yusufo@chromium.org,gogerald@chromium.org,skym@chromium.org Change-Id: I6af1d483fc1b912d1b60d2ba9b7280125c65b410 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 982018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721000Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#681427}
-
Kristyn Hamasaki authored
Change from text() to GetText() and read_only() to ReadOnly() in order to convert to properties. Bug: 979037 Change-Id: I07939e24857d4ebce541c54394fb41d0f77d29df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679533 Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#681426}
-
Yuwei Huang authored
This CL removes unused scopes from Android client and test binaries. Bug: 983282 Change-Id: I2e8b7ff344e0dcfafafca28d3025ec8b49c3fed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719228 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#681425}
-
Hesen Zhang authored
- Added sanity check for icons field in NotificationData. Bug: 987823 Change-Id: I01e839a3c77783931a3ca8da58b99e6f6e941c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719671 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#681424}
-
Owen Min authored
Turn off pretty print. Use default value of no convert value, no device data, convert type and includes user policies. Bug: 983174 Change-Id: I54ac204c18d55463431beade7e54d619b4b81051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721450Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#681423}
-
K Moon authored
Refactors layout-specific state (document size, rotation) from PDFiumEngine into a separate DocumentLayout class. This will allow new layouts to be computed without disturbing the current layout. As a side benefit, this should be another step towards simplifying PDFiumEngine to be less of a grab bag of concerns. Bug: 885110 Change-Id: Ieabde78d8acdcb2f83aac980d03f6fd8f28295a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716158 Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#681422}
-
Xiyuan Xia authored
Release MachineLearningDecisionServiceProvider before tearing down ash to fix the crash. Bug: 987687 Change-Id: Ice42d1c50b0534d5f8386038087b74a84bd6969c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719447Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#681421}
-
David Bokan authored
This CL adds two metrics. The first is an UMA histogram tracking how often we try to use an element-id based fragment and succeed vs fail. Note that if the TextFragmentAnchor feature is enabled, we won't count this metric if the fragment successfully parses to a |targetText| anchor. The second metric measures how often we see a hash ("#") character in the fragment. This is technically an invalid URL but we'd like to evaluate how often it happens in practice. Similarly to above, if targetText is enabled, we won't count cases of ##targetText as being part of this metric. Bug: 987027 Change-Id: Ic3b6cf1a85e590449af12c131edc60b13bad0dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719651Reviewed-by:Robert Kaplow <rkaplow@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#681420}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/23a204c3872e..22762d94d758 git log 23a204c3872e..22762d94d758 --date=short --no-merges --format='%ad %ae %s' 2019-07-26 jclinton@chromium.org Mark mistral experimental Created with: gclient setdep -r src/third_party/chromite@22762d94d758 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I171b442b739138a76439c96f4c84a2b16ea54c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720924Reviewed-by:
-
Vladimir Levin authored
Since some layout objects don't have Nodes (ie they are anonymous), we need to still properly detect if they are in locked subtrees. To that end, this patch adds LayoutObject version of NearestLocked* functions which first find the nearest node and then call the appropriate Node versions. R=chrishtr@chromium.org, rakina@chromium.org Bug: 986827, 987724, 987816 Change-Id: I7f8011bc0182f99cdcb032303ad6e1851cb9b897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720736Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681418}
-
Alex Keng authored
This change implements the reveal button for <input type=password>. The button is added using same pattern as the clear/cancel button for <input type=search> except that instead of using -webkit-appearance to draw the button, we use svgs defined in controls-refresh.css. A keydown handler is added to support Alt-F8 hotkey to reveal/obscure password and logics are added to make sure the reveal button only appears with direct user input. If the password is not empty in the first place (ex. autofill or value=xxx) or the control loses focus and regains focus, or the value is changed by script, the reveal button won't show. Note we are using -internal-reveal as the pseudo element id, so there is no way for authors to customize or hide the reveal button. This might be changed after a consensus over what id to use is reached, or after the button gets standardized. Tests are added in web_tests/fast/forms/controls-new-ui/password. Change-Id: Ib2b37771b8ca246c7401eea65bfd20be6cc73f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708748 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#681417}
-
Koji Ishii authored
These tests are for an edge case that is resolved[1] to be undefined in CSS Writing Modes Level 3, and the new behavior is defined in Level 4. We don't have a plan to implement Level 4 yet. These tests will be moved back when it starts. [1] https://github.com/w3c/csswg-drafts/issues/4139 TBR: eae@chromium.org Bug: 987976 Change-Id: I08056a2d3f49ec04ade3aa1ced848b8a418cc51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720866Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#681416}
-
Meilin Wang authored
This change updates the logic for setting DSP model based on different locales. See the linked bug for more details. Bug: b/134125220 Test: local compile and manually test. Change-Id: If4f33cf038f373853e8a9ff3b0fa1b3885320d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648832 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#681415}
-
Antonio Gomes authored
This is part of phase 4.8 in the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/ Note that, in order to eliminate calls to classes not available to blink yet, a blink::Platform method was added - namely, GetWebRtcSignalingTaskRunner(). Also, in order to make this class reside in blink/renderer from the beginning, a factory method was added to [2] - namely CreateWebMediaStreamRendererFactory. Also, [2] was moved to [3] so that the implementation of this method could reside in renderer/modules/mediastream, where it needs to call a class from (MediaStreamRendererFactoryImpl). [2] public/platform/modules/mediastream/web_media_stream_renderer_factory.h [3] public/web/modules/mediastream/web_media_stream_renderer_factory.h Note that the switch from using std::string to WebString in WebMediaStreamRendererFactory is done in a follow up CL already up for review, https://crrev.com/c/1715310/ BUG=704136 R=guidou@chromium.org, haraken@chromium.org TBR=jam@chromium.org Change-Id: Ia8b7d00328a77159318964abfa715004d60dcdcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715418Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#681414}
-
Owen Min authored
Turn off convert types and pretty print. Use default value of no convert value, no device data and includes user policies. Bug: 983174 Change-Id: I8815e4f66c5b7326cf337fb610a2dfbebc4d3f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721078Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#681413}
-
gogerald authored
Screenshots: https://drive.google.com/file/d/14ssIg6-tvLU_yAa8RTZEPHNsvbfGYgTa/view?usp=sharing This CL split the original FeedNewTabPage, FeedNewTabPageMediator and StreamLifecycleManager into multiple classes, but we do not expect visible changes on FeedNewTabPage. This CL also fixed the dummy FeedNewTabPage which was broken by https://chromium-review.googlesource.com/c/chromium/src/+/1709731 Bug: 982018 Change-Id: I933cb01789d5eda8a196de00e4bf279bb7d6d785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715410Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#681412}
-
Dominic Battre authored
This CL shares the common code of the WebUI of chrome://password-manager-internals and chrome://autofill-internals. This enables simpler development of follow-up features such as reporting active experiments. Bug: 928595 Change-Id: I7d4bda4f2a1b643ed4e5cfa0056ae843a4d1eedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710653Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#681411}
-
John Budorick authored
This reverts commit 67eba1f6. Reason for revert: Responsible for compile failures on https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/12897, which were warnings on previous builds. Original change's description: > Enable fatal linker warnings on cros/arm builds. > > The references bug was closed long ago, and we're on a completely different > toolchain now. > > Bug: 356580 > Change-Id: I92b1a0c2ddd33a18775a72347ac996a4320d173c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721249 > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Mike Frysinger <vapier@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681379} TBR=vapier@chromium.org,thakis@chromium.org Change-Id: I946510c52c36d1488c48c220ef3c88bb0b0ae076 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 356580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721032Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#681410}
-
Matthew Cary authored
Bug: 795291 Change-Id: I17cdb24f7b98e43323fd40f86af445509632bd0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695290 Auto-Submit: Matthew Cary (CET) <mattcary@chromium.org> Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#681409}
-
Katie D authored
Left click is the most useful click type. Upon re-enable, autoclick type should always be left click. Also don't draw the scroll icon when disabled. Bug: 988020,988007 Change-Id: I5f92376ac2f26bde0ecceea401c573a2f306a47f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721510 Commit-Queue: Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#681408}
-
Stefan Zager authored
This CL replaced a bunch of element_->GetLayoutObject() calls with GetLayoutEmbeddedContent(): https://chromium-review.googlesource.com/c/chromium/src/+/1597534 However, those two calls are not equivalent if the LayoutObject is not a LayoutEmbeddedContent. This patch restores the calls to element_->GetLayoutObject(). I was unable to reproduce the crash, even using the clusterfuzz tools, so I can't write a test. BUG=982214 R=bokan@chromium.org Change-Id: If2dee39a235ee961d7f27258e7a04e8165d2ab3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719911Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#681407}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6e3a40600f24..e5bc2758b312 git log 6e3a40600f24..e5bc2758b312 --date=short --no-merges --format='%ad %ae %s' 2019-07-26 tsepez@chromium.org Mark CPDF_DocPageData::Clear() as private 2019-07-26 tsepez@chromium.org Remove some other virtual dtors. 2019-07-26 tsepez@chromium.org De-virtualize CFWL_FontManager and CFWL_FontData. Created with: gclient setdep -r src/third_party/pdfium@e5bc2758b312 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Iaea4c41e612e6d260f45f237f1a3acacc2d8d59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720739Reviewed-by:
-
Natalie Chouinard authored
Because the preferences on this screen are loaded asynchronously, the default RecyclerView animations delay the preferences first appearing, so we disable them here to reduce animation jank. A long-term solution for disabling preference animations is being tracked here: https://crbug.com/986401 Bug: 986241 Change-Id: I0ea833d79a49c15bf602d6374080f65d32586555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717323Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#681405}
-
Devlin Cronin authored
The "browser_action_hidden" preference hasn't been used since the Extension Toolbar Redesign launched (several years ago). Remove the preference, add it to the list of obsolete prefs to be cleaned up in the ExtensionPrefs, and remove the corresponding histogram. Bug: 975789 Change-Id: I427629ef6f3741d672af71aa7892beae4f6527ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719970Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Nick Diego Yamane authored
This CL adds some properties that were missing at PlatformWindow level as well as code to convert Widget::InitParams into PlatformWindowInitProperties in DWTHPlatform. Bug: 789065 Change-Id: Ie224c3ae3434afce0ecdd6d4b044ca9f75f29aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718456 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#681403}
-
Koji Ishii authored
This patch changes HtmlLinkElement to use LowerASCII instead of DeprecatedLower. DeprecatedLower has partial Unicode conversions, such as converting U+212A to 'k', but lowering only ASCII should be sufficient for most web platform usages. Currently, there are 6 usages of AtomicString::DeprecatedLower and 37 usages of String::DeprecatedLower. This patch reduces one of the 6 usages. Bug: 627682 Change-Id: I8b94712275ec94b5cc21f8941049864e5b66e384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720819 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Cleans up various aspects of the GPU pixel tests, such as adding docstrings, renaming, and generally making them more readable. Bug: 985007 Change-Id: I2f179db7dca9b209881d09f40b5750db36f6f62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718782 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#681401}
-
weiliangc authored
This reverts commit 89eb64aa. Reason for revert: Suspect this breaks the Mac display. Original change's description: > viz: Merge CA Overlay Validator into a Subclass of Overlay Processor > > CA Overlay Validator has simple logic and could be easily merged into > a subclass of overlay processor. > > R=rjkroege > > Bug: 963597 > Change-Id: Ia6334b82a8826740098ad279b74cd044ff4d8d42 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664973 > Commit-Queue: weiliangc <weiliangc@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681186} TBR=rjkroege@chromium.org,weiliangc@chromium.org Change-Id: Icd40d3893d1fa71d09764864536eb442a733c0d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721496Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#681400}
-
