GitLab

skip_service_worker flag was introduced in https://codereview.chromium.org/527713002/.
But setting this flag of RequestExtraData in RenderFrameImpl::willSendRequest() is looks weird.
This flag should be in RequestInfo and should be set in WebURLLoaderImpl::Context::Start.

BUG=402093

Review URL: https://codereview.chromium.org/547213002

Cr-Commit-Position: refs/heads/master@{#294151}

Revert of ReReland ServiceWorkerCacheStorage::Keys function (patchset #3 id:140001 of https://codereview.chromium.org/543093003/)

Reason for revert:
Linux Valgrind now passes but ChromeOS Valgrind doesn't.  Looks like I need to do more on TearDown.

Original issue's description:
> ReReland ServiceWorkerCacheStorage::Keys function
>
> Suppression (error hash=#E226F7559AD360E7#):
> For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
> {
> <insert_a_suppression_name_here>
> Memcheck:Leak
> fun:_Znw*
> fun:_ZN4base8internal20PostTaskAndReplyImpl16PostTaskAndReplyERKN15tracked_objects8LocationERKNS_8CallbackIFvvEEESA_
> fun:_ZN4base10TaskRunner16PostTaskAndReplyERKN15tracked_objects8LocationERKNS_8CallbackIFvvEEES9_
> fun:_ZN10disk_cache15SimpleEntryImpl13CloseInternalEv
> fun:_ZN10disk_cache15SimpleEntryImpl24RunNextOperationIfNeededEv
> fun:_ZN10disk_cache15SimpleEntryImpl21DoomOperationCompleteERKN4base8CallbackIFviEEENS0_5StateEi
> }
> Original CL: https://codereview.chromium.org/477973002/
> Reland: https://codereview.chromium.org/528233003/
>
> The SimpleCache backend wasn't given a chance to finish up a close operation before the IO messageloop closed at the end of functions.  The tests now run the loop in TearDown.
>
> The original patch is PatchSet1 and the fix is PatchSet3.
>
> BUG=392621
>
> Committed: https://crrev.com/bbfe6ce49b8e99b190085dffbf446b474c5f07ff
> Cr-Commit-Position: refs/heads/master@{#294090}

TBR=michaeln@chromium.org,horo@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=392621

Review URL: https://codereview.chromium.org/562613002

Cr-Commit-Position: refs/heads/master@{#294150}

Navigating directly to chrome://voicesearch in guest mode is causing
a crash, since the HotwordService is NULL in the guest mode. This
patch adds a NULL check on HotwordService to fix the crash.

BUG=411784
TEST=With --new-profile-management enabled, try to open chrome://voicesearch
in guest mode.

Review URL: https://codereview.chromium.org/554603002

Cr-Commit-Position: refs/heads/master@{#294149}

Media unit tests depending on ffmpeg are currently only removed
using OS=="android", but let's remove them based on
media_use_ffmpeg==0 instead.

BUG=410779
R=acolwell@chromium.org

Review URL: https://codereview.chromium.org/541553003

Cr-Commit-Position: refs/heads/master@{#294148}

Potential controllees need to observe version change events to make a ready
registration, but, before this patch, those events are sent not to potential
controllees but to pages that have the corresponding registration object
(to be more precise, pages that have the reference to the registration).

After this patch, ServiceWorkerProviderHost sends an IPC message to the
corresponding ServiceWorkerProviderContext when the host gets associated with
a registration and the provider context retains a reference of the registration
so that the potential controllee can observe the version change events.

1) Blink: https://codereview.chromium.org/476043002/
2) Chromium: THIS PATCH
3) Blink: https://codereview.chromium.org/532653002/

BUG=399533
TEST=content_unittests --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py --debug http/tests/serviceworker/ (with the patch (3))

Review URL: https://codereview.chromium.org/477593007

Cr-Commit-Position: refs/heads/master@{#294147}

Embedders may want to apply independent filters on layers for their
browser GUI. If they need two instances of a GUI element then they are
forced to add two layers with the same content in them. In the DRL case
an access to DelegatedFrameProvider needed. With this change embedders
can create secondary DRL layers easily.

https://groups.google.com/a/chromium.org/forum/
    /#!topic/graphics-dev/xZPzMnBe6dg

R=sievers@chromium.org,aelias@chromium.org
BUG=

Review URL: https://codereview.chromium.org/527073002

Cr-Commit-Position: refs/heads/master@{#294146}

TEST=n/a
BUG=none

Review URL: https://codereview.chromium.org/560753002

Cr-Commit-Position: refs/heads/master@{#294145}

R=pkl@chromium.org,cmasone@chromium.org

Review URL: https://codereview.chromium.org/545433002

Cr-Commit-Position: refs/heads/master@{#294144}

Removing a local variable to keep it in the crash dump, that is added in:
http://crrev.com/c7f0b95fefa64b7bb0accea8aafc3fb819bfdcc7

BUG=393634

Review URL: https://codereview.chromium.org/562493004

Cr-Commit-Position: refs/heads/master@{#294143}

Add support for Cmd- (the universal "cancel" shortcut on Mac) to close print dialog.

BUG=249786
R=dpapad@chromium.org

TEST=
1. Open a web page
2. Hit Cmd-P to bring up print dialog.
3. Hit Cmd- and observe.
4. The print dialog should get closed.

Review URL: https://codereview.chromium.org/555733003

Cr-Commit-Position: refs/heads/master@{#294142}

ServiceWorkerRegistration::unregister returns false when the registration is already unregistered. (2/3)

1. [Blink] https://codereview.chromium.org/549093002/
2. [Chromium] this patch
3. [Blink] https://codereview.chromium.org/550093002/

BUG=390894

TEST=content_browsertests --gtest_filter='ServiceWorkerBlackBoxBrowserTest.Registration'
TEST=content_unittests --gtest_filter='ServiceWorkerJobTest.Unregister_NothingRegistered'
TEST=content_unittests --gtest_filter='ServiceWorkerJobTest.ParallelUnreg'

Review URL: https://codereview.chromium.org/554573002

Cr-Commit-Position: refs/heads/master@{#294141}

These functions used to be called asynchronously, and recently switched to be synchronous.
Then it's more readable to expand them to their caller.

BUG=412367

Review URL: https://codereview.chromium.org/560703002

Cr-Commit-Position: refs/heads/master@{#294140}

Cleanup: Use base/files/file_util.h instead of base/file_util.h in cc/, chromecast/, cloud_print/, mojo/, and win8/

TBR=enne@chromium.org,lcwu@chromium.org,vitalybuka@chromium.org,viettrunglluu@chromium.org,cpu@chromium.org

Review URL: https://codereview.chromium.org/559743002

Cr-Commit-Position: refs/heads/master@{#294139}

Currently there is only AppListServiceInteractiveTest which is excessive
for tests that do not need to be interactive. It also leaves gaps in the
testing of the AppListServiceImpl, since it only uses the parent,
AppListService interface.

This CL adds scaffolding for better app list test coverage, leading up
to better testing for Chrome's AppListViewDelegate, which is currently
hard to get at in a test.

The test is a non-interactive version of showing the app list, which
verifies expectations about the actual Profile* that is missing from
current tests (e.g. TestingAppListServiceImpl has it mocked out to
return NULL, since unit_tests don't have a ProfileManager).

BUG=169114

Review URL: https://codereview.chromium.org/552153002

Cr-Commit-Position: refs/heads/master@{#294138}

For aria role like spinbutton, button, toolbar, the corresponding .html files are without 'aria-' prefix which might cause confusion. So, prefixing 'aria-' with those missed .html files.

Review URL: https://codereview.chromium.org/557883002

Cr-Commit-Position: refs/heads/master@{#294137}

Review URL: https://codereview.chromium.org/558833002

Cr-Commit-Position: refs/heads/master@{#294136}

Revert of Cross-process iframe accessibility. (patchset #19 id:360001 of https://codereview.chromium.org/268543008/)

Reason for revert:
Broke Mac tests:

http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%281%29/builds/26131

http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/52684

http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/26975

http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/26976

and so on.

Original issue's description:
> Cross-process iframe accessibility.
>
> This change completes the plumbing to join cross-process iframes into a single composed accessibility tree on platforms that implement native accessibility APIs (Windows, Mac, Android).
>
> Further work will be needed to update some accessibility API implementations to be multi-frame-aware.
>
> BUG=368298
>
> Committed: https://crrev.com/387942c041da17ea6337bc0a81e96619e67e4ac4
> Cr-Commit-Position: refs/heads/master@{#294118}

TBR=creis@chromium.org,dtseng@chromium.org,aboxhall@chromium.org,nick@chromium.org,nasko@chromium.org,dmazzoni@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=368298

Review URL: https://codereview.chromium.org/558943002

Cr-Commit-Position: refs/heads/master@{#294135}

Now the start page always slides in from the top, while the other pages
slide in from the bottom. (Previously they were all arranged in order
from top to bottom.)

BUG=406222

Review URL: https://codereview.chromium.org/555753002

Cr-Commit-Position: refs/heads/master@{#294134}

BUG=393889
TEST=Verified by unit_tests.

Review URL: https://codereview.chromium.org/560623003

Cr-Commit-Position: refs/heads/master@{#294133}

Cr-Commit-Position: refs/heads/master@{#294132}

According to spec http://www.w3schools.com/tags/av_prop_duration.asp,
if no audio/video is set, NaN should be returned. When metadata is not
available, duration is unknown then NaN is returned.

R=qinmin@chromium.org

Review URL: https://codereview.chromium.org/552723003

Cr-Commit-Position: refs/heads/master@{#294131}

https://chromium.googlesource.com/chromium/blink/+log/adfaa7e06fafd9c57a4b019fbef0950b185c4d87..a35fa45e4848392d9d768ec88c7931d5099c1df4
TBR=keishi@chromium.org,jianli@chromium.org

Review URL: https://codereview.chromium.org/557153003

Cr-Commit-Position: refs/heads/master@{#294130}

BUG=406222

Review URL: https://codereview.chromium.org/557173003

Cr-Commit-Position: refs/heads/master@{#294129}

https://skia.googlesource.com/skia/+log/d954498c01ccf0417feacf89e45d0c62a06a813b..8247ec313d87afcdd4da59b1f2f0d24e0983e359

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/561573002

Cr-Commit-Position: refs/heads/master@{#294128}

Review URL: https://codereview.chromium.org/543333002

Cr-Commit-Position: refs/heads/master@{#294127}

This slows top-level app list page transitions from 120ms to 180ms.

BUG=406222

Review URL: https://codereview.chromium.org/559853003

Cr-Commit-Position: refs/heads/master@{#294126}

Elements which don't have corresponding entries can be focused. (for example, when buttons are focused by <Tab>.)
When they are focused, canExecute of commands are called and warnings are emitted in CommandUtil.getCommandEntry().
This CL warn more specific (really suspicious) case. That is, a command executed on an element which doesn't have corresponding entry.

BUG=411790
TEST=manually tested

Review URL: https://codereview.chromium.org/550943003

Cr-Commit-Position: refs/heads/master@{#294125}

It results in a use-after-free if AppWindow is not closed.

Add a new method DesktopController::CreateAppWindow()
-Rename existing CreateAppWindow() method to CreateShellAppWindow().
-Add a new method CreateAppWindow() to remember the AppWindow.
-Close the AppWindow in CloseAppWindows().

Implement ShellNativeAppWindow::Close()
-Call AppWindow::OnNativeClose() to destruct the AppWindow.

BUG=387288

Review URL: https://codereview.chromium.org/543123004

Cr-Commit-Position: refs/heads/master@{#294124}

 * Add AthenaAppDelegate
 * Add factory functions to create various dialogs
 * Add terminating callback to AthenaEnv

BUG=411415
TEST=AthenaEnvTest.TerminatingCallback
TBR=sky@chromium.org, jochen@chromium.org, reed@chromium.org

Review URL: https://codereview.chromium.org/544953003

Cr-Commit-Position: refs/heads/master@{#294123}

Compilation on linux using gcc 4.8 toolchain fails for the following duplicate statement.

FRIEND_TEST_ALL_PREFIXES(PrintWebViewHelperTest, OnPrintPages):
error: ‘printing::PrintWebViewHelperTest_DISABLED_OnPrintPages_Test’ is already a friend of ‘printing::PrintWebViewHelper’ [-Werror]

NOTRY=true

Review URL: https://codereview.chromium.org/553313002

Cr-Commit-Position: refs/heads/master@{#294122}

chrome/test/data/gdata will be removed once WAPI code is removed,
hence google_apis/drive/drive_api_requests_unittest.cc should stop
using chrome/test/data/gdata/testfile.txt

BUG=412238
TEST=no change to production binary.
     google_apis_unittests should pass as before

Review URL: https://codereview.chromium.org/548343004

Cr-Commit-Position: refs/heads/master@{#294121}

Will add layout tests to Blink after this CL.

BUG=123896

Review URL: https://codereview.chromium.org/555733002

Cr-Commit-Position: refs/heads/master@{#294120}

operator new(size_t size, void* buffer, sandbox::AllocationType type) just
returns buffer, which is what the default placement new operator does too.

No intended behavior change.

(The motivation is to get rid of the two "return NULL"s in
`operator delete(void* memory, sandbox::AllocationType type)`, as they are
undefined behavior.)

BUG=none

Review URL: https://codereview.chromium.org/544333002

Cr-Commit-Position: refs/heads/master@{#294119}

This change completes the plumbing to join cross-process iframes into a single composed accessibility tree on platforms that implement native accessibility APIs (Windows, Mac, Android).

Further work will be needed to update some accessibility API implementations to be multi-frame-aware.

BUG=368298

Review URL: https://codereview.chromium.org/268543008

Cr-Commit-Position: refs/heads/master@{#294118}

Cleaning up weak_ptr_factory destruction order in "src/tools" module.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/555093002

Cr-Commit-Position: refs/heads/master@{#294117}

- Defined all properties in the constructor.
- Prevent adding new properties outside the constructor.
- Removed unused properties (searchBoxWrapper_, driveBuyMoreStorageCommand_)

BUG=294698
TEST=run browser_tests

Review URL: https://codereview.chromium.org/555403003

Cr-Commit-Position: refs/heads/master@{#294116}

BUG=325029
TEST=none

Review URL: https://codereview.chromium.org/559843003

Cr-Commit-Position: refs/heads/master@{#294115}

BUG=410639
TEST=components_unittests
R=tengs@chromium.org, cbentzel@chromium.org

Review URL: https://codereview.chromium.org/538843002

Cr-Commit-Position: refs/heads/master@{#294114}

Before this CL:
Candidate processes info is saved in EmbeddedWorkerInstance, when a new
worker instance is created for a same scope, the info will be absent for
the new worker. E.g., periodic update will spawn a new process every time.

After this CL:
Candidate processes info will be saved in  ServiceWorkerProcessManager
key by registration scope. Then different versions with the same scope could
share this info.

BUG=399982
TEST=content_unittests --gtest_filter=ServiceWorker*

Review URL: https://codereview.chromium.org/443593002

Cr-Commit-Position: refs/heads/master@{#294113}

app_window_custom_bindings.js depends on currentWindowInternal.

BUG=387288

Review URL: https://codereview.chromium.org/540273002

Cr-Commit-Position: refs/heads/master@{#294112}