GitLab

v8::Handle<T> is just an alias of v8::Local<T>

BUG=424445

Review URL: https://codereview.chromium.org/660243003

git-svn-id: svn://svn.chromium.org/blink/trunk@183938 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The related CL:
https://codereview.chromium.org/609793002/

BUG=226505

Review URL: https://codereview.chromium.org/623693002

git-svn-id: svn://svn.chromium.org/blink/trunk@183937 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=141116

Review URL: https://codereview.chromium.org/657293002

git-svn-id: svn://svn.chromium.org/blink/trunk@183936 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These forward references are not needed anymore. After
this patch, Source/core/events has no unneeded forward references
any more.

Review URL: https://codereview.chromium.org/656683009

git-svn-id: svn://svn.chromium.org/blink/trunk@183935 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Tightened int types to unsigned in TextRun to make it easier to reason about the code and in the process removed some casts and some ASSERTS that are no longer needed.

Also made the getter type consistent with the corresponding member type for for consistency where applicable.

Review URL: https://codereview.chromium.org/652483002

git-svn-id: svn://svn.chromium.org/blink/trunk@183934 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/663923002

git-svn-id: svn://svn.chromium.org/blink/trunk@183933 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The code already avoided scrolling if an object was already visible.
This extends that logic so that if the object is larger than the viewport,
it avoids scrolling if the subfocus is already visible.

BUG=374316, 424691

Review URL: https://codereview.chromium.org/657903004

git-svn-id: svn://svn.chromium.org/blink/trunk@183932 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This still leaves the old codepaths for the geofencing API in place, those will be cleaned up in a followup CL.

BUG=383125

Review URL: https://codereview.chromium.org/623813002

git-svn-id: svn://svn.chromium.org/blink/trunk@183931 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ASSERT that the m_glyphToCharacterIndexes vector is available in the
characterIndexForXPosition method.

BUG=423649
R=jln@chromium.org

Review URL: https://codereview.chromium.org/666613002

git-svn-id: svn://svn.chromium.org/blink/trunk@183930 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also mark the test as Pass/Fail until the next V8 roll lands (at
which point it'll start passing again).

TBR=dslomov@chromium.org
BUG=424756

Review URL: https://codereview.chromium.org/662873002

git-svn-id: svn://svn.chromium.org/blink/trunk@183929 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews,haraken
BUG=391288
NOTRY=true

Review URL: https://codereview.chromium.org/659953004

git-svn-id: svn://svn.chromium.org/blink/trunk@183928 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183917

BUG=295848
TBR=ambarish.r@samsung.com

Review URL: https://codereview.chromium.org/662683004

git-svn-id: svn://svn.chromium.org/blink/trunk@183927 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The particular broken case is when the object to be made visible is inside of
a scrollable container that's larger than the viewport (window).

Previously, the code scrolled the object to be visible within the container,
then recursively scrolled the container to be visible within the viewport.
That doesn't necessarily work if the container is larger than the viewport.
Now it passes the coordinates of the original object up recursively as the
"subfocus".

In addition, this change centers the object within the viewport, rather than
scrolling minimally to get it in view. This more closely matches how the
browser normally behaves when you focus something offscreen, and makes for
a better experience on Android, where we use this function extensively
every time you move accessibility focus.

Well-covered by existing tests, plus a new test for the case that didn't
previously work.

BUG=374316,424691

Review URL: https://codereview.chromium.org/661183002

git-svn-id: svn://svn.chromium.org/blink/trunk@183926 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The HRTF panner uses significant memory for the responses and requires a fair amount of processing to implement. For low-end mobile devices, this can be an issue. Since the default panner model is HRTF, the creation of the panner can cause the responses to be loaded.

Perhaps the default should be changed to equalpower, which doesn't consume significant memory and is much less intensive in processing power.

This is an incompatible change with the current spec.

See also: https://github.com/WebAudio/web-audio-api/issues/368

BUG=424356

Review URL: https://codereview.chromium.org/652073003

git-svn-id: svn://svn.chromium.org/blink/trunk@183925 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=adamk
BUG=424736

Review URL: https://codereview.chromium.org/644993004

git-svn-id: svn://svn.chromium.org/blink/trunk@183924 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Improves code readabilty

BUG=none
TEST=no layout test failures

Review URL: https://codereview.chromium.org/645513003

git-svn-id: svn://svn.chromium.org/blink/trunk@183923 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No need to fall back to subtree recalc for:

::-webkit-scrollbar
::-webkit-scrollbar-button
::-webkit-scrollbar-thumb
::-webkit-scrollbar-track
::-webkit-scrollbar-track-piece

R=chrishtr@chromium.org,esprehn@chromium.org
BUG=424546

Review URL: https://codereview.chromium.org/653423003

git-svn-id: svn://svn.chromium.org/blink/trunk@183922 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183913

BUG=391288
TBR=dsinclair@chromium.org

Review URL: https://codereview.chromium.org/661073004

git-svn-id: svn://svn.chromium.org/blink/trunk@183921 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183910

BUG=422812
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/635273005

git-svn-id: svn://svn.chromium.org/blink/trunk@183920 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL checks used total size before computing the thumb
size. If it's zero, we'll show no thumb.

BUG=421869

Review URL: https://codereview.chromium.org/662593004

git-svn-id: svn://svn.chromium.org/blink/trunk@183919 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Element::scrollIntoViewIfNeeded computes the scroll bounding box by calling containerNode::boundingBox(), for performing autoscroll.
This bounding box rect is passed to RenderLayerScrollableArea::exposeRect(), where actual
scroll parent rect to be scrolled is computed.

This bound is computed by using two factors.
current Scroll Offset and the target Scroll Offset.

target scroll offset is Y position of the element which has to be
scrolled into view. This Y position computation includes top border
of the parent container.
for example. in the bug reported page.
Parent grid has border of 5 px so,
the position of first  child would be 5  and
the position of second child would be 55 and so on

But [current]scroll offset is independent of top border.
When target bounding box is computed, target scroll offset is
substracted from current scroll offset which results in incorrect
scroll offset.
for example. in the bug reported page
1. When page loads grid is scrolled to 200.
2. Parents top border is      5,
3. Position of 2nd child is  55
4. so the target scroll offset is computed as,
   55 - 200 = -145 , which is incorrect &
   should be,  50 - 200 = -150
5. Hence the borderTop included in the position causes the issue, and needs to be removed from computed scroll offset value.

BUG=295848

Review URL: https://codereview.chromium.org/568453002

git-svn-id: svn://svn.chromium.org/blink/trunk@183917 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebAudio is adding a suspend()/resume() API:

https://github.com/WebAudio/web-audio-api/issues/361
https://github.com/WebAudio/web-audio-api/issues/317

In more detail, here is the proposed additions to the spec:

New attribute "state" with values:
paused
  Currently paused (time is not proceeding, audio hardware may be powered down/released).
running
  Audio is being processed.
released
  AudioContext has been released, and can no longer be used to process audio. All system resources should be released.

void suspend()
Suspends the progression of time in the audio context, allows any current buffer contents to be played to the destination and then allows the system to power down and/or release audio hardware. If the context has been released, an InvalidStateError MUST be thrown. This is generally useful when the application knows it will not need the AudioContext for some time, and wishes to let the audio hardware power down.

While the system is suspend, MediaStreams will have their output ignored; that is, data will be lost by the real time nature of media streams. HTMLMediaElements will similarly have their output ignored until the system is resumed. Audio Workers and ScriptProcessorNodes will simply not fire their onaudioprocess events while suspended, but will resume when resumed. For the purpose of AnalyserNode window functions, the data is considered as a continuous stream - i.e. the resume()/suspend() does not cause silence to appear in the AnalyserNode's stream of data.

Promise resume()
Resumes the progression of time in the audio context, which may involve re-priming the frame buffer contents. The promise resolves when the system has re-acquired (if necessary) access to audio hardware and has begun streaming to the destination, or immediately (with no other effect) if the context is already running. The promise is rejected if the context has been released.

BUG=420106

Review URL: https://codereview.chromium.org/625363004

git-svn-id: svn://svn.chromium.org/blink/trunk@183916 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch fixes a bug in removing uiSourceCodes from workspace as
the associated stylesheet gets removed.

BUG=424544
R=vsevik

Review URL: https://codereview.chromium.org/661923005

git-svn-id: svn://svn.chromium.org/blink/trunk@183915 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently, first letter renderers are created and destroyed through the updateFirstLetters() call in
RenderBlock. This has, historically, been problematic as we may miss places where the call
was required, leading to accessing invalid memory.

This CL converts the first letter code to use a PseudoElement for the first-letter instead of
creating classes during layout.

With the PseudoElement implementation the two tests which are currently in
LayoutTests/fast/css/first-letter-removed-added.html work as expected.

BUG=391288

Review URL: https://codereview.chromium.org/571603003

git-svn-id: svn://svn.chromium.org/blink/trunk@183913 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To be compliant to the WHATWG Encoding spec (living standard), we should
treat ISO-8859-1 and windows-1252 synonymously. Moreover, windows-1252
is the canonical encoding name.

Update TextCodecLatin1 to list only aliases specified in the encoding
spec.

See https://codereview.chromium.org/598383002 (ICU update) and
    https://codereview.chromium.org/649413002 (roll ICU with necessary
    test/pref/UI changes in Chrome).

BUG=412053
TEST=fast/encoding/*
TEST=http/tests/misc/char*
R=jochen@chromium.org, jsbell@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183781

Review URL: https://codereview.chromium.org/655083002

git-svn-id: svn://svn.chromium.org/blink/trunk@183912 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=True
TBR=kouhei,eae
BUG=397902,422050

Review URL: https://codereview.chromium.org/663863002

git-svn-id: svn://svn.chromium.org/blink/trunk@183911 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a render object changes location, we should force paint
invalidation checking for all descendants on the same backing,
including positioned ones. However, previously we only force
invalidation checking for non-positioned descendants.

Now let RenderBlock override
RenderObject::invalidatePaintOfSubtreesIfNeeded() so that it
can use the childPaintInvalidationState, which has been forced
checking of invaldation, for the positioned descendants.

BUG=422812
TEST=fast/repaint/positioned-great-grandparent-change-location.html

Review URL: https://codereview.chromium.org/662483002

git-svn-id: svn://svn.chromium.org/blink/trunk@183910 bbb929c8-8fbe-4397-9dbb-9b2b20218538

So as to be able to trace its PendingScript part object.

R=haraken
BUG=

Review URL: https://codereview.chromium.org/660233002

git-svn-id: svn://svn.chromium.org/blink/trunk@183909 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The plan is to create a LocalFrame that is loosely tied to an existing RemoteFrame but is not really attached to the FrameTree. The LocalFrame will begin loading, and when it commits, it will be swapped into where the RemotFrame was. This adds sufficient logic to actually support that swap (and to maintain the intermediate semi-attached state while the LocalFrame is provisional).

BUG=422583

Review URL: https://codereview.chromium.org/643333002

git-svn-id: svn://svn.chromium.org/blink/trunk@183908 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=424648
TBR=yoichio@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/665643002

git-svn-id: svn://svn.chromium.org/blink/trunk@183907 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- add graphics for chrome on top of viewport rectange;
- make viewport border light-grey, let its width scale along with
    contents scale.
- change Viewport checkbox to Chrome (always show viewport)
- (drive by) properly handle potential image/texture creation errors
- (drive by) disable user selection on Layers3DView in CSS as annoying.

BUG=

Review URL: https://codereview.chromium.org/661753002

git-svn-id: svn://svn.chromium.org/blink/trunk@183906 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change adds code to save and replay the canvas state stack when
transferring from a display list to a raste canvas

BUG=423913
TEST=fast/canvas/canvas-unballanced-save.html

Review URL: https://codereview.chromium.org/661763003

git-svn-id: svn://svn.chromium.org/blink/trunk@183904 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183890

BUG=421380
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/663783003

git-svn-id: svn://svn.chromium.org/blink/trunk@183903 bbb929c8-8fbe-4397-9dbb-9b2b20218538

beginLayer()/endLayer() behaves like save()/restore() for only CTM and clip states.
SkCanvas::saveLayer() behaves the same as save(), but in addition it allocates an offscreen buffer.
It causes the inconsistency for restoring states managed by between SkCanvas and SkPaint.

For example,
    context.translate(1, 0);
    context.setCompositeOperation(CompositeDestinationIn);

    context.beginLayer(1, CompositeSourceIn);
    context.translate(-1, 0);
    context.setCompositeOperation(CompositeSourceOver);
    context.endLayer();

    // At this moment, CTM is translate(1, 0) while current composite operator is CompositeSourceOver.

It's because CTM is managed by SkCanvas, while current composite operator is managed by GraphicsContext.

BUG=423414

Review URL: https://codereview.chromium.org/651243002

git-svn-id: svn://svn.chromium.org/blink/trunk@183902 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The exception handling was added in r177449, but then was accidentally
removed via r183686. This patch brings the test and functionality back.

R=vsevik

Review URL: https://codereview.chromium.org/661983003

git-svn-id: svn://svn.chromium.org/blink/trunk@183901 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This setting will not longer be used after:
https://codereview.chromium.org/618013003/

It will be landed after that change.

BUG=398485

Review URL: https://codereview.chromium.org/614173003

git-svn-id: svn://svn.chromium.org/blink/trunk@183900 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add WebRuntimeFeatures::enableCSSViewport() method that should substitute the unfortunately named 'WebRuntimeFeatures::setCSSViewportEnabled()'.

BUG=424459

Review URL: https://codereview.chromium.org/662003002

git-svn-id: svn://svn.chromium.org/blink/trunk@183899 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds UseCounters for SVG DOM, to see how much usage there is.

SVG DOM support is enabled by default, but it will be possible to disable it with a commandline flag (--disable-svg1dom), see https://codereview.chromium.org/577943002.

BUG=415074

Review URL: https://codereview.chromium.org/474013004

git-svn-id: svn://svn.chromium.org/blink/trunk@183898 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These forward references are not needed anymore. After
this patch, Source/modules has no unneeded forward references
any more.

Review URL: https://codereview.chromium.org/651503002

git-svn-id: svn://svn.chromium.org/blink/trunk@183897 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Updated spec, IDL files, and all the *Credential variants.

BUG=400674

Review URL: https://codereview.chromium.org/661973002

git-svn-id: svn://svn.chromium.org/blink/trunk@183896 bbb929c8-8fbe-4397-9dbb-9b2b20218538