GitLab

Implment UnusedResourcesAreAvailable to send the unused resources back if there are
no pending ACKs.

Also handle the LoseAllResources from ResourceCollection to send back the resources.

R=danakj, sievers

Review URL: https://codereview.chromium.org/153683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248892 0039d316-1c4b-4281-b951-d872f2087c98

As a preparation to implement DispatchInstallEvent(), this implements
following two methods:
- SendMessage()
- SendMessageAndRegisterCallback()

Unlike my previous patches, this supports:
- Sending messages without explicitly starting the worker
- Sending multiple messages concurrently
- Receiving a response for each message

Now each message can be sent with a unique 'request_id', which can be
used to send back a response to a particular message.

BUG=313530
TEST=ServiceWorkerVersionTest.\*
R=alecflett@chromium.org

Review URL: https://codereview.chromium.org/139923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248889 0039d316-1c4b-4281-b951-d872f2087c98

Previously, files.app opens drive apps in the desktop of the running profile.
This CL adds lines to move the opened browser to the active desktop.

BUG=336093
TEST=manually

Review URL: https://codereview.chromium.org/153543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248888 0039d316-1c4b-4281-b951-d872f2087c98

Replaces obsolete methods of gfx::Font and gfx::FontList with new ones.

BUG=265485
TEST=Run ui_unittests.

Review URL: https://codereview.chromium.org/152733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248887 0039d316-1c4b-4281-b951-d872f2087c98

Because of a typo during refactoring, the url wasn't passed correctly. This patch fixes the typo.

TEST=Tested manually with an image on the downloads shelf.
BUG=340176

Review URL: https://codereview.chromium.org/145973017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248886 0039d316-1c4b-4281-b951-d872f2087c98

Password manager now ignores autocomplete='off' by default; user may specify a flag that says otherwise.

(Recommit after original commit reverted in https://codereview.chromium.org/130183003 due to unit test memory leak.)

BUG=177288

Review URL: https://codereview.chromium.org/146023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248885 0039d316-1c4b-4281-b951-d872f2087c98

Also use bold font for the stats table of the active ICE connection for highlight.


BUG=244648

Review URL: https://codereview.chromium.org/68103011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248882 0039d316-1c4b-4281-b951-d872f2087c98

```------------------------------
"Signin" is not a word.
"Sign into" doesn't make any more sense than "sign outof".

As a phrasal verb, it stands as a unit.
* "Bob signed in to Chromium to sync his settings."
* "Bob signed into Chromium, and it hurt. Next time he'll be more careful while
   signing and walking in the chemistry lab."
Don't hurt Bob.

As a phrasal noun, "sign-in" should be hyphenated.

Follow these simple[1] rules for correct usage:

* "signin" is not a word
* "sign in to", not "sign into" (you wouldn't "sign outof" Chrome)
* as a noun or noun adjunct, "sign-in", not "sign in":
    "Sign-in happens at the sign-in screen."
* as a participle + adverb:
  * "signed-in" before a noun: "who is the signed-in cat?"
  * "signed in" after a noun: "why is the cat signed in?"

Additionally, do not capitalize "in" or "out" in title case.
* "Sign in Again", not "Sign In Again"

[1] May not be simple.
```

------------------------------

Secondly, we should say "sign in" instead of "log in" in most places.

---------------------------------

Sources:
* go/uxwordlist
* https://net.educause.edu/elements/attachments/educause/pdf/ch07_tab01.pdf

I'd like to have kuscher check my work. Including aruslan and derat for sign-off
because the changes are somewhat extensive.

BUG=315617
NOPRESUBMIT=true
R=kuscher@chromium.org, bulach@chromium.org, derat@chromium.org

Review URL: https://codereview.chromium.org/145273019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=340426

Review URL: https://codereview.chromium.org/145973012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248880 0039d316-1c4b-4281-b951-d872f2087c98

This should make debugging webkit unit tests a bit easier.

R=jochen@chromium.org,japhet@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/139783014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248877 0039d316-1c4b-4281-b951-d872f2087c98

Create 2 benchmarks for ChromeOS devices, one playing only 4-content, the other playing all other test content.

BUG=339837

Review URL: https://codereview.chromium.org/134243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248876 0039d316-1c4b-4281-b951-d872f2087c98

when in icognito mode. 

This variable should always be initialized, not just in incognito mode.

BUG=339909

Review URL: https://codereview.chromium.org/148983006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248873 0039d316-1c4b-4281-b951-d872f2087c98

When Register fails with transient erro retry with exponential backoff.

BUG=335670

Review URL: https://codereview.chromium.org/144383008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248872 0039d316-1c4b-4281-b951-d872f2087c98

This is printed in every browser test, and just adds noise. Switch it
to LOG_IF so it's only printed when needed.

R=kinaba@chromium.org
BUG=339891

Review URL: https://codereview.chromium.org/149533005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248871 0039d316-1c4b-4281-b951-d872f2087c98

Allow windows developsers to run app_shell.

BUG=None
TEST=Build app_shell on windows with use_aura=1, it launches normally.

Review URL: https://codereview.chromium.org/136093011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248870 0039d316-1c4b-4281-b951-d872f2087c98

- Stop sending the worker script from the renderer.
- In this change we can remove the pending instances in WorkerServiceImpl.

This is step 4 of moving the worker script loading code from the renderer process to the worker process.
See: http://crbug.com/329786

BUG=329786

Review URL: https://codereview.chromium.org/133093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248869 0039d316-1c4b-4281-b951-d872f2087c98

Add support for distilling multiple pages, currently support is really
basic and just distills pages sequentially.
BUG=288015
TEST=included
NOTRY=true
R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/146843010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248867 0039d316-1c4b-4281-b951-d872f2087c98

BUG=340330

Review URL: https://codereview.chromium.org/147793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248866 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thestig
BUG=340563

Review URL: https://codereview.chromium.org/153553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248865 0039d316-1c4b-4281-b951-d872f2087c98

Previously, if the sync took a time, the message never disappeared.
This was caused by drop of the callback() invokation in AsyncUtil.Queue.
This CL fixes it.

BUG=340419
TEST=manually

Review URL: https://codereview.chromium.org/153663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248864 0039d316-1c4b-4281-b951-d872f2087c98

The extension uninstall dialog currently only accepts 128x128 or larger
icons. Bookmark apps may not have this icon size. Since the 48x48 icon is
shown in the launcher, bookmark apps should use that icon in the extension
uninstall dialog to prevent the case of having an icon in the launcher, but
not in the uninstall dialog.

BUG=318607

Review URL: https://codereview.chromium.org/153393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248863 0039d316-1c4b-4281-b951-d872f2087c98

Flake at http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%284%29/builds/24523/steps/memory%20test%3A%20unit/logs/stdio

[ RUN      ] WebRequestConditionAttributeTest.ResponseHeaders
[4593:4593:0203/083335:1568179503:ERROR:local_test_server_posix.cc(76)] poll() timed out; bytes_read=0
[4593:4593:0203/083335:1568183325:ERROR:local_test_server_posix.cc(159)] Could not read server_data_len
HTTP server started on 127.0.0.1:55369...
sending server_data: {"host": "127.0.0.1", "port": 55369} (36 bytes)
../../chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc:508: Failure
Value of: test_server.Start()
  Actual: false
  Expected: true
  [  FAILED  ] WebRequestConditionAttributeTest.ResponseHeaders (11177 ms)

BUG=

Review URL: https://codereview.chromium.org/137433010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248862 0039d316-1c4b-4281-b951-d872f2087c98

Currently, some code uses the type variable to check the type of
the given resource, while other code uses the shared_bitmap,
pixels or mailbox variable to check the same condition.

This CL makes all code use the type variable for this purpose.

In addition, this CL clarify texture_pool can be non-null only if
the type is Texture and the origin is Internal.

In addition, add several DCHECKs to increase readability.

BUG=337519

Review URL: https://codereview.chromium.org/135273008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=260347
TEST=Done manually.

Review URL: https://codereview.chromium.org/149153005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248860 0039d316-1c4b-4281-b951-d872f2087c98

Makes it easier to snap or dock windows near the edges when using touch. This is a followup on https://codereview.chromium.org/58973004/ to make the subsequent drags in the snapping sequence use the same touch fuzzing as the initial drag.

BUG=316645
TEST=ash_unittests --gtest_filter=*SystemGestureEventFilterTest.Drag*NearEdgeSnaps*
TEST=Manual:
     1. Snap a 500px wide browser window using touch screen.
     2. Continue drag to dock a window.

Review URL: https://codereview.chromium.org/153893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248857 0039d316-1c4b-4281-b951-d872f2087c98

Creates a base class shared by zero_suggest_provider and search_provider
which will contain common implementation pieces for both classes.

Moves Result, NavigationsResults, SuggestResult, Results objects into
the base class without any changes to the implementation. These objects
are used by both classes.

Moves common typedefs up: MatchKey, MatchMap, NavigationResults,
SuggestResults.

BUG=338955
TBR=mpearson@chromium.org

Review URL: https://codereview.chromium.org/131003011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248856 0039d316-1c4b-4281-b951-d872f2087c98

A part of code of FileOperationManager aims to recursive operations in order to
obtain the detailed progress. But the recursive operations is not implemented
now.

The code caused bugs of wrong progress bytes and remaining file count.
This CL fixes the bug.

BUG=340180
TEST=manually

Review URL: https://codereview.chromium.org/152513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248855 0039d316-1c4b-4281-b951-d872f2087c98

readlink is in gnu coreutils, which should be more widely available. On my
machine, the gnu version is prefixed with 'g', while 'readlink' is a crippled
Mac version without the -e option.

Review URL: https://codereview.chromium.org/144243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248853 0039d316-1c4b-4281-b951-d872f2087c98

This is being done so that content::BrowserThread can be used in
PowerDataCollector, which is required for future changes.

BUG=312956,335816
TBR=arv

Review URL: https://codereview.chromium.org/153153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248852 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/146693018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248849 0039d316-1c4b-4281-b951-d872f2087c98

This is for fully supporting multi-profile in Files.app.
Drive folder from different profiles need to have different paths.

The change includes:
- Change mount path from /special/drive to /special/drive-<user-id-hash>.
 Stored settings (like Download path) are migrated by MigratePathFromOldFormat.

- Profile extraction function from the above path format that
 will be used in next patch. (I included the function in the current
 patch to emphasize that the new path format is intended for
 this type of use.)

- Change mount point name from drive to drive-<user-id-hash>

- Mount point is added to the system global instance, not
the per-profile ones (otherwise cross-profile copy is impossible.)

BUG=336123
R=hashimoto@chromium.org, hirono@chromium.org

Review URL: https://codereview.chromium.org/150163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248848 0039d316-1c4b-4281-b951-d872f2087c98

TemplateDataSource so that the nacl docs and partial templates are correctly
pulled in by the cronjob. Make the integration tests actually test nacl docs.

BUG=339936
R=yoz@chromium.org

Review URL: https://codereview.chromium.org/151773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248847 0039d316-1c4b-4281-b951-d872f2087c98

This reappeared in
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%281%29/builds/25830,
but none of the CLs in that blamelist look likely.  It's probably a change in
test randomization and/or bot configuration.

BUG=105525,257276,340847
NOTRY=true

Review URL: https://codereview.chromium.org/155333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248846 0039d316-1c4b-4281-b951-d872f2087c98

I don't see anything suspicious in this code...

BUG=340909
TBR=abarth@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/154933005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248844 0039d316-1c4b-4281-b951-d872f2087c98

These asserts may cause telemetry to silently exit - we'd prefer a stack trace.

BUG=338622
TEST=None
NOTRY=True

Review URL: https://codereview.chromium.org/154933004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248843 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317027
NOTRY=true

Review URL: https://codereview.chromium.org/153373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248842 0039d316-1c4b-4281-b951-d872f2087c98

This is the first step to using OffsetByteQueue in the Mpeg2 TS stream parser.

BUG=340426

Review URL: https://codereview.chromium.org/153103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248841 0039d316-1c4b-4281-b951-d872f2087c98

This adds support for more XCODE flags to GN's GYP generator which XCode needs to be happy. With this patch, XCode can actually compile targets now and seems to do basically the right things (to the limited extent of my understanding).

TBR=thakis

Review URL: https://codereview.chromium.org/132803008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248840 0039d316-1c4b-4281-b951-d872f2087c98

of its operation. It was basically working around a TestFileSystem bug, so fix
that too. This will make running tests much faster, particularly now that the
entire of the src/ directory is considered part of the docset.

BUG=None
R=yoz@chromium.org

Review URL: https://codereview.chromium.org/151883009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248838 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248837 0039d316-1c4b-4281-b951-d872f2087c98