- 21 Aug, 2010 25 commits
-
-
tfarina@chromium.org authored
- Remove this obscure function since it was called only once. - Use Environment::GetVar instead. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3135036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56978 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/3115011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56977 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3133032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56973 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
A new field to describe the sources of history urls(visits) is added. This field is recorded in visit_database. So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries. In the future, history extension API may allow queries to combinate with this criterion. BUG=none TEST=Unit tests are already included. Please test the web browser with history from previous versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the sources added to the visit_source table in hitory database are correct. Original review: http://codereview.chromium.org/2906004/show Patch by weili@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56971 0039d316-1c4b-4281-b951-d872f2087c98
-
mbelshe@chromium.org authored
for a specific port. This allows me to alter resolutions for certain ports like send :80 lookups to one location and :443 lookups to a different location. This enables me to mock out support for AlternateProtocol. BUG=none TEST=HostMappingRulesTest.PortSpecificMatching Review URL: http://codereview.chromium.org/3177026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56970 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
to see if that makes mac release happy. BUG=none TEST=none TBR=eroman Review URL: http://codereview.chromium.org/3167032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56969 0039d316-1c4b-4281-b951-d872f2087c98
-
mrossetti@chromium.org authored
Revert 56962 - Next step integrating the HistoryQuickProvider: Implement index initialization and population and provide unit test with test data. BUG=None TEST=None Review URL: http://codereview.chromium.org/3138006 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/3197008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56968 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=None TEST=out/Debug/base_unittests --gtest_filter=RegistryTest.* Review URL: http://codereview.chromium.org/3190010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56965 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
may be called from within one of the notifications of "backend construction done". This CL makes sure that this scenario is handled properly by invoking the callbacks one at a time, posting a task before moving on to the next one. BUG=52090 TEST=netunittests Review URL: http://codereview.chromium.org/3173030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56964 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
the test shows up as succeeded even though it is failing. The test fails when the automation client instance is reused, i.e the new page loads in the same tab. We need to set the ready state of the active document instance to ready when we reuse the automation client instance. TBR=amit Review URL: http://codereview.chromium.org/3117032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56963 0039d316-1c4b-4281-b951-d872f2087c98
-
mrossetti@chromium.org authored
Next step integrating the HistoryQuickProvider: Implement index initialization and population and provide unit test with test data. BUG=None TEST=None Review URL: http://codereview.chromium.org/3138006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56962 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=52826 TEST=Valgrind goes green. TBR=ukai Review URL: http://codereview.chromium.org/3112026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56961 0039d316-1c4b-4281-b951-d872f2087c98
-
pmehta@chromium.org authored
Review URL: http://codereview.chromium.org/3146031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56960 0039d316-1c4b-4281-b951-d872f2087c98
-
maf@google.com authored
Add separate GL version field. Review URL: http://codereview.chromium.org/3104011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56957 0039d316-1c4b-4281-b951-d872f2087c98
-
alyssad@google.com authored
Review URL: http://codereview.chromium.org/3135039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56955 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
BUG=none TEST=builds Review URL: http://codereview.chromium.org/3134022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56954 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
Set state of a new audio stream to Paused until it start to play. Also added media layout tests in ui tests. BUG=39825 TEST=sound is still playing (with and without autoplay). Review URL: http://codereview.chromium.org/3160027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56953 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
Marked OmniboxApiTest.Basic and AutocompleteBrowserTest.Autocomplete flaky on ChromeOS. Both test fail consistently in autotest runs while manual run with --gfilter_test seems to be OK. BUG=52928,52929 TEST=make sure these two test don't cause autotest to fail anymore Review URL: http://codereview.chromium.org/3150027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56952 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
This makes it easy to digest pass/fail status for individual tests ("OK" is more discoverable than '.' in the output log). And makes it easier to associate LOG messages from chrome with the individual tests triggering them. BUG=42148 Review URL: http://codereview.chromium.org/3191014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56951 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
This test basically test another behavior of the GetVar function. It tries to get a variable by looking for its reverse form. BUG=None TEST=out/Debug/base_unittests --gtest_filter=EnvironmentTest.GetVarReverse. Review URL: http://codereview.chromium.org/3162025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56950 0039d316-1c4b-4281-b951-d872f2087c98
-
jcivelli@chromium.org authored
WebKit unit-tests using webkit_support fail with these initializations as the test executable doesn't have any packages. BUG=None TEST=None Review URL: http://codereview.chromium.org/3148024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56949 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
BUG=38475 TEST=This is the test. Review URL: http://codereview.chromium.org/3159030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56948 0039d316-1c4b-4281-b951-d872f2087c98
-
kurrik@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/3175031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56947 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
Sort the methods in template_url_model.cc to match the ordering in template_url_model.h (Only moving things around. No other changes.) BUG=None TEST=unit_tests --gtest_filer=TemplateURL*.* Review URL: http://codereview.chromium.org/3171025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56946 0039d316-1c4b-4281-b951-d872f2087c98
-
atwilson@chromium.org authored
Fix to change the sense (and name) of kRestoreBackgroundContents to be kDisableRestoreBackgroundContents BUG=52793 TEST=none Review URL: http://codereview.chromium.org/3202004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56945 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Aug, 2010 15 commits
-
-
thestig@chromium.org authored
BUG=none TEST=it compiles Review URL: http://codereview.chromium.org/3177020 TBR=isherman@chromium.org Review URL: http://codereview.chromium.org/3192006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56943 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56942 0039d316-1c4b-4281-b951-d872f2087c98
-
garykac@chromium.org authored
BUG=none TEST=remoting unittests Review URL: http://codereview.chromium.org/3176023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56941 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
BUG=51376 TEST=Verify proxy settings UI matches proposal when proxy settings are managed by an extension. Review URL: http://codereview.chromium.org/3132030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56940 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=none TEST=it compiles Review URL: http://codereview.chromium.org/3177020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56939 0039d316-1c4b-4281-b951-d872f2087c98
-
cpu@chromium.org authored
Second take, I had off-by-one bad check in line 164 for more info see review 3142022 BUG=52682 TEST=included Review URL: http://codereview.chromium.org/3130037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56938 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
BUG=none TEST=Verify 'Show Gears Settings' button works properly in ChromeWin via --enable-tabbed-options. Review URL: http://codereview.chromium.org/3187010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56937 0039d316-1c4b-4281-b951-d872f2087c98
-
kurrik@chromium.org authored
Review URL: http://codereview.chromium.org/3122030 Patch from Eric Bidelman <ericbidelman@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56936 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
BUG=none TEST=Verify that the 'Show Passwords' button displays the passwords panel in dom-ui. Review URL: http://codereview.chromium.org/3149025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56935 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
BUG=49241 Review URL: http://codereview.chromium.org/3125031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56934 0039d316-1c4b-4281-b951-d872f2087c98
-
sargrass@google.com authored
Fix the problem when force closing the tab while importing. BUG=49095 TEST=None Review URL: http://codereview.chromium.org/3167028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56933 0039d316-1c4b-4281-b951-d872f2087c98
-
chase@chromium.org authored
Review URL: http://codereview.chromium.org/3145006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56932 0039d316-1c4b-4281-b951-d872f2087c98
-
sargrass@google.com authored
Separate the password exceptions list. BUG=49093 TEST=None Review URL: http://codereview.chromium.org/3177023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56931 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=52900 TEST=none Review URL: http://codereview.chromium.org/3164031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56930 0039d316-1c4b-4281-b951-d872f2087c98
-
tim@chromium.org authored
BUG=52703 TEST=Start chrome, set up sync, dont crash. ProfileSyncFactoryImplTest. Review URL: http://codereview.chromium.org/3165046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56928 0039d316-1c4b-4281-b951-d872f2087c98
-