- 16 Nov, 2020 38 commits
-
-
Lei Shi authored
Add two properties for automation node, sentenceStarts and sentenceEnds, to calculate sentence boundary in a node's name. These two functions rely on i18n::BreakIterator, which is surfaced from ax_text_utils. AX-Relnotes: N/A Bug: 1143823 Change-Id: Ie05628e310f1850562069f83f7095e7d34277eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525604Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Lei Shi <leileilei@google.com> Cr-Commit-Position: refs/heads/master@{#827690}
-
Maggie Cai authored
This CL adds a check to avoid potential crash in FiltersHaveOverlap. The possible reason for this crash is that in M88, we briefly turned on the kIntentHandlingSharing flag, which result in a upgrade in the PreferredApp file format. After turning off the flag, the PreferredApp file is still upgrated, which result in comparing two intent filters with different number of conditions (one with action, the other without), which causes crash in the for loop. However this fix is actually not the best fix, because after turning on the flag again, there will be residual preferred app entries that will not be clean up in users PreferredApps file. The best fix is to downgrade the preferred app list when we found out the file version and the flag status does not match. BUG=1148617 Change-Id: I9d96691d663aa7603c8f37e6d1820b08aa9ef7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536666 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#827689}
-
Tomasz Tylenda authored
BUG=1142502 TEST=none Change-Id: I4c668310ffc1903eab90a9e2152bf78bf621032e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536656Reviewed-by:
Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/master@{#827688}
-
Noel Gordon authored
The example mojo code is being moved the SWA sample app. Remove it from SWA files app, leaving an empty shell that will be filled-in later. Bug: 1113981 Change-Id: If329ce6ba9df1bc08394892d67d6023f91cbeb21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536581Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#827687}
-
Leo Zhang authored
The flag has been set enabled by default on M87. It's time to clean it up now. BUG=b:171846787 Change-Id: I3e32ee6de00e2df7bd315b1d06243980bc8f202e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538860Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
Due to a HTML specification change, the default UA stylesheet for modal dialog elements has changed: https://github.com/whatwg/html/pull/5936/files https://chromium.googlesource.com/chromium/src/+/be7281e188f22856bf9084d9f5c74a0f48eee1da Specifically for this bug max-width/max-height were set. This change explicitly resets the style for max-width/max-height to their initial values. Bug: 1148225 Change-Id: Ibf62fea46fc78206df4da240b1fb44f923b07415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538332Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#827685}
-
Hsin-Yu Chao authored
In commit 0bcb2086 we settled the Bluetooth mic node's priority to the same as headphones when it's in wideband speech mode. Now that Bluetooth WBS feature is ready on more platforms/models we need a switch to separate normal users and those who opt-in to try out the new feature during the feature stabilizing period. The switch mechanism is achieved by two things: (1) CrasAudioHandler queries the 'DeprioritizeBtWbsMic' value from CRAS and override BT mic to the lowest node priority if it's true. (2) The newly added bluetooth-wbs-dogfood feature flag will be used to stop (1) if it's set to enabled. The CRAS side change at http://crrev/c/2526821 R=enshuo, jennyz Bug: b/171763363 Change-Id: Ibace71c195434ca1ad935622cf29a4b68264315a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526861 Commit-Queue: Hsinyu Chao <hychao@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#827684}
-
Wenbin Zhang authored
Sharding after algorithm update and some days after mac arm in use. Bug: chromium:1130157 Change-Id: I29ab5b4cf3e1cae39ba595e7374d4b5ff5d2d8d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536800Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#827683}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605473970-858e020e397b6c69b02a6b98027a57d7f071f21b.profdata to chrome-win64-master-1605484714-e7960c8b645b53c1b4adeb64d7f205eadd5164b6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If9bcbe986f97f1de1d388ac362dbf0f29132c380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539438Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827682}
-
Darren Shen authored
Bug: 1148157 Change-Id: I96548155baa4226d32c2ab752cefd0326665d8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537818Reviewed-by:
Jing Wang <jiwan@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#827681}
-
Ricky Liang authored
In the GPU process, GpuMemoryBuffer is stored and referenced using (buffer_id, client_id), where client_id is essentially the process that allocates (and usually owns) the GpuMemoryBuffer. When passing a GpuMemoryBuffer handle allocated by the Chrome OS video capture device, we need to invalidate the GpuMemoryBuffer id of the cloned handle before passing to the remote process to make sure we don't collide with another GpuMemoryBuffer allocated by the remote process that happens to have the same buffer_id. This CL invalidates the GpuMemoryBufferId before passing a GMB buffer from the browser to the renderer process. When the renderer process creates a SharedImage from the received GMB buffer, the GPU process will look up the real native pixmap handle through the DMA-buf fds in [1] because of the invalid GpuMemoryBufferId, instead of re-using a wrong pixmap handle in the cache. [1]: https://tinyurl.com/yymtv22y Bug: 993265 Change-Id: I58047207c53fa9dccb5b6c06166464b600aefbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368641 Commit-Queue: Ricky Liang <jcliang@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#827680}
-
Darren Shen authored
Impl & Test usually use the same namespace. NativeInputMethodEngine uses the chromeos namespace, so use the same namespace for the test file. Bug: 1148157 Change-Id: Idde400dcb320c8da1dc89335db8e734f4ec695b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532485Reviewed-by:
-
Chih-Yu Huang authored
Originally, V4L2StatefulVDBackend skipped flush when the V4L2 output queue is not streaming. However, it doesn't mean there is no pending requests needed to be flushed. This CL fixes this issue by introduing a new flag to track if there is any pending request. BUG=b:170728773 TEST=android.media.cts.AdaptivePlaybackTest#testH264_adaptiveReconfigDrc TEST=tast.video.DecodeAccel.{h264,vp8,vp9} Change-Id: I45d2b6072e47f23a3a61ccb622bef206ad1bb6e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532027 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#827678}
-
Darren Shen authored
Remove unused default constructor and remove redundant comments that are better explained by the types themselves. Change-Id: Ia80404906241e592c4df33f4a97d26245a24440a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533063 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#827677}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I2d26ffbaee504748d97f2383a0c4cee6e0e7bace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538722Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827676}
-
Matthew Denton authored
At least in Clang, this flag does more than just preventing null pointer checks from being removed, it actually make dereferencing null into defined behavior. This means code dereferencing null won't be automatically removed in Clang, which is good if some piece of code relies on the null pointer dereference to prevent a security bug, which may be more widespread than we expected. For example: https://crbug.com/1133635 added code is necessary to prevent security bugs. Binary-Size: Binary size increase is unavoidable because some of the Bug: 1139129 Change-Id: Id8edf94f950a23780ab75286d5cfe9981040b939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481465 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#827675}
-
Hiroki Nakagawa authored
Calling blink::mojom::PrerenderProcessorImpl::Start() twice is disallowed. The test makes sure that it results in mojo bad message error. Bug: n/a Change-Id: Icb99b085d8f314f2e6a321164e219ef900393970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538854Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#827674}
-
Erik Jensen authored
https://crrev.com/c/2410841 updated x_server_clipboard.cc to use Xproto, but introduced two errors that broke reading the clipboard in UTF-8 format. The first error has to do with how 32-bit properties are returned. With Xlib, such properties are returned as longs regardless of the platform, meaning they are actually returned as 64-bit values on 64-bit architectures. Xproto, however, always returns them as 32-bit values. The clipboard code, however, was still expecting longs. This change updates the clipboard code to expect 32-bit values as returned by Xproto. The second error was a mistranscription when converting RequestSelectionTargets from XConvertSelection to the equivalent Xproto call. Bug: 1149033 Change-Id: Ib3fe97fcbd0b0579a578858796e084901dd8a360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537977Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#827673}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/aabde6c88f91..575729e8dd25 2020-11-16 hao.x.li@intel.com Add query availability tracking in render pass encoder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I78bf98e6deaced304284e46e62a0417176bd7395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539440Reviewed-by:
-
Noel Gordon authored
The chrome.mediaGalleries was removed from files app crbug.com/1114622 and a new file manager private API FMP.getContentMetadata was added to replace it. Add it to the UITest system test FMP impl. Test: browser_tests --gtest_filter="FileManagerUITest*" Bug: 1113981 Change-Id: I03f26913f7f0f96f85c74053e458a42bf314e9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537453Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#827671}
-
Joel Hockey authored
We now only remove the spinner from crostini apps after the window is showing, and we ensure that the icon stays in the same position the whole time. In crrev.com/c/2294742, I changed to always call CloseSpinner when a crostini app is launched. The result of this is that we were removing the spinner and icon from the shelf, and then the icon was being added back later (usually a few seconds) when the window appears. Note that it was possible that the shelf position could change if other apps were opened while the spinner was showing. Bug: 1132089 Change-Id: I1b03c0df5f88ffa892d352b0fdfc36f93daa0a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532341 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#827670}
-
Joel Hockey authored
Some web apps such as the crostini terminal may have a spinner before the app is launched. This closes any such spinner and removes the icon prior to recreating the app icon without a spinner. Bug: 1132089 Change-Id: Ie60c50c6b5c6928db82e43a6682c55fea897efc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538861 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#827669}
-
Zhaoliang Ma authored
In webcodecs, VideoEncodeAcceleratorAdapter needs to call Flush method, since the mojoVEA doesn't support IsFlushSupported, so the VideoEncodeAcceleratorAdapter cannot really call the backendVEA Flush even the backendVEA support Flush. This CL fix this issue. Bug: 1128768, 1110279 Change-Id: I4853c2bd0e494cafdd806d183ab3d659ca542d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389840Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Zhaoliang Ma <zhaoliang.ma@intel.com> Cr-Commit-Position: refs/heads/master@{#827668}
-
Darren Shen authored
Mostly adds = default and changes typedef to using. Change-Id: Ic9d8ab0caf10acf8b86e97a02d5dcd15764d3148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532023Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#827667}
-
tby authored
Events are currently stored in this format: {"events":[{event1}, {event2}, {event3}], "keys":{...}} But we are about to create new categories of event, related to whether they are associated with the UMA client ID or not. This requires we store two separate event lists on-disk. This will look like: {"events":{ "independent":[{event1}, {event2}, {event3}], "associated":[....]}, "keys":{...}} This CL: - refactors the logic for getting the events list, creating GetEventsList. - adds logic to migrate from the old storage format to the new. Bug: 1148168 Change-Id: I1d828a4e44b2e483b908a53d5d47c241f3603b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532164 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#827666}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605458715-f00155bc52e72dc18d30745134240890a44f1534.profdata to chrome-linux-master-1605484714-0506bb900efd9e0694325713b333ba7d388746e8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I41e24b5065afab4bddf3b5b108dfb36d4d1e44e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539439Reviewed-by:
-
Minoru Chikamune authored
IntegrationTest.COMRegistration is failing on Win7 like below. https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/86558 IntegrationTest.COMRegistration was added on the CL below. https://chromium-review.googlesource.com/c/chromium/src/+/2538267 TBR: ganesh@chromium.org, sorin@chromium.org Bug: 1149213, 1140562 Change-Id: Ibe95b8a2a5955adefdf1691e1cf68a350d656ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537821 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#827664}
-
Shengsong Tan authored
This change add a new event for desktop window focus state change. With this change, ARC can have different behavior when Chrome window or ChromeOS desktop get activated. Fix the reverted change https://crrev.com/c/2519686 BUG=b:171450038 TEST=Active different window between Chrome/ARC and logcat events Change-Id: Ied6245028578b89abb1ae376b7b49919c5cebee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536578 Commit-Queue: Shengsong Tan <sstan@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#827663}
-
Fergus Dall authored
Currently we have: - IsAllowed which checks enterprise policy and nothing else - IsUIAllowed(_, false) which checks other aspects of eligibility - IsUIAllowed(_, true) which checks both These methods are confusingly named and IsUIAllowed is really doing two separate things. This has lead to the crash in the associated bug, when a query that was subject to change was used as if it were persistent. Change this interface to the following two methods: - CouldBeAllowed which checks persistent (within the lifetime of the process) aspects of eligibility - IsAllowedNow which determines if we are allowed to run crostini right now, with the understanding that this answer may change at any time. Bug: 1015345 Change-Id: Iab4263c2fcae57bd4ed6bcf6956fd6e7c1e016e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537450Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605451535-a6af4ac0273470e6b457bdea723c0bedf776d930.profdata to chrome-win32-master-1605473970-18d5ebf07ab680b4396ec4f82e9b49e24c2d43e9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I02669881506ed317dd1cf15dc026a569fc08d55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539436Reviewed-by:
-
Thanh Nguyen authored
This CL implements InvertedIndexSearch functions that are inherited from new Index interface. Design doc: go/lss-sandboxing Implementation plan: go/lss-sandboxing-impl Bug: 1137560 Change-Id: I3a1439f9b43d9d52bbb6819308535aa28ef7fe3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531078Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#827660}
-
Minoru Chikamune authored
This reverts commit c0d403ae. Reason for revert: May be causing chromeos errors. Speculatively reverting based on error log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863577786188639024/+/steps/isolate_tests/0/stdout?format=raw > 0cf1ad3e42632633d1110de0b0a6e30ef2599740 boringssl_ssl_tests isolate: isolate /b/s/w/ir/cache/builder/src/out/Release/browser_tests.isolate: failed to process: stat /b/s/w/ir/cache/builder/src/out/Release/gen/chrome/test/data/webui/cr_components/chromeos/cellular_setup/sim_detect_page_test.m.js: no such file or directory So this error is caused by sim_detect_page_test.m.js. Original change's description: > [CrOS Settings] Update sim-detect-page to be more generic > > Rename sim-detect-page to setup-loading-page and update UI to be used > for both psim and esim flows. > > Bug: 1093185 > Change-Id: Iaf8934a3423c1ce21d6115bc9ea28c9d972738b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535231 > Commit-Queue: Gordon Seto <gordonseto@google.com> > Reviewed-by: Azeem Arshad <azeemarshad@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827473} TBR=khorimoto@chromium.org,azeemarshad@chromium.org,gordonseto@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1093185 Change-Id: I48421a06df20aadd0913c1ee9bc3dc313f31097d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538858Reviewed-by:
-
John Palmer authored
Increasing delay also helps by making sure things aren't interrupted. FIXES: 1148100 Change-Id: Ie6e4f696a23ca00b67d88be28d9a5b91ffef3282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530955Reviewed-by:
-
Noel Gordon authored
Add launcher.launchFileManager() - move this part out of file_manager.js changes in CL:2500642 Add ready() handler to read load time data - move this part out of file_manager.js changes in CL:2500642 Add getVolumeManager() helper - to match this new helper, which was added in CL:2534551 for moving VolumeManager into JS modules Re-position the various background fake classes - move them so they are adjacent in the code Tbr: alex Bug: 1113981 Change-Id: Ia301098b5e0a357d69b7ee5e89560f7cc6b8210f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539255Reviewed-by: -
Chromium WPT Sync authored
Using wpt-import in Chromium d3c10ef3. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I712ac2e9129b51be4dac8aeb36d4a8d1a7409115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539456Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827656}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605451535-67d2a4e0717e49940da54310411b235218dd38d3.profdata to chrome-win64-master-1605473970-858e020e397b6c69b02a6b98027a57d7f071f21b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3470cb66e313f4ba8a5eadb8d3e97a5159c76886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539435Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ib9edd5ea68d49c368156a32387228f6bb8288edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539414Reviewed-by:
-
Johann Koenig authored
This reverts commit c7a07b61. Reason for revert: May be causing Win7 errors. Speculatively reverting based on change log: https://chromium.googlesource.com/chromium/src/+log/88b177aef..742f164dd0 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/110238 content_browsertests failed because of: All/DumpAccessibilityEventsTest.AccessibilityEventsAriaComboBoxFocus/uia All/DumpAccessibilityTreeTest.AccessibilityAriaTreeDiscontinuous/uia Original change's description: > Invalidate SelectionShouldFollowFocus elements during container focus > > Items in single selection containers that have accessibility focus > should get the selected state. Code to mirror focus to selection > exists, but the selected state must be refreshed. > > Replacing AXLayoutObject::SelectionShouldFollowFocus with a helper > method in ax_role_properties, ui::IsSelectRequiredOrImplicit and > including Role::kTreeItem [1] since the ARIA spec lists aria-selected > as a required state. > > Adding AXObject::IsSelectedFromFocusSupported (see AXLayoutObject impl) > which provides a mostly conclusive answer for whether an element can > support this behavior. > > During this investigation, I found there was a portion of the spec that > was not implemented, so I created a crbug [2] for that. "If any DOM > element in the widget is explicitly marked as selected, the user > agent MUST NOT convey implicit selection for the widget." > > Also created a crbug [3] for followup to consider including more > selectable roles for this behavior. Currently only roles that require > or have an implicit value for aria-selected allow this behavior. > It may be desirable to include roles columnheader, rowheader, gridcell > and row, but felt that would be out of scope for this CL. > > [1]: https://www.w3.org/TR/wai-aria-1.1/#treeitem > [2]: https://crbug.com/1143451 (Not allowed with explicit selection) > [3]: https://crbug.com/1143483 (Consider allowing more roles) > > AX-Relnotes:Notify the aria-selected state changed for items that > have their selected state follow focus, and enable this behavior for > role=treeitem elements inside single-selection containers. > > Bug: 1141579 > Change-Id: Idce80a91f41df859775eed59a922ac7c923d9f4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493000 > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827487} TBR=dmazzoni@chromium.org,haraken@chromium.org,aleventhal@chromium.org,kschmi@microsoft.com,Adam.Ettenberger@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1141579 Change-Id: Ibd959d5d6066bbe93aea4dffa3d4bc7cc6b35dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537820Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#827653}
-
- 15 Nov, 2020 2 commits
-
-
Darren Shen authored
Planning to do a lot of refactoring in this directory, so adding myself as OWNER to reduce review load. Change-Id: I27decd0dcdb1e59f76bacaa4949d88031e661062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536510Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b3f1d1491a00..bf281d84688d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I841ccbea5d9c6c1d5c17648cf1dcb9ad0d48d24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539434Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827651}
-
