GitLab

Revert of Convert the re2 GYP targets to be generated by GN. (https://codereview.chromium.org/68853015/)

Reason for revert:
Broke Blink compile

Original issue's description:
> Convert the re2 GYP targets to be generated by GN.
> 
> BUG=288991
> R=bradnelson@google.com
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245254

TBR=bradnelson@chromium.org,bradnelson@google.com
NOTREECHECKS=true
NOTRY=true
BUG=288991

Review URL: https://codereview.chromium.org/141063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245271 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
The indexeddb_perf tests on all Windows testers regressed in performance significantly. Don't yet know the exact cause, but because the performance drop is significant will revert this change first, and then proceed with the investigation.

Original issue's description:
> Created new Win32 LevelDB environment.
>     
> This change splits ChromiumEnv into two classes: ChromiumEnv/ChromiumEnvPosix.
> ChromiumEnvWin32 was also added which uses the Win32 API - except for logging.
> 
> The default is to create POSIX environments for all platforms for non-IDB
> LevelDB users. For IDB we create a Windows environment on Windows, else a
> POSIX environment like before.
> 
> BUG=222623
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245135

TBR=dgrogan@chromium.org,alecflett@chromium.org,jsbell@chromium.org,iannucci@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=222623

Review URL: https://codereview.chromium.org/140923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245270 0039d316-1c4b-4281-b951-d872f2087c98

Under non-impl-side painting, the thread proxy ends up releasing the
main thread then setting commit_waits_for_activation_ to false, which
is the wrong way around. This puts the order right.

R=enne
BUG=334611

Review URL: https://codereview.chromium.org/139553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245269 0039d316-1c4b-4281-b951-d872f2087c98

TBR=szym@chromium.org
BUG=334837

Review URL: https://codereview.chromium.org/139543006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245268 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/139923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245267 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/139903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245266 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/139883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245265 0039d316-1c4b-4281-b951-d872f2087c98

Simplify the code by using DOM Promises.

BUG=282464
TEST=browser_tests

Review URL: https://codereview.chromium.org/132013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245264 0039d316-1c4b-4281-b951-d872f2087c98

This CL updates the inbox_app in the Silk benchmark to use the newest
dynamics.js. The main difference is that we now do more work inside
requestAnimationFrame.

TBR=nduca

Review URL: https://codereview.chromium.org/140173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245263 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316496,317432
R=wtc@chromium.org
CC=tzik@chromium.org

Review URL: https://codereview.chromium.org/138263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245262 0039d316-1c4b-4281-b951-d872f2087c98

Introduce content::TestLauncherDelegate.AdjustDefaultParallelJobs() to allow us to auto-disable parallelization for Ash browsertests.

BUG=286205

Review URL: https://codereview.chromium.org/132313006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245261 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes the LatecyInfo merging from the following path:

Compsitor to GPU:
CommandBufferProxyImpl::SetLatencyInfo()
-> (GpuCommandBufferMsg_SetLatencyInfo)
-> GpuCommandBufferStub::OnSetLatencyInfo()
-> ImageTransportHelper::SetLatencyInfo()
-> XXXImageTransportSurface:SetLatencyInfo()

After swap buffers:
XXXImageTransportSurface::SwapBuffers()
-> (GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params/
    GpuHostMsg_AcceleratedSurfacePostSubBuffer_Params/
    GpuHostMsg_FrameDrawn)
-> RenderWidgetHostView

BUG=246034
TEST=unittests pass.
     Tested on Pixel. chrome://tracing shows correct InputLatency tracking for
     various inputs.

Review URL: https://codereview.chromium.org/123563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245260 0039d316-1c4b-4281-b951-d872f2087c98

On Linux, we need to show a dialog to get permission to collect UMA data
and to change the default browser.

BUG=234637
R=msw@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/137393008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245259 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334679
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/139413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245258 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334253
R=ksakamoto@chromium.org

Review URL: https://codereview.chromium.org/139343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245257 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322820
TEST=manual tests on Daisy

Review URL: https://codereview.chromium.org/139323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245256 0039d316-1c4b-4281-b951-d872f2087c98

The real Drive server returns NOT_FOUND for deleted entries.

BUG=None
TEST=unit_tests

Review URL: https://codereview.chromium.org/139153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245255 0039d316-1c4b-4281-b951-d872f2087c98

BUG=288991
R=bradnelson@google.com

Review URL: https://codereview.chromium.org/68853015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245254 0039d316-1c4b-4281-b951-d872f2087c98

Someday we will rip out support for SYN_STREAM altogether,
but that will likely wait until we rip out SPDY <4.

This lands server change 56555536 by hkhalil.

Also updated SpdySession to work around removal of SYN_STREAM/SYN_REPLY:
 * OnSynReply() won't be called in SPDY4 contexts. OnHeaders() must
    handle initial response headers.
 * As OnPushPromise() isn't handled, associated stream checks aren't
   possible in SPDY4. Disable checks & related unit-tests.

Also updated compression test fixtures.

Review URL: https://codereview.chromium.org/138803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245253 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/138443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245252 0039d316-1c4b-4281-b951-d872f2087c98

That is, starting with an OS "channel" (e.g., socket), you can tell the
system to set up to send messages over it. It'll provide an initial
"bootstrap" message pipe, from which you'll eventually be able to bring
up more message pipes multiplexed on that channel (once you can pass
handles in messages over the channel).

Also:
- Make a base class for tests that need an IO thread.
- Add a way for test embedders to shut down the global instance.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/140403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245251 0039d316-1c4b-4281-b951-d872f2087c98

There is no need to derive(create) a new font list in views::Tab.  Uses BaseFont and BoldFont.

TEST=none

Review URL: https://codereview.chromium.org/137533011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245250 0039d316-1c4b-4281-b951-d872f2087c98

Temporarily move AshKeyboardControllerProxyTest from unit test to browser test.
There is a problem with calling ui::SetUpInputMethodFactoryForTesting() in unit
test right now. See comments in codereview.chromium.org/136033005 for detail.

BUG=NONE
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/139293009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245249 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements nacl_irt_futex for non-sfi mode.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Tried to call a newly added function from plugin via AT_SYSINFO.

Review URL: https://codereview.chromium.org/139453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245248 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245247 0039d316-1c4b-4281-b951-d872f2087c98

Chromium base revision: 244998 / a10bed42
Old Skia revision: 13077
New Skia revision: 13107
Control CL: https://codereview.chromium.org/140193002

This CL was created by Skia's roll_deps.py script.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/131123006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245246 0039d316-1c4b-4281-b951-d872f2087c98

Using STYLE_OBSCURED in the ctor broke with r244436.
Remove 'styles', that ctor, and IsObscured/SetObscured.
Use TextInputType for password textfield configuration.
(rename textfield 'obscured' identifiers to 'password')

Inline STYLE_LOWERCASE to the EditSearchEngineDialog.
Remove GetTextForDisplay and its related handling.

Inline set_controller; remove GetController.
Cleanup users and unit tests.

BUG=131660,334252
TEST=Password textfields work (show '*'s, reveal last typed char, toggle in wifi/wimax dialogs, etc.) as expected. The EditSearchEngineDialog's keyword textfield holds lowercase text as expected.
R=sky@chromium.org
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/138363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245243 0039d316-1c4b-4281-b951-d872f2087c98

This is not something that would happen under normal circumstances, but it may happen if the preferences become corrupted or are modified.

BUG=321370

Review URL: https://codereview.chromium.org/138243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245242 0039d316-1c4b-4281-b951-d872f2087c98

Use the --objdump argument to point perf to the correct ARM objdump
binary so that it can properly annotate source code. Since this requires
a fairly new version of perf (3.10), don't add the argument to the
default set of perf options but rather just print a hint.

See http://www.chromium.org/developers/telemetry/profiling for
instructions on how to get a newer version of perf.

NOTRY=true

Review URL: https://codereview.chromium.org/137783020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245241 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334479

Review URL: https://codereview.chromium.org/133273016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245240 0039d316-1c4b-4281-b951-d872f2087c98

> Nukes MessageLoop::Dispatcher
> 
> There is no point in this typedef now that MessagePumpDispatcher is
> its own class.
> 
> BUG=none
> TEST=none
> R=ben@chromium.org, darin@chromium.org
> 
> Review URL: https://codereview.chromium.org/139593002

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/138433008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245239 0039d316-1c4b-4281-b951-d872f2087c98

Deprecate the External Extension Install via Preferences file (Windows only). Use the Registry to externally install extensions instead.

BUG=41902

Review URL: https://codereview.chromium.org/138053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245235 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245234 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165145:165201&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/138033008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245233 0039d316-1c4b-4281-b951-d872f2087c98

Note that this temporarily adds some content:: notion in webkit/ (mostly for friend'ing / forward decls)

This also includes some refactoring in some test code (namely obfuscated_file_util_unittest.cc) to work around
cross-namespace friend'ing.

BUG=265769
TEST=build
TBR=mmenke

Review URL: https://codereview.chromium.org/137923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245232 0039d316-1c4b-4281-b951-d872f2087c98

XRaiseWindow does not reliably set the focus. GTK code is doing the same
thing, see gdk/x11/gdkwindow-x11.c.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244779

Review URL: https://codereview.chromium.org/137533006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245231 0039d316-1c4b-4281-b951-d872f2087c98

BUG=223464

Review URL: https://codereview.chromium.org/137463006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245230 0039d316-1c4b-4281-b951-d872f2087c98

This will allow use to ignore profiles unused for a certain length of time (likely 28 days) when calculating statistics on number of profiles, number of signed-in profiles, etc.

BUG=295817

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244760

Review URL: https://codereview.chromium.org/134863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245229 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245228 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nduca

Review URL: https://codereview.chromium.org/132883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245227 0039d316-1c4b-4281-b951-d872f2087c98