- 31 Jul, 2020 40 commits
-
-
John Lee authored
Bug: 642982, 1084620 Change-Id: I397768b3cb48d3c357365e32ee2130ceed720523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323724Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#793714}
-
David Benjamin authored
As documented, the policy is to be retired after M85. This policy was a temporary workaround for potential compatibility issues due to buggy and insecure enterprise proxies. Bug: 1012400 Change-Id: Ia47e544b8f7ed546633351d7c55c40c366e1d032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324170Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#793713}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/26d2e8aa289b..2cd291aae824 2020-07-31 bsheedy@chromium.org Clean up artifact implementation after tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1111474 Tbr: rmhasan@google.com Change-Id: I1e81c6eadbd2b9445c57467b254fbd4232f9254a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333086Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793712}
-
Rakina Zata Amni authored
Allows disabling of BackForwardCache through enterprise policy. Bug: 511340 Change-Id: I1d9830499dc25a8cb987165578d98bea8195bf85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329107 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793711}
-
harrisonsean authored
Refactor Safety check to use mediator and delegates for updating the view controller. Add safe browsing preference to mediator for safe browsing check. Change Safety Check rows to use SettingsCheckItem. Bug: 1078782 Change-Id: Ie4b38b1e617e56cb013a6ce18c8d6d2c62fd9e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287295 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#793710}
-
Rakib M. Hasan authored
Bug: 1050754 Change-Id: I1c71844fa405689c7b0d24ead36cf188a9cccf80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329916Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#793709}
-
Emily Stark authored
When the simplified domain field trials are enabled, ElideURL() is sometimes used to hide most of the URL except for (part of) the domain. This is implemented by using GetSubstringBounds() to find the portion of the string that should not be elided, and setting the display rect and offset to show only that portion. However, GetSubstringBounds() can return bounds that just slightly larger (+/- 1 pixel) than the actual string, due to internal rounding. This can result in small artifacts around the simplified domain, as shown in the screenshots in the bug. To hide these artifacts, this CL sets the hidden portions of the URL to transparent in ElideURL(). The hidden portions are already set to transparent when we use ElideAnimation to animate from full URL to simplified domain, because fading is part of the animation. So in this CL we only need to add transparency in ElideURL() which is called when an animation isn't necessary. Bug: 1108045 Change-Id: Ie146b3585a908067a722dfcec6b6e0c9d03071d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323721 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#793708}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d7c4f9d06425..6d3996c1f67e 2020-07-31 johnstiles@google.com Update gradient colorizers to take coords instead of colors. 2020-07-31 robertphillips@google.com Fix bug(s) in combining and chaining GrTextureOps 2020-07-31 brianosman@google.com Always write binary (eg, UNIX line endings) to sksl .c.inc files 2020-07-31 jmbetancourt@google.com configure attributes for SkottieView to be initialized from XML layout 2020-07-31 johnstiles@google.com Replace manually-implemented lerp with mix(). 2020-07-31 mtklein@google.com remove SkDescriptor API fuzzer 2020-07-31 jvanverth@google.com Use staging buffers for Metal uploads If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1108475 Tbr: borenet@google.com Change-Id: Ib0e04c9809bd5ab69fc8f7fdc712a0fcb76f27e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331927Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/343f63643b43..98b332f2dbbd 2020-07-31 saagarsanghavi@google.com Fixed relative path to work when presubmit run from any directory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1111829 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I0885180cca0d56f7145e3945d1f31a61470e8fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331926Reviewed-by:
-
Omer Katz authored
This CL doesn't yet solve the root cause of the crash. This will only limit its effect to less HashMaps (the stacktrace mentions a map from weak member to int which we have no reason to trace as an ephemeron). Bug: 1110416 Change-Id: I0b349f44e90605c8cd6ec9dd3c8983301ead29b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332582 Auto-Submit: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#793705}
-
Avi Drissman authored
Platform #if defined(OS_*) macros are generated from the .json5 file by uppercasing the platform name and prepending "OS_" to it. Switch to "Mac" in the .json5 file so that the macro generated is OS_MAC. Bug: 1105907 Change-Id: I4916c746d035fb1d35b1789092e36aa4a2c86faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330579 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#793704}
-
Henrique Nakashima authored
Currently we only load from localhost. That will not work in production, so first try to access a graph from gs://clank-dependency-graphs, then fall back to localhost (which cannot GET from the bucket due to CORS). Bug: 1111056 Change-Id: Idf06dfeb6eb49047e7c4c54f60c99e156f0387d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327463 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#793703}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3186e69eb799..bc6aebc6f315 2020-07-31 brgoddar@microsoft.com Grid: Set default CSS grid setting to extended dashed lines 2020-07-31 sigurds@chromium.org Update DevTools Chromium DEPS. 2020-07-31 janscheffler@chromium.org Migrate `front_end/resources` to `devtools_entrypoint` 2020-07-31 janscheffler@chromium.org Migrate `front_end/network` to `devtools_entrypoint` 2020-07-31 janscheffler@chromium.org Migrate `front_end/sources` to `devtools_entrypoint` If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738,chromium:1109215 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia83df8572552548eb917a0e057317bfda2c8601d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332251Reviewed-by:
-
Eugene But authored
According to Session.WebStates.NavigationItem.SerializedPostDataSize histogram stored POST data can be quite large, which can have negative impact on stability. slim-nav based navigation can not restore POST data, so there is no point in storing this data. This also apply for Preload feature, which relies on session restoration and looses POST data. Bug: 1082279 Change-Id: Iedfdc247be8b8fd5e7872351f36529d4d10ce66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325208 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
-
Prabir Pradhan authored
- layout_mode should use the unsigned int type. - remote_shell should send the initial layout_mode after connecting to the client for the first time. BUG=None TEST=None Change-Id: I7f811a9afd72d0b889cb5cac5dded98018f4826c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317858Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Cr-Commit-Position: refs/heads/master@{#793700}
-
Josh Nohle authored
In the previous CL [2/4], we fetched ClientAppMetadata as part of the DeviceSync service initialization. In this CL, we pass the ClientAppMetadata directly to the classes that need it. This eliminates the technical complexity caused by the ClientAppMetadata provider's asynchronous API. --- This is ClientAppMetadata change-detection CL [3/4]: This chain of CLs relates to the end goal of re-enrolling if ClientAppMetadata has changed since the last successful enrollment. For example, when Phone Hub become supported, we will want to re-enroll. We were previously only fetching ClientAppMetadata on demand, for instance, right before a periodic enrollment. Now, we need to fetch the data every time the service starts up to see if it changed. We continue to make the assumption that the data will not change during a user session. Bug: 1105703 Change-Id: I41920152a299a7137d48acd7755718f023b1957b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319329Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#793699}
-
Jon Azose authored
Change-Id: Ib48aebe2a001745485fe5bb84c88035c69afe6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332563Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596192746-6fea58b93463f5fc9ccbb164a8054cb0a38af6db.profdata to chrome-win32-master-1596200193-009c7ebe0bb7420a825c0bad7e0cdc3d24f6a3ae.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I0d1fbb0561141ad7367a18f46f282856e945cfc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332253Reviewed-by:
-
Sophie Chang authored
Server isn't sending down host suffix anymore and makes for an easier migration to HOST-keyed hints. Bug: 1110487 Change-Id: I4517bf134b832d0c166cde652062f6eccefd5138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331132 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#793696}
-
Robbie McElrath authored
This CL moves the 3 menu items related to browser controls into their own menu in the top left. A followup CL will be adding the ability to toggle the top view, which would hide the menu with the checkbox used to turn it back on. By creating this new menu, we'll always have the ability to get the top controls back if they're hidden. Bug: 1109035 Change-Id: I5def9c5d87afda38a258c7a2c730f32e1f6b941a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330614Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#793695}
-
Collin Baker authored
Desktop IPH implementations have grown organically with lots of duplicated code scattered around. To avoid duplication and inconsistencies, IPH promos should originate from a common point in code. FeaturePromoController is a first step in this direction, owning promo bubbles while allowing clients to take control of the promo after displaying a bubble. This will make simple IPH trivial to implement, and more complex promos are still possible. Bug: 1106523 Change-Id: I330c1525dbc9622a5aef2c5e039ae8e29c4f30fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318630Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#793694}
-
Benoit Lize authored
Bug: 1108911 Change-Id: Id43fa27447b9a531e60de0390224d35f8f437dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325921Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#793693}
-
Emily Stark authored
Before this CL, RenderText::GetSubstringBounds() rounded up both the starting x and ending x that it computed. As a result, the left edge of the substring could be slightly outside the returned bounds, and the right edge of the returned bounds might contain some small portion of the next characters. When the output of GetSubstringBounds() is used as input for set_display_rect(), this rounding behavior could show up as small artifacts trailing the domain and/or clipping the first character slightly (see screenshots in linked bug). This CL makes GetSubstringBounds() round down the starting x coordinate. This provides the guarantee that the returned bounds always fully contain the substring -- that is, the bounds will be slightly larger rather than slightly smaller when rounding occurs. An alternative I considered was to introduce GetSubstringBoundsF and let consumers do their own rounding. However, as far as I can tell no other caller cares about the rounding behavior so it seemed like unnecessary complexity to add a float version of the method. Bug: 1108045, 1111044 Change-Id: I733326ef0544c4ecbe3e39bb9bd8f7a410bc0047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317820 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#793692}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596174933-c71437d8a30297882573ea069b38258c9e90f721.profdata to chrome-win64-master-1596193635-02bce97a1becd63464acfea57c5b1e9a80097f4f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I32373aad7537ea96895aeb14c2801c0eb9e203ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332252Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4766bd88cf78..22b8657a5558 2020-07-31 taylori@google.com Merge "perfetto-ui: Add thread state summary" 2020-07-31 fmayer@google.com Merge "Elaborate unknown architecture error." 2020-07-31 aninditaghosh@google.com Use http.client rather than urllib.request 2020-07-31 aninditaghosh@google.com Merge "Add tests for Python API." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:162165450 Tbr: perfetto-bugs@google.com Change-Id: I7b618ced88c3ef3abc8dd51343ced1cc8fa49b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331920Reviewed-by:
-
Carlos Caballero authored
Access to TabSpecificContentSettings in now done via the frame as the data is attached to the main frame's active document's RenderDocumentHostUserData. Bug: 998171 Change-Id: I6b635b7c80ab61d201685da5e068c6c07d82dc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277737 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#793689}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ie224bbcb38bab0de92649936611509d17bb411ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333046Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793688}
-
Yulan Lin authored
Change-Id: I8f8da9aa793b5818f2395795094f0e2313e0af25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321867 Commit-Queue: Andrew Whalley <awhalley@chromium.org> Auto-Submit: Yulan Lin <yulanlin@google.com> Reviewed-by:
Andrew Whalley <awhalley@chromium.org> Cr-Commit-Position: refs/heads/master@{#793687}
-
Nicolas Ouellet-Payeur authored
This reverts commit efc4423e. Reason for revert: Test failures on macOS bots, e.g.: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/19535 Original change's description: > Reland "[LiteVideo] Observe MediaPlayer rebuffer events to stop throttling." > > This is a reland of 57fd8da7 > > This improves the test that was flaking and disables it on > ChromeOS for now. Bug filed to improve test reliability. > > Original change's description: > > [LiteVideo] Observe MediaPlayer rebuffer events to stop throttling. > > > > This change adds plumbing to allow the LiteVideo optimization to > > observe when rebuffer events occur so that all throttling can be > > stopped. > > > > A future change will record the even in the user blocklist and > > record the event in UKM. > > > > Bug: 1082554 > > Change-Id: I9109fe221800b355e46c78e80254f75f433f9448 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316849 > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: rajendrant <rajendrant@chromium.org> > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#793232} > > > TBR=dalecurtis@chromium.org,tbansal@chromium.org > > Bug: 1082554 > Change-Id: I8ead8df5c6e0046bc4d7f6c592307e66f5676762 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330076 > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793616} TBR=dalecurtis@chromium.org,kinuko@chromium.org,tbansal@chromium.org,rajendrant@chromium.org,mcrouse@chromium.org Change-Id: Id7d522b9c27eb371c01dca824142062428b8c611 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332682Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#793686}
-
Swapnil authored
We have several downloading stages that the force installed extension must go through. We want to add downloading stage event to the existing events for the event based reporting for force installed extensions. Bug: 1108257 Change-Id: I0dacd8f319c1d9eed186fc290d20659c2bbfd223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310539 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#793685}
-
Abigail Klein authored
recognition service is ready. As soon as a user presses play on a video or audio, the caption bubble should appear with the text "Detecting speech...". To do this, this CL introduces an OnSpeechRecognitionReady function to the CaptionHost mojo interface, which is called the first time the ChromeSpeechRecognitionClient receives audio to be sent to the speech service. The ChromeSpeechRecognitionClient is constructed when the media is first constructed, which is why this is called when audio is received rather than when the recognizer is bound (which is when the on_ready_callback is called back to the renderer). The flow of information from the speech recognition service to the UI is as follows: ChromeSpeechRecognitionClient::SendAudioToSpeechRecognitionService() -----chrome::mojom::CaptionHost OnSpeechRecognitionReady----- CaptionHostImpl::OnSpeechRecognitionReady() CaptionController::OnSpeechRecognitionReady( content::WebContents* web_contents) CaptionBubbleControllerViews::OnSpeechRecognitionReady() CaptionBubbleModel::OnReady() Bug: 1055150 Change-Id: Ib5eff4034b236b1ee1c6747628b11f9f21506460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321406Reviewed-by:Alex Gough <ajgo@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#793684}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2a2392d4..759f7034 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3745ed0cdb79f53e9883c8f9e662d96647c6ab49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331863Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793683}
-
Alice Wang authored
This CL adjusts the account picker |expand more| icon in dark mode according to the UI mock. Bug: 1107383 Change-Id: I90532fee7b9bd12884e0a4f36c91b6eb17e55665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320168Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#793682}
-
dpapad authored
Bug: 1110015 Change-Id: I7978308c2f402f0c221f96131a440c3375aa5726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326830Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#793681}
-
Peter Kasting authored
Bug: none Change-Id: I9fef002a0abf8ca87ecf044f8824448aa865feef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327456 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#793680}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f6c424bb5923..4766bd88cf78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie713de4cf6a388cf4c8a10da0991d5647d80d024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332562Reviewed-by:
-
behdad authored
With recent changes the flaky stories are prevented by invalidating failures using cpu_wall_time_ratio (https://chromium-review.googlesource.com/c/chromium/src/+/2292811), the previously flaky stories do not need to stay marked as experimental. Bug: 1053614,1093313 Change-Id: I64120d9ba34a2363f21a943131b66d65f20e301f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332737Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#793678}
-
Haiyang Pan authored
And update the related AVD creation textpb files Assigning larger memory size via ram_size might help mitigate crbug.com/1105697 Bug: 922145, 1105697 Change-Id: I05c765cffb50b2196cdb99963f1d4a2cf3476c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146136 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#793677}
-
Patrick Noland authored
Bug: 1111201 Change-Id: Iac335d42a332e4a6bee7bcda5c588c9d74de679a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331070Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#793676}
-
Tommy Martino authored
This feature splits the scroll to text functionality off of the Shared Highlighting flag. This is needed because: * The Scroll-to-text portion will be launching first * The Scroll-to-text portion is being built in //ios/web to enable external usage. Bug: 1099268 Change-Id: I60cbe5d20907d4889aa46a051ec335dfe55b59b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329947Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#793675}
-
