GitLab

ignore_certificate_errors in HttpNetworkSession, which is set by the
--ignore-certificate-errors command-line flag, is currently
implemented by continuing to use the SSLClientSocket after Connect()
fails with a certificate error. Since we currently don't verify until
after the handshake, it's safe to ignore the errors and we still allow
Read() and Write(). At higher levels, we map the certificate errors
back to OK.

This is confusing and will longer work when certificate verification
happens inside the handshake. A certificate error will mean the
handshake hasn't completed. Instead, route the boolean into
SSLClientSocketImpl and map the error to OK there. This allows us to
remove the error-mapping logic at each of the higher levels.

Bug: 347402
Change-Id: I7318e7e9d9e0a3cb0287555b3fd24c9347cc9821
Reviewed-on: https://chromium-review.googlesource.com/c/1343054
Commit-Queue: Jesse Selover <jselover@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613232}

To reveal and select a node, we would call 'onpopulate' on all of its
ancestors without a TreeElement, which ensured that the node's own
TreeElement would be constructed.

When a parent has 500+ children, extra nodes are lazily built after
clicking a "Show more" button. To allow revealing hidden nodes,
this CL expands the limit if a parent is already populated.

Bug: 890632
Change-Id: Ia7b916c21baf5b35dbce8a26eca1681c9bb0b243
Reviewed-on: https://chromium-review.googlesource.com/c/1320569
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613231}

conformance2/textures/misc/copy-texture-image-same-texture.html is
failing on AMD even after http://crrev.com/c/1356330. Suppressing the
failure.

TBR: kbr@chromium.org
Bug: 809233, 911216
Change-Id: I56138fe20025eb4836f9b588755fcdc71ba88055
Reviewed-on: https://chromium-review.googlesource.com/c/1359129Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613230}

This reverts commit 3f40244c.

Reason for revert: Caused a data race running components_unittests with ScopedFeatureList.

Sample failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/30398

WARNING: ThreadSanitizer: data race (pid=9805)
  Write of size 8 at 0x55b63bfba2b0 by main thread:
    #0 base::FeatureList::ClearInstanceForTesting() base/feature_list.cc:284:27 (components_unittests+0x85bec63)
    #1 base::test::ScopedFeatureList::~ScopedFeatureList() base/test/scoped_feature_list.cc:98:3 (components_unittests+0x9a65d52)
    #2 content::UnitTestTestSuite::~UnitTestTestSuite() content/public/test/unittest_test_suite.cc:61:1 (components_unittests+0xb03cf21)
    #3 operator() buildtools/third_party/libc++/trunk/include/memory:2325:5 (components_unittests+0x8256779)
    #4 reset buildtools/third_party/libc++/trunk/include/memory:2638 (components_unittests+0x8256779)
    #5 ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2592 (components_unittests+0x8256779)
    #6 ~__tuple_leaf buildtools/third_party/libc++/trunk/include/tuple:171 (components_unittests+0x8256779)
    #7 ~tuple buildtools/third_party/libc++/trunk/include/tuple:470 (components_unittests+0x8256779)
    #8 ~BindState base/bind_internal.h:871 (components_unittests+0x8256779)
    #9 base::internal::BindState<int (content::UnitTestTestSuite::*)(), std::__1::unique_ptr<content::UnitTestTestSuite, std::__1::default_delete<content::UnitTestTestSuite> > >::Destroy(base::internal::BindStateBase const*) base/bind_internal.h:874 (components_unittests+0x8256779)
    #10 Destruct base/callback_internal.cc:29:3 (components_unittests+0x85b80c7)
    #11 Release base/memory/ref_counted.h:403 (components_unittests+0x85b80c7)
    #12 Release base/memory/scoped_refptr.h:284 (components_unittests+0x85b80c7)
    #13 ~scoped_refptr base/memory/scoped_refptr.h:208 (components_unittests+0x85b80c7)
    #14 base::internal::CallbackBase::~CallbackBase() base/callback_internal.cc:84 (components_unittests+0x85b80c7)
    #15 base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:3 (components_unittests+0x9a71272)
    #16 main components/test/run_all_unittests.cc:8:10 (components_unittests+0x4e49ad5)

  Previous read of size 8 at 0x55b63bfba2b0 by thread T12 (mutexes: write M19294):
    #0 base::FeatureList::IsEnabled(base::Feature const&) base/feature_list.cc:200:8 (components_unittests+0x85be82d)
    #1 CanCleanupLockRequired base/task/task_scheduler/scheduler_worker_pool_impl.cc:672:12 (components_unittests+0x866a5e8)
    #2 base::internal::SchedulerWorkerPoolImpl::SchedulerWorkerDelegateImpl::GetWork(base::internal::SchedulerWorker*) base/task/task_scheduler/scheduler_worker_pool_impl.cc:538 (components_unittests+0x866a5e8)
    #3 base::internal::SchedulerWorker::RunWorker() base/task/task_scheduler/scheduler_worker.cc:324:51 (components_unittests+0x866f81d)
    #4 base::internal::SchedulerWorker::RunPooledWorker() base/task/task_scheduler/scheduler_worker.cc:229:3 (components_unittests+0x866f481)
    #5 base::internal::SchedulerWorker::ThreadMain() base/task/task_scheduler/scheduler_worker.cc:208:7 (components_unittests+0x866f2f1)
    #6 base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:81:13 (components_unittests+0x86daf04)

  Location is global 'base::(anonymous namespace)::g_feature_list_instance' of size 8 at 0x55b63bfba2b0 (components_unittests+0x00000ebe52b0)

Original change's description:
> [TaskScheduler]: Create no detach below initial capacity feature
> 
> Under this experiment, scheduler workers are only detached if the pool is
> above its initial capacity (threads that are created to replace blocked threads).
> 
> 2 options were considered:
> Option A: Detach only when over initial capacity.
> 
> Option B: Detach only when over current capacity (includes currently blocked threads in capacity).
> This might better handle the following case: At any given time, there is at least 1 blocked thread.
> On top of that, some periodic work uses all worker every 30s or so. The current capacity will
> encompass for the blocked thread and avoid detaching it periodically.
> 
> Option A was picked because it is more conservative. Initial capacity is smaller or
> equal to current capacity, so detaching is closer to current behavior. We want to avoid having
> too many threads that aren't used.
> 
> Bug: 847501
> Change-Id: I0b116db54095767768b158d92f5f146249720b45
> Reviewed-on: https://chromium-review.googlesource.com/c/1348863
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612698}

TBR=fdoray@chromium.org,etiennep@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 847501
Change-Id: I951f5c5701e2d296b2c4edef37648105c4911cf9
Reviewed-on: https://chromium-review.googlesource.com/c/1359127Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613229}

This CL does four things:
* Support 'sensitiveValue': True for regular policies defined in
  policy_templates.json
* Improve de-duplication logic for SchemaNode generation by also
  re-using more complex schemas. (Reduces number of |SchemaNode|s from
  180 to 131)
* Fix a crash if 'sensitiveValue': True was applied to a schema with
  type 'list' or 'object' (see |CopyAndMaybeConvert()| in
  policy_conversion.cc) and added tests for this.
* Add documentation about 'sensitiveValue' to policy_templates.json.
* Make use of namedtuples in generate_policy_source.py

Bug: 905357
Change-Id: If3889ada705d9576165c2467f6dd8d9376e54886
Reviewed-on: https://chromium-review.googlesource.com/c/1337346Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613228}

We do a number of tasks in javac.py after the javac command completes:
- Move annotation processor generated files to out/Default/gen.
  - Scan all java files (including aforesaid generated ones) to
    construct .apk.jar.info files.
- Pack all .class (and other files?) into a .jar file for future build
  steps.

This CL splits out these tasks and does them in parallel, in particular
also processing java files in parallel.

Estimated incremental build savings: ~1.2s

Bug: 906803
Change-Id: Ic7a4d4e4cee998ea15f90a1c435de34e60780a3a
Reviewed-on: https://chromium-review.googlesource.com/c/1352806
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613227}

Bug: None
Change-Id: I16c48291147a71dd119983811e45e3a268ef963e
Reviewed-on: https://chromium-review.googlesource.com/c/1343411Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613226}

Fixes WebGL conformance test:
conformance2/textures/misc/tex-subimage3d-canvas-bug.html

The test expects to be able to create a canvas larger than 32767 in
height. Skia seems to support this, and there have been user requests
for it.

Bug: 859400, 339725, skia:2122
Change-Id: Ibba89e98178bd73817c7b4cbdf569e89ee5764b1
Reviewed-on: https://chromium-review.googlesource.com/c/1356555Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613225}

This CL achieve the animation by adding sequential labeled CSS class
to overflow menu list item so that we can add delays to each visible
items to let the items appear one after another.

Bug: 814507
Change-Id: I46ee3b6e6a8cbadaad33d2417454267ff4d62a66
Reviewed-on: https://chromium-review.googlesource.com/c/1357462
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613224}

Behind an experiment, a new context menu option in the Sources gutter
allows adding a logpoint. Future CLs will tackle editing a breakpoint
type and UI changes.

Logpoints `console.log` a message instead of pausing.

Bug: 700519
Change-Id: Ib33c1a84de4fbc06b6fde6e2e3dd7628e3896d64
Reviewed-on: https://chromium-review.googlesource.com/c/1330079
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613223}

create_string_rc.py globs a bunch of xtb files off disk behind gn's and
ninja's back, so that they didn't know that create_string_rc.py needs to
rerun when the xtb files are updated. Make the script write a depfile so
that ninja knows to re-run the script if an xtb file is udpated.

(This is incomplete: if an xtb file is added or removed and nothing else
changes, the step still won't re-run. The Right Fix is to list all the xtb
files in the gn file and pass them to the script, then make the script assert
that the glob matches the passed-in line. That way, if an xtb is added or
removed, the command-line tracking will make sure that the command re-runs.
But xtb files being added or removed is super rare, so let's punt on this for
now.)

Bug: 910465
Change-Id: I7050dee3c62d997b750d8b150504a04d086518b8
Reviewed-on: https://chromium-review.googlesource.com/c/1359087Reviewed-by: Robert Shield <robertshield@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613222}

Various functions in WorkletAnimation had gotten far too big to be anonymous
namespace methods. Pull them out into proper utility functions - which means
they can also now be tested!

Bug: 910777
Change-Id: I50a65f0e613ff71e7fddc042ee80448f0c3fbcba
Reviewed-on: https://chromium-review.googlesource.com/c/1355984Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613221}

DialogModel is a currently unnecessary pure abstract class. Removing it simplifies the dialog
hierarchy.

Change-Id: Iac8c096b2879d594a723c57abcb1a05bba216e4b
Reviewed-on: https://chromium-review.googlesource.com/c/1345212Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613220}

This CL moves the method -setActive: to the coordinator layer since
it deals with many child coordinators.

Change-Id: I8e61ece1380169ffc10e9e00bccaa68dbde7d4d4
Reviewed-on: https://chromium-review.googlesource.com/c/1355924Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613219}

Added to webrtc rtpencoder struct is a field for specifying the dscp value
on a per-encoder basis, allowing audio and video to have different priorities.
The API is defined in https://w3c.github.io/webrtc-dscp-exp/ , and the
particular codepoints are defined in
https://tools.ietf.org/html/draft-ietf-tsvwg-rtcweb-qos-18#section-5
Note, actually enabling DSCP at all is still guarded by the googDscp
PeerConnection constraint, for now.

WPT tests:  https://chromium-review.googlesource.com/c/chromium/src/+/1357515
I2I: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/bVNynDp9PHo
chromestatus:  https://www.chromestatus.com/feature/5583278023114752


Bug: webrtc:5008
Change-Id: I05bdcf62787d30211310a4686bb5fc18fda674da
Reviewed-on: https://chromium-review.googlesource.com/c/1298231Reviewed-by: Florent Castelli <orphis@chromium.org>
Commit-Queue: Tim Haloun <thaloun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613218}

Bug: 905939
Change-Id: Iae8ed5b83aa8bb384ed2c8e65f345547f188a986
Reviewed-on: https://chromium-review.googlesource.com/c/1357382Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613217}

Bug: 908988
Change-Id: I3f00b9e786d617fd288e90f2632bb86d18452502
Reviewed-on: https://chromium-review.googlesource.com/c/1358913Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613216}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b9f9a3bc9f36..d80259d35e66


git log b9f9a3bc9f36..d80259d35e66 --date=short --no-merges --format='%ad %ae %s'
2018-12-03 33432579+alan-baker@users.noreply.github.com Strict validation of where type ids are acceptable (#2142)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@d80259d35e66

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I1632d3f88c2ebd24572357241e054df5dfd3ab96
Reviewed-on: https://chromium-review.googlesource.com/c/1358759Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613215}

Bug: 910026
Change-Id: Ifdf6cb51032dd8885297bf3d8d4febaa2e564647
Reviewed-on: https://chromium-review.googlesource.com/c/1357459Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613214}

Bug: 910739
Change-Id: Ic708c771665e70979cf6011c482dd050ce749fe5
Reviewed-on: https://chromium-review.googlesource.com/c/1357539
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613213}

No change to behavior, this only moves the value into a getter method
for both code paths.

This moves the cache size to a centrally-determined spot, since we may
want to create more complex logic for the value we set.

R=changwan@chromium.org

Bug: 893318,887538
Test: None
Change-Id: I0e22928bc37a247f165e3913b1e7007fa0d7a1f3
Reviewed-on: https://chromium-review.googlesource.com/c/1357331Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613212}

Bug: 890348
Change-Id: I9946191164b4e9f8fde4be3452d80d866317b156
Reviewed-on: https://chromium-review.googlesource.com/c/1354693Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613211}

No change to behavior, this only re-applies default settings for the
sake of explicitly declaring our support.

This sets ct_policy and ftp_url_support to false.

R=changwan@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
Bug: 887538
Test: None
Change-Id: Ie05fbe7f64c2b599227223d76c697f2624d69c62
Reviewed-on: https://chromium-review.googlesource.com/c/1357630Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613210}

```-----------------------------------------------
Date:   Mon Nov 19 19:16:16 2018 +0000

Add support for IETF QUIC STOP_SENDING frame

Wire in upcall indicating an IETF QUIC STOP SENDING has been received.

This is only for version 99

Merge internal change: 222106599

https://chromium-review.googlesource.com/c/1355606/
```

-----------------------------------------------
Date:   Mon Nov 19 20:18:06 2018 +0000

Deprecate all overrides of QuicSpdyStream::OndataAvailable()

Deprecate all overrides of QuicSpdyStream::OndataAvailable() and change
them to OnbodyAvailable().

no behavior change. refactor only.

Merge internal change: 222117730

https://chromium-review.googlesource.com/c/1355529/


--------------------------------------------------
Date:   Mon Nov 19 20:18:56 2018 +0000

Simplify the QuicFlowController constructor

Simplify the QuicFlowController constructor by getting the connection
and perspective from the session instead of taking them explicitly.

Moving code only

Merge internal change: 222117854

https://chromium-review.googlesource.com/c/1355607/


--------------------------------------------------
Date:   Mon Nov 19 21:57:12 2018 +0000

Increase the period of Quartc acks from 25ms to 100ms.

Increase the maximum (minimum) period of acks from 25ms to 100ms.
This changes the % of non-data packets from 30-40% to 4-9% on bidirectional test.

Merge internal change: 222133474

https://chromium-review.googlesource.com/c/1355532/

Bug: 119768803

--------------------------------------------------
Date:   Mon Nov 19 22:19:07 2018 +0000

Enable quic 46 => 45 for SendMessage

Version 46 is not negotiated. Downgrading quartc to 45.

Added follow-up b/119779614 to use QuartcFactory in QuartcSession test
so that we do not duplicate factory settings in session test. This is
follow-up for cl/222104840.

(Quartc only)

Merge internal change: 222137694

https://chromium-review.googlesource.com/c/1355533/

Bug: 119779614

--------------------------------------------------
Date:   Tue Nov 20 00:13:58 2018 +0000

Add PendingStream class.

Add a new PendingStream class to buffered frames before a QuicStream
can be created.

Merge internal change: 222157340

https://chromium-review.googlesource.com/c/1355609/


--------------------------------------------------
Date:   Tue Nov 20 17:54:47 2018 +0000

Parametrize QpackInstructionDecoderTests on fragment size.

Decode test data two ways: byte by byte, as well as in a single
Decode() call.

Also, remove unnecessary lambdas.

Prototype code not in production yet.

Merge internal change: 222262308

https://chromium-review.googlesource.com/c/1356859/

Bug: 112770235

--------------------------------------------------
Date:   Tue Nov 20 19:46:27 2018 +0000

Implement QpackInstructionEncoder and convert QpackEncoder to use it.

Also inline some constants in qpack_constants.cc that are only used there.

Prototype code not in production yet.

Merge internal change: 222281298

https://chromium-review.googlesource.com/c/1356879/

Bug: 112770235

--------------------------------------------------
Date:   Tue Nov 20 20:25:53 2018 +0000

Move kStringLiteralLengthLimit to qpack_instruction_decoder.cc.

Move kStringLiteralLengthLimit from qpack_constants.h to
qpack_instruction_decoder.cc since it's only used there.

Prototype code not in production yet.

Merge internal change: 222287727

https://chromium-review.googlesource.com/c/1356860/

Bug: 112770235

--------------------------------------------------
Date:   Tue Nov 20 20:36:47 2018 +0000

Use QpackInstructionEncoder in QpackEncoderStreamSender.

Prototype code not in production yet.

Merge internal change: 222289390

https://chromium-review.googlesource.com/c/1356880/

Bug: 112770235

--------------------------------------------------
Date:   Tue Nov 20 20:54:52 2018 +0000

Use quic's unlimited decimation.

It's difficult to say if it is making a big difference: the % of
non-data packets didn't change, but it seems that we are sending fewer
packets.

This shouldn't harm.

Quartc only

Merge internal change: 222292216

https://chromium-review.googlesource.com/c/1356881/


--------------------------------------------------
Date:   Wed Nov 21 16:30:06 2018 +0000

Remove test QuicDispatcherWriteBlockedListTest.TestWriteLimits, it is
redundant with
QuicDispatcherWriteBlockedListTest.OnCanWriteHandleBlock.

Test only change.

Merge internal change: 222412079

https://chromium-review.googlesource.com/c/1356861/



Move Google QUIC stream id management into a legacy stream ID manager.

In QUIC, move more variables from session to stream ID manager. Add
LegacyQuicStreamIdManager which manages Google QUIC stream IDs. Code
move. No functional change expected. Not protected.

Merge internal change: 222413629

https://chromium-review.googlesource.com/c/1356877/

Bug: 113641764

--------------------------------------------------
Date:   Wed Nov 21 17:08:25 2018 +0000

Deprecate FLAGS_quic_reloadable_flag_quic_fix_is_useful_for_retrans.

Merge internal change: 222417022

https://chromium-review.googlesource.com/c/1356878/


--------------------------------------------------

Explicitly delete the PendingStream copy constructor.

It is implicitly deleted by virtue of having non-copyable members
and having a user-defined move constructor, but explicit is WAY
better than implicit.

Compile-time change only

Merge internal change: 222419425

https://chromium-review.googlesource.com/c/1356893/


--------------------------------------------------
Date:   Wed Nov 21 17:41:23 2018 +0000

Do not send & count probes during crypto handshake.

Quic ignores probing retransmissions during handshake, and so GoogCC
thinks it's doing probing, but it isn't, and the estimates are based
on pure packet contents (with no padding or retransmissions).

This change delays probing until crypto handshake is completed.

Do note that the 'HasPendingCryptoPackets' occurs later than the
crypto handshake callback to quartc session.

This change fixes the 3G calling scenario where caller's bitrate and
moslqo would be way worse than callee's.

Note that this change is not sufficient for the general goog-cc
scenario; we still need further improvements for probing, but this
fixes the most glaring issue.

Quartc only

Merge internal change: 222421279

https://chromium-review.googlesource.com/c/1356894/


--------------------------------------------------
Date:   Wed Nov 21 19:38:52 2018 +0000

Initialize negotiated_version_ from filtered version list.

negotiated_version_ was initialized using an unfiltered set of versions,
while the rest of quic used the set of versions filtered by the version
enable flags.  this led to version skew. when there were expectations that
the QuicConnection version and negotiated_version_ would be the same, things
failed because they were not the same. This change fixes that.

Negotiated_version_ is the version that should be in use. Use it in the
STOP_SENDING test to ensure that the test is run only if V99 has
been negotiated.

Leave in some asserts to catch the problem if it arises again

test changes only.

Merge internal change: 222438849

https://chromium-review.googlesource.com/c/1356895/


--------------------------------------------------
Date:   Mon Nov 26 16:26:45 2018 +0000

Count unmunged IETF Short Header packets at proxy dispatcher.

For UDP proxy, record a varz when the proxy dispatcher receives a
unmunged IETF short header packet. Stats only, not protected.

Merge internal change: 222829011

https://chromium-review.googlesource.com/c/1356896/

R=rch@chromium.org

Change-Id: I2263742a1a636d05daa3da31c11d7430b98ed0a8
Reviewed-on: https://chromium-review.googlesource.com/c/1357542Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613209}

There are a few instances remaining which use it, for those use a temporary friend class to disable the DCHECK.

Bug: 837753
Change-Id: I186488d87e44411a131f59b1b0def2133c7e2339
Reviewed-on: https://chromium-review.googlesource.com/c/1355136
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613208}

This fixes a regression where the platform impl was created even
when it wasn't yet needed.

Bug: 911184
Change-Id: I6555a81ff86327fd12994bf4de5e44074dfeee15
Reviewed-on: https://chromium-review.googlesource.com/c/1358919Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613207}

This reverts commit 71f820a1 ("Disable assistant for child account").

Bug: b:120075638
Test: built and tested locally
Change-Id: I59d3d4869ba596fa462a904b8a64a88230c28325
Reviewed-on: https://chromium-review.googlesource.com/c/1351155
Commit-Queue: Henrique Nazaré Santos <nazare@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613206}

Change-Id: Id5440ef6f3cd24040a57bd7e74873df899b59266
Reviewed-on: https://chromium-review.googlesource.com/c/1346729
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613205}

With this patch users are able to search for cache entries which contain a given
URL path in Application panel's cache storage table. Only entries that have the
matching URL paths will be displayed in the table, which supports pagination if
there are too many entries returned.

Bug: 884194
Change-Id: If285cc43859e82f5e59b80b1b761e9836aa5f510
Reviewed-on: https://chromium-review.googlesource.com/c/1345421Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Haihong Li (Harley) <hhli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613204}

Whenever the user unelides the URL, the omnibox also enters
user_input_in_progress_ mode.

This is was harmless before, but since then we have started displaying
suggestion favicons in the omnibox, the current page's security
indicator is being clobbered by the page's favicon during unelision.

This is not correct, since unelision is supposed to be as unobtrusive
as possible.

This is going to become more noticable now that Ctrl+L triggers
unelision, as well as our future planned work for One-Click-Unelide.

This CL replaces the old logic, and keeps showing the current page's
security indicator until the user actually modifies the user text.

Bug: 874592, 906223, 910145
Change-Id: I8a5619d4408b09d2e9f98fd5ce011ecbd2cab085
Reviewed-on: https://chromium-review.googlesource.com/c/1351564
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613203}

FrameSinkElement creation is moved into a function that creates the
unique_ptr and adds it to the map of elements. Removing elements from
this map now deletes them.

The FrameSinkElements need to be owned by DOMAgentViz because it
receives all of the FrameSinkObserver events. Whereas for Views, each
ViewElement, WidgetElement, and WindowElement is its own Observer, so
centralized ownership in DOMAgentAura doesn't make as much sense.

Elements are no longer inserted into |frame_sink_elements_| by
BuildTreeForFrameSink(), so we don't need to static_cast pointers any
more. Also make variable names in BuildTreeForFrameSink() clearer.

Bug: 816802
Change-Id: Ieec4db482ffb3ff8a740eb559c1c3d9ee9a80705
Reviewed-on: https://chromium-review.googlesource.com/c/1346910
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613202}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/58dc4bf4fc2b..f1684ef61ea6


git log 58dc4bf4fc2b..f1684ef61ea6 --date=short --no-merges --format='%ad %ae %s'
2018-12-03 stevenjb@chromium.org cros_chrome_sdk: Elim _StripGnArgs


Created with:
  gclient setdep -r src/third_party/chromite@f1684ef61ea6

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ie0821ee52d1b39b60a83b4f4261b897def21b39f
Reviewed-on: https://chromium-review.googlesource.com/c/1358802Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613201}

There's no downside of doing this on Windows and it makes the build
deterministic, so always enable it.

Bug: 330260
Change-Id: I0e86a2ae5864af2fb4e1716cff1718c9606ab42f
Reviewed-on: https://chromium-review.googlesource.com/c/1358700Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613200}

Makes the loading-progress animation smoother for pages that have not
finished loading pretty-much instantly. A follow-up might consider
removing actual loading progress completely and just animate to 70%
slowly until loading finishes.

Bug: chromium:908920
Change-Id: I207d602c1552591396840c346e88b0962af07be2
Reviewed-on: https://chromium-review.googlesource.com/c/1358923Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613199}

This CL turns on ThinLTO optimizations for Android by default for all
official builds.

This CL is expected to increase link times of official builds by
something around 2.5x CPU/2x wall time. More build capacity was requested
in http://crbug.com/883563.

This is also a pretty wide-reaching CL. A size decrease of a hundred
KB is expected, and we expect that the CPU-bound parts of Chrome will
generally be faster. If there are slowdowns, they should be very few in
number, and very small.

ThinLTO is a type of link-time optimization, which defers actual
code-generation and some optimization until link-time. This is very
beneficial to the optimizer, since it now has visibility into
functions/constants that, at a per-TU level, would be opaque. ThinLTO is
already deployed on Linux and Android, but our default Linux configuration
does *not* use optimizations. This CL specifically enables these
optimizations for Android.

      size/build time measurements.

Bug: 807147
Test: Perf testing on nexus-5 (crbug.com/836550); manual binary
Change-Id: I7e07d9d9cb1dadd077adf44ca6217c40e13b00a8
Reviewed-on: https://chromium-review.googlesource.com/c/1149061Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613198}

This change adds an InSettings attribute that is used to determine whether
the File Manager should be automatically opened on a successful mount call.
When mounting from the free-form dialog, the File Manager will not be
automatically opened.

Bug: chromium:887135
Test: browser_tests --gtest_filter=CrSettingsSmb*
Change-Id: I4e681c1ffe104f234784c2f958d24b2d257bc33c
Reviewed-on: https://chromium-review.googlesource.com/c/1336911Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613197}

Previously, the HintCache's initialization, which involved adding all
hints contained within a hint vector to the cache, was being handled
on the UI thread. This initialization could take a significant amount
of time and triggered the creation of a jank startup performance bug.

The logic has been modified so that the HintCache is no longer
initialized on the UI thread. It is instead initialized within its
constructor during PreviewsHints::CreateFromHintsComponent() on a
background thread.

This is accomplished via a HintCache::Data object. Once the hints are
fully added to Data, it is moved into the HintCache's constructor. The
HintCache is immutable after construction.

Not only does this remove all of the costly UI thread processing, but
it also eliminates the expensive intermediate hint vector.

Bug: 910251
Change-Id: I04a28248ad1ce790f999da06f48e3c5aabfcb812
Reviewed-on: https://chromium-review.googlesource.com/c/1356226
Commit-Queue: Jered Gray <jegray@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613196}

Change-Id: I06a35cb28512af457eb7e77fe44eedfef7fab9f9
Reviewed-on: https://chromium-review.googlesource.com/c/1359055Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613195}

Place the colored monogram inside a gray circle. This matches the
fallback style on mobile.

Screenshots:
https://screenshot.googleplex.com/SjGT71VeutN.png
https://screenshot.googleplex.com/6eXirCU0knX.png
https://screenshot.googleplex.com/8xcd9KZvvgp.png

Bug: 905437
Change-Id: Ib26c04fc22e4eb50685c5de04300dd543a625cee
Reviewed-on: https://chromium-review.googlesource.com/c/1354318
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613194}

Bug: 717812
Change-Id: I6d53865348171ba2fe777a8730b08248d05e7f26
Reviewed-on: https://chromium-review.googlesource.com/c/1344222
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613193}