GitLab

On Windows 32 bit, Chrome reserves a significant chunk of address space
when a renderer starts, to make large contiguous allocations easier to
fulfill. Once a memory allocation fails, the reservation is released,
then the allocation retried. This only works if *all* the allocators are
aware that this mechanism exists. Unfortunately, malloc() in particular
is not aware of this, meaning that if a large malloc() allocation bumps
into this issue first, then the renderer crashes.

As this seems to be the case, from looking at crash reports (see linked
bugs for instance), malloc() should be made aware of this.

On Windows, allocations use the allocator shim, and call the "new
handler", which should return a non-0 value when it is able to free some
memory. Currently, this new handler always crashes the process. We
update it to drop the reservation if it exists, and crash otherwise.

This should hopefully solve some crashes we are seeing, especially some
related to video decoding, frequently allocating buffers of ~1MB, which
is large enough to trigger the issue, as seen in crash reports.

This is not a complete fix, since it does not address all allocators in
a process, e.g. allocations by DLLs loaded by the process will not pass
through the new-handler hook. We do not (yet) see these as a significant
cause of crashes in practice though.

Note that this CL also adds the reservation dropping behavior to Linux
builds as well. There is no address space reservation in actual Chrome
builds on Linux, but adding this allows to exercise the tests on Linux
builders as well, which is preferable.

Bug: 1028086, 1023804
Change-Id: I12ad4aa0c7bf518c3cf1df93c966e8631a69c280
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989747Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730994}

Remove several that have already expired, as well as MaxTaskDuration and
StartupDuration.

Bug: 1039326
Change-Id: I65da54c7c60c376fff80fe5288efbbd7b37e8d66
Fixed: 1039326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986440
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730993}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=khorimoto@chromium.org

Bug: 1041419
Change-Id: Icb6f30e6c7d6070efa6d732a88dfcc21ae02da55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998712
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730992}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=amoylan@chromium.org

Bug: 1041419
Change-Id: Ide2c1303468964b156b0d370b38f79abbdf3c01a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993855
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Commit-Queue: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730991}

This reverts commit 6f69db7b.

Reason for revert:

The cleanup CLs haven't landed yet cuz the tree is borked
(ex: https://crrev.com/c/1995802)

NOTREECHECKS=true
NOTRY=true

Original change's description:
> Add cr.exportPath() to ESLint banned properties
> 
> R=​dpapad@chromium.org
> 
> Bug: 1028829
> Change-Id: I6ff5518a178bd86a5ab13b8ef7d8bce52b9588fd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995947
> Commit-Queue: Dan Beam <dbeam@chromium.org>
> Auto-Submit: Dan Beam <dbeam@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#730348}

TBR=dbeam@chromium.org,dpapad@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1028829
Change-Id: I57cca1d4367794050cbd571382b30f11e650d429
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999549Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730990}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=rsesek@chromium.org

Bug: 1041419
Change-Id: I36f0b57e35e5e30edb0dffa6753549192d36476e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998919
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730989}

While all infobar banners have relatively similar interaction patterns,
the interaction signals from modals are all special-cased for each
modal view's API.  As a result, there is no way to share code amongst
interaction handlers for infobar detail sheet or modal UI.  Moreover,
each of these handers needs to specify a separate OverlayRequestSupport
since each only responds to a single request type.

Since the top-level interfaces for detail sheet and modal interaction
handlers expose identical API (i.e. visibility updates and callback
installer creation), this CL combines them together into a single
nested interface within the InfobarInteractionHandler.  The visibility
observer in the InfobarOverlayBrowserAgent was also updated to no longer
be specific to the banner UI, as the Handler class now supports
receiving visibility signals for all overlay types.

For consistency, the banner interaction handler was also converted into
this shared handler interface.  The common interaction handling logic
shared amongst banner implementations was moved into a common/
directory that can be implemented for each InfobarType.  This CL also
converts the password banner interaction handler to use this new
interface.

In order to test this new implementation, InfobarOverlayBrowserAgentTest
was updated to a parameterized test for each InfobarOverlayType.  The
test fixture sets up Handlers with mock callback installers for each
overlay type.  The OverlayPresentation test verifies the presentation
flow for infobar overlays of each InfobarOverlayType.  It verifies that
the callbacks are successfully installed and that the infobar overlay
visibility callbacks are executed properly.

Bug: 1030357
Change-Id: If735f30b0bf6741dfd30a2f606a07bacb5ac1e7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995930
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730988}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=drubery@chromium.org

Bug: 1041419
Change-Id: Iea425beb9d19b73f2b5d55360e6c9074965fed50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997557
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730987}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=estevenson@chromium.org

Bug: 1041419
Change-Id: I6f964aad93e1125cd482d043db3abd4a314e5741
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998685
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730986}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=dnicoara@chromium.org

Bug: 1041419
Change-Id: I38a770cc4fb885eb49e7d6356e99ea4c50fa84da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997713
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730985}

PasswordReuseDialog will bold the domains where passwords
are reused. This CL add support for bold spans. The usage
of bold spans will be added in a follow up CL.

Bug: 1036042
Change-Id: I9153da224011d358569d2659b4d33c6415ebdd95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993740
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730984}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=jennyz@chromium.org

Bug: 1041419
Change-Id: I9ffe3d86934385cec5ba115267c6a064d7cd57b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998978
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730983}

Currently, the logic for identifying threads in components/safe_browsing
depends directly on content::BrowserThread. There are two main use cases:
1) DHECK-ing the currently running thread; 2) creating TaskTraits for a
call to PostTask.

This CL creates more generic utility functions for identifying threads,
checking the currently active thread, and creating TaskTraits given a
thread id. It adds a common header file along with content-specific and
ios-specific implementations.

This CL also converts a single file (v4_local_database_manager.cc) to using
the new functions.

Finally, this CL adds an ios unit_test target for compiling the newly-created
thread_utils_ios.cc. Over time, as more files become buildable on ios, they
will be added to that target.

This is a step towards removing dependencies on content/ from
components/safe_browsing/core.

Change-Id: I0194b57c5fc6fc4652cf578bceb5083f08e63432
Bug: 1028755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992353
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730982}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=dalecurtis@chromium.org

Bug: 1041419
Change-Id: Ie028bb68b57fb36845f4825459257be95b848685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998270
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730981}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=rsesek@chromium.org

Bug: 1041419
Change-Id: I8f2d90b271b4be38f50d974c1f1691b628a290ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997767
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730980}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=huangs@chromium.org

Bug: 1041419
Change-Id: I6a2e1245b543eee2ed837e2779c8a34c1183171b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998444
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730979}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=rsleevi@chromium.org

Bug: 1041419
Change-Id: Ie86918ddd7230441dbd4612003208df53e30c0a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998628
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730978}

This will be used for multiple OverlayRequestMediators, so is moved to
a category that can be used by all subclasses.

Bug: 1030357
Change-Id: Ia314d2e9a951cc509361094d1d4d89487eaf662e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996155
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730977}

This will add the --test-logging-path switch that prevents flakes while
spawning a subprocess.

R=proberge

Bug: 1030333
Change-Id: I4beaeb0cf1950516d8528d4134889f8043f1d5a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998710Reviewed-by: proberge <proberge@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730976}

This CL temporarily adds kaleidoscope-content to the network access
whitelist while we await support for untrusted WebUIs.

Bug: 1039904
Change-Id: I1f03f21be9ebb121c7bfc16878566ab6fc41836f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994535Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730975}

Update Chrome's copy of cros_healthd.mojom to stay in
sync with Chrome OS's copy, and change cros_healthd's
ServiceConnection to work with the new mojo interface.

Bug: chromium:1040161
Test: chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.*
Change-Id: If3b0fba44bcea71e8221dd86f9a9ad8f772b05e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992586
Commit-Queue: Paul Moy <pmoy@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730974}

The math to scale and size the rect was incorrect. The quad rect
should actually be an unscaled embedded_surface_size_ instead
of a scaled content_size_. This fixes distortion of the contents as
currently the quad will still be scaled incorrectly

Similarly, the implementation of the matrix means that translate needs
to be scaled up/down as well

  with continually variable crop offsets and scaling

Bug: b/143612326
Test: manually, a 256x256 crop of a 1024x600 surface into a 512x512 quad
Change-Id: If545170f9ae4cd53075b2f3128b7dc38383077d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994263
Commit-Queue: Albert Chaulk <achaulk@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730973}

There are a few tablet mode transitions are fixed:
* in app state, long press home button to start assistant then
  hit home button to go to launcher
* in app state, long press home button to start assistant then
  fling from bottom to go to home launcher
* in app state, long press home button to start assistant then
  drag to overview mode, then hit home button

Bug: 1026727, 1039787
Test: locally build and test
Change-Id: Ie9c9bab98ed73b4e419149554b9bead6b8cd8e24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994241
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730972}

IsConnected() and OnGpuServiceLost() are expected to be called on the
UI thread, but they're being used in OnGpuServiceLaunched() that is run
on the IO thread.

Bug: 620927,1039834
Change-Id: I41459fe834f444fe72418950d9fdb393352a7c71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999323Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730971}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=ekaramad@chromium.org

Bug: 1041419
Change-Id: I5ecbae9d7f892c8dca80c002daa45c04459614c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998920
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730970}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=tengs@chromium.org

Bug: 1041419
Change-Id: Id587e815c27d0ca6f86006757a987ab453e665f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998784
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730969}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=kbr@chromium.org

Bug: 1041419
Change-Id: I14c49a96e42dabd429da802c1538e13d5a4850b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998620
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730968}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=msarda@chromium.org

Bug: 1041419
Change-Id: I8cd0ca11583d6c403b79c1d4b8925d710f402dcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995857
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730967}

Bug: 1038415
Change-Id: I8dbdfdc17d1fd88e75a77d86346b2153a6aa3afd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989863Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730966}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=vitalybuka@chromium.org

Bug: 1041419
Change-Id: Ic6e1f57be18eae39f00e8f8141f0fb39aec60965
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997951
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730965}

Also add the UMA suffix FromLink, FromOmnibox, and FromChromeInternal
for DefaultAppLaunchSource based on TODO comments.

BUG=1005640

Change-Id: I1ab92d9ea2aabf7afdd9c1b2599b8af349b326df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996964Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730964}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=yoavweiss@chromium.org

Bug: 1041419
Change-Id: I7fff56ed3f06009203fa9cf81fcf4d71577c3b3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998314
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730963}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=rajendrant@chromium.org

Bug: 1041419
Change-Id: Ic53a705035bee6656c7195b95295fcf69f4f08d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998637
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730962}

The previous method for disabling these tests didn't work, as the
parameterized prefix was added before the DISABLED_ prefix & gtest
ignored it. This moves the DISABLED_ prefix to the parameterized
prefix.

Bug: 514632
Change-Id: I2fda9d744a4801d70affbf1f066e3e65c7715818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995639
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730961}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 1041419
Change-Id: I78142fdf2541e1f4a9152b47c71f5acf4f1d314f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998315
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730960}

Failures on these bots lack stace traces, eg:
https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8892247654280769408/+/steps/interactive_ui_tests/0/logs/Deterministic_failure:_TabDragging__x2f_DetachToBrowserTabDragControllerTest.OffsetForDraggingTab__x2f_0__status_CRASH_/0

That's due to exclude_unwind_tables defaulting to true on official builds.
This will explicitly include them on our official testers (won't affect
any other official build).

Bug: 1041069
Change-Id: Idf568a06939529936fc4cb6e361b1f6a36ca3852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996123
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730959}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=pkasting@chromium.org

Bug: 1041419
Change-Id: I2bffb2735322f74e3b6349a0ec5b597e80191d6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997796
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730958}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=rouslan@chromium.org

Bug: 1041419
Change-Id: I99ed345f485b53dffd7c56393cb0c5155e3dc7e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995792
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730957}

ResizeObserver notifications are delivered out of order because
observers for the same element are stored in a HeapHashSet, which does
not track insertion order. Using HeapLinkedHashSet mitigates this issue.
Web test to insure correct notification order is also added.

Bug: 1026663
Change-Id: I532c566d16f00bcd60a7164af4f4e6fc22cb881b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992910Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#730956}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=nyquist@chromium.org

Bug: 1041419
Change-Id: I2b170f09acfa44ada72eb0f88ec1a04e512cfc5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995791
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730955}