- 18 Jan, 2021 40 commits
-
-
Kevin Ellis authored
Prior to the patch, the validity of the execution context was only checked on entry to the method; however, the execution context can be invalidated during the course of parsing keyframes or options. The parsing of options is upstream of Animatable::animate and caught by the existing check, but invalidation during keyframe parsing could fall through triggering a crash. Bug: 1161739 Change-Id: Ic0fc927d1d6ce902592bf92261fd4c506e96afac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636213 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#844622}
-
Henrique Ferreiro authored
The class DictationChromeos already lives in a ChromeOS-only directory: chrome/browser/ash/. Remove its suffix. This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1164001 Change-Id: I28ff84b527e3eebc7584b22a7f99a9acdbe4cf04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627371 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Owners-Override: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#844621}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610981979-8f34756a4da6cb018f171d5c6603852477d6e4b4.profdata to chrome-win32-master-1610992290-682e9bbbdeeb2e8d01a84d67f327a574b1495751.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic72ee725b81807e3d184e601258cb7f4f9f944cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633440Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844620}
-
Jonathan Backer authored
This CL copies https://skia-review.googlesource.com/c/skia/+/312056 and uses coherent memory on mobile GPUs, which demonstrated a significant CPU saving on Android. Change-Id: I3ca13695a168e7b998b9ebffddab06d21f10983b Bug: 1167904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636380Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#844619}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610981979-6557ac3082422cce80dd82b8ef29d8213086e8c3.profdata to chrome-win64-master-1610992290-a2bb9ab0a72f07714d6834315a5f80b743087bf7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I527fff2ad672983e847e3ab0071fe403e007a166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636478Reviewed-by:
-
Luke Zielinski authored
Turns out there are two flavours of this test in similar directories. Bug: 1167318 Change-Id: I8684f093b7eb74d9912a53d1050fffb6a2526e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633938 Commit-Queue: Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#844617}
-
alanlxl authored
1. Add a task_runner_ to ServiceConnectionImpl, it's initialized when ServiceConnection::GetInstance() is first called. All the calls to top-level ml service interfaces will run on this task_runner_. Now they can be called from any sequence. 2. Add BindMachineLearningServiceReceiver, customers can use it to bind their own remote and call ml service interfaces via it. Eventually clients should all use this method, rather than any of existing public methods, which will become deprecated. Bug: chromium:916760 Test: pass the unit_test Change-Id: I7e6e693289cd8d29bbb4bde8a949af7374855139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626950Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Honglin Yu <honglinyu@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#844616}
-
Victor Costan authored
Bug: 1163048 Change-Id: If05d0b84f98fa4969b670f1e80d5bb2d0699925d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627942 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#844615}
-
Peter E Conn authored
This is the first step in a three sided patch: 1. Create empty build targets. 2. Have downstream depend on the empty build targets. 3. Move upstream files into the build targets. Change-Id: I81c636dca974b5561e717ce46e5a83922fddc238 Bug: 1164866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632652Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#844614}
-
Geoff Lang authored
Rename the WebGL2 compute context type to ES3.1 for testing and disallow creating contexts of this type except through explicitly passing version 3.1 to context creation. Add a command decoder fuzzer bit which enables running against ES 3.1 command decoders. Bug: 1166743 Change-Id: Ifee885db02c3617f252900aa0ef4e2c3fc99e811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627885 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#844613}
-
Guillaume Jenkins authored
Extends the IOS.SiriShortcuts.Count histogram by 5 months. The histogram is periodically used to determine the importance of Siri Shortcuts in iOS 14 and whether richer integration would be valuable. Bug: 1167772 Change-Id: Ia9374d20e2bb550f601949fe1b0352cb5e8fd5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636295Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#844612}
-
Vincent Boisselle authored
Tested: Tested the integration with the new synchronous reporter that runs on the UI thread. Important: Do not submit until the new internal renderer lib is rolled out. Change-Id: If9d23ebe16f3e5a72a315e8af547c2a0cc6daf60 Bug: 1117586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367643 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#844611}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/765e4f6f0ef4..8da0f82baf35 2021-01-18 amaiorano@google.com VulkanBenchmarks: improve and clarify resource ownership If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I143dc63d06afe30d944f6e022e706bf6810d39cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635685Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b434291562fd..4ce36a5a3764 2021-01-18 andoli@chromium.org [module.json extensions] Wrap localizable fields in anonymous functions 2021-01-18 andoli@chromium.org [module.json extensions] issues views If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7f1b63f6cdeb22787ce5c9f9db937d3a7ed06238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636475Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/297e1ae19685..679d118787e7 2021-01-18 cwoffenden@gmail.com Fix to build with VS2019 2021-01-18 james@clarkezone.io Add support for building in Flutter Windows UWP configuration If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ia46a02c45d409d059548dc5ca1f0b37f59486700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635691Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/61649cc4962e..73b54fac553a 2021-01-18 rharrison@google.com Deprecate WebGPU SPIRV support (#1167) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I980f0bbd17ff5adb0706e9d78514f749d1c4f246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635234Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I63e121897ba566106fbe95de674667782812c928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633937Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844606}
-
Henrique Ferreiro authored
Code in //chrome is not supposed to be in any namespace, so remove the chromeos namespace from this code. To avoid having to make namespace changes twice, code that will be eventually moved to namespace ash or having its chromeos namespace removed is changed to additionally export its symbols in the newer namespace. This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. The CL skips presubmit to allow "using namespace" declarations that are banned by the style guide. These are temporary, and will be removed after the migration. No-Presubmit: true Bug: 1164001 Change-Id: Ibd43e52cadd6a2ae75e93bb752b1fe3332a2a40c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627314 Commit-Queue: James Cook <jamescook@chromium.org> Owners-Override: James Cook <jamescook@chromium.org> Reviewed-by:
-
Chrome Cunningham authored
This reverts commit 4a8451e4. Reason for revert: The issue wasn't fixed by [1], so lets reinstate the defensive fix. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2626920 Original change's description: > Revert "Defensive fix for crash in MediaWebContentsobserver" > > This reverts commit 79de0d4b. > > Reason for revert: We expect another CL may be the correct fix. https://chromium-review.googlesource.com/c/chromium/src/+/2626920 > > Original change's description: > > Defensive fix for crash in MediaWebContentsobserver > > > > This defensive fix until MediaSession owners return from vacation. > > Reverting is challenging given the long string of CLs. > > > > GetMediaPlayerRemote(player_id) is crashing for failing to find the > > remote with that ID. The stack shows the call coming from > > MediaSessionController, which should have the same lifetime as its > > associated mojo::Remote<media::mojom::MediaPlayer>. So far, I have not > > found how those lifetimes are getting out of sync. > > > > Ownership looks like this (read -> as "owns", MWCO as MediaWebContentsObserver): > > MWCO -> MediaSessionControllersManager -> map<MediaPlayerId, MediaSessionController(s)> > > MWCO -> map<MediaPlayerId, mojo::Remote<media::mojom::MediaPlayer>> > > > > I've combed through all the places where MWCO removes from its map of > > MediaPlayer remotes, and looked for a failure to call > > MediaSessionControllersManger::OnEnd(Id) to remove the associated > > MediaSessionController. There are 3 cases where we remove from the > > map... > > 1. MediaWebContentsObserver::RenderFrameDeleted() > > 2. MediaWebContentsObserver::WebContentsDestroyed() > > 3. media_player_remotes_[player_id].set_disconnect_handler(base::BindOnce(... > > > > The only case where I don't see a call to > > MediaSessionControllersManager is #2. But that shouldn't matter since > > MWCO's destructor is called shortly (synchronously) after > > WebContentsDestroyed(). Its destructor will tear down the > > MediaSessionControllersManager. > > > > The defensive fix does not address the root lifetime issue. It is > > probably the case that the MediaSessionControllers are being leaked. > > > > Bug: 1161551, 1039252 > > Change-Id: I85337eae106d8b56b7d48fc9759702dc579855ca > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607579 > > Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> > > Commit-Queue: Frank Liberato <liberato@chromium.org> > > Reviewed-by: Frank Liberato <liberato@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#839818} > > TBR=dcheng@chromium.org,mlamouri@chromium.org,chcunningham@chromium.org,liberato@chromium.org,beccahughes@chromium.org,mario@igalia.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1161551 > Bug: 1039252 > Change-Id: Id12ba170758a4479342c0eb3b2c64bb1243f34b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632919 > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844208} TBR=dcheng@chromium.org,mlamouri@chromium.org,chcunningham@chromium.org,liberato@chromium.org,beccahughes@chromium.org,mario@igalia.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1161551 Bug: 1039252 Change-Id: I6ff223f67ce4c45bf1a49722f98e0a3dc8eef8bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636377Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#844604}
-
Ben Mason authored
R=rubber-stamper@appspot.gserviceaccount.com Change-Id: Ic3e74a5bed0ef712555c64e6fc06a34f435246d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636055 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844603}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610970273-8e469593c6a515d27af32fe96ea4451632963806.profdata to chrome-mac-master-1610992290-93f2acc9d0a77f7b507d260e7f325f3b3b6e6de9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2cad30a13c231945b34ea0eac29325627a749ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636473Reviewed-by:
-
Maria Kazinova authored
Added tests for standard flows for saving a new credential or updating a password for an already existing credential on a successful password form submission. Change-Id: I448fc801984e9462f212c3ae9a643325343fbd59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627279 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#844601}
-
Nick Burris authored
* Both PaymentRequestContactInfoEditorTest and PaymentRequestShippingAddressEditorTest are flaky on Mac10.11. The flake output[1] shows that OnPersonalDataChanged is called twice, the first call is unexpected and happens before the profile is created, so the test fails. * Local debugging shows that OnPersonalDataChanged is always called twice when the test runs, but only the second call is meant to be observed. * A possible cause is the persistent observer between tests and not removing the observer from the PersonalDataManager. This is a tentative fix to make the observer local to each test and remove it after the event. * Could not repro the flake with this fix after 7 tries on mac_chromium_10.11_rel_ng (note this bot consistently fails for unrelated tests). [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863274960955528464/+/steps/browser_tests_on__none__GPU_on_Mac_on_Mac-10.11/0/logs/Deterministic_failure:_PaymentRequestShippingAddressEditorTest.AsyncData__status_FAILURE_/0 Bug: 1164438 Change-Id: Ia3e3f4f360f0b58a42a7816616aa8c697047dd60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580303Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#844600}
-
Michael Lippautz authored
V8-side change: https://crrev.com/c/2631504 Bug: 1056170 Change-Id: Idd1e1f9d2fcd6804d0d9a010cde83c2fa34a68e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636313Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#844599}
-
Camillo Bruni authored
Calculating the source position for a module request is not free. Even the information is only used by DevTools we currently always calculate the line and column information. V8 only lazily initializes line-end information. This behavior currently causes needless memory and performance overhead. To partially mitigate the issue we only report the detailed source position if there is an active DevTools session. Ideally we would only report the source offset and let all the clients (in this case DevTools) resolve the offset to line and column. Bug: 1162107 Change-Id: I9942cde3bc28e483f1aa2c2b03e8cef2e182d838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622217 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#844598}
-
Aaron Krajeski authored
This only should happen if the paint canvas exists so that it doesn't wipe out the buffer in the situation when the context is lost. Bug: 1131449, 1131137 Change-Id: I355de75bc92e41e8d2224bf4ecd4e9104b94a67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633345 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#844597}
-
Matthias Körber authored
This CL implements the ability to divide a label between a series of fields to address the following scenario in a form: Street Name / House Number: [ ][ ] or First Name & Last Name: [ ][ ] ([ ]: indicates a text input field in a form.) Here, it is anticipated that the label is divided between the two following fields. For this to happen, the label is split by a list of separator characters and words. If the field is followed by a series of unlabeled fields such that the total number of fields exactly matches the non-empty components of the first fields' label after the split, the label is divided. There are additional conditions for the label sharing: * The maximum number of fields to share a label is limited to 3. * The maximum length of the label to be shared is limited to 40. To store the divided labels, a new field |parseable_label_| is added to |AutofillField| which is only supposed to be used in the heuristic type detection. Note, this change only makes the |parseable_label_| available, but does not utilize this yet. This will be subject to a subsequent CL. Change-Id: If098b2aa5a0c3c29a28fff846a4c694c64b837f5 Bug: 1167702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623547Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#844596}
-
Maksim Sisov authored
Our current weston version is 6.0.91 and it's pretty old. The latest stable version is 9.0.0. This patch updates weston and does necessary changes to third_party/weston/BUILD.gn to make it compilable with GN. Bug: 1149588 Change-Id: I8dba452cab131052ae3f85486e1f841fc6304847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632585Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#844595}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610970273-d0f0048b36f7949e3d42c84fb209656aa5017f8c.profdata to chrome-win32-master-1610981979-8f34756a4da6cb018f171d5c6603852477d6e4b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie0a61b32ea432e01dd46225f6d515d4ad6e6fc58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635683Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I7b25122c57d4d12b0ea8cbd9dbca1820323e2c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636257Reviewed-by:
-
Tim van der Lippe authored
Required for https://crrev.com/c/2631114 R=jacktfranklin@chromium.org Bug: 1050549 Change-Id: Ibccfb2e59f218754bc9af8254d58e055b60b758e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636315 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Bug: 1152970 Change-Id: I3eab1ea2535c6f03b041519cf3ccf257488f0318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634924Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#844591}
-
Patrick Monette authored
The single instance is now owned by ChromeBrowserMainExtraPartsPerformanceMonitor but it can still be retrieved by the Get() method. Bug: 1166820 Change-Id: I27300c2fafb9d5ce04d73397dd791c85efd9393b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630368 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#844590}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9c423651c0fb..b434291562fd 2021-01-18 janscheffler@chromium.org [JSDOC2TS]: Migrate animation 2021-01-18 janscheffler@chromium.org [JSDOC2TS]: Migrate event_listeners 2021-01-18 janscheffler@chromium.org [JSDOC2TS]: Migrate layers 2021-01-18 jacktfranklin@chromium.org Inject inspectorStyle.css into the component docs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1158760,chromium:1167724 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I85175a92e7c7f7c16fdf083ef9ab6ae7cb915e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636294Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610970273-10063fdcfa50f030104140b77891927983b7acbd.profdata to chrome-win64-master-1610981979-6557ac3082422cce80dd82b8ef29d8213086e8c3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9481ba633ef90044fcc604db8f42f117d3cdcf0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635684Reviewed-by:
-
Mike Reed authored
Bug: skia:11188 Change-Id: I15ebdc464c12537d7c7a489b5b5ff6cb6b9a38a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633747 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
-
Hans Wennborg authored
This rebuilds the current clang version, bootstrapped with the newer GCC version (see second bug) and libstdc++ version. Also add libstdc++ to isolates which use llvm-symbolizer. Otherwise llvm-symbolizer runs with libstdc++ from the host system rather than the clang package; this happened to work before but not anymore. Bug: 1166977, 1164952 Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Change-Id: I739f94aaa3bdc4a0a1c858d0fbf08d1449d4c0ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633051 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#844586}
-
Daniel Nicoara authored
This allows overriding the user agent if an override is set. NOTE: This does require the caller to override the user agent in order for it to happen. If the caller doesn't override, the default user agent is used. Bug: b:175857659 Test: cast_shell_browsertests Change-Id: I713f01076baabe108b17e1d4934f7dc4259b7139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633705Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#844585}
-
Christoph Schwering authored
Bug: 1007974 Change-Id: Ia50bbdef505695f29b9c924dfa4c62ffbd156be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630806 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#844584}
-
Guillaume Jenkins authored
Adds support for changing the value of the BrowserSignin policy to 0 while the browser is running. Adds a BrowserAgent that monitors the kSigninAllowed pref, which is controlled by the BrowserSignin policy. When kSigninAllowed changes to false, the BrowserAgent dispatches a command to SceneController to dismiss any in-progress sign-in UI and sign the user out. Bug: 1155745 Change-Id: Ifac4c785f73e098e94be8c3df35040ec60b489c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616278Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#844583}
-
