- 09 Apr, 2019 40 commits
-
-
Daniel Rubery authored
Metrics on Stable look good (see bug for details), so set this to enabled by default. Bug: 909778 Change-Id: I8a7cfacfa28a72943be407186bafdd51d5a98137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539014 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649288}
-
Justin DeWitt authored
Change-Id: I4ef7f45a017f24b59dae7dea24f17664c13b3136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555250Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#649287}
-
Kyle Milka authored
Fix NewTabPage.Promos.RequestLatency to properly capture if a request fails or succeeds and differentiate between succeeding with and without a promo present. Add NewTabPage.Promos.ShownTime to log the time from when an NTP is opened to when the promo is inserted into the page. Add NewTabPage.Promos.LinkClicked to log clicks on links embedded in middle-slot promos. Bug: 937505, 934604 Change-Id: I5f4fdb464929485ba38a7a134de4f4f5112e7670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504221Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#649286}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d90aae9a5a6c..82ebbbba15c2 git log d90aae9a5a6c..82ebbbba15c2 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 dneto@google.com README: fix formatting of requiring Python 'future' (#2500) 2019-04-09 stevenperron@google.com Accept OpBitCast in fix storage class. (#2505) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@82ebbbba15c2 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I62b775d43a9deb6d424a516465952f0ffeea4341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559459Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649285}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b4c008bb..825bcc75 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I502cefa1b0f3dd52c9aa9f97012afc30df95687c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560022Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649284}
-
Yuwei Huang authored
This CL implements FtlSignalStrategy similar to XmppSignalStrategy that can be hooked into JingleSessionManager. Bug: 947337 Change-Id: I5ab582c9cb880d99b35c077b376dce5006eb5f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552104 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#649283}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic257eaa06cdd9c7ffd055997fcbe77753d969b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560222Reviewed-by:
-
Dan Beam authored
Screenshots: https://imgur.com/a/7sab9SR R=dpapad@chromium.org BUG=950814 Change-Id: I48ce37a3b7fd369fea9f6d3852017a0c423a32f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559398 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#649281}
-
Elly Fong-Jones authored
This change removes: The enable-spelling-feedback-field-trial flag The enable-spelling-feedback-field-trial switch The spelling-service-feedback-interval-seconds switch The spelling-service-feedback-url switch Bug: None Change-Id: I1afd55697edcb5b2fc35a681d232b47ec5cf7f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560371 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649280}
-
Elly Fong-Jones authored
Bug: None Change-Id: I3bd9367fe4ee2eee7df32f3cc6f3a5539f9b08d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559503 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649279}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6a489f22c71b..d39e2c83b730 git log 6a489f22c71b..d39e2c83b730 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fe4d0c8e..56b0d36f (649101:649210) 2019-04-09 ilnik@webrtc.org Fix undefined behavior in FrameBuffer Created with: gclient setdep -r src/third_party/webrtc@d39e2c83b730 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8b3cfe6247a0d885d67e50c771b89ca4480df7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560221Reviewed-by:
-
Elly Fong-Jones authored
Bug: 937166 Change-Id: Id928f7ef7dfa8fbdee76971870a22fd3d07af2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560375Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649277}
-
Dominik Laskowski authored
DisplayConfigurator clients are responsible for renewing their content protection requests when the display configuration changes, as pending tasks will be killed on reconfiguration in a future CL. This CL invokes the failure callback for requests whose display is invalid. Bug: 929449 Test: display_unittests Change-Id: I74d247b8532a7072d7852903d1ce4c4e5006f1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554004 Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#649276}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3d77140b9d58..4689063021d2 git log 3d77140b9d58..4689063021d2 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 rmhasan@google.com Revert "[Typ] Adds new methods to the API of TestSet and runner.py" Created with: gclient setdep -r src/third_party/catapult@4689063021d2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:951018 TBR=skyostil@chromium.org Change-Id: Ibb09ab7e092b641c618756b3a814c946c532659e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560220Reviewed-by:
-
Becca Hughes authored
Adds two histograms. The first records what metadata was displayed by a notification. The seconds records whether the artwork is present. BUG=949303 Change-Id: Id9c172720503fd0906026ceb141139c70c80e21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552289Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#649274}
-
Caitlin Fischer authored
Bug: 870342 Change-Id: I680e7984cedbd2de073c1197ecf3780e90a180c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542238 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#649273}
-
Kelvin Jiang authored
The code for parsing host permissions is moved to its own function as it will be used in more than one place in a follow up CL which adds a new manifest key for host permissions for Manifest V3. Bug: 62898 Change-Id: I6cbb8bf18048f0abcbdfb57219c87500dee142ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553398 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649272}
-
Scott Violet authored
As part of https://chromium-review.googlesource.com/c/chromium/src/+/1547051 InvalidateLayout() was changed to result in a Layout() at a later date. This means there may be an additional Layout() called. In particular, the app-list now attempts to layout the search-box when closed, which triggers the search-box to go off screen. The fix is to not layout the search box if closed. BUG=949368 TEST=see bug Change-Id: I810ba64a0d44cfedb4f1746697c78b74a303526d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559887Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#649271}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d54b1fcdd915..201b3752e642 git log d54b1fcdd915..201b3752e642 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 bungeman@google.com Build HarfBuzz with multi-thread support. 2019-04-09 mtklein@google.com remove DMJsonWriter::AddTestFailure 2019-04-09 bsalomon@google.com Temporarily make TransferPixelsFromTest read BGRA as RGBA on ES. 2019-04-09 reed@google.com remove def of colorfilter flag 2019-04-09 reed@google.com New factories for SkShaders Created with: gclient setdep -r src/third_party/skia@201b3752e642 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I7bfc816e1626436608b3abe8dcdb60400fec63cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560219Reviewed-by:
-
chrome://flagmanuk authored
- Enabling the local entities feature will also enable the rich entities feature. - This CL also updates some outdated flag descriptions and comments. Bug: 950512 Change-Id: Id9be6a3afa1f40b85fd193f5aec37d0bed73cc21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560148 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#649269}
-
Doug Arnett authored
Adds new Hint Optimization proto field: excluded_experiment_name and adds implementation support to consider an optimization as disabled if it has an excluded_experiment_name that matches the client's kOptimizationHintsExperiments name. This is the preferred approach to supporting an FCP feedback based server blacklist experiment. Bug: 950532 Change-Id: Ifbcbbb5d27b8a4c3f86e3abeeda84c3fd44351cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559258Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#649268}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/572984e9ca2b..de427f13cef6 Created with: gclient setdep -r src-internal@de427f13cef6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I99f8415b73f2579c378f0a0b264b773031a92235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560218Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649267}
-
Yue Ru Sun authored
Bug: 944942 Change-Id: I23b7909483f85a704ca02abd99dcbe96306875be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559752Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#649266}
-
Sammie Quon authored
Test: added test Bug: 950100 Change-Id: Ia05e481a15ac3c42bdfef075b5f1b930f37f3605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559253Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#649265}
-
Corentin Wallez authored
Mac is the first platform where WebGPU is implemented. Enabling use_dawn there makes sure that dawn-related tests are run on the CQ, and allows developers to use Mac Canary to test WebGPU. BUG=chromium:852089 Change-Id: Ic076afbe4d6d9efe97bee7bb56f0d375a35bec5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559319Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#649264}
-
Paul Miller authored
WebView times out while waiting for the seed too frequently, and the current metrics don't explain why. We record Variations.SeedLoadResult and Variations.SeedLoadBlockingTime, but these are rather coarse measurements. Add Variations.SeedLoadSuccessTime, specifically for loading the seed file, and Variations.SeedLoadWouldBlockTime, to measure how long loading would take if not for the timeout. The latter should show how much we'd have to increase the timeout in order to improve the success rate. BUG=936172 Change-Id: Ia3fcd7bfdf394a4e6e4bdd85a2c6682425552194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552487Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#649263}
-
Josh Horwich authored
Current ARC Bluetooth bridge assumes that setting of discoverable timeout implies the adapter should go into discoverable mode. This change tracks the discoverable timeout separately from the actual transition to discoverable mode, and only puts the adapter into discoverable mode when the scan mode is set to discoverable. Bug: 945076 Test: OOBE flow on kevin Change-Id: I5b154af261563bb4d241327c81bb9a819259dcce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559992Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Josh Horwich <jhorwich@chromium.org> Cr-Commit-Position: refs/heads/master@{#649262}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3ed8ba0c5a4b..3d497385cd77 git log 3ed8ba0c5a4b..3d497385cd77 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 bclayton@google.com src/Pipeline: Add SIMD::Pointer 2019-04-09 bclayton@google.com SpirvShader: Implement OpBitFieldInsert 2019-04-09 bclayton@google.com SpirvShader: Implement OpBitFieldSExtract and OpBitFieldUExtract 2019-04-09 bclayton@google.com SpirvShader: Implement OpBitReverse 2019-04-09 bclayton@google.com SpirvShader: Implement OpBitCount 2019-04-09 bclayton@google.com SpirvShader: Implement OpTranspose 2019-04-09 bclayton@google.com SpirvShader: Implement OpOuterProduct 2019-04-09 bclayton@google.com SpirvShader: Add type field to GenericValue Created with: gclient setdep -r src/third_party/swiftshader@3d497385cd77 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126126820,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Icef00374eae583f1b0fa34ec982d0d844b1595ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560174Reviewed-by:
-
Takuto Ikuta authored
This is preparation CL to enable some tests on win10_chromium_x64_rel_ng builder. I don't have mini_installer_tests due to some cases fail. Bug: 950584 Cq-Include-Trybots: luci.chromium.try:win10_chromium_x64_dbg_ng Change-Id: Ic4dcf82a80b6a8a5309a6f8365ebadfd53a6627e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559090 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#649260}
-
May Lippert authored
Build this by setting optimize_webui = false (default is true) What's in this change: - Move os_settings.html to c/b/r/settings/chromeos - Add new os_settings_resources.grd What's still WIP: - Optimized webui build BUG=950007 Change-Id: I752153668877a25a29b315cb82456ed564fd52df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553820Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Tony de Luna authored
This is a reland of 426df2be Original change's description: > Increase coverage for EULA browser tests > > Adds tests for: > * Clicking on "System security settings" button in EULA screen > * Accepting and rejecting usage stats collection > * Clicking on "Learn more" button in EULA screen > > Removes dead code from EulaScreen class. > > Adds a HelpApp extension manifest to use in tests and modifies > HelpAppLauncher class to allow tests to set the extension id. > > Adds a HelpAppTestHelper class to facilitate writing tests that > open HelpApp dialogs. > > Change-Id: Id7841be5bf3faabb067d3a75d3b034bdf0e00e32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554123 > Commit-Queue: Tony De Luna <tonydeluna@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648759} TBR=hashimoto Bug: 947358 Change-Id: I23865c1957f300f55812f3275e830772aa27c32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560146Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Cr-Commit-Position: refs/heads/master@{#649258}
-
Devlin Cronin authored
The `tabs` custom bindings have been entirely replaced by native counterparts. Remove the JS version. Bug: 938998 Change-Id: I7a55e00fb2bf008bcecae6c3b00179040f6aba8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559255Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649257}
-
Mike Wasserman authored
Destroy old embeddings as needed when a new one is requested. Bug: 944699 Test: No flaky window service DCHECKs running files app browser tests. Change-Id: I77d681b222a3e6608354f72dfe2663d7574e2c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559336 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#649256}
-
John Budorick authored
This script is currently only invoked for cronet, but when we switch the perf bots to invoking it for chrome & webview, we can create separate chrome_sizes and webview_sizes scripts to similarly handle the compile targets. Bug: 861983 Change-Id: I98a77cedc40b356be0a07268fcb511e657c73ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560141Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#649255}
-
Mike Reed authored
Bug: skia:8937 Change-Id: I59be04380805a78b7a9e24721e4f4349797735f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558685 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#649254}
-
Sigurdur Asgeirsson authored
This simplifies the property setter interfaces and allows using the process without race on the PM sequence (on Windows). Bug: 910288 Change-Id: I15a5e25a8ee3ab5f08464c819475a298491da11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558573 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#649253}
-
Mehran Mahmoudi authored
This adds a new Apphooks method that instantiates TouchlessMenuCoordinator. Link to the internal CL in the bug. Bug: 930744 Change-Id: I5f7bf87b50633b793980e6dd945952f8b096910b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559018Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#649252}
-
Takumi Fujimoto authored
When mirroring a tab using the Mirroring Service, show an indicator icon on the tabstrip. Bug: 889942 Change-Id: I3e95484e01d84ac94d3afd400703ccc19119bb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550637Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#649251}
-
Daniel Cheng authored
base::Optional::value() already does this; change operator* and operator-> to match, and ensure the behavior is tested. Change-Id: Id686b86d0e68360dea3a92d01206aefde6782a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531498 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#649250}
-
Meilin Wang authored
This change adds a new chromeos switch "redirect-libassistant-logging" to control redirect libassistant logging from /home/chronos/user/log to /var/log/chrome. One scenario to use this switch is in the Tast integration tests, where we want to export libassistant.log into the test result package to help debugging test failure. The previous logging directory /home/chronos/user is an encrypted user home directory, so we need to move the log to /var/log/chrome where Tast collects newly-written data after running all tests. Bug: 950197. Test: local compile and manually test. Change-Id: I4f5124d53d1c55f03738b9823c82dc83c3e3580f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560145 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#649249}
-
