GitLab

This crash is caused because of a divide-by-zero when calculating viewport
units. The zero width visual viewport occurs because the WebView is responsible
for resizing the VisualViewport but the autoresize code resizes the FrameView.
This does eventually lead to resizing the WebView when a layout occurs and
calls though to WebView::layoutUpdated, however, until that happens the layout
will use the 0 value.

This isn't ever a problem since the calculation that's dividing by 0 is used to
adjust the browser controls to the minimum page scale but autoresize isn't ever
used on Android, which is the only platform that uses browser controls and a
non-1 minimum page scale.

BUG=667712

Review-Url: https://codereview.chromium.org/2616893004
Cr-Commit-Position: refs/heads/master@{#442048}

Chrome for iOS crashes in |didCommitNavigation:| with empty Navigation
Manager. It's unclear how app can get into this state and one assumption
is that didStartProvisionalNavigation: does not add a pending navigation
item. This UMA histogram is logged when didStartProvisionalNavigation:
fails to add a pending item.

This histogram is added only to verify the assumption and should be removed
after M46 is released.

BUG=676458

Review-Url: https://codereview.chromium.org/2602133002
Cr-Commit-Position: refs/heads/master@{#442047}

Floating object belongs to its containing block, no matter if it's
under an inline and no matter if the inline is layered, stacked, or
paint invalidation container. This requires us to specially handle
floating objects for LayoutObject::paintingLayer(), LayoutObject::
container(), paint invalidator, etc.

BUG=666553
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2575423003
Cr-Commit-Position: refs/heads/master@{#442046}

Used the attached profile; not the active profile.
Regressed in: https://codereview.chromium.org/2391253004

BUG=675599
TEST=Multi-login cros users get correct shelf prefs.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2613303003
Cr-Commit-Position: refs/heads/master@{#442045}

Review-Url: https://codereview.chromium.org/2614123004
Cr-Commit-Position: refs/heads/master@{#442044}

Empty placeholder text could cause TextPrompt to lose its editing caret

BUG=none

Review-Url: https://codereview.chromium.org/2615933002
Cr-Commit-Position: refs/heads/master@{#442043}

In r441491 I neglected to notice that the lifetime of the
PermissionManager is longer than that of PermissionServiceContext. On
frame changes existing subscriptions should be cleared as they were
before that patch.

PermissionServiceImpl::AddPermissionObserver removes redundant
early return logic checking that
browser_context->GetPermissionManager() is non null.
CreateSubscription already does that.

BUG=677774,678664
TBR=mlamouri@chromium.org

Review-Url: https://codereview.chromium.org/2617863003
Cr-Commit-Position: refs/heads/master@{#442042}

https://skia.googlesource.com/skia.git/+log/8c8cb5bfc547..f55ea6a1deb2

$ git log 8c8cb5bfc..f55ea6a1d --date=short --no-merges --format='%ad %ae %s'
2017-01-06 mtklein Retry "SkRasterPipelineBlitter: support A8"...
2017-01-06 mtklein Revert "Get latest ANGLE as of January 6, 2017"
2017-01-06 djsollen Add a script and documentation for building the Viewer APK.
2017-01-06 brianosman Get latest ANGLE as of January 6, 2017
2017-01-06 robertphillips Get Debugger app compiling again

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=csmartdalton@google.com

Review-Url: https://codereview.chromium.org/2618973002
Cr-Commit-Position: refs/heads/master@{#442041}

Using update-w3c-deps in Chromium 00f04a8e.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7859

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2613313002
Cr-Commit-Position: refs/heads/master@{#442040}

DragImageBuilder is currently instantiating a picture-backed SkImage.
But there is no advantage to that, because DragImage::create() is
immediately rasterizing it (via SkImage::asLegacyBitmap).

Since we're trying to reduce the use of picture-backed images in Blink,
refactor to rasterize upfront.

R=reed@google.com
BUG=skia:6100

Review-Url: https://codereview.chromium.org/2619573002
Cr-Commit-Position: refs/heads/master@{#442039}

Roll Material Font Disk Loader to 93acc021e3034898716028822cb802a3a816be7e

Roll Material Sprited Animation View to c6e16d06bdafd95540c62b3402d9414692fbca81

Roll Material Text Accessibility to 318d5100f2976e59c94643e5dcab69e7a830ee43

TBR=smut

Review-Url: https://codereview.chromium.org/2615613008
Cr-Commit-Position: refs/heads/master@{#442038}

Custom hooks need the ability to return results synchronously and
throw exceptions in the case of bad invocations. Update native
bindings to allow for hooks to do this, and add a number of tests.

BUG=653596

Review-Url: https://codereview.chromium.org/2609553003
Cr-Commit-Position: refs/heads/master@{#442037}

Revert of [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest. (patchset #1 id:1 of https://codereview.chromium.org/2613163002/ )

Reason for revert:
This is crashing on 32-bit devices.

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.CoreFoundation      	0x05b57301 _CFRelease + 1505
1   org.chromium.gtest.generic-unit-test	0x00a3afb7
base::internal::ScopedNSProtocolTraitsRelease(objc_object*) + 39
2   org.chromium.gtest.generic-unit-test	0x00071d47
base::internal::ScopedNSProtocolTraits<NSString*>::Release(NSString*) + 23
3   org.chromium.gtest.generic-unit-test	0x00071d28
base::ScopedTypeRef<NSString*, base::internal::ScopedNSProtocolTraits<NSString*>
>::~ScopedTypeRef() + 40
4   org.chromium.gtest.generic-unit-test	0x00071cf7
base::scoped_nsprotocol<NSString*>::~scoped_nsprotocol() + 23
5   org.chromium.gtest.generic-unit-test	0x00071cd7
base::scoped_nsobject<NSString>::~scoped_nsobject() + 23
6   org.chromium.gtest.generic-unit-test	0x00071567
base::scoped_nsobject<NSString>::~scoped_nsobject() + 23
7   org.chromium.gtest.generic-unit-test	0x000716dd
web::TestJavaScriptDialog::~TestJavaScriptDialog() + 45
8   org.chromium.gtest.generic-unit-test	0x00071707
web::TestJavaScriptDialog::~TestJavaScriptDialog() + 23
9   org.chromium.gtest.generic-unit-test	0x00383724 (anonymous
namespace)::CRWWebControllerPageDialogOpenPolicyTest_AllowConfirmWithTrue_Test::TestBody()
+ 4212
10  org.chromium.gtest.generic-unit-test	0x00adafe7 void
testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test,
void>(testing::Test*, void (testing::Test::*)(), char const*) + 103
11  org.chromium.gtest.generic-unit-test	0x00aae98a void
testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,
void>(testing::Test*, void (testing::Test::*)(), char const*) + 106
12  org.chromium.gtest.generic-unit-test	0x00aae8b6 testing::Test::Run() + 246
13  org.chromium.gtest.generic-unit-test	0x00ab062f testing::TestInfo::Run() +
255
14  org.chromium.gtest.generic-unit-test	0x00ab1d44 testing::TestCase::Run() +
260
15  org.chromium.gtest.generic-unit-test	0x00ac59ce
testing::internal::UnitTestImpl::RunAllTests() + 974
16  org.chromium.gtest.generic-unit-test	0x00add3c7 bool
testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
bool>(testing::internal::UnitTestImpl*, bool
(testing::internal::UnitTestImpl::*)(), char const*) + 103
17  org.chromium.gtest.generic-unit-test	0x00ac559a bool
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
bool>(testing::internal::UnitTestImpl*, bool
(testing::internal::UnitTestImpl::*)(), char const*) + 106
18  org.chromium.gtest.generic-unit-test	0x00ac549f testing::UnitTest::Run() +
335
19  org.chromium.gtest.generic-unit-test	0x00a4bc93 RUN_ALL_TESTS() + 19

Original issue's description:
> [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest.
>
> Use TestJavaScriptDialogPresenter instead of deprecated
> CRWWebUserInterfaceDelegate.
>
> BUG=661445
> TBR=kkhorimoto@chromium.org
>
> Review-Url: https://codereview.chromium.org/2613163002
> Cr-Commit-Position: refs/heads/master@{#441998}
> Committed: https://chromium.googlesource.com/chromium/src/+/e3cb6842bb7d440a8f8259bea661e5b97159fdca

TBR=michaeldo@chromium.org,eugenebut@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661445

Review-Url: https://codereview.chromium.org/2615283002
Cr-Commit-Position: refs/heads/master@{#442036}

BUG=629299
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2569863002
Cr-Commit-Position: refs/heads/master@{#442035}

Using PlatformCanvas (previously) always paid for the cost of the native graphics context (e.g. HDC or CGContext), but there are no callers of gfx::Canvas that use those facilities.

BUG=675977

Review-Url: https://codereview.chromium.org/2615493003
Cr-Commit-Position: refs/heads/master@{#442034}

In this patch:

  1) Query locally installed native Android payment apps.
  2) Show the name and icon of these apps in UI.
  3) Invoke the apps with matching payment method data.
  4) Return the results back to the merchant website.

Intent to implement:

  https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/fsslHD1Gf88/K2KpikS6BwAJ

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPay:
     https://drive.google.com/open?id=0B9_TYWUgXNVFLXpRRkthd1lRbjg
  2) Enable chrome://flags/#android-payment-apps.
  3) Open https://rsolomakhin.github.io/pr/bob/.
  4) Click [Buy] button.

BUG=620173

Review-Url: https://codereview.chromium.org/2604193002
Cr-Commit-Position: refs/heads/master@{#442033}

https://pdfium.googlesource.com/pdfium.git/+log/8d94b6687f27..591ed144f8df

$ git log 8d94b6687..591ed144f --date=short --no-merges --format='%ad %ae %s'
2017-01-06 tsepez Remove CFX_MapPtrToPtr and templates.
2017-01-06 tsepez Remove CFX_MapPtrToPtr in xfa/fgas, part 2

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2617953003
Cr-Commit-Position: refs/heads/master@{#442032}

This CL ensures the correct layout of the launcher
button and the overflow button in the Ash MD shelf
when the shelf is being resized. This can occur in
two situations: when the shelf is being 'stretched'
toward the center of the screen by touch, or
during a shelf hide/show animation.

BUG=668230
TEST=manual

Review-Url: https://codereview.chromium.org/2598223002
Cr-Commit-Position: refs/heads/master@{#442031}

It has only one client.  Inline the implementation (and simplify, as the
optional src_rect param is always present).

BUG=675977
R=reed@google.com,robertphillips@chromium.org
TBR=danakj@chromium.org

Review-Url: https://codereview.chromium.org/2610323004
Cr-Commit-Position: refs/heads/master@{#442030}

And improve comment. Additionally removes some dead includes in
RootWindowController.

BUG=671246
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2610853012
Cr-Commit-Position: refs/heads/master@{#442029}

setNeedsActiveStyleUpdate checks if the document is active before
calling markTreeScopeDirty. This avoids marking shadow root tree scopes
dirty for non-active documents which caused a DCHECK fail in
markTreeScopeDirty.

R=esprehn@chromium.org
BUG=676441

Review-Url: https://codereview.chromium.org/2611053004
Cr-Commit-Position: refs/heads/master@{#442028}

"DownloadExtensionTest.DownloadExtensionTest_FileIcon_Active" is flaky.

BUG=678967
TBR=benjhayden@chromium.org

Review-Url: https://codereview.chromium.org/2616133002
Cr-Commit-Position: refs/heads/master@{#442027}

When we capture an aura window, namely the chrome window itself, we did
not bring it to the front as we did for other windows.

This CL fixes this issue.

BUG=678436

Review-Url: https://codereview.chromium.org/2617613002
Cr-Commit-Position: refs/heads/master@{#442026}

Don't change the current implementation but enable the ability to
adjust the mouse leave event sending dynamically.

BUG=450631

Review-Url: https://codereview.chromium.org/2614163002
Cr-Commit-Position: refs/heads/master@{#442025}

This adds some degree of feature parity with iOS, which also has a
Physical Web omnibox completion and zero-suggest feature.

BUG=663842

Review-Url: https://codereview.chromium.org/2604243002
Cr-Commit-Position: refs/heads/master@{#442024}

(reland with updated Linux .deb shared lib deps)

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
TBR=

Review-Url: https://codereview.chromium.org/2611153002
Cr-Commit-Position: refs/heads/master@{#442023}

These histograms:
- TaskScheduler.TaskLatency.BackgroundPool.BackgroundTaskPriority
- TaskScheduler.TaskLatency.BackgroundPool.UserVisibleTaskPriority
- TaskScheduler.TaskLatency.BackgroundPool.UserBlockingTaskPriority
- TaskScheduler.TaskLatency.BackgroundFileIOPool.BackgroundTaskPriority
- TaskScheduler.TaskLatency.BackgroundFileIOPool.UserVisibleTaskPriority
- TaskScheduler.TaskLatency.BackgroundFileIOPool.UserBlockingTaskPriority
- TaskScheduler.TaskLatency.ForegroundPool.BackgroundTaskPriority
- TaskScheduler.TaskLatency.ForegroundPool.UserVisibleTaskPriority
- TaskScheduler.TaskLatency.ForegroundPool.UserBlockingTaskPriority
- TaskScheduler.TaskLatency.ForegroundFileIOPool.BackgroundTaskPriority
- TaskScheduler.TaskLatency.ForegroundFileIOPool.UserVisibleTaskPriority
- TaskScheduler.TaskLatency.ForegroundFileIOPool.UserBlockingTaskPriority
are replaced with:
- TaskScheduler.TaskLatency.BackgroundTaskPriority
- TaskScheduler.TaskLatency.BackgroundTaskPriority.MayBlock
- TaskScheduler.TaskLatency.UserVisibleTaskPriority
- TaskScheduler.TaskLatency.UserVisibleTaskPriority.MayBlock
- TaskScheduler.TaskLatency.UserBlockingTaskPriority
- TaskScheduler.TaskLatency.UserBlockingTaskPriority.MayBlock

Not having a pool name in task latency histogram names will allow
us to keep track of the latency of each type of task when running
experiments that change the way TaskTraits are mapped to pools.

BUG=553459

Review-Url: https://codereview.chromium.org/2600023002
Cr-Commit-Position: refs/heads/master@{#442022}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fa1926f937dc..24315c519ee9

$ git log fa1926f93..24315c519 --date=short --no-merges --format='%ad %ae %s'
2017-01-06 sullivan Fix stoppage alert counts.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2618983002
Cr-Commit-Position: refs/heads/master@{#442021}

This CL fixes the selection color on Ambiance being darker than it's
supposed to be.

The reason this was broken is the Ambiance theme adds:
*:selected { background-color: alpha(@selected_bg_color, 0.9); }

Since we were always rendering onto a black background, the selection
color was picking up 10% black when it should have been using white
from the GtkEntry.  The solution is simply to render parent widget
backgrounds first.

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2612363004
Cr-Commit-Position: refs/heads/master@{#442020}

This was already disabled on Windows but was seen failing on the following
bot:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ASan%20Tests%20%28sandboxed%29/builds/32603

BUG=678975
TBR=treib@chromium.org

Review-Url: https://codereview.chromium.org/2617133003
Cr-Commit-Position: refs/heads/master@{#442019}

On ChromeOS, kernel notifies Chrome when system gets into low memory
condition. However the low memory calculation misses a parameter
|min_free_kbytes| so the notification comes too late. A kernel fix is
coming to fix the issue.

On Chrome side, TabManager tries to recover memory to normal level. It
mirrors the low memory calculation in kernel to know how many tabs to
kill. So the missing parameter |min_free_kbytes| should be added back.

In the future, try to consolidate the logic in kernel so TabManager
doesn't need to do its own calculation.

BUG=chromium:645512,chrome-os-partner:60498
TEST=cave,peppy,etc.

Review-Url: https://codereview.chromium.org/2618483002
Cr-Commit-Position: refs/heads/master@{#442018}

* Download notifications are grouped together, and Incognito
  is put into its own group.  Summary notifications will come
  in a later patch; Android N doesn't seem to bundle these
  together once they're in their own group, making it hard
  to debug without Android Wear.

* New and existing group name constants are moved into
  NotificationConstants.java.

* Cleans up DownloadNotificationService's constant naming
  schemes to make it clearer what each field does.

BUG=678694,674015

Review-Url: https://codereview.chromium.org/2619433003
Cr-Commit-Position: refs/heads/master@{#442017}

Specifically, this compares making mojo interface calls vs just sending raw IPC::Messages or callbacks.

Review-Url: https://codereview.chromium.org/2608403002
Cr-Commit-Position: refs/heads/master@{#442016}

Crash is reported when doing screen share on hangouts. We found it initiates
at a place where we try to get image for a null icon handle.

This CL fixes the issue.

BUG=676758
TEST=running screen share on hangouts

Review-Url: https://codereview.chromium.org/2617153002
Cr-Commit-Position: refs/heads/master@{#442015}

ASSERT_TRUE stops test execution by retuning, which will not stop the
test if return is called from the block.

BUG=678942

Review-Url: https://codereview.chromium.org/2611283003
Cr-Commit-Position: refs/heads/master@{#442014}

These methods are not implemented by Tab anymore.

BUG=661445

Review-Url: https://codereview.chromium.org/2616843004
Cr-Commit-Position: refs/heads/master@{#442013}

This mode is always enabled now, so we can remove the code for handling
when it is disabled.

BUG=236848
TEST=Tests still pass
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2617893002
Cr-Commit-Position: refs/heads/master@{#442012}

Previously we were going to use a | delimiter and manually construct
storage keys ourselves. The requires us to write logic to reverse it,
and is inefficient when encoding characters that need to be escaped.
The disadvantages are that we always have 4 bytes (instead of 1) of
overhead, and printing the string is less readable.

BUG=675992

Review-Url: https://codereview.chromium.org/2598113002
Cr-Commit-Position: refs/heads/master@{#442011}

Right now, this code will hide the notification at the end of the
timeout, even we switched to showing a different article in the
notification in the meantime. Fixing that will mean switching to
different tags for different articles.

Notifications should also implicitly be hidden if the articles
themselves expire, since the notifier service will watch for their
removal.

BUG=675561

Review-Url: https://codereview.chromium.org/2616893003
Cr-Commit-Position: refs/heads/master@{#442010}

Move the logic for converting from TitledUrlMatch items to
AutocompleteMatch items out of BookmarkProvider into places where it can
be shared with other AutocompleteProviders.

BUG=630769

Review-Url: https://codereview.chromium.org/2583763003
Cr-Commit-Position: refs/heads/master@{#442009}