- 03 Feb, 2017 40 commits
 - 
- 
csashi authored
BUG=664367 Review-Url: https://codereview.chromium.org/2671993004 Cr-Commit-Position: refs/heads/master@{#448082}
 - 
hablich authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f9f5e5b..5dd3abff Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. Speculative roll-back because of CL Suspected of causing webkit failures in Chromium trybots: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/2007 Test (fails due to leak): inspector/sources/debugger-step/debugger-step-into-custom-element-callbacks.html TBR=machenbach@chromium.org,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2672633006 Cr-Commit-Position: refs/heads/master@{#448081}
 - 
mikecase authored
Add helper script to manage uploading data to logdog from the test runner. Also, add new 'links' entry to results.json file which will primarily contain logdog URLs. Review-Url: https://codereview.chromium.org/2664873002 Cr-Commit-Position: refs/heads/master@{#448080}
 - 
wangxianzhu authored
Shape of an outline can be affected by layout/style change of descendants. Previously we assumed that an outline will change when an object having outline is checked for paint invalidation for any reason, which covered all cases of outline changes, but also produced over invalidations, which is especially bad when we move caret paint invalidation into paint invalidation stage: a blinking caret will cause full paint invalidation of the edit box having focus ring. Now tighten the condition. If a box's outline is not affected by descendants, don't do full paint invalidation. TEST=paint/invalidation/outline-*.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2669003002 Cr-Commit-Position: refs/heads/master@{#448079}
 - 
chaopeng authored
This issue is caused by remove hit test element in |Document::updateHoverActiveState| when hit test contains scrollbar. Instead we should replace the hit test element to be scrollbar's parent when hitting a scrollbar. BUG=686678 Review-Url: https://codereview.chromium.org/2668133003 Cr-Commit-Position: refs/heads/master@{#448078}
 - 
aizatsky authored
Changes: https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer/+log/4d737af21c2ce9e8b0655cd9397d83fa7956406c..64bdf915852b7a8c2b81013682d77e003280168b BUG= Review-Url: https://codereview.chromium.org/2669243011 Cr-Commit-Position: refs/heads/master@{#448077}
 - 
tkent authored
This CL has no behaivor changes. BUG=685886 TBR=kochi@chromium.org Review-Url: https://codereview.chromium.org/2675703004 Cr-Commit-Position: refs/heads/master@{#448076}
 - 
poromov authored
Implemented similar to App Launch Splash Screen that is used for Chrome Kiosk. Splash screen is shown immediately after launching ARC++ Kiosk session and destructed when app window is launched. This leads to no UI exposed, except to sign in screen, splash screen and finally app window. User can escape launching of the app by pressing Ctrl+Alt+S during the splash screen. Also fixes bug of restarting app few seconds after launch. BUG=682778,682780, 681111,677310 TEST=Manual, Start ARC++ Kiosk sessions. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2649103006 Cr-Commit-Position: refs/heads/master@{#448075}
 - 
thakis authored
One change in behavior: clang-format wants <> includes to go first (like in Chromium -- but Chromium style recommends a newline between the <> include block and the "" include block), while they used to go to the end in Blink. BUG=688155 Review-Url: https://codereview.chromium.org/2667423006 Cr-Commit-Position: refs/heads/master@{#448074}
 - 
emircan authored
This test checks that canvas capture happens for N times when there are N repaints on <canvas>. Currently 2D and WebGL redraws are added. It will be followed by OffscreenCanvas and transferFromImageBitmap tests. BUG=685796 Review-Url: https://codereview.chromium.org/2658973002 Cr-Commit-Position: refs/heads/master@{#448073}
 - 
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=rkaplow@chromium.org Review-Url: https://codereview.chromium.org/2669923004 Cr-Commit-Position: refs/heads/master@{#448072}
 - 
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/20c5e0b31c76..0a400c91d743 $ git log 20c5e0b31..0a400c91d --date=short --no-merges --format='%ad %ae %s' 2017-02-03 charliea Fix multiple --extra-args for RunEslint 2017-02-03 simonhatch Revert of Dashboard - Remove pre-hook logic from alert.py. (patchset #2 id:240001 of https://codereview.chromium.org/2650683007/ ) 2017-02-03 charliea Fix bug in run_eslint where only the exit code would be printed 2017-02-03 charliea Roll deps for eslint and eslint-plugin-html Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2677673003 Cr-Commit-Position: refs/heads/master@{#448071}
 - 
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/8d3196bdfcf4..e0b048cd1d97 $ git log 8d3196bdf..e0b048cd1 --date=short --no-merges --format='%ad %ae %s' 2017-02-03 mtklein iOS: set up device dirs to be relative 2017-02-03 fmalita Revert "Revert "Don't instantiate shaders with non-invertible local matrix"" Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=halcanary@google.com Review-Url: https://codereview.chromium.org/2677603005 Cr-Commit-Position: refs/heads/master@{#448070}
 - 
beaufort.francois authored
Review-Url: https://codereview.chromium.org/2663193004 Cr-Commit-Position: refs/heads/master@{#448069}
 - 
sammiequon authored
The fingerprint list was previously part of the lock screen subpage. This CL moves it to its own subpage. BUG=672269 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2676763002 Cr-Commit-Position: refs/heads/master@{#448068}
 - 
erikchen authored
The test currently passes, but fails when the feature "Stop creating layout objects for elements inside display: none iframes" is enabled. The root cause is a long-standing fullscreen issue, see minimized repro in crbug.com/676432. The issue is likely going to go away with "migrate fullscreen to use top layer". BUG=676432, 650433, 240576 Review-Url: https://codereview.chromium.org/2662453002 Cr-Commit-Position: refs/heads/master@{#448067}
 - 
thomasanderson authored
This CL fixes a bug where borders would always render 1px x 1px instead of the widget width and height. In addition, it also adds color_utils::GetReadableColor in LoadGtkValues, and uses GtkButton borders instead of GtkEntry borders in headerbars, since they're more common. BUG=132847 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2671713003 Cr-Commit-Position: refs/heads/master@{#448066}
 - 
estade authored
They are already opaque anyway, so this doesn't create any visible change. BUG=none Review-Url: https://codereview.chromium.org/2674813002 Cr-Commit-Position: refs/heads/master@{#448065}
 - 
scheib authored
This labels some recently popular unknown UUIDs for services and characteristics. Many are not 16 bit values, however and remain unknown. They are marked to save effort in attempting to look them up again in the future. Review-Url: https://codereview.chromium.org/2672863004 Cr-Commit-Position: refs/heads/master@{#448064}
 - 
kkhorimoto authored
This CL creates CRWNavigationItemStorage and its associated builder class, which handles persisting serialized NavigationItem state. BUG=454984, 619992 Review-Url: https://codereview.chromium.org/2664113003 Cr-Commit-Position: refs/heads/master@{#448063}
 - 
pfeldman authored
BUG=643400 Review-Url: https://codereview.chromium.org/2675863002 Cr-Commit-Position: refs/heads/master@{#448062}
 - 
jdufault authored
BUG=657139 Review-Url: https://codereview.chromium.org/2618493002 Cr-Commit-Position: refs/heads/master@{#448061}
 - 
pkotwicz authored
BUG=None Review-Url: https://codereview.chromium.org/2670373004 Cr-Commit-Position: refs/heads/master@{#448060}
 - 
fdoray authored
Also, remove NSSCertDatabase::SetSlowTaskRunnerForTest(). This method was used to run slow NSSCertDatabase tasks synchronously in tests. This is no longer useful since tasks posted through the post_task.h API within the scope of a ScopedTaskScheduler run synchronously. The following traits are used to post tasks to TaskScheduler: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Review-Url: https://codereview.chromium.org/2603173002 Cr-Commit-Position: refs/heads/master@{#448059}
 - 
eugenebut authored
This CHECK did not fire. Either because WKNavigation object is nil or because the assumption from crbug.com/676721 was incorrect. BUG=676721 Review-Url: https://codereview.chromium.org/2672673002 Cr-Commit-Position: refs/heads/master@{#448058}
 - 
mfoltz authored
Typemap for ConnectionMessage will come in a separate patch, which should finish the conversion for presentation.mojom, barring further refactorings. BUG=632623 Review-Url: https://codereview.chromium.org/2613153003 Cr-Commit-Position: refs/heads/master@{#448057}
 - 
mlippautz authored
Without this fix we would call into V8 for marking an object when creating a heap snapshot. The intented behavior is to intercept marking and record an edge in the snapshot. We cannot do that right now as we cannot properly intercept marking in GlobalValueMaps and their friends. Note that this is not a regression as we still record the object as live in the snapshot and we also didn't record the edge using object grouping. BUG=chromium:688162 Review-Url: https://codereview.chromium.org/2673693003 Cr-Commit-Position: refs/heads/master@{#448056}
 - 
fdoray authored
Before this CL, installer::GetModulePath() used the version in the VS_VERSION_INFO resource of the current module to construct the path to another module. Unfortunately, reading that resource sometimes crashed. With this CL, installer::GetModulePath() uses the chrome::kChromeVersion constant instead. This contains the same value as the VS_VERSION_INFO resource. BUG=682987 Review-Url: https://codereview.chromium.org/2656443002 Cr-Commit-Position: refs/heads/master@{#448055}
 - 
mariakhomenko authored
Since we are launching to 100%, remove the experiment and all the flags associated with it. BUG=687234 Review-Url: https://codereview.chromium.org/2668553003 Cr-Commit-Position: refs/heads/master@{#448054}
 - 
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/20f00784b850..8d3196bdfcf4 $ git log 20f00784b..8d3196bdf --date=short --no-merges --format='%ad %ae %s' 2017-02-03 reed expose new tight-bounds method on SkPath Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=halcanary@google.com Review-Url: https://codereview.chromium.org/2673923002 Cr-Commit-Position: refs/heads/master@{#448053}
 - 
robertogden authored
Video requests made by XHR should not be proxied. BUG=688069 Review-Url: https://codereview.chromium.org/2676673004 Cr-Commit-Position: refs/heads/master@{#448052}
 - 
mvanouwerkerk authored
* Tile is MostVisitedItem stripped of logic, just a data holder. * TileGroup implements MostVisitedURLsObserver and is extracted from NewTabPageView. * TileGroup.Delegate replaces MostVisitedItemManager and bits of NewTabPageManager. * TileGroupDelegateImpl is extracted from NewTabPageManagerImpl. * TileGroup.Observer allows custom actions to be taken for certain events in TileGroup. * TileGrid and NewTabPageView now have a TileGroup. BUG=677672 Review-Url: https://codereview.chromium.org/2651673010 Cr-Commit-Position: refs/heads/master@{#448051}
 - 
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4dd2f587ffc3..20c5e0b31c76 $ git log 4dd2f587f..20c5e0b31 --date=short --no-merges --format='%ad %ae %s' 2017-02-03 simonhatch Previously alert.py has some pre-hook logic to update associated groups. This involved several sync gets + query, with some potential puts and deletes. The newer implementation strips the pre-hook out in favour of heavily batching async calls when alerts are updated. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2671023002 Cr-Commit-Position: refs/heads/master@{#448050}
 - 
kylechar authored
WindowServerTests need a TYPE_UI message loop to work with libevent for Ozone X11. Luckily, there is already a virtual function in ServiceTest to create a MessageLoop. Other Changes: - Switch mus_ws_unittests to run with Ozone X11 - Add media_service_unittests to CQ trybot instead of FYI trybot. - Delete tests from FYI trybot that run on CQ trybot. BUG=664570 Review-Url: https://codereview.chromium.org/2661163006 Cr-Commit-Position: refs/heads/master@{#448049}
 - 
erikchen authored
Use mach_vm_region_recurse to recurse through all memory regions and emit the relevant stats. BUG=677302 Review-Url: https://codereview.chromium.org/2601193002 Cr-Commit-Position: refs/heads/master@{#448048}
 - 
eugenebut authored
BUG=None Review-Url: https://codereview.chromium.org/2661723002 Cr-Commit-Position: refs/heads/master@{#448047}
 - 
alexclarke authored
Revert of Dont post delayed DoWork for disabled queues. (patchset #9 id:160001 of https://codereview.chromium.org/2572893002/ ) Reason for revert: Speculative revert. Might be causing renderer hangs. Original issue's description: > Dont post delayed DoWork for disabled queues. We could do this for fences too but don't > because that would break the throttling logic which needs to know when the next delayed > task is due to be run. > > BUG=671669 > > Committed: https://crrev.com/cab9842ac55e5b9dab766f11c6e412949d854483 > Cr-Original-Commit-Position: refs/heads/master@{#438962} > Review-Url: https://codereview.chromium.org/2572893002 > Cr-Commit-Position: refs/heads/master@{#447591} > Committed: https://chromium.googlesource.com/chromium/src/+/9a8a61516e750796f74869167bb919a05551d4dd TBR=skyostil@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=671669, 688426, 688422 Review-Url: https://codereview.chromium.org/2674903003 Cr-Commit-Position: refs/heads/master@{#448046}
 - 
qyearsley authored
This changes the rule about testharness test results to make it less conservative and simpler - so that newlines and text in the output are OK, and the test is considered passing as long as there's at least one PASS and no FAIL. BUG=687492 Review-Url: https://codereview.chromium.org/2668973002 Cr-Commit-Position: refs/heads/master@{#448045}
 - 
dpapad authored
The test shouldn't explicitly import load_time_data.js, because in Vulcanized mode it ends up importing that file twice, whcih throws an error. Instead the element being tested should depend on i18n_setup.html in the first place. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2675863003 Cr-Commit-Position: refs/heads/master@{#448044}
 - 
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2676003002 Cr-Commit-Position: refs/heads/master@{#448043}
 
 -