- 11 Sep, 2020 40 commits
-
-
Daniel Classon authored
Adds deep link to the enable SIM lock toggle on the Internet Detail subpage. Bug: 1115732, 1084154 Change-Id: Id3a7c85990e247d7238ba112e0b3e9f13b3c7836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353535 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#806300}
-
Gang Wu authored
Switch to tab is not fully enabled on Android yet, so those metrics still needed. Change-Id: Ib95b879c65f2ed1dc8298710d515ccd5eef449bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405895Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806299}
-
Dirk Pranke authored
This reverts commit 56428611. Reason for revert: Relanding now that the internal failure has been fixed. Original change's description: > Revert "Rename wrapper_scripts for generated_script tests in MB." > > This reverts commit 8700df8a. > > Reason for revert: > > Android builders started failing since this commit: > https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/217957 > > Traceback (most recent call last): > File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 105, in Main > ret = self.args.func() > File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 378, in CmdGen > return self.RunGNGen(vals) > File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 961, in RunGNGen > ret = self.GenerateIsolates(vals, isolate_targets, isolate_map, build_dir) > File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 1075, in GenerateIsolates > command, extra_files = self.GetIsolateCommand(target, vals) > File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 1392, in GetIsolateCommand > 'generated_scripts can no longer customize the script path') > AssertionError: generated_scripts can no longer customize the script path > > > Original change's description: > > Rename wrapper_scripts for generated_script tests in MB. > > > > A few tests (some Android resource_sizes tests, and one Perfetto > > test), were using generated_script tests that were generating > > wrappers that weren't named 'bin/run_$target_name'. > > > > We want all generated_script tests to be using consistent names, so > > this CL changes those targets. > > > > Bug: 816629 > > Change-Id: If447fbee6b33637de4c9711e87379128272285af > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380672 > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Reviewed-by: John Chen <johnchen@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#802694} > > TBR=dpranke@google.com,agrieve@chromium.org,johnchen@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 816629 > Change-Id: I11ec06405105860f01f3b7752df2024615f7badc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384069 > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802984} TBR=dpranke@google.com,agrieve@chromium.org,johnchen@chromium.org,wenbinzhang@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 816629 Change-Id: I44017e48dc94a1af692a66e00bbd3a127b32b382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405793 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#806298}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b686cc006318..970bf5ad2cd0 2020-09-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I9b8d9888b13f79dcc1c2eea909160b13bcb0a830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406472Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806297}
-
Daniel Hosseinian authored
Navigate to the corresponding PDF page when the thumbnail is clicked on. Bug: 652400 Change-Id: I793a14f4b15b30506e2eaa22c87f6bf432ddd583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402180 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#806296}
-
Joshua Berenhaus authored
Adding the comma in so the message looks right! Change-Id: I2b2ee8da289df56914e986f36548f1fa03bfdb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406672 Auto-Submit: Joshua Berenhaus <joshber@microsoft.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#806295}
-
Josh Nohle authored
Create a default device name of the form <profile name>'s <device model>. The profile name is retrieved in the same way as profile_info_handler.cc [1]. So, the name should be consistent with the one shown in Settings > "You and Google". The device model is set to model name from SysInfo HardwareInfo. If the model name is empty, a variation of "Chromebook" is used for Chrome OS and "device" for other platforms. [1]https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/webui/settings/profile_info_handler.cc;l=132-168;drc=b93f16ad9f7a986d964033bbd539a8eec677bfbf Bug: b/154863679, 1127017 Change-Id: I219cc3965ae0180f66c3953f0a9213dc5c55a1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298169 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#806294}
-
Avi Drissman authored
Use a plugin child process, which doesn't have library validation. This way, loading the nss3 dylib into the process will work. Bug: 1111241 Change-Id: I8c9c6c0c77ac345bfb73e1574bccebc0db9dd791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404487Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#806293}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9f91f3564a76..e53ee0c93173 2020-09-11 jleconte@google.com Fix WebRTC Perf Test gtest_filter. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1123318 Tbr: skyostil@google.com Change-Id: I06b98fbdc0de8f154abadd67a9151c60e8ccac46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406354Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806292}
-
Daniel Cheng authored
This logic was originally implemented to allow the webrequest API to block navigations without triggering an error page inside a <webview> guest (see https://crbug.com/284741). However, the current implementation allows the renderer to ignore a call to `CommitFailedNavigation()`. To make it easier to ensure that browser and renderer state remain in sync, handle this suppression on the browser side instead. Bug: 284741, 1117282 Change-Id: I63c835953ca3b309c6a0cb8e1f9f889906784db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393253 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#806291}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1599825590-2ad7f8d1aefd3309725ac2db96fd5021cdb15d15.profdata to chrome-linux-master-1599847371-251c84d55c3e42dd8994b61e3cd668b3bbeb13e1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: Iee21cda911fabb7f4f52a8d73cf0b0b7ee836e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405785Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806290}
-
Ayu Ishii authored
Attributes cannot be of sequence type. This change updates CookieChangeEvent to use FrozenArray instead of sequence and also updates to use SaveSameObject for the changed/deleted object. Details of this discussion can be found at https://github.com/WICG/cookie-store/issues/156 Bug: 1124841, 1127363 Change-Id: I1fb6ab7c50aff6d892013bf4c971833b9ddee9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401513 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#806289}
-
Thomas Tellier authored
This reverts commit 253d9157. Reason for revert: Need to implement the feature Original change's description: > Revert "Add a pop-up for Chrome OS secondary login screen" > > This reverts commit 3e085ec3. > > Reason for revert: Test is crashing with a segmentation fault > > Original change's description: > > Add a pop-up for Chrome OS secondary login screen > > > > Bug: 1066489 > > Change-Id: I5af5d0ab745176572dfa01cb02e6d45ac1b27c99 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303429 > > Commit-Queue: Thomas Tellier <tellier@google.com> > > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > > Reviewed-by: Thomas Tellier <tellier@google.com> > > Cr-Commit-Position: refs/heads/master@{#805844} > > TBR=antrim@chromium.org,raleksandrov@google.com,tellier@google.com > > Change-Id: I35550da66bba011cb35b9e50d38b4b02b572ce29 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1066489 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404061 > Reviewed-by: K. Moon <kmoon@chromium.org> > Commit-Queue: K. Moon <kmoon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805939} TBR=antrim@chromium.org,raleksandrov@google.com,kmoon@chromium.org,tellier@google.com # Not skipping CQ checks because this is a reland. Bug: 1066489 Change-Id: Id1eebd7da875a5c12f5f4821875b4590f7e76331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404350Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Thomas Tellier <tellier@google.com> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#806288}
-
Maria Kazinova authored
Deleting the API and its tests, as the kCredentialManager feature was never launched and there is no plan to launch it in the future. Bug: 435048 Change-Id: Id295c436a8583d50aaa7cb727555f4888fd69a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401042Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#806287}
-
Noah Rose Ledesma authored
This change adds several metrics for the device picker in the Global Media Controls dialog: Media.GlobalMediaControls.NumberOfAvailableAudioDevices tracks the number of audio devices displayed in the device picker UI each time it is opened. Media.GlobalMediaControls.DeviceSelectorAvailable tracks if the device selector was available. Media.GlobalMediaControls.DeviceSelectorOpened tracks if the device selector was opened. For details see the entries in histograms.xml Bug: 1096257 Change-Id: Ia67b919ee63330239ed5e4cd38c694142896417d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393256 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/master@{#806286}
-
Haiyang Pan authored
And renamed to android-marshmallow-x86-rel-non-cq Most of the test suites that run on android-marshmallow-x86-rel will be moved to non-cq (Will be done in a separate CL). So that we can enable android-marshmallow-x86-rel on CQ, starting with just one test suite. And gradually migrate test suites from non-cq to CQ. Also switch the tests to run on 4-cores, except for network_service_out_of_process_chrome_public_test_apk Bug: 997376, 1127110 Change-Id: I5788e61ddde1623672c7bfc8e2b521856e01a03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405534Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#806285}
-
Maksim Sisov authored
if use_wayland_gbm set to false, Chromium doesn't use dmabuf path. However, it still gets supported buffer formats that it got from either wl_drm or zwp_linux_dmabuf protocols. This is incorrect. Instead, it must report all the buffer formats as "software only" (can be checked in the about://gpu page). Bug: 578890 Change-Id: I44234af9b1b5b8960b2f698f815a62d95922660b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404922 Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#806284}
-
Chris Hamilton authored
BUG=1096617 Change-Id: I6fe9a8c8597520bc05f2e74d2d8ce969436ce69c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399766Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#806283}
-
Allen Bauer authored
Bug: 938501 Change-Id: I39d9693833ac8f2c1ffb2f3c307edb303382bf39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404948 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#806282}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: If5e48dc41abef9f2d12bd1f711d759a477f44d16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405902Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#806281}
-
Tibor Goldschwendt authored
That way we can assign both local and external URLs and ntp-img will figure out whether to load the image directly or employ the chrome://image source. + Use this new functionality for the middle slot promo. Change-Id: I4855023ff5bdb946b14d2f2f2bf46f1bc29d2e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404153Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#806280}
-
Natasha Lee authored
Before Dawn implemented DeviceLostCallback, we were using UncapturedErrorCallback to handle device lost errors. Bug: dawn:68 Change-Id: I6d603f2d54f34d7e25c6f12fe4ee1098c5da53b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363387 Commit-Queue: Natasha Lee <natlee@microsoft.com> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#806279}
-
Joon Ahn authored
Fixed:805766 Test:autoninja -C out/mychrome components_tests && ./out/mychrome components_tests TESTED=autoninja -C out_hatch/Release chrome && deploy_chrome --build-dir=out_hatch/Release --device=$DUT Verified by setting a feature with param in chrome://flags on hatch Change-Id: I83f8c81237c3db50a4f23bf5b17e73363bf10504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401336 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#806278}
-
zhaoyangli authored
Changed Xcode version in config and OS requirement. Bug: 1126929 Change-Id: Iece9d00be25f06df812ccfa9a82bdb4df7f85687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405742Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#806277}
-
Kyle Horimoto authored
Bug: 1106937 Change-Id: I46b2a08379bb3996de0cc61b909d3e7abe64f7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405904 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#806276}
-
Dominic Farolino authored
R=mheikal@google.com Bug: N/A Change-Id: I747efdce3e2b9f76defb6bd97e77351d1d13be7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406179Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#806275}
-
Chris Lu authored
Update it to match Google Finch config name Bug: 790886 Change-Id: I1bf4e02619cdf334dcefe5ac620cbd321eb3f1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398967 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#806274}
-
Vadim Shtayura authored
Based on pools.cfg in infradata/config. Not really used by anything yet. One complication is per-milestone projects: we "fork" builders, but not Swarming pools. So some chunks of configuration should be defined only on the main branch. R=gbeaty@chromium.org, estaab@chromium.org, iannucci@chromium.org BUG=1123142 Change-Id: I4850e1be0efc6215a0bc58f3ad707dbdc3a1e473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401814Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Cr-Commit-Position: refs/heads/master@{#806273}
-
Sinan Sahin authored
Bug: 1067365 Change-Id: If721820718fec110e2e606a5fde4a9a3a2af7038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382963Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#806272}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ab5010493df3..30d3022f727a 2020-09-11 ethannicholas@google.com Moved SkSL type into IRNode, now accessed via a method 2020-09-11 johnstiles@google.com Reland "Add InlineCandidateAnalyzer to locate candidate functions for inlining." 2020-09-11 johnstiles@google.com Pass non-temporary Program::Settings to convertProgram. 2020-09-11 egdaniel@google.com Reduce the amount of forced dedicated allocations we do in Vulkan. 2020-09-11 jmadill@chromium.org Port to ANGLE's GN files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1127358 Tbr: reed@google.com Change-Id: Ic95f7d99034bf209bc1b351fed5eb03376d79071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406330Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806271}
-
Xiaohui Chen authored
Previously ambient window is sharing the same window container as the lock screen. It is behind the shelf buttons, e.g. logout, shutdown. We need to be able to hide those button according to UX. Additionally using a separate window container from lockscreen makes it possible in the future to show Ambient mode before lockscreen window is created to facilitate a better transition. Bug: b:162596816 Test: run existing unit tests and manual test. Change-Id: I21390685f4408e0a6c85d33e1c04db9fb10c9ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402291Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#806270}
-
sczs authored
Bug: 1127014, 1085419 Change-Id: Ia87c235ca32e60396e721f1821eafc78f44c9ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404958Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#806269}
-
Matt Menke authored
And always enable it. We've decided that we want to have the feature enabled when we launch network partitioning, so there's no reason to keep around the path where it's disabled. Bug: 1126059 Change-Id: Ie02a4a52544e63319fdcae81dce6e9d4aea27684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398903Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#806268}
-
Natalie Chouinard authored
After the AndroidFontLookup implementation was switched to using a PostTask to fetch the font, and an Executor to run the callback, these tests were only passing because the callback (checking assertions) wasn't being run at all in tests. This fixes that issue by initializing native to ensure PostTasks are run, and adding a runLoop to run the Executor tasks (the latter mirrors the Mojo ExecutorFactoryTest). Bug: 1111148 Change-Id: I71eda8b1ab20ed2aabf8810303a6435b5007aaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404073Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#806267}
-
Mike Wasserman authored
This reverts commit 4986fdfd. Reason for revert: Chrome Apps regression: crbug.com/1125403 and crbug.com/1125858 Original change's description: > cros: V2 apps open on the same display as GetDisplayForNewWindows. > > This emulates behaviour for browser and V1 apps [1]. Adjusts bounds on > app creation if the new window display is different than the saved > bounds. > > [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/window_sizer/window_sizer.cc;drc=2f11470d7ad8963a9add116df64d2edd1b85d3a4;l=274?originalUrl=https:%2F%2Fcs.chromium.org%2F > > Test: browser_tests ChromeNativeAppWindowViewsAuraAshBrowserTest.OpenOnTheCorrectDisplay > Bug: 1080390 > Change-Id: I5a705a0875ae8a1fb35d1f1a92613c3f38bef7d9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189575 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: calamity <calamity@chromium.org> > Reviewed-by: Ben Wells <benwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769381} TBR=xiyuan@chromium.org,benwells@chromium.org,calamity@chromium.org,sammiequon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1080390 Change-Id: Ie0962dd5ebae9c2837d2a74503583d9c48748882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405618Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#806266}
-
Becca Hughes authored
Change-Id: Ic6254af767545e783605a6f0cbe853601fcec236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405750Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#806265}
-
Miguel Casas authored
This CL follows crrev.com/c/2393629 by batching up SubmitBuffer calls in the H264 decode accelerator. This is verified via chrome:tracing and codepen.io/miguelao/full/MMxGJw that plays 4 1280x546 H.264 videos at the same time. Tracing is captured for a few seconds, basically with this patch we have 2 SubmitBuffers() calls adding up to ~0.461ms/frame versus ToT individual SubmitBuffer() calls (4 of them) ~0.504ms in total -- which gives an aggregate of about ~40us improvement, or savings of about ~10%. Since decoding itself takes about the 0.390ms/frame, savings are OKish, so let's take them. This is all on my BSW device (reks), Improvements are of course extremely small, the advantages of this CL are in reducing lock/unlock churn and associated contention. This benefit grows with the amount of decodes (e.g. Meet grid scenarios). Bug: b/166646505 Change-Id: Id51bb6db39e4f7b9d67760f86b8f8963f20c2b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405586Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#806264}
-
Morten Stenshorne authored
If the inline-size is deduced from the min/max size somehow (e.g. shrink-to-fit), a font size change may change the intrinsic (min/max) sizes, which in turn may affect the inline-size of the element. Additionally, we need to make sure that we actually DO recalculate the intrinsic size of all elements affected by a font size change. Note that this bug also exists in the legacy layout engine, but this CL doesn't address that. Bug: 1125109 Change-Id: Ibb33648fcb9bc6c9061d95e42b7f3c4db7b1bd90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404847Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#806263}
-
Elly Fong-Jones authored
There are three: * The app dialog view, which is now always window-modal * The Aura eye dropper dialog, which is now always window-modal * The generic message box dialog, which loses support for system modal on non-ChromeOS and will DCHECK if asked to be system modal. Bug: 1121132 Change-Id: I7e10431db9a0001adb8d081bb19b974a46046fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398943 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#806262}
-
Ben Pastene authored
The test is failing on CrOS and blocking LKGM updates. This disables it while we figure out what regressed to allow for LKGM updates. Bug: 1127052 Change-Id: Ie44baff4b78e495c1af42b4f01e4b6bb6b16071d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404749 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Mitsuru Oshima (Slow: gardener) <oshima@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#806261}
-