- 08 Jun, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4e7a485eecb16506bb357e6f80ffbb8c60a96988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236467Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776260}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Id795b9748949b12ae08fe1f2ede7c285a756daad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232896Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#776259}
-
Henrique Ferreiro authored
This CL also removes WebString::FromUTF16(NullableString16) and WebString::ToNullableString16(WebString) which, after this change, have no users. Bug: 604860, 1039255 Change-Id: I26e1fe104aa208b2423c0d30112e5af0cb32ea71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232860Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#776258}
-
Mounir Lamouri authored
Bug: 1088918 Change-Id: I18b179b6da4b10a021386d3afb35713de4b5636e Fixes: 1088918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232765Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#776257}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/60bf7bf3310f..93f2980477a5 2020-06-08 tmathmeyer@chromium.org Remove little chevron arrows in favor of the general TabbedPane layout If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:794255 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I70bc1f07d67d8aa09d7d6852255f1f4b938a2c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236322Reviewed-by:
-
Mohamed Amir Yosef authored
Before this CL: the color of the arrow is determined once and doesn't adapt to changes in the theme. After this CL: the arrow color always matches the text color Here is a screenshot for the dark mode on Linux. Before: https://screenshot.googleplex.com/6yK0cmkBQxJ After: https://screenshot.googleplex.com/ctW6pGELa1Y Bug: 1044038 Change-Id: I62a056deb31d4ac87cfa85469fee868210519fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232858 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#776255}
-
Tom Anderson authored
Background: as part of bug 1066670, we're removing usage of Xlib and switching to our own X11 protocol bindings. In Xlib, constants are usually defined as macros: #define GenericEvent 35 Our approach is different: struct GeGenericEvent { static constexpr uint8_t opcode = 35; }; There are many instances of the following snippet: DCHECK_EQ(event.type, GenericEvent); which now need to be changed to: DCHECK_EQ(event.type, GeGenericEvent::opcode); However, this causes a subtle link failure: ld.lld: error: undefined symbol: x11::GeGenericEvent::opcode This is because CheckEqImpl's parameters are passed as const&, but the static constexpr value doesn't have an address. Alternatives considered: * Change uint8_t to int to get the existing int overload of CheckEqImpl. We want to avoid this because using int would imply there are more opcodes than can actually exist in the protocol. * Change *::opcode to be non-constexpr static, defined in source file. This won't work because it's common to switch() over the opcode, and that won't work unless the cases are constexpr values. * Create a separate source file that provides redundant definitions of these constants. This is a hack. This CL extends the existing int-int overload meant to solve this issue to any fundamental type. BUG=1066670 R=thestig Change-Id: If62c845cf590cca484e13cf482a67ef4cdd51cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236220 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#776254}
-
Xinghui Lu authored
Bug: 1077352 Change-Id: Ia70455d12f05f6cbd4ba90a5de74f04a98c79fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231256 Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776253}
-
Takumi Fujimoto authored
Add media_router::mojom::Logger, used by Media Router's native components to record event logs. Add LoggerImpl implementing the Mojo interface, which will be owned by MediaRouterMojoImpl in a later patch. Bug: 687380, b/154271334 Change-Id: Idefe67682a3c850ee99ab456083a489e4a400c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079535Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#776252}
-
Josh Simmons authored
Uma has also been added to track the result of querying a specific source for a hint. This also removes the former definition of PerformanceClassForURL. PerformanceClassForURL wasn't called anywhere, so PerformanceClassForURLInternal has been renamed and better documented. Bug:1087123 Change-Id: Iac30bcece87f282f826bbf2eff6b19dd37d0d764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225831 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#776251}
-
John Lee authored
Bug: 1000989 Change-Id: I99eeb765ce372deef7ba03c57edf45f0f14479ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233489 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#776250}
-
Ayu Ishii authored
This change changes GetCookieList to return a list of a new struct called CookieWithAccessResult instead of CookieWithStatus which includes CookieEffectiveSameSite data as well as CookieInclusionStatus but makes it available for extensibility to include other data from cookie access time as well. The struct looks as follows. struct CookieAccessResult { CookieEffectiveSameSite effective_same_site; CookieInclusionStatus status; } struct CookieWithAccessResult { CanonicalCookie cookie; CookieAccessResult access_result; }; Bug: 1065010 Change-Id: I7ac01827fff511b422f5ff5a712d50d5a3885d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212697Reviewed-by:Mike West <mkwst@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#776249}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ic835373e7de291a5685192d9bace593dbaaff1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235946Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776248}
-
Nazih Almalki authored
Bug: 1060058 Bug: 1087865 Bug: 1091977 Bug: 1091555 Bug: 1091454 Bug: 1091453 Bug: 1091076 Change-Id: I1e6a67c7704b0df984df8fb18af7f236fa6e4ffc Bug: 1087865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235653Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Nazih Almalki <nalmalki@google.com> Cr-Commit-Position: refs/heads/master@{#776247}
-
Liquan (Max) Gu authored
Before: * When the payment app security was neutral, the security icon was empty. * The initial security icon was empty. * The initial content description of the security icon was empty. After: * When the payment app security is neutral, the security icon shows "R.drawable.omnibox_info". * The initial security icon is "R.drawable.omnibox_info". * The initial content description of the security icon is "Your connection to this site is not secure. Site information" Change: * Change the initial security icon and its content description to align with PageInfo's. * Change the security-neutral security icon to align with omnibox's and CCT PH's. Bug: 1091334 Change-Id: If9fbcba624da4375b5ddb3100eb2a6a1363d6205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231705 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#776246}
-
Shakti Sahu authored
We cache an old object in the DownloadProgressInfoBar native while we keep updating the java object. When activity restarts after a theme change, we show the UI from the old object in native. This CL updates the java object as well to fix it. Bug: 1092000 Change-Id: Ic5f12e5e38db2f20a3dd2ce5ec6ce061f88bfa20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233828Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776245}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cab169a237ea..1e6bb06ceaf3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xidachen@google.com,dimich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1091337,chromium:1092525 Tbr: xidachen@google.com,dimich@google.com Change-Id: Ice162ce12852e5fa4c57b85ec44d4d151a7e587f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236318Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776244}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6370cd416c74..ac68fc0764f5 2020-06-08 lalitm@google.com Merge "ui: fix recording on P" 2020-06-08 lalitm@google.com Merge "docs: add type and id columns to all root tables" 2020-06-08 hjd@google.com Merge "tools/tmux forward ANDROID_ADB_SERVER_PORT" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3ebaea5c85ba4513cc8da68a6d5d53e5e6314367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236319Reviewed-by:
-
Yichen Zhou authored
Add animation smoothness metrics for fade-in/fade-out animation of tab hover card. It uses ThroughputTracker to track throughput and calculate smoothness. Bug: 1060816 Change-Id: I5e9c15a9a5b4320214c1cc27a1deae9230466ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231583Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yichen Zhou <yichenz@chromium.org> Cr-Commit-Position: refs/heads/master@{#776242}
-
David Tseng authored
R=dmazzoni@chromium.org, rni@google.com Change-Id: Id876d13aa592850ea5a771cfe66da80aafbe6d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230932 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776241}
-
James Cook authored
Better explain the feature, and note that the code may be enabled by a field trial even though it defaults to disabled. Bug: none Change-Id: I6e596f1535f86128df67a8f38f715f0140208258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236494 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
Mei Liang authored
This CL does the following: * Updates the GTS to show a next TabSuggestion, if any, immediately after dismissing the shown TabSuggestion. * Invalidates all TabSuggestions after the shown TabSuggestion is accepted. * Updates the BaselineTabSuggestionProvider for testing. * Adds a debug variation to chrome:flags for showing grouping and closing suggestion immediately. Change-Id: I2a6b5b498f7b8ecdf69e0cdb787360b077efc40c Bug: 1076538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212547 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776239}
-
Andrew Xu authored
Creating hotseat bounds animation which is triggered by hotseat state change requires the hotseat state transition type. However, the current method to calculate the transition type in HotseatWidget::SetState is hard to reset the stored transition type after the transition completes. In this CL, a scoped class is introduced to set/reset the transition type stored in HotseatWidget. Note that the only place to set the hotseat state then update the hotseat bounds is ShelfLayoutManager::SetState(). It ensures the correctness of this CL. Bug: 1024911 Change-Id: Ie68d182dbf105c4376898e7c0269a620194e6e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235980Reviewed-by:
-
Pavel Yatsuk authored
This reverts commit ce14e58b. Reason for revert: The CL causes failures on Cronet KitKat builders https://ci.chromium.org/p/chromium/builders/ci/android-cronet-kitkat-arm-rel The error code is INSTALL_FAILED_OLDER_SDK https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878029920810653312/+/steps/cronet_smoketests_missing_native_library_instrumentation_apk_on_Android_device_Nexus_5/0/stdout Original change's description: > Android: Increase default_min_sdk_version 19 -> 21 > > Cronet is the only project that requires a lower minSdkVersion. To > continue supporting building of their targets, this change enabled > proguard on all of their apks in order to have all files desugared at > the proper minApiVersion. > > This change should speed up compiles somewhat, as it removes the need to > generate main-dex-lists for legacy multidex purposes. > > Bug: 1091919 > Change-Id: Ifd8089bbf4965b55a13dea11464ccda979fd5028 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233581 > Reviewed-by: Peter Wen <wnwen@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776166} TBR=wnwen@chromium.org,agrieve@chromium.org Change-Id: Id4b92d5549d13de9684f542ce646993c3833795f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1091919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236715Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#776237}
-
Zach Trudo authored
The messages defined in record.proto will need to be available to the server and the future daemon. Moving to the appropriate location. Also - reporting_messaging_layer is far too long for a namespace. Renamed to simply reporting. :-D Bug: chromium:1078512 Change-Id: Idd14c07e548e0b937c2a64b4ff4a4ae771e6cc7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235991 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#776236}
-
Brian Sheedy authored
Updates the expectations for WebGL2 shaderoperation tests on Windows Intel machines: 1. Applies the skip to both UHD 630 and HD 630 machines - previously it only applied to UHD 630 machines. 2. Removes the d3d11 tag, as this can apparently also happen when not using d3d11. TBR=ynovikov@chromium.org Bug: 1085222 Change-Id: Ifde543f4bc069a4d5116a9656dc39326fa973ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236456Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#776235}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 624f611c. With Chromium commits locally applied on WPT: 9c24e63c "Check for first frame in CreateImageBitmap" 101c532f "[css-lists] Fix list image gradient with dynamic zoom" a8a28083 "[Security][Coop] Browsing context switch reporting WPT" ba95aee6 "Move where we set the root forced background-color" 9703ac7b "Portals: XFO sameorigin now traverses the portal hierarchy." 45e0194e "Revert "Disable tests for landing a WebRTC name change" and rebase changed tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I76f36c72383bf2ac0dc062ad9289bb2f167eed13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236334Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776234}
-
Eric Roman authored
Bug: 1089015 Change-Id: Ic68dc830c40deda61544ae772d22e1d10662e87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231094Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
-
David Black authored
Previously, the unittest could attempt to advance the mock clock by a negative amount which is disallowed by the framework. Bug: 1092026 Change-Id: I47ce0ecc69b4391cff08154138c001bf7062f69a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236214Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#776232}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fee069880d16..7b1355e5093a 2020-06-08 johnstiles@google.com Revert "Reland "Move JavaInputStreamAdaptor into third_party and add a LICENSE file."" 2020-06-08 adlai@google.com Clean up SkShaper_coretext.cpp & SkCGBase.h 2020-06-08 jlavrova@google.com Dealing with another crash when some fonts are unresolved 2020-06-08 johnstiles@google.com Update Gr(Circle|Ellipse)Effect to use a child FP. 2020-06-08 herb@google.com move painter to GrRenderTargetContext from TextTarget If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I4802653157bfb065da6958f56340584006f9eda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236376Reviewed-by:
-
Dmitry Titov authored
TBR=altimin@chromium.org Bug: 1090223 Change-Id: I5a0641d62d9bddb0b9b060bcf426fa45dc2bf637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236050 Commit-Queue: Dmitry Titov <dimich@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#776230}
-
Mehran Mahmoudi authored
This CL implements the integration needed for paint previews to show on a cold start. This feature is guarded behind an experimental flag that is only intended for the Canary/Dev channels. PTAL at the design doc for more context: http://go/fdt-tab-integration Bug: 1064011 Change-Id: I91bd682f32eccb8e22b27ec026f04079fd6fc250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231179Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#776229}
-
Andy Paicu authored
https://testtracker.googleplex.com/testplans/details/33023?revision=10 The link above describes the currently existing manual tests related to the permission prompts. As part of the review process, I've implemented the tests from section 1.3. Bug: 1063164 Change-Id: I30b1268fe010ee450afe440ac610cdc6fa3b9fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218169 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#776228}
-
Will Harris authored
This is a critical stability metric. Also add second owner. BUG=1053151 Change-Id: Id365c7b882542d5be37b57e53c5fbc25d8e54149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236063Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#776227}
-
Jonah Chin authored
This change introduces GetRasterSkImage() for use when an image's pixels are needed in CPU memory for raster. The goal is to remove GetSkImage() from PaintImage since, when texture backed, this API will incur the cost of a GPU to CPU readback. GetRasterSkImage() makes it clear that this readback may happen. Follow up changes will work on converting the remaining callers of GetSkImage() to other APIs. For details about this overall PaintImage effort, see crbug.com/1023259 This is being done as part of the OOPR-Canvas2D project. For more info about that project see the tracking bug here: crbug.com/1018894 Bug: 1031050 Change-Id: Iae075b4c5d936ac7c6f3db578e6ef5c47b99ffd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226922Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#776226}
-
Mikel Astiz authored
It's rarely inspected and after having deleted the Directory-based logic the remaining codepaths are either dead, very unlikely or covered by other UMA metrics. Change-Id: I3b266263a1c974738b6c1647115ca845733c825a Bug: 1089547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231123Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#776225}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I81353282f2c9e22d324b7a6a783ab569c36d765b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236240Reviewed-by:
-
Sergey Ulanov authored
Tests started flaking around the 0.20200605.1.1 roll due to a pkgsvr issue. TBR=wez@chromium.org Bug: 1092054 Change-Id: I09f7c9c16c7d2f44324af5383f3131d37a3ddccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235839 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#776223}
-
Adam Langley authored
This is a test-only, non-semantic change that renames a parameter in the attestation tests to better reflect what it's used for in reality. (This is cut out of enterprint-attestation support to reduce diff noise.) Change-Id: If9cea22bc88085e7318c61c8ee40bfd358f67d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236229 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#776222}
-
Victor Hugo Vianna Silva authored
This CL is simply the analogous of crrev.com/c/2218055 for password exceptions. This means it changes the signature of this helper function to: a) make it easier to write tests in a multi-store scenario; b) allow the deduplication functionality to be introduced without breaking the existing tests. Besides that, the CL fixes a comment typo in validatePasswordList() and also exposes chrome.passwordsPrivate.removeExceptions() API in the PasswordManagerProxy, so it can later be used at PasswordsSection when exceptions are deduplicated. TBR=fhorschig@chromium.org Bug: 1049141 Change-Id: I3a501283c964904b981a6e2463336f4f147816bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234755 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
