- 29 Mar, 2018 40 commits
-
-
Bruce Dawson authored
All unchecked code will contain errors and apparently, due to quirks of VC++ template compilation, emulated by clang-cl, the ThreadSpecific<T> destructor was never *really* compiled. It referenced two functions and one variable and only one of these three things actually existed. This was reported by Microsoft who use chromium as a compiler torture test. Bug: 825352 Change-Id: I5dd1868acda760ef33dde518d72e3d7694fad9a8 Reviewed-on: https://chromium-review.googlesource.com/978849 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#546720}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I622d8232e5511fb28f3a5976effe9e8d94347629 Reviewed-on: https://chromium-review.googlesource.com/985462Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#546719}
-
Kenneth Russell authored
Failing intermittently on Windows 10 / Quadro P400 / D3D9 / passthrough command decoder. Mark it flaky for both passthrough and non-passthrough. TBR=zmo@chromium.org, geofflang@chromium.org Bug: 825416 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ica54a091b5d447be3a3da71fd022a64f3b188b22 Reviewed-on: https://chromium-review.googlesource.com/979152 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#546718}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7a12b0f2..deec2b95 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If068d7ca90ac3559824c3cd15780bc3d68291622 Reviewed-on: https://chromium-review.googlesource.com/985457Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#546717}
-
Saman Sami authored
After resize once commit happens eventually a CompositorFrame will be submitted with the right size, so just ack the resize after commit instead of draw. Change-Id: I9ab712dc325ad77cd704123d93d94ba74eaf63d2 Reviewed-on: https://chromium-review.googlesource.com/984598Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#546716}
-
bsheedy authored
Ports all of the WebVR browser tests to have an additional WebXR version, plus adds several WebXR-only tests. As a result, removes vr_transition_utils and moves the code originally there into VR/XR test classes so that most WebVR and WebXR tests can share the same test implementation. Bug: 804043 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I62c4e1049e6999ff784c9e69ffedff50915e7b8e Reviewed-on: https://chromium-review.googlesource.com/974137Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#546715}
-
Alexandre Courbot authored
The V4L2 VDAs were still using the deprecated linked_ptr where unique_ptr ought to be used. This patch performs the conversion. BUG=792790 TEST=Checked that video_VDAPerf was still passing on hana (v4l2_vda) and kevin (v4l2_slice_vda) Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic3290d9ae5fa5fa2630cbcc5a35eda93e1cd03ca Reviewed-on: https://chromium-review.googlesource.com/983316 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#546714}
-
David Bokan authored
This method is a hodgepodge of legacy code inherited from the WebKit days. This CL cleans it up a bit, making it easier to read and: -Use one variable as the input to the next recursive call, renamed to absolute_rect_for_parent for clarity. -Remove use of IsDisallowedAutoscroll. There's no reason autoscroll should be special - we already handle the scrolling=no case for other types of scrolls. Added a test to ensure this. -Removed the special parent_box setter for selection autoscroll. Similarly to above, this doesn't need to be special and is already covered by tests: autoscroll-upwards-propagation.html TEST=fast/events/autoscroll-upwards-propagation.html, fast/events/autoscroll-iframe-no-scrolling.html Change-Id: I86cfd03c3ee9366bd01c086a63b379e7a98d46aa Reviewed-on: https://chromium-review.googlesource.com/978966 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#546713}
-
Robert Liao authored
http://crbug.com/773565 removed accelerators for textfields, breaking Cut, Copy, and Paste in the Chrome Menu. This fix forwards those calls to NSApp. BUG=788262 Change-Id: I70adfe270dd672961ca04bc0e4a9ab498e7f2944 Reviewed-on: https://chromium-review.googlesource.com/984346 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#546712}
-
Andrew Grieve authored
Shrinks ChromePublic.apk's classes.dex uncompressed by 110kb Release notes: https://www.guardsquare.com/en/blog/proguard-60-released Change-Id: I237dfb7fb35c33671766c217f838ff559d0a4baf Reviewed-on: https://chromium-review.googlesource.com/982011Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#546711}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3b299243038c..4e367c2f4075 $ git log 3b2992430..4e367c2f4 --date=short --no-merges --format='%ad %ae %s' 2018-03-27 achuith cros_vm: Fix crashes when board is not supplied. 2018-03-26 achuith cros_vm: Refactor argument parsing in cros_vm. Created with: roll-dep src/third_party/chromite BUG=chromium:782664,chromium:782664 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Icfad6a5106689e7989b59bb8801d5ba12fd69fb3 Reviewed-on: https://chromium-review.googlesource.com/985122Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546710}
-
Joel Hockey authored
Bug: 825659 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6c4ba182597aa58f8f8d1a12d1112b4bce75e9aa Reviewed-on: https://chromium-review.googlesource.com/984753 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#546709}
-
tanvir.rizvi authored
FontSizeDelta command crashes if the element after text is a span element. This happens because ApplyStyleCommand tries to surround the text node with a style span, since the next node is a span element, code tries to wrap it in a single node as both being identical(span elements) making the other child of the first node and deleting. Hence the NodeTraversal::Next(*node) gives a NULL node. We should not DCHECK as this is possible and instead break out of the loop. Bug: 726992 Change-Id: I83537518e2080c051be10ed7a6be628d3260b1a7 Reviewed-on: https://chromium-review.googlesource.com/973103Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546708}
-
Peter Collingbourne authored
Otherwise, link against a new set of gn-built prebuilts. Bug: 749784 Change-Id: Id96666125226b3400bb92c31e5c97a7c2a64624d Reviewed-on: https://chromium-review.googlesource.com/947577 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#546707}
-
Edward Lesmes authored
Add linux_chromium_rel_ng_patch_on_gclient as an experimental builder at 5% to test that patching on GClient instead of bot_update works as intended. Bug: 643346 Change-Id: I6af85c344fff4e4d88c66b5e96872fbb90ffbb8d Reviewed-on: https://chromium-review.googlesource.com/983012Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#546706}
-
Yoshifumi Inoue authored
Rewrite "editing/selection/modify_move/move-by-word-visually-multi-line.html" to utilize selection_test() This patch changes "move-by-word-visually-multi-line.html" to utilize |selection_test()| and split into multiple files to remove from slow test list for ease of maintenance. This patch is a preparation of the patch[1]. Note: Test files are generated by the tool[2]. [1] http://crrev.com/c/975083 Implement AdjustSelectionToAvoidCrossingEditingBoundaries() with HonorEditingBoundaryAtOr{After,Before}() [2] http://crrev.com/c/620331 Generate selection_test() for Selection#modify() Bug: 679977, 824687 Change-Id: I965c8dc2e2d6af7d0ed5f906d7185f12a3db2c12 Reviewed-on: https://chromium-review.googlesource.com/981917Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546705}
-
Dale Curtis authored
This removes the need for stalled loading to force states on the WMPI pipeline by instead having WMPI suspend once it reaches one of the target states. This provides equivalent coverage with much faster testing. BUG=819194,817705,756897 TEST=no more flaky tests. Change-Id: I1fa9e1ff6d165ed7921abf62127d3c2cd89f5707 Reviewed-on: https://chromium-review.googlesource.com/980802Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#546704}
-
yiyix authored
RenderWidgetHostViewMac are used to sniff the |root_background_color| in SubmitCompositorFrame. After this change, both RWHVMac listen to RenderFrameMetadataProvider and update its |last_frame_root_background_color_| Bug:716911 Change-Id: Iafa466919c9d29185a59994ca74206fa205335f8 Reviewed-on: https://chromium-review.googlesource.com/982576Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#546703}
-
Joel Hockey authored
Add joelhockey@, noel@, sashab@ to: //ui/file_manager/OWNERS //chrome/browser/chromeos/file_manager/OWNERS Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic9c20ceac030d07d84ef302b64daabda5c8b9799 Reviewed-on: https://chromium-review.googlesource.com/985333Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#546702}
-
Ryan Ki Sing Chung authored
Bug: internal b/70832293 Change-Id: I675c6bf39a3c410bb071f53ebd66f5dd12a03fbc Reviewed-on: https://chromium-review.googlesource.com/984776 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#546701}
-
Dmitry Gozman authored
This will be superseeded by the OOPIF support in timeline. Bug: 820250 Change-Id: I63b58ca3f0ba2203f54459b828cb5ec039399483 Reviewed-on: https://chromium-review.googlesource.com/985098 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#546700}
-
Katie D authored
Bug: 824105 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib9e13381ca9a9e6b51439731d66b629fed29c346 Reviewed-on: https://chromium-review.googlesource.com/985206Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#546699}
-
Rune Lillesveen authored
Gets rid of MutableStyleRef() in test. Bug: 813068 Change-Id: I3ee3d2e13223164c2b3ca32c69989f3f573e0cf4 Reviewed-on: https://chromium-review.googlesource.com/984877 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#546698}
-
Khushal authored
The cache keys generated for an image with an empty target size can have collisions. The ProcessingType for these cases is set to kOriginal, indicating an original sized decode. If the cache is already populated with an original sized decode, this will cause us to use the unlocked memory for that entry. Fix this by using a kSubrectAndScale Processing type for this case, so the key comparison is accurate. R=enne@chromium.org Bug: 825772, 802976 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I26b40673975b64c6fb75a8363d925273407ed3f0 Reviewed-on: https://chromium-review.googlesource.com/981115 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#546697}
-
Peter Boström authored
Increases toolbar element padding and standard spacing under the Material refresh flag (to 4dip and 8dip respectively). Bug: chromium:822069 Change-Id: I2305f1f6af6d3b7ac8d9590467793e17690077e7 Reviewed-on: https://chromium-review.googlesource.com/984863Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#546696}
-
Ken Rockot authored
Adds a histogram and possible dump-without-crashing to observe behavior of pending cookie fetch requests waiting to be fulfilled in the browser. Bug: 824024 Change-Id: I034792ece9dd6f72ef308c3bea16fc439712c7fd Reviewed-on: https://chromium-review.googlesource.com/985021Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#546695}
-
Chih-Yu Huang authored
After calling Flush(), the client may wait for the buffer with EOS flag instead of waiting for callback function be called. Therefore we cannot just recycle the zero-size buffer. The failed CTS is fixed by CL:981916 Bug: b/74503577 Test: pass video_encode_accelerator_unittest Test: pass android.media.cts.MediaCodecTest#testSignalSurfaceEOS CTS This reverts commit 0d44efe1. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8d1dac22c12195b2cc99f9f53c83698443b0a230 Reviewed-on: https://chromium-review.googlesource.com/983279Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#546694}
-
https://pdfium.googlesource.com/pdfium.git/+log/cbf76e656042..a17a0e219d5f $ git log cbf76e656..a17a0e219 --date=short --no-merges --format='%ad %ae %s' 2018-03-28 dsinclair Remove CPDF_DefaultAppearance reference params Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I332e802bdbba4044cb8e54d4ae97819bfea19ac9 Reviewed-on: https://chromium-review.googlesource.com/985418Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546693}
-
Rune Lillesveen authored
This flag was added to try to narrow down the source of a crasher. I could not find any reports on DCHECKs triggered by this. Removing as this requires mutating the ComputedStyle after it's been set on the LayoutObject which we are trying to get rid of. Bug: 813068, 783598 Change-Id: I8bd02b143c6aaf820837721072e21e2324362f90 Reviewed-on: https://chromium-review.googlesource.com/984874Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#546692}
-
Sammie Quon authored
After rotate, SplitViewIndicatorView::Layout gets called, but width() and height() return the wrong values. Set the widget to the correct bounds on rotation, which will then call Layout with the correct width() and height(). Test: manual Bug: 826958 Change-Id: Ibc243ab676fba7503370a38fe7bfb3e4edd25e4d Reviewed-on: https://chromium-review.googlesource.com/985497Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#546691}
-
https://skia.googlesource.com/skia.git/+log/6cf20044d88d..6eba063b63ef $ git log 6cf20044d..6eba063b6 --date=short --no-merges --format='%ad %ae %s' 2018-03-28 robertphillips Add new GrResourceCache::purgeUnlockedResources variant 2018-03-28 bungeman Check that paint is not null in OveridePaintFilterCanvas. 2018-03-27 robertphillips Remove old method of drawing DDL SKPs from DM (in favor of ViaDDL method) 2018-03-28 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 680ab5a31..59fdb4e14 (3 commits) 2018-03-28 angle-skia-autoroll Roll skia/third_party/externals/angle2/ c7575da54..78c5eb2ab (1 commit) 2018-03-28 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ fc0d0c4c7..680ab5a31 (1 commit) 2018-03-27 bungeman Roll FreeType. 2018-03-27 halcanary SkPDF: Accept non-monotonic text cluster indices 2018-03-27 csmartdalton Delete GPU alpha clip masks 2018-03-28 jvanverth Rename SkInsetConvexPolygon to SkOffsetPolygon. 2018-03-27 robertphillips Add handling for allocation failure in GrTextureOpList Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: Iffa7f2df9e3b63397d3ea0c60593e3e091ca560c Reviewed-on: https://chromium-review.googlesource.com/984909Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#546690}
-
https://chromium.googlesource.com/catapult.git/+log/10232e9c96f4..b1c9ad5aa1d0 $ git log 10232e9c9..b1c9ad5aa --date=short --no-merges --format='%ad %ae %s' 2018-03-28 minch Disable testRepeatableScrollActionNoRepeats on chromeos. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ib649feeb91db6e063cf475c5666fe6204f580f7b Reviewed-on: https://chromium-review.googlesource.com/984960 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546689}
-
Avi Drissman authored
1. C++11ify a few things. 2. Clarify that the callbacks are RepeatingCallbacks. BUG=714018 Change-Id: I6f1ffeacbcaee54d70a53803a2082cfb11f98f83 Reviewed-on: https://chromium-review.googlesource.com/979196 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#546688}
-
Naoki Fukino authored
On BACKSPACE, users should be navigated to the parent folder of the current one. We have used Entry.getParent() to identify the parent folder, but it is not safe when the current folder is under fake directories. As we already have the current folder's ascendant folders as breadcrumbs, using it to identify parent folders is safe for consistency between UI and shortcut-key handling. Bug: 769015 Test: Manually tested Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id3af343dd12921fb14d37f2bed6ce146a478987a Reviewed-on: https://chromium-review.googlesource.com/984832Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#546687}
-
Conley Owens authored
This change adds a bool `network_accessed` to the list of fields in SubresourceLoadInfo. Notably, this is important for recording page load metrics when the Network Service is enabled. BUG=816684 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0192a50584da4a932da98ebd0a84f4c126836ce1 Reviewed-on: https://chromium-review.googlesource.com/963313Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#546686}
-
Joel Einbinder authored
Change-Id: I89abcf3b5350722ac4d58842250acf9d4b714aa4 Reviewed-on: https://chromium-review.googlesource.com/954405Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#546685}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/86ddc1d4..7a12b0f2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I80153419b0bb01d6234a2d2e175135530337c765 Reviewed-on: https://chromium-review.googlesource.com/985312Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#546684}
-
Oksana Zhuravlova authored
This change moves memory_allocator_dump_cross_process_uid.mojom and process_id.mojom from //mojo/common to//mojo/public/mojom/base. Corresponding typemap and struct traits files were also moved. Unit test for MemoryAllocatorDumpGuid and ProcessId were to mojo_unittests. This change also removes mojo/common/common_custom_types_struct_traits.{h,cc} and //mojo/common:struct_traits target. Bug: 799482,806965 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I750b22ccd208c1929e2dfca85d58c9496e84272f Reviewed-on: https://chromium-review.googlesource.com/978783 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#546683}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: none Test: none Change-Id: Iee5ec5f5fa2e6fbcbc37bd676860db123da2aaf5 Reviewed-on: https://chromium-review.googlesource.com/985492 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#546682}
-
Tibor Goldschwendt authored
Bug: 819883 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2014bd7f195b773b74e9366f916c32092ceba879 Reviewed-on: https://chromium-review.googlesource.com/984733 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#546681}
-