- 16 Jul, 2017 16 commits
-
-
Hidehiko Abe authored
This CL migrates ArcPrintService. BUG=672829 TEST=Ran try. Change-Id: Ia223ec8dc9d05d044ddb66812cd322d705cb1d39 Reviewed-on: https://chromium-review.googlesource.com/572882 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#487017}
-
Jinsuk Kim authored
This removes all the public native references to ContentViewCore from the embedder, which were indirections that became unnecessary. Now they can be handled by using WebContents, passing container view or view-specific coordinates values instead. For many parts, changes were made so that these values are converted from css to device pixel unit right before being passed up to Java layer. I think it helps the two units avoid being mixed in the code. BUG=626764 Change-Id: I7348c9aea00cde93f976d1bae3779270826dce03 Reviewed-on: https://chromium-review.googlesource.com/536895 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#487016}
-
dskiba authored
Profiling StackFrameDeduplicator with new heap format revealed that: 1. At least 60% of all insertions are hits, i.e. they insert backtraces that already exist. 2. There can be as many as 500K frames. 3. The average child count at each level is ~1.2. This CL optimizes StackFrameDeduplicator based on that data: 1. Adds a hash-based backtrace lookup to cut down number of lookups in FrameNode::children maps. 2. Changes FrameNode storage from std::vector to std::deque, avoiding costly vector reallocations. 3. Changes FrameNode::children storage from std::map to std::flat_map. These changes improve HeapProfilerPerfTest.DeduplicateStackFrames perftest ~1.6x on macOS (1040ms -> 620ms), but real-world impact should be higher because the perftest is pessimistic. BUG=739378 Review-Url: https://codereview.chromium.org/2977783002 Cr-Commit-Position: refs/heads/master@{#487015}
-
Mostyn Bramley-Moore authored
BUG=741927,743615 TEST=Running browser_tests with the flags below, should print "Using 1 parallel jobs." --run-manual --ui-test-action-max-timeout=350000 --test-launcher-jobs=1 --test-launcher-bot-mode --test-launcher-print-test-stdio=always TBR=phajdan.jr@chromium.org Change-Id: I33f2b4fc54b43ebec8a27c532da17146b42c07cd Reviewed-on: https://chromium-review.googlesource.com/573380Reviewed-by:
Mostyn Bramley-Moore <mostynb@opera.com> Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com> Cr-Commit-Position: refs/heads/master@{#487014}
-
Hidehiko Abe authored
This CL migrates ArcPowerBridge. BUG=672829 TEST=Ran try. Change-Id: I02dac942cbd31635120c62734032ca7611edae4b Reviewed-on: https://chromium-review.googlesource.com/572881 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
Hidehiko Abe authored
This CL migrates ArcObbMounterBridge. BUG=672829 TEST=Ran try. Change-Id: Iac02330ae8ac2c0226f81ea25f5045494290da0d Reviewed-on: https://chromium-review.googlesource.com/572472 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
Hidehiko Abe authored
This CL migrates ArcMetricsService. BUG=672829 TEST=Ran try. Change-Id: If61b381d0aac425117601b0f514aaebac431e9bc Reviewed-on: https://chromium-review.googlesource.com/572471 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
Hidehiko Abe authored
This CL migrates ArcFileSystemMounter. BUG=672829 TEST=Ran try. Change-Id: I0fe8ac4c2d3aec887cd716b53cd5c02421d47b14 Reviewed-on: https://chromium-review.googlesource.com/572670Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 730 739 740 741 742 745 746 4022 lines were removed by consecutive passes since 681 (Jul 10). TBR=eae@chromium.org NOTRY=true BUG: 591099 Bug: Change-Id: I22cabe0f1175ddab6449e18d70ef63cc2e09d537 Reviewed-on: https://chromium-review.googlesource.com/572485 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#487009}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/1a325d25b941..1fcd10aae433 $ git log 1a325d25b..1fcd10aae --date=short --no-merges --format='%ad %ae %s' 2017-07-16 update-skps Update SKP version Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Idafa5caed27b3921332735781a3833a5b393e98e Reviewed-on: https://chromium-review.googlesource.com/573280Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487008}
-
Felix Ekblom authored
In https://codereview.chromium.org/2964823002 the OobeDisplayChooser started using the DeviceDataManager to look for touchscreen devices when searching for a good primary display to use during OOBE. On device cold boot the DeviceDataManager has not yet found any touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely due to lower level systems not being fully initialized). This CL make LoginDisplayHostImpl an observer of changes to connected touchscreen devices, re-triggering the OobeDisplayChooser when the DeviceDataManager is notified of the connected touchscreens. This overcomes the timing issues on cold boot. Bug: 738885 Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd Reviewed-on: https://chromium-review.googlesource.com/569958Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Felix Ekblom <felixe@chromium.org> Cr-Commit-Position: refs/heads/master@{#487007}
-
Koji Ishii authored
This is a follow up and minor cleanups after the initial NGBaseline patch[1]. 1. Addresses cbiesinger reviews. 2. NGBaseline has NGBaselineRequest as a member. 3. Some arguments are changed to use struct, not each member. [1] https://codereview.chromium.org/2867293002/ BUG=636993 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib781a08f3b85be6519b70f07413719d0a76db7e7 Reviewed-on: https://chromium-review.googlesource.com/571680 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#487006}
-
Tomasz Figa authored
When building from within a ChromiumOS chroot (and any other Gentoo-base system), the right command to call pkg-config is specified up front and needs to be honored. However currently Chromium build system always calls 'pkg-config' directly if --sysroot is given to the build. This ignores any necessary setup done by the board sysroot pkg-config wrapper used on ChromiumOS and causes host's paths being pulled into the build. Precisely, PKG_CONFIG_PATH is not being unset and PKG_CONFIG_SYSROOT_DIR is not being set to the sysroot path. Fix this by always using the specified pkg-config binary, even if sysroot is given. Even though, the problem could be fixed up by adding necessary setup to Chromium's pkg-config wrapper, it is not the right solution, as the setup is inherently sysroot specific and only the external build system is aware of necessary configuration to be done. Bug: 743366 Test: Build chromeos-chrome with host's /usr/lib64/pkgconfig/dbus-1.pc chmodded to a-r. Change-Id: I6e80dbaa94510e31aa5000c6cc31ca32b5e5cbe4 Reviewed-on: https://chromium-review.googlesource.com/572666Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Tomasz Figa <tfiga@chromium.org> Cr-Commit-Position: refs/heads/master@{#487005}
-
Takeshi Yoshino authored
Bug: Change-Id: I2226cd621bcd9c85d8ce179f14f768645cf97db3 Reviewed-on: https://chromium-review.googlesource.com/572444 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#487004}
-
Nicholas Verne authored
WebDevToolsAgentImpl uses many InspectorAgents that are implemented in modules/. To enable these agents' use from core/ we now register a callback from ModulesInitializer::Initialize that can append the modules/ InspectorAgents to an InspectorSession. Since WebDevToolsAgentImpl needs to use static methods of WebView and WebViewBase directly, these need to be availble in core/ as well. We created WebViewBase.cpp and moved the definitions there. Also, to keep Windows happy WebViewBase is now a NON_EXPORTED_BASE of WebViewImpl, since there is now code for WebViewBase static methods in different library and Windows otherwise fails to link warning C4275: non dll-interface class 'blink::WebViewBase' used as base for dll-interface class 'blink::WebViewImpl' Bug: 712963 Change-Id: I9159327618118b2a2f652ed15a76271040b5bc30 Reviewed-on: https://chromium-review.googlesource.com/544726 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#487003}
-
chrome-release-bot authored
TBR=dimu@chromium.org Change-Id: I3ab7d08870b5f5c78af2c2b5bd6ffbce345b4242 Reviewed-on: https://chromium-review.googlesource.com/572396Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#487002}
-
- 15 Jul, 2017 24 commits
-
-
Reza.Zakerinasab authored
In V8ScriptValueSerializerTest.RoundTripImageBitmapWithColorSpaceInfo we serialize and deserialize an ImageBitmap in red color in P3 color space. We expect red in P3 to be {0x94, 0x3A, 0x3F, 0x28, 0x5F, 0x24, 0x00, 0x3C} when each color component is presented as a half float in Skia. However, difference in GPU hardware may result in small differences in Skia color conversion pipeline. This change adds a tolerance of 2 to the color compare to avoid failing ARM64 official test bot. Bug: 743300 Change-Id: Ie790c10f77a8a829d7b86e79f6155d4b9e43faf8 Reviewed-on: https://chromium-review.googlesource.com/572716Reviewed-by: -
Peter Kotwicz authored
This CL: - Removes Bitmap encoding to PNG from WebappDataStorage#createWebappLaunchIntent() - Runs WebappDataStorage#createWebappLaunchIntent() on UI thread Bug: None Change-Id: I9aa406a16c8085797eb86812dbd32000b635fe38 Reviewed-on: https://chromium-review.googlesource.com/568849Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#487000}
-
Bruce Dawson authored
Doing another VS2017 test over the week end now with the newly packaged VS 2017 Update 3 Preview 4 (was Preview 2 last time). This CL is currently purely for testing purposes and will be reverted by the end of the weekend. R=dpranke@chromium.org BUG=683729 Change-Id: Ie5c2e92b789b1dcbd51d4e0028230b5b72ce9eb9 Reviewed-on: https://chromium-review.googlesource.com/572500Reviewed-by:
-
Justin Schuh authored
Perform template check with UnderlyingType and clamp shift value for SaturateFastAsmOp<>; TBR=servolk@chromium.org Change-Id: I8828b06a211515ee06d65c7dd1989b7cd84a841c Reviewed-on: https://chromium-review.googlesource.com/572870 Commit-Queue: Justin Schuh <jschuh@chromium.org> Reviewed-by:
Justin Schuh <jschuh@chromium.org> Cr-Commit-Position: refs/heads/master@{#486998}
-
Dmitry Torokhov authored
We are changing the layout of top function row key, removing the "Browser Forward" button, moving several keys one position left, and inserting the Play/Pause button. Because Chrome needs to be able to map from Fnn keys to the proper action keys and back, we need to know the layout of keyboard we are dealing with. ChromeOS will use UDEV to mark the keyboards with new top row layout with CROS_KEYBOARD_TOP_ROW_LAYOUT=2 property, and we will be looking for this property in the event rewriter code and select appropriate layout. BUG=b:63576567 Change-Id: Id2be04ef85809b6bd7627d3b55ac6d3082f7b8c5 Reviewed-on: https://chromium-review.googlesource.com/571652Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#486997}
-
Varun Khaneja authored
This list used to be sync'd for both Chromium and Chrome previously but that was changed due to https://crbug.com/728757 because the PVer4 server did not support that list for non-Chrome clients. The server has now been updated to return this list to non-Chrome clients so changing the sync condition from kSyncOnlyOnChromeBuilds back to kSyncAlways. Bug: 728757,543161 Change-Id: I0dec4aa8556a9ba6b667f168d95711eaf48a5b61 Reviewed-on: https://chromium-review.googlesource.com/570378Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#486996}
-
Quinten Yearsley authored
Bug: 736177 Change-Id: I7c4d54a4a3a7b33ac3be88ac07ee0e0d3a4353fb Reviewed-on: https://chromium-review.googlesource.com/570774 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Cr-Commit-Position: refs/heads/master@{#486995}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3184e075. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/320 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: Iea65fd4163ebd4fb0948b6dcb3ac82df05d6ed08 Reviewed-on: https://chromium-review.googlesource.com/572942 Commit-Queue: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486994}
-
Geoff Lang authored
TBR=kbr@chromium.org NOTRY=true BUG=angleproject:2103 Change-Id: If69f5782e45218e5df364fb756d7676c5248c5be Reviewed-on: https://chromium-review.googlesource.com/572850Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#486993}
-
Mounir Lamouri authored
The work to abstract the media controls from the HTMLMediaElement allows us to do this without risks. However, when the Cast overlay has to be used, the controls need to be created even if they are not used. The code implementing this logic is part of the native controls so we can't lazy initialise the controls the same way. Bug: 731143 Change-Id: I2eb912ab6124c24000860007c1d6e6aa3300c440 Reviewed-on: https://chromium-review.googlesource.com/528176 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Anton Vayvod <avayvod@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#486992}
-
Amirhossein Simjour authored
screen_share.icon is moved back to ash/resources/vector_icons. As a result VrShell is no longer using the 1x version of this icon. BUG=736350 Change-Id: Iaa9934fa99345e58acd60d7e3250b58b80ba170f Reviewed-on: https://chromium-review.googlesource.com/565546Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#486991}
-
Hidehiko Abe authored
This CL migrates ArcEnterpriseReportingService. BUG=672829 TEST=Ran try. Change-Id: Ib86168f0cf52096025366c4a52ec0030a1c09f55 Reviewed-on: https://chromium-review.googlesource.com/571116 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#486990}
-
Tom Anderson authored
BUG=661774 TBR=erg@chromium.org Change-Id: I16aa7ff8acd6c389173f970485fcb9659900a45d Reviewed-on: https://chromium-review.googlesource.com/572871Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#486989}
-
Jinho Bang authored
The spec[1] was changed. FYI, this feature is still behind runtime flag. [1] https://github.com/w3c/payment-handler/pull/187 Bug: 661608 Change-Id: I134c668110fcdc79d237dfd349e3dbf4203fb090 Reviewed-on: https://chromium-review.googlesource.com/564097Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#486988}
-
Hidehiko Abe authored
This CL migrates ArcCrashCollectorBridge. BUG=672829 TEST=Ran try. Change-Id: Idc873df7e2519c79e1ee2b0ed45b0100d8ee543c Reviewed-on: https://chromium-review.googlesource.com/571566 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
ImageResourceContent::content_status_ is suspected to be reset to kNotStarted (i.e. 0) during ImageResourceContent::UpdateImage(), but therer is no code that sets content_status_ to kNotStarted explicitly. This CL adds CHECKs() to - Check whether |this| is garbage collected unexpectedly during UpdateImage(), and - Investigate where |content_status_| becomes kNotStarted precisely. This is to be reverted before going to beta. Bug: 737392 Change-Id: I2879bc54771a295a2dd77fed6808c1c08668e262 Reviewed-on: https://chromium-review.googlesource.com/572036 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/86730555..248b789e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I8751ec8fd592db1cf6086ca46b7b3d13e7e378ea Reviewed-on: https://chromium-review.googlesource.com/572534Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#486985}
-
tzik authored
This CL removes all dependency from SyncFileSystem to SequencedWorkerPool. SyncFileSystem did not use the task runner from SequencedWorkerPool even before this CL, and the remaining dependencies were shutdown detection and task queue flushing. Change-Id: I9feefbebee6b153472bbc04ac7d6cbb621162e4e Reviewed-on: https://chromium-review.googlesource.com/569530Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#486984}
-
Takeshi Yoshino authored
FindCharsetInMediaType() looks for a substring that is likely to be indicating the charset parameter loosely without performing ABNF validation. New code should use the strict version in HttpUtil. Bug: 674329, 743311 Change-Id: I9faa60dcb63e983a62aff74601ac16257da28e80 Reviewed-on: https://chromium-review.googlesource.com/564749 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#486983}
-
Takeshi Yoshino authored
Bug: 699873 Change-Id: I9663d6728e770a4860f4f05beffc68722fa981b8 Reviewed-on: https://chromium-review.googlesource.com/571202Reviewed-by:
Sigbjørn Finne <sigbjornf@opera.com> Reviewed-by:
-
Hidehiko Abe authored
This CL migrates ArcClipboardBridge. BUG=672829 TEST=Ran try. Change-Id: I34642868629e673015bcf298869d1ced2d0a0ad5 Reviewed-on: https://chromium-review.googlesource.com/571528 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
Aleks Totic authored
They symptom was really slow pipes between content_shell and test runner. I did not know what XDG_RUNTIME_DIR was, so I looked it up. Seems relevant to the symptom. Curious about what the root cause was. https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html XDG_RUNTIME_DIR defines the base directory relative to which user-specific non-essential runtime files and other file objects (such as sockets, named pipes, ...) should be stored. The directory MUST be owned by the user, and he MUST be the only one having read and write access to it. Its Unix access mode MUST be 0700. The lifetime of the directory MUST be bound to the user being logged in. It MUST be created when the user first logs in and if the user fully logs out the directory MUST be removed. If the user logs in more than once he should get pointed to the same directory, and it is mandatory that the directory continues to exist from his first login to his last logout on the system, and not removed in between. Files in the directory MUST not survive reboot or a full logout/login cycle. The directory MUST be on a local file system and not shared with any other system. The directory MUST by fully-featured by the standards of the operating system. More specifically, on Unix-like operating systems AF_UNIX sockets, symbolic links, hard links, proper permissions, file locking, sparse files, memory mapping, file change notifications, a reliable hard link count must be supported, and no restrictions on the file name character set should be imposed. Files in this directory MAY be subjected to periodic clean-up. To ensure that your files are not removed, they should have their access time timestamp modified at least once every 6 hours of monotonic time or the 'sticky' bit should be set on the file. If $XDG_RUNTIME_DIR is not set applications should fall back to a replacement directory with similar capabilities and print a warning message. Applications should use this directory for communication and synchronization purposes and should not place larger files in it, since it might reside in runtime memory and cannot necessarily be swapped out to disk. Bug: 725229 Change-Id: Ia34c349c94dd44357c135b98deab1a119fa557a6 Reviewed-on: https://chromium-review.googlesource.com/572640Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#486980}
-
Brett Wilson authored
These are on both Windows and Linux. Use the new ScopedPlatformFile typedef. Change-Id: I3905a70c68c306c418ac1d24913d624bdd997c8b Reviewed-on: https://chromium-review.googlesource.com/572521 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#486979}
-
Hidehiko Abe authored
This CL migrates ArcBootErrorNotification. BUG=672829 TEST=Ran try. Change-Id: I8ea1f03507a4a654e035f5b9ba34819770d4b6fe Reviewed-on: https://chromium-review.googlesource.com/571527 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
