- 09 Sep, 2019 40 commits
-
-
Matt Mueller authored
Disables the use of system-provided trust roots. Only supported by the "builtin" and "pathbuilder" verifier impls. Change-Id: Iaebcdbb8a5d826963b4deea18b1befeb4f9d5bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790468 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#694978}
-
Xinghui Lu authored
A lot of #ifs are introduced in cl:1758740. Rearrange them to make the code cleaner, no functional change. Bug: 995926 Change-Id: I0d60b0a610e9a14a892587c124f9582bd6555299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789996Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#694977}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ef368773be1..92f197b8a4e7 Created with: gclient setdep -r src-internal@92f197b8a4e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:977050 Change-Id: I6d756e104d7806f7b4c4f0f37c67cd4826e47023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792798Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694976}
-
Jon Mann authored
Bug: 1001687 Change-Id: I50c527dcce3ffc5b831519c346ff0db30f5495a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790471 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#694975}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a0e6ded9fcac..116ffe7e5be4 git log a0e6ded9fcac..116ffe7e5be4 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 danilchap@webrtc.org Switch to compiling WebRTC -std=c++14 by default Created with: gclient setdep -r src/third_party/webrtc@116ffe7e5be4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ic8fa2bf9280158b167bf825090ecc064b5938cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793505Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694974}
-
Peter Kasting authored
Bug: 1000055 Change-Id: Ic19035c7dd1bc69cccc1161e2007563051bcda36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793442 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#694973}
-
Robbie McElrath authored
This reverts commit 362070db. Reason for revert: This probably broke monochrome-feedless-builder Original change's description: > Don't include JNI headers in chrome android when they're not used. > > This CL removes dependencies on JNI headers when they're not used and > the Java implementation isn't included. This makes chrome_public_apk > work with crrev.com/c/1743088. > > Bug: 836335 > Change-Id: Iec02f4fec9cf93183949547960e191e675e62ebf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746641 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694921} TBR=changwan@chromium.org,agrieve@chromium.org,rmcelrath@chromium.org Change-Id: I21c2f41e2772f74c1081bf72af96fea9c37d5502 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794022Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#694972}
-
Kenneth Russell authored
GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash ContextLost_WebGLContextLostFromGPUProcessExit ContextLost_WebGLContextLostInHiddenTab These are now running on the full Chromium browser which should have tab control. Bug: 609629 Change-Id: Ia158a3829b5615a8a1f4f0eac1a5903f769294e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788138 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#694971}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ipc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=rockot@google.com Bug: 891670 Change-Id: I410de34fd2b80faf6403ee60d3a81e9a0ac40a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787059 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#694970}
-
Dale Curtis authored
As with 69e8f306 and subsequently ad645f7a. It appears that allowing media elements to remain suspended while in the metadata state is not working as expected. This change reverts our play state calculations to requiring the element to reach the future data state to remain suspended. This is okay for preload=metadata suspend and lazy load suspend since we advance to have future data for these modes (in order to not break any pages). This patch also modifies our browser tests to expose the suspend state for the element under test using the window.internals() methods so we can debug this further in case this turns out not to be the right root cause. BUG=986021 TEST=updated tests. R=sandersd Change-Id: Idae559195c238edd3ccf6b2477ae18c3dfbda7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793129 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#694969}
-
Xinghui Lu authored
Replaced it with a local histogram for testing. Bug: 986648 Change-Id: Ie4b3b7971ec63ecbf1e52b4f254bfd9a18538e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790427Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#694968}
-
Philip Rogers authored
The interest rect is a window within a scroller which has display items. The typical invalidation mechanisms will handle changes to drawing display items. Hit test display items are a little different because we need to ensure ScrollingCoordinator::UpdateTouchEventTargetRectsIfNeeded is called post-paint to map them into the space of the cc::Layer. The bug was that this mapping update did not occur on interest rect changes. This patch ensures the scrolling coordinator updates anytime display items are painted. Bug: 995715 Change-Id: I1428e956a83c4c07a18e40a8e36559f694eabf97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793546Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#694967}
-
Tricia Crichton authored
Refactored InitSessionHelper for better test coverage. Extracted ConfigureHeadlessSession function, and added unit tests. Bug: chromedriver:3102 Change-Id: I6ac964c923924d8b6205a87710e2468c40acf5fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792796Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#694966}
-
Peter Kasting authored
Bug: 1000055 Change-Id: Ie9432692525fe21719b88cf8b06f015785824cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793264 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#694965}
-
Xiaoqian Dai authored
- StartOverview() should return true if enter overview successfully, false otherwise - EndOverview() should return true if end overview successfully, false otherwise - Other small refactorings No functionality change in this CL. Bug: None Change-Id: I47fcf479bda3d51da98ee693e0a5acbe51f80c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785625 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#694964}
-
Peter Kasting authored
Bug: 1000055 Change-Id: Ide9895a75b1db5f27a22a94d5cc3c48f6e9322ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791625 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#694963}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c2d84bfa7421..9c173c8347f8 git log c2d84bfa7421..9c173c8347f8 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 brianosman@google.com Remove temporary Metal pipeline cache size hack 2019-09-09 hcm@google.com Add release section for milestones and rel notes Created with: gclient setdep -r src/third_party/skia@9c173c8347f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I594b7d02d39a67c5401e9c3071264313e4646fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792237Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694962}
-
Nick Diego Yamane authored
PlatformEventSource provides mechanisms which allow both (1) PlatformEventDispatcher to be installed "overriding" the previously installed dispatchers (i.e: that dispatcher will get the chance to process every event before any other dispatcher in the list), as well as (2) PlatformEventObserver instances to be installed to monitor events as they come in and are processed. Such APIs are not supported in X11EventSource for x11-specific event dispatchers (aka: ui::XEventDispatcher), which is needed to migrate components, such as, X11PropertyChangeWaiter, PropertyEventWaiter, to XEvent{Dispatcher,Observer}, as part of larger PlatformEvent migration to ui::Event, which will be addressed in follow-up CL crrev.com/c/1747274. So, this CL adds such APIs, with implementations based on PlatformEventSource's ones. Bug: 965991 Change-Id: I666a49cab3d522c5c87e942bf302e848e36ebfef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779280Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#694961}
-
Maggie Chen authored
After Dx12/Vulkan Info collection task is delayed for 2 minutes (the other CL), Dx12/Vulkan info will always be requested if the data is not available for about:gpu. Rewrite the code to make DxDiagNode function aligned with Dx12VulkanInfo function. Bug:949839 Change-Id: Ifcab4885dccb13e206f707657ac9074a21cdf4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785827 Auto-Submit: Maggie Chen <magchen@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694960}
-
Luum Habtemariam authored
Earlier interface changes that weren't propagated to the unittests. Bug: chromium:945409 Test: unit_tests now build (and pass) Change-Id: Ib284c02dafc8ad04eb9bef3c09b8ae1ec16074fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793526Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@google.com> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#694959}
-
Tarun Bansal authored
Add browsertests that check the interaction between the site engagement service and top hosts provider. Change-Id: I8161c9c823ff98027ddb5674fead173606232ed3 Bug: 999541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790289Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#694958}
-
Bo Liu authored
Note this feature only applies to Android Q, which has no automated testing coverage right now. Bug: 946216 Change-Id: I88dcedb0595815c9a2e8384539a249d43196ae02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786833 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#694957}
-
Xianzhu Wang authored
Bug: 994361 Change-Id: I3c11a74df88bc38ba647faa4d014e8e39d887462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792005Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#694956}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1e4d70d1dd08..ca8793223ace git log 1e4d70d1dd08..ca8793223ace --date=short --no-merges --format='%ad %ae %s' 2019-09-09 ehmaldonado@chromium.org gclient: Fix gclient Python 3 errors and add to presubmit tests. 2019-09-09 ehmaldonado@chromium.org git-cl: Remove unused auth configs. Created with: gclient setdep -r src/third_party/depot_tools@ca8793223ace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:984182,chromium:1001756 Change-Id: I756c6becdb2544f2df86d8a85f6c2a8498f26e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792238Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694955}
-
Luum Habtemariam authored
Adding necessary dependency on IppParser, fixes some breaking fuzzer builds. Bug: chromium:1001869 Test: build succeeds Change-Id: Ie04e8fc0de87b9639bf4086d31131b91ccae2b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793253Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#694954}
-
Sergey Ulanov authored
Vulkan-related leaks have been fixed, so it's safe to re-enable it now. This reverts commit 38dc3a47. Bug: 1001296 Change-Id: If21c1562b5ba3e6a25ab41431d5144fad2375edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790418 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#694953}
-
Zhenyao Mo authored
At the moment, the endless loop code to simulate the hang is optimized out by the compiler, so about:gpuhang becomes a no-op. BUG=1001773 TEST=about:gpuhang R=kbr@chromium.org NOTRY=true Change-Id: I965ca7b3a5cadb65d568b3857804b9507b5a9f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790587 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#694952}
-
Scott Violet authored
Here's the set of changes: . Copies ContentViewRenderView into weblayer so that it works for our needs, which specifically means adding a Layer. This layer contains the layer for the top-controls and the webcontents. . TopControlsContainerView uses ViewResourceAdapter to keep a bitmap in sync with the contents of the actual top-view. . BrowserControllerImpl creates and owns TopControlsContainerView. . TopControlsContainerView creates a cc::Layer that contains the bitmap from ViewResourceAdapter. . The cc::Layer is always visible, and ViewResourceAdapter is always kept in sync with the actual top-controls. To do otherwise results in a noticeable delay between when the layer is needed (during scrolling) and the bitmap is rendered by cc. . The actual top-controls View is hidden during scroll. BUG=none TEST=none Change-Id: Id32588de75c603508e499fc0e3c87f77941c95c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790722Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#694951}
-
Rohit Rao authored
Original change's description: > Revert "[ios] Adds the ability to run unittests using XCTest." > > This reverts commit b6c231b5. > > Reason for revert: Suspected for causing compiling errors on mac. > > Original change's description: > > [ios] Adds the ability to run unittests using XCTest. > > > > This new functionality is hidden behind both a GN arg > > (enable_run_ios_unittests_with_xctest) and a commandline switch > > (--enable-run-unittests-with-xctest), in order to default it to off > > until the bots are updated to properly run XCTest-based unittests. > > > > The iOS test runner is updated to run in one of two modes. When > > --enable-run-unittests-with-xctest is false (the default), behavior is > > unchanged; TestSuite::Run() calls UIApplicationMain(), then the > > UIApplicationDelegate calls TestSuite::Run() again, which actually runs > > the tests when invoked the second time. When the switch is set to true, > > the second invocation of TestSuite::Run() is made by our XCTestCase > > subclass rather than by the application delegate. > > > > Xcode provides the ability to run XCTests and XCUITests from the > > commandline, but does not provide any other way to install and run an > > app outside of this test-based workflow. (We had an alternative that > > used third party libraries, but they no longer work on iOS 13.) This > > makes it difficult to install and run GoogleTest-based tests on iOS > > devices, since they run as a single self-contained application, but it > > would not be practical to drop GoogleTest support on iOS. Instead, we > > are exploring invoking these tests via XCTest, which would allow us to > > use Xcode's tooling but still run the same GoogleTest-based tests as on > > other platforms. > > > > BUG=635509 > > > > Change-Id: I26c67d9c7e16a744f43a20f2d8c5839ca8b3c31a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787593 > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Reviewed-by: Mark Mentovai <mark@chromium.org> > > Reviewed-by: Justin Cohen <justincohen@chromium.org> > > Commit-Queue: Rohit Rao <rohitrao@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#694749} > > TBR=rohitrao@chromium.org,dpranke@chromium.org,justincohen@chromium.org,mark@chromium.org > > Change-Id: Ic67605ab0292551500a163e993c6d93fec3048c0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 635509,1002144 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791798 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694814} TBR=rohitrao@chromium.org,dpranke@chromium.org,justincohen@chromium.org,tbansal@chromium.org,mark@chromium.org Change-Id: I94e59823c379e1afb4e9e965bfe602d06400e8b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 635509, 1002144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790069Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#694950}
-
John Rummell authored
This is breaking partners who want to build Chromium with Widevine enabled and only get Widevine through the component updater. This was added in commit 90c6eb51 (https://chromium.googlesource.com/chromium/src/+/90c6eb5176bf1347001dde9edd27aa8b70b74186) Bug: 971433 Test: compiles Change-Id: I59158db398b9062084770a8850345da0d030d9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793256 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#694949}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/common/service_manager. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=rockot@google.com Bug: 891670 Change-Id: I26e756b427a41a07ced80e5d9306788644d26ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786956 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#694948}
-
Shimi Zhang authored
This is a followup of http://crrev/c/1685837. See more at https://docs.google.com/document/d/1Jwfbzbe8ozaoilhqj5mAPYbYGpgZCen_XAAAdwmyP1E/edit Bug: 955171 Change-Id: I8db6d8816f62f6fe864e3ea35269a223a1fd7f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790132Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#694947}
-
Peter Kasting authored
Bug: 1000055 Change-Id: Ibb9b282f711456543f032f809cb01fcb4f900614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792792 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#694946}
-
Yuchen Liu authored
1. Turn on flag 'enable_widevine' and 'ENABLE_PROTECTED_MEDIA_IDENTIFIER_PERMISSION'. 2. Add widevine key system config. Bug: 991723 Test: Shaka player demo "Dig the Uke". Change-Id: I49a7661fb4b8b5732b597622f9d496ea611dc9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783802 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#694945}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4f431ad17465..eb4f2d5031bc git log 4f431ad17465..eb4f2d5031bc --date=short --no-merges --format='%ad %ae %s' 2019-09-09 jdarpinian@chromium.org Fix WebKit iOS build Created with: gclient setdep -r src/third_party/angle@eb4f2d5031bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: I43ec7d3621fe6e1b2b22da9c24b06593fdc37d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790441Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694944}
-
Daniel Cheng authored
319125 is a straightforward browser memory corruption bug where an IPC handler blindly trusts data from the renderer, forgetting that one of the types of data that can be set is a raw pointer ^_^ Change-Id: I14a37f1882c06edc56e5d4d2f7c1d0444869bec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790480 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#694943}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/305a5283c5b4..5a0242ba5c8f $ git log 305a5283c..5a0242ba5 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 marpan vp9-svc: Add new frame drop mode for SVC 2019-08-30 angiebird Report failure of vp9_alloc_motion_field_info 2019-08-30 zxdan Upload Motion Field Estimation Unit Test Files 2019-08-29 angiebird Free set_mv properly 2019-06-28 alexconv Don't generate mv refs that won't be used 2019-08-22 angiebird Move motion field from TplDepFrame to MotionField 2019-08-28 jianj Add resize test for smaller width bigger size. 2019-08-28 hienho vpx_dsp/x86/highbd_idct4x4_add_sse2: fix int sanitizer warnings 2019-08-21 angiebird Add MACRO MAX_INTER_REF_FRAMES 2019-08-21 angiebird Add motion_filed_info in VP9_COMP 2019-08-20 angiebird Add free_tpl_buffer 2019-08-13 hienho vp8/encoder/vp8_quantize: fix int sanitizer warnings 2019-08-09 hienho test/acm_random.h: int sanitizer warning Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: Ib7502b9e520ed37d16e6eaab29b07bd2a5d46495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792980Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#694942}
-
Peter Kasting authored
Bug: 1000055 Change-Id: I42c276f72ec4d1532e6a63db4dd52cc15afcd31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792787 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#694941}
-
Peter Kotwicz authored
In order to use the theme-color specified by the web page for TWAs, CustomTabStatusBarColorProvider#setUseTabThemeColor() needs to be invoked because CustomTabStatusBarColorProvider#mUseTabThemeColor defaults to false. setUseTabThemeColor() is currently not invoked because TrustedWebActivityCoordinator#mInTwaMode defaults to true This CL fixes the bug by adding a speculative call to setUseTabThemeColor() in onPostInflationStartup() similar to what is done for the toolbar hide state This CL also enables CustomTabActivityTest.testToolbarColor() on Lollipop. This matches similar tests like WebappSplashScreenThemeColorTest#testThemeColorNotUsedIfPagesHasOne() BUG=997578 TEST=TrustedWebActivityTest.testStatusBarColorPrecedence Change-Id: I6015acbae310650051b49f75cacbddc16a5e66e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771316 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#694940}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9e380fd484db..a0e6ded9fcac git log 9e380fd484db..a0e6ded9fcac --date=short --no-merges --format='%ad %ae %s' 2019-09-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 75cf3925..e25e7642 (694706:694813) Created with: gclient setdep -r src/third_party/webrtc@a0e6ded9fcac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I4a4b4d4c58050e2f4ccd55b29c8930d1e29d6013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793288Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694939}
-