GitLab

This CL moves top/bottom bar control updating to a separate
UpdateControls method in RenderWidgetHostViewAndroid. If surface sync
is on then it gets called in DidUpdateVisualProperties, and if surface
sync is off it continues to get called in OnFrameMetadataUpdated.

Change-Id: Ieb4926a4393686db05afd153ec243b72a85c45c7
Bug: 672962
Reviewed-on: https://chromium-review.googlesource.com/1062084
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559375}

We'll enable to see if it they still flake or not.

Bug: 715632
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I2a305db1120d98b1a1bb632bb4c2e1315a2571b2
Reviewed-on: https://chromium-review.googlesource.com/1063105Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559374}

This adds master mixins for:
* chromium
* chromium.chromedriver
* chromium.lkgr
* chromium.swarm

Bug: 840631
Change-Id: Ia615d68243c114bc61b44ec2179e1b5830ea02d5
Reviewed-on: https://chromium-review.googlesource.com/1063167Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559373}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/4c1562dfdeef..966fe62677b1

$ git log 4c1562dfd..966fe6267 --date=short --no-merges --format='%ad %ae %s'
2018-05-14 ayatane sysmon: Add ignored metric to prod manifest
2018-05-16 bmgordon build_stages: Handle exceptions in snapshot commands
2018-05-16 manojgupta cros_fuzz_test_env: Fix cleanup option.
2018-04-27 dgarrett remote_try: Rename to request_build.
2018-04-27 dgarrett remote_try: Rearrange a little.
2018-04-26 dgarrett cros_tryjob: Move tryjob specific logic into cros tryjob.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:None,chromium:843441,chromium:843627,chromium:824550,chromium:824550,chromium:824550


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ibd98b2152ec46624b2c80e06bb60514e17ca9e2a
Reviewed-on: https://chromium-review.googlesource.com/1063030
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559372}

Adds content::AuraWindowVideoCaptureDevice, which provides screen
capture of aura::Windows that have compositor frame sinks associated
with them. Then, for Chrome OS browser window capture, where a CFS is
not available, use a fall-back window capturer impl instead. The
intention is for the LameWindowCapturerChromeOS to be a temporary
solution until more work is complete on services/ui/ws (the new Window
Service).

Note: This change does not activate the new impl yet. A follow-up
change will switch from the legacy impl to the new impl.

Bug: 806366
Change-Id: Ia6aa81e4addde603b120a6ab61c5e35a0041b418
Reviewed-on: https://chromium-review.googlesource.com/1006366
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Adam Parker <amp@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559371}

This increases stability of chunk ids under subsequences to reduce
full chunk invalidation because of chunk id changes. This especially
improves chunk id stability that was reduced by crrev.com/c/1027209.

This also helps to stabilize composited layer ids for SPv2, though
I need some more work for it (crbug.com/842356).

An example:
  Paint N-1:
  {
    ScopedPaintChunkProperties properties1(id1, same_properties);
    PaintBackground();
  }
  {
    ScopedPaintChunkProperties properties2(id2, same_properties);
    PaintForeground();
  }

  Paint N:
  {
    ScopedPaintChunkProperties properties2(id2, same_properties);
    PaintForeground();
  }

Previously, in Paint N-1, we combined both background and foreground
in chunk(id1), and in Paint N, we painted forground in chunk(id2).
Because the paint invalidator saw that chunk(id1) disappeared and
chunk(id2) appeared, it issued full chunk invalidation for
chunk(id1) and chunk(id2).

With this CL we'll force chunk for background and foreground, so
we'll issue chunk invalidation for the background only.

Measurements:
For all compositing and paint layout tests, this increases total
number of chunks from 3390 to 3676. (For comparison,
crrev.com/c/1027209 reduced the number from 4055 to 3390.)

Bug: 838456,842356
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4e9809fee46364189845b293706ff70554f562ba
Reviewed-on: https://chromium-review.googlesource.com/1040876
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559370}

Implementing custom caption bar as there will likely be motion specs
requiring unique animation.

Close button not currently wired up.
Demo in bug.

Also fixed a height issue with DialogPlate.

Bug: b:79440488
Change-Id: I6eecff9c48c231e1b1d8aaea026baca09979b7ca
Reviewed-on: https://chromium-review.googlesource.com/1062185Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#559369}

This reuses a lot of the existing code for shapes located within
core/layout/shape.

As a result of this after we perform a layout on a float, we need to
copy some additional shape data back into the existing tree so that the
ShapeOutsideInfo is up to date.

Devtools currently requires the ShapeOutsideInfo object to be up to
date for the appropriate LayoutBox object. (This is used to draw the
"shape area" when hovering on an element within devtools).

In the future (once everything has a NGLayoutResult) we'll likely be
able to remove the ShapeOutsideInfo object, and replace it with just a
"computed shape" living off the NGLayoutResult.

The majority of the work is done within ng_layout_opportunity.cc which
calculates a new line-layout-opportunity based on the shape area.

The rebaselines in this patch:
spec-examples/shape-outside-{010..019}-expected.txt
... are for "change detector tests". We do pass them in LayoutNG but
"better". (We place things closer to the shape typically). One LayoutNG
has been switched on we can fix/change these tests.

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I029b1503be74b4a17e0a634ec93c644ff4352358
Reviewed-on: https://chromium-review.googlesource.com/1032884
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559368}

Bug: 733662
Bug: 824429
Change-Id: I58b625aac5c07d0d3a0d2bd0a2a40c0d52011cb7
Reviewed-on: https://chromium-review.googlesource.com/1059977
Commit-Queue: Jiaquan He <hejq@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559367}

Rather than plumbing around an int64_t for color, using a magic value to
represent an invalid/null color, just use base::Optional.

This simplifies the code in a number of ways:
- No more magic values
- No need to assume that all non-magic int64_t values fit in a uint32_t
- No more reinterpret_cast<uint32_t&>

The conversion helpers are consolidated into color_helpers.h and shared
as well.

Bug: 836683
Change-Id: I09ac717f3c852c63680a2c1c561ee8e2fed98777
Reviewed-on: https://chromium-review.googlesource.com/1050994
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559366}

Ensure that click-to-script functionality is only applied if the feature
is enabled. This guarantees that users have an escape hatch.

Bug: 841465

Change-Id: Ieaf7aa19af449329f536fc46ec3b4dedf09c66b8
Reviewed-on: https://chromium-review.googlesource.com/1053049Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559365}

https://chromium.googlesource.com/catapult.git/+log/a7e134aa0dbf..07bcf9fc1678

$ git log a7e134aa0..07bcf9fc1 --date=short --no-merges --format='%ad %ae %s'
2018-05-16 szager Add linux support for interval profiling
2018-05-16 benjhayden Add iron-icons to third_party/polymer2.
2018-05-16 simonhatch Histogram - Cache info types

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:839645


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I506c9407ed2cebcdce0ff04dacf5e1e68a849206
Reviewed-on: https://chromium-review.googlesource.com/1062936Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559364}

SignedExchangeDevToolsProxy sends the SignedExchangeHeader and the certificate
information and the error messages to DevTools.
When the user clicks a signed exchange response in Network panel, these
information will be displayed in the Preview panel.

And the network grid view will show “from SignedExchange” in the size column of
the content of the signed exchange like “from disk cache”.

See the doc for more details: https://bit.ly/2HXVbCU

This CL depends on https://crrev.com/c/1029755

Bug: 830505
Change-Id: Ice3743f2e1675b6d604eeaba731ebd8494c2b5a1
Reviewed-on: https://chromium-review.googlesource.com/1004890Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559363}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I7aa131974aa56db2faf380da90b06a015a928f3d
Reviewed-on: https://chromium-review.googlesource.com/1063038Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559362}

Bug: 827128
Change-Id: Id23ecbb271fc2b27b6bd06a66d260d1dd4dfe27b
Reviewed-on: https://chromium-review.googlesource.com/1028553
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559361}

BUG=837155

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I51327a0a0fcd8f23050ccc214f0169e8b6740e6d
Reviewed-on: https://chromium-review.googlesource.com/1051262Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#559360}

Users need to be able to preview any of the possible voices in order to
be able to pick a reasonable default. Now, to preview the voice, the
tts_handler requests the tts_controller to speak directly, which allows
for more control over the voice used than window.speechsynthesis.

Re-ordering page after discussion with a11y team about common use-cases.

Bug: 823359
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0e12d1a2865ae5ab9281b5a08d578ad49b1999f2
Reviewed-on: https://chromium-review.googlesource.com/1052925
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559359}

Current we have a NOTREACHED() which essentially DCHECK that
MediaDrmBridge::IsKeySystemSupported(key_system) must return true. This
DCHECK is based on the fact that we called the same function when
deciding whether the key system is supported [1]. However, that is
called in the browser process and the DCHECK is in the GPU process.
Also, the DCHECK could happen much later. Further, the implemenation of
MediaDrmBridge::IsKeySystemSupported() actually calls into Java
MediaDrm, where it's hard to assume what it'll return.

This CL removes the NOTREACHED() so that if that happens we'll just
fail. UMA is also added to track how often this happens in the field.

[1] See CdmMessageFilterAndroid::OnQueryKeySystemSupport()

Bug: 843784
Change-Id: I6ce743033811e4d2bfbde75ccb715697e6205063
Reviewed-on: https://chromium-review.googlesource.com/1062803
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559358}

https://pdfium.googlesource.com/pdfium.git/+log/33515fbec463..98ec53359b8e

$ git log 33515fbec..98ec53359 --date=short --no-merges --format='%ad %ae %s'
2018-05-16 rharrison Add support for PartionRealloc to return nullptr
2018-05-16 thestig Update third_party/base/bits.h.
2018-05-16 tsepez Remove some more unused #defines
2018-05-16 tsepez Move FX_LBUN shorthand codes from .h to .cpp file

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:783022


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I6a02d43557a7e40c91e953fb0a1324bb44d7710d
Reviewed-on: https://chromium-review.googlesource.com/1062772
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559357}

This CL adds Stability.ChildFrameCrash.Visibility which is logged after
detecting that a sad subframe is shown.  The logged enum describes the
timing of a renderer crash in relation to whether the subframe is
visible or not.

Bug: 841493
Change-Id: Ic893764817bd1a9aa31684d53f858a398a31dfc8
Reviewed-on: https://chromium-review.googlesource.com/1054099Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559356}

CMake does not like .cc files mixed with .h files in add_library targets
so we filter only for .cc files.

Bug: 827294
Change-Id: I793d39b90d5f38d9c66704b19c39d0cc48ebdf43
Reviewed-on: https://chromium-review.googlesource.com/1062076
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559355}

Currently MediaDrmBridge::Create() is doing a lot of work, including
initializing storage and fetching origin ID. We also plan to handle
provisioning as part of MediaDrmBridge creation (see Bug).

Given MediaDrmBridge::Create() is a static function, there's no easy way
to hold objects we created before MediaDrmBridge is finally created and
initialized. For example, today we have to bind MediaDrmStorageBridge
into a callback. This makes the code harder to read. Also, if the
storage never fires the initialization callback, the object will be held
in the callback even after CdmFactory is destroyed, making the lifetime
more complex. For another example, for finish provisioning before firing
|cdm_created_cb|, we also need a way to hold the created-not-provisioned
CDM.

This CL adds a MediaDrmBridgeFactory to hold the async creation logic
and temporary objects. AndroidCdmFactory owns MediaDrmBridgeFactory so
that if AndroidCdmFactory is destroyed, the creation of CDM is cancelled
cleanly.

Bug: 834965
Change-Id: I890d800e7ef86df85a8b027d41154148db706e57
Reviewed-on: https://chromium-review.googlesource.com/1059011Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559354}

Implement NGBoxFragmentPainter::AdjustForScrolledContent among requisite
support methods. Falls back on the underlying layout object for overflow
computation for now as scrolling and overflow isn't supported by NG yet.

Test: fast/overflow/overflow-with-local-background-attachment.html
Bug: 714962
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Idd77f7ef5c55f320255325045ed5cc00d14fa159
Reviewed-on: https://chromium-review.googlesource.com/1062325Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559353}

SitePerProcess and IsolateOrigins work on Chrome Desktop (including Chrome OS).
We don't want to make them work on Android, because enterprises that want and
can use SI on Desktop might not have an Android fleet capable of it yet. For
those that do also want SI on Android, these new Android-specific settings
enable that.

BUG=783842,760761

TEST=Enable one of the new Android-specific policy settings (e.g.
IsolateOriginsAndroid) for an enterprise-managed Android device, then follow the
verification steps given in https://support.google.com/chrome/a/answer/7581529
(under "Verify Site Isolation"). Then do the same but with the other policy
setting (e.g. SitePerProcessAndroid). For both, check also that enabling only
the Android-specific policies does not enable SI on Desktop machines in the same
management domain.

Change-Id: Id304937132723a6856b0e507bc4b9d801403c429
Reviewed-on: https://chromium-review.googlesource.com/1026390Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559352}

A series of tests in viz_browser_tests and viz_content_browsertests have been
fixed, but no re-enabled.

This re-enables them.

TBR=kylechar@chromium.org
TEST=viz_browser_tests, viz_content_browsertests

Bug: 	794961
Change-Id: Ife0401cc891696a549aa180cbc0cf0034bc5bc5c
Reviewed-on: https://chromium-review.googlesource.com/1062812Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559351}

In the WebUI dialog, this is shown with the same display icon [1].
In the Views dialog, this uses the new input icon [2].

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js?l=962
[2] https://cs.chromium.org/chromium/src/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc?sq=package:chromium&l=36

Bug: 826393
Change-Id: I44333292ba95695fd64b5421303a1c8d75a74459
Reviewed-on: https://chromium-review.googlesource.com/1052912Reviewed-by: Adam Parker <amp@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559350}

This CL adds the controller changes for the download progress infobar.
UX : https://docs.google.com/presentation/d/1wfX6QkEzDbt3Bx2hj6v85_lND1iSUUfXIZN6TMhREuo

Key points :
1 - The controller listens to all the updates from downloads and offline
content agggregator. It converts download items into offline items,
keeps track of all the offline items in a current session.
2 - The state transitions between accelerating, downloading one or more
files, downloads complete/failed/pending etc is handled in the controller as per the UX.

Bug: 1003754
Change-Id: Id7d3d9f91616c79facbcf87a82346f70709e2af2
Reviewed-on: https://chromium-review.googlesource.com/1003873Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559349}

Removes the last dubious API surface (size_t usage) in the core ABI and
documents the ABI as stable.

Bug: 822034,819046
Change-Id: I60438dd6613d45738514a92ce8c21777b859bfee
Reviewed-on: https://chromium-review.googlesource.com/1062932Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559348}

In Blink, we parse floating point numbers such as those from ARIA value now from strings to doubles.

In the midst of conversions, we incur some amount of errors (trailing garbage) when converting from doubles to floats.

To see this, within Blink,

LOG(ERROR) << "Float valueNow=" << base::NumberToString(float_value);

for the snippet:
<div role="progressbar" aria-valuenow=0.05>

You will see:
0.05000000074505806

V8 uses doubles in its underlying number type.

For the purposes of automation, default to a precision of 2 decimal places.

Since the underlying data is always available, we can consider exposing a more full featured api like GetFloatAttribute(int precision) to the wrapping js and on up to chrome.automation.AutomationNode, if needed.

Bug: 841972
Change-Id: Ideb979d43d7ed28bae8a5293f0f40fb2a7c79199
Reviewed-on: https://chromium-review.googlesource.com/1058448Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559347}

The issue here is that viewports_need_updating_ is uninitialized until
OnResume, and that leaves viewports uninitialized until the first
DrawFrame after OnResume.

However, some incoming calls from mojo, such as UpdateLayerBounds may
be processed before that first DrawFrame.

The fix is to initialize viewports_need_updating_ to true, so viewports
are created in InitializeRenderer, before mojo calls are processed.

This then creates a new bug, where we lose the UVs set by a call to
UpdateLayerBounds before the first OnResume/DrawFrame. We need to cache
the bounds and can reapply them when creating new viewports.

BUG=839108

Change-Id: Ieef7f98d9606fe033095e8b8a8e9cde92afdcccc
Reviewed-on: https://chromium-review.googlesource.com/1062930Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559346}

R=hinoka@chromium.org

Bug: 843638
Change-Id: I80fc3f991b697298c8866d6e81ea64e7c1aed256
Reviewed-on: https://chromium-review.googlesource.com/1062944Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559345}

They were missing the snapshot-level annotations (prod, ver, plat, and
channel), client ID, and report ID.

Bug: 842806
Change-Id: Ic6784728d57e747515197bc45e990cb2bb684834
Reviewed-on: https://chromium-review.googlesource.com/1062807Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559344}

Bug: 842865
Change-Id: I46f2b69c56ae157e72d4e513e326094fb050b288
Reviewed-on: https://chromium-review.googlesource.com/1058592Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559343}

Sometimes a function would have multiple signatures in the IDL files
with the difference just being some of the arguments are optional.
This patch improves the deduplication logic to correctly support
array.splice(start, ?deleteCount, ...items)

Change-Id: Ie9230d54dadd1c8c7cadbb92afc37fbfa87ea857
Reviewed-on: https://chromium-review.googlesource.com/1062885Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559342}

A min-height was only supposed to apply within settings, so this CL
moves that back.

Even after that though, the cr-radio-button would have a forced 40px
height due to how disc-wrapper and ripples were styled. This CL adjusts
the styling such that the circle only takes up 16x16 space in the layout,
and instead the ripple is absolutely positioned and out of the layout.

Note that settings has styling to override min-height and padding
of cr-radio-buttons, so visuals before and after this CL is unchanged, but
this will make replacing paper-radio-button with cr-radio-button
outside of settings easier.

Bug: 840527
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idc7d52cd8ced581bd81ac682cadf97ae4948fb55
Reviewed-on: https://chromium-review.googlesource.com/1060517Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559341}

Implement the frontend mojo interface for chrome://snippets-internals
and talk to the backend interface.

Bug: 830931
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifc1e1d890153ac90a62fff82e15cdb8724ca0b09
Reviewed-on: https://chromium-review.googlesource.com/1053381
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559340}

- Move ui/arc into ash/system/message_center/arc
- Merge ui_arc_unittests into ash_unittests

Bug: 768439
Change-Id: I56dd855ee2b4defefd9c57fd0c1b5bda453e61e7
Reviewed-on: https://chromium-review.googlesource.com/1053302
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559339}

Animating looks bad for OOBE, and doesn't really make things look much
better in general.

Bug: internal b/77704079
Test: cast something
Change-Id: I37784c5952873eb0f8d1e0f79e8dd650f176f73f
Reviewed-on: https://chromium-review.googlesource.com/1047997Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Thoren Paulson <thoren@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559338}

Bug: 838354
Change-Id: Icf745b379da838efcddf58a723c03fa71ad814c4
Reviewed-on: https://chromium-review.googlesource.com/1060640
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559337}

Currently, when the keyboard is shown, we check if it obscures the
focused window. If it does, we move the focused window upwards so that
it's no longer obscured by the text field.

While this works well for the docked keyboard, it doesn't make much
sense for the floating keyboard. Thus, we change the logic to use
the occluded bounds of the keyboard to check whether it obscures the
focused window. The occluded bounds is the same as the actual bounds
for the docked keyboard, but is empty for the floating keyboard. This
means that the floating keyboard will no longer cause the focused
window to move upwards.

Bug: 838731
Change-Id: Id5de5c35980c69443be114631840bdfb64f26b3e
Reviewed-on: https://chromium-review.googlesource.com/1059976Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559336}