- 14 Dec, 2020 40 commits
-
-
Frédéric Wang authored
In [1], security levels 0-1 were introduced for registerProtocolHandler. This CL adds a third level: Level 0: Strictly follow the HTML5 specification (*). Level 1: Allow registration from cross-origin. Level 2: Allow registration of ext+ scheme and chrome-extension:// handler. The ext+ scheme covers one of the use case mentioned in [2] : Extensions willing to register protocols for a "reserved" scheme, that is not overridable by pages. The HTML5 specification does not allow handler with chrome-extension:// scheme [3]. However, removing it was not possible without breaking existing extensions [4]. This CL changes that behavior to both match the spec and allow registration of handler with chrome-extension:// scheme in the context of extensions. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2287304 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=64100#c19 [3] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers [4] https://chromium-review.googlesource.com/c/chromium/src/+/1728369 Bug: 64100 Change-Id: I60e6abc19d5a134c67a9ab7a1ff83b7d11ea3622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560305Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#836557}
-
Alice Wang authored
This CL moves two confirm sync dialog tests to the junit target of c.b.signin.ui module. Bug: 1156585, 1156588 Change-Id: I3f54d90707a20ab22671d3f20e8ef1146c784cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584977Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#836556}
-
Alice Wang authored
This CL moves ConfirmSyncDataStateMachine to signin.ui target. Bug: 1156609 Change-Id: I8cf36f4597c6566fd2f81a1fc896255d90d0277c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584881Reviewed-by:
-
Morten Stenshorne authored
Not sure what fixed it (went through some recent "suspicious" CLs, but it wasn't any of them). TBR=almaher@microsoft.com Change-Id: Id2283b394b667798ebf4d4060bf260c6916f1eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588929Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#836554}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607903843-a675fcd2050380ffbc0661240474ef4aba9bd536.profdata to chrome-linux-master-1607925234-871dfb77196d03b9fcef95521dbd7963c906e6ee.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7c4df23997b3db699908c84798587bef025bb9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589224Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836553}
-
arthursonzogni authored
Users wanting to prevent plugins to be used were providing an empty list of plugin type to the 'plugin-types' directive. As a result, they were getting a console error, despite getting the intended behavior. It was not clear to the user what was wrong. Users should use object-src: 'none' instead. This patch reflects this into the error message. Bug: 1111546 Fixed: 1111546 Change-Id: I64a266582e33fa3417293ebfdb2e6bf87e08578e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584943 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d3bcd2b23165..68da2313ca77 2020-12-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c75473c2cf88 to 282fb4092b6c (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: Ibf13ab15ae6c89c2864a51cd81dc7f52f74dbb5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589218Reviewed-by:
-
Ikjoon Jang authored
Replace defined(OS_CHROMEOS) or BUILDFLAG(IS_CHROMEOS_ASH) with BUILDFLAG(IS_CHROMEOS_ASH) || BUILDFLAG(IS_CHROMEOS_LACROS) to apply scheduler boosting to both world. BUG=1041117,1052397,b:159370915 TEST=check /proc/*/sched for all urgent threads Signed-off-by:
Ikjoon Jang <ikjn@chromium.org> Change-Id: Ic3c61b36977d1675037983cd159164bd38a50aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563423 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#836550}
-
Nancy Wang authored
This CL adds the convert functions to convert the restore data to base::Value. Add FullRestoreFileHandler to convert the restore data to JSON string, and write to the full restore file. BUG=1146900 Change-Id: I1e93579464cf97ab04235599fc5519f86a606e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581709 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607903843-cfbf56cfb9918bf3ea560508846f459222f50389.profdata to chrome-mac-master-1607925234-ef20c18621d9ca5f7c0d39fedb05c76a05c36900.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib28e7d3e4f9ec172054d468e4492f9d770e80b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589221Reviewed-by:
-
Koji Ishii authored
When |NGLineBreaker| finds a forced break, it includes following close-tags but not empty text items. This caused an additional empty line when there are spaces before/after the close-tags, which causes the `widows` property to count the empty lines. This patch changes |NGLineBreaker| to include them as well. Bug: 1156773 Change-Id: Id01966dd57dce3185d384544e9af662fd43917c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584431Reviewed-by:
-
Anthony Polito authored
this was generated by an automated workflow Bug: 1113033 Change-Id: I9ac4108a97bc50fa795d1b425925b7a82177e20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586280 Auto-Submit: Anthony Polito <apolito@google.com> Reviewed-by:
-
Christian Dullweber authored
We still need the flag. Bug: 1077766 Change-Id: Iba4c5834636845716872209019bd3eb4ccbba5c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584925 Auto-Submit: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#836545}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/da8c22614051..282fb4092b6c 2020-12-14 syoussefi@chromium.org Fix link validation of I/O block members If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I4bb98d59684a5a2412d07ed369d9d67fc72ad9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589002Reviewed-by:
-
Taoyu Li authored
BUG=b:175079058 TEST=manual: verify routes6 view is included in feedback log. Change-Id: I192efc11547d7169d22d8f252ef10fa5177d9d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578338Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Hugo Benichi <hugobenichi@google.com> Auto-Submit: Taoyu Li <taoyl@chromium.org> Commit-Queue: Taoyu Li <taoyl@chromium.org> Cr-Commit-Position: refs/heads/master@{#836543}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/35ebfe2c3bf8..d3bcd2b23165 2020-12-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0a64a9747555 to c16dc7107fd3 (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: I26d47b1b6328113c1324f5a8cd89cb13c564990d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588820Reviewed-by:
-
Kenichi Ishibashi authored
To de-flake payment related browser_tests. These tests call GetUserDataForAllRegistrationsByKeyPrefix() more than 500 times. Storage operations are serialized as of crrev.com/c/2494208 but the serialization mechanism doesn't seem to be working correctly for these tests. There seems a situation where we don't call the callback of the method and hit DCHECK() in mojo generated bindings. This CL stops serializing storage operations. Follow-up CLs will address the root cause and re-implement the serialization. I ran LoadAndRemoveIframeWithManyPaymentRequestsTest 50 times on my local environment and didn't observe flakiness. Without this CL the test crashed once every 5 times. Bug: 1129578,1133143 Change-Id: I3054f02eadfb21c570124aca5a377d8112ef8cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584432 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#836541}
-
Nancy Wang authored
This CL adds the interface AddAppLaunchInfo to the RestoreData class. This interface will be used by FullRestoreSaveHandler to save the app launch parameters to the restore data. The unit tests are added to verify the interface. BUG=1146900 Change-Id: I4cc9a5f967ce1c9d19d14ffc79f390fd91cb89db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581623 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Lingqi Chi authored
This is part of work to control the Mojo interfaces available to prerendered pages. See design doc[1] for more details. In addition to content/, embedders define their own Mojo interfaces, so they need to add their binding policies. This CL adds a new content API named MojoBinderPolicyMap that allows embedders to register policies for embedder-specific interfaces by overriding ContentBrowserClient::RegisterMojoBinderPolicyMap method. [1] https://docs.google.com/document/d/1E3Ma8HQFmxx8OvWVrjqpLziYIRbTRgLat4cM-nyKB6w/edit?usp=sharing Bug: 1132752 Change-Id: Ie47a9fc2517fd3cda8438e9c61a5fa6854a8f36d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507230Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Lingqi Chi <lingqi@chromium.org> Cr-Commit-Position: refs/heads/master@{#836539}
-
David Lei authored
b/163285796 was a duplicate of b/164613918 which is fixed. Change-Id: I92141ccb9b03267eb78b482a5db008a59a320b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589253Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
David Lei <dlei@google.com> Commit-Queue: Trent Apted <tapted@chromium.org> Auto-Submit: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#836538}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/86263397d149..822333dd25e7 2020-12-14 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Catapult from ed4fb99735f4 to 0991ca17bab3 (34 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I8863be122ccacc92cd00e584b4bc3b4f539119c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589215Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607891758-dfc01cb84a8cbce40136b5ebc3d0c450466784dd.profdata to chrome-win64-master-1607903843-e9f03e03b6a80ac1b9393fa413e44243742fdb9c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6fa3d143a477cb7a85778c98e3c1a363bfc33976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589003Reviewed-by:
-
Luciano Pacheco authored
This is the last file for //ui/file_manager/file_manager/common/js/. Remove unused `ProgressCenterEvent`. Sort alphabetically the js_modulizer() input_files. Bug: 1133186 Change-Id: I4478aca92889231801a97f265f0d5c28828e1493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589255 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#836535}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fdc63243..afdda12d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I622c67032a343bb83522cfa00da75fb1c85deb3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589012Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836534}
-
Hiroki Nakagawa authored
<link rel=next> is expected to trigger prerendering like <link rel=prerender>. Note that when the feature flag `kPrerender2` is disabled, <link rel=next> triggers NoStatePrefetch. Bug: 1155925 Change-Id: If430701e125dcc55e9bded8350dcc43eed8a1a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578499Reviewed-by:
-
Alan Cutter authored
This CL replaces a check that was accidentally removed by: https://chromium-review.googlesource.com/c/chromium/src/+/2422022 Specifically the lines: const base::FilePath dir = DetermineScanDir(profile_); if (dir.empty()) { std::move(callback).Run(std::vector<ExternalInstallOptions>()); return; } Without this check Chrome would attempt to read json files in its own installation directory on non-Chrome OS platforms. Bug: 1157424 Change-Id: I351ad24d13c1ce394660f74013d094adef2a02f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585257 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#836532}
-
Joel Hockey authored
Bug: 1144138 Change-Id: I970293c61c9686ab32f574957c028bd3db754ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589049 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#836531}
-
Fergal Daly authored
Looks like render_frame_created_ is getting reset to true inside RenderFrameDeleted! - extend the dump_on_render_frame_created_for_bug_1146573_ region to catch this. - add dump points inside RenderFrameDeleted. These seem redundant if the the prior debugging works but I want to avoid yet another round. Bug: 1146573 Change-Id: I93dfd0a89fd9b95fc3e86e68189195c3b9c6dc08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586456Reviewed-by:
-
Leo Lai authored
We are deprecating GetTpmStatus APIs by cryptohome. Also, GetLoginStatus is a better fit to reporting "lock to single user" status. BUG=b:172748724 TEST=unit_tests. Cq-Depend: chromium:2586412 Change-Id: I096e09c8ecbc670b03f375f059f70d466f8839e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586414 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#836529}
-
Bo Majewski authored
Adding chrome://file-manager/* as one of the URLs allowed to use metics private. This allows us to remove faked out metrics private from file_manager_fakes.js Bug: 1113981 Change-Id: Ica90a7fe5560474bde91bbd911782d5cdca57211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586417 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#836528}
-
Melissa Zhang authored
We are adding a nullcheck before the callback because callers may call ShowBubble with NullCallback. Bug: 1142706 Change-Id: I2d3c1376b036057a2e5890e20a10f6478d5c7075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589139 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Auto-Submit: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 97514559. With Chromium commits locally applied on WPT: ced49c96 "[AspectRatio] Correctly handle abspos replaced elements with aspect-ratio" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ibd2f63c22377281fb8c19fefae1383fa15a097da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588754Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836526}
-
Jérémie Boulic authored
Update the modules generation script with the changes below. Fix reformatting of single-line dependency lists: empty dependency lists (e.g. `deps = []`) were rewritten on multiple lines (deps = [\n]) incorrectly. In the `find_dependencies` function, simplify calls to `add_dependency` by the need for redundant `if is_unittest... else...`. "//chrome/test/data/webui:chai_assert" can be imported in non-unittest files, and "//ui/webui/resources/js" can be imported in unittest files. Remove unittest distinction when importing variabble from these locations. Fix function exports: The detection of functions used a variable (the name of the function the export) that was not defined. Fix test function exports: when converting the same unittest multiple times, the "export" keyword was added multiple times in front of each test function to be exported. Facilitate testing by adding a `add_js_file_exports` function that takes `file_lines` as arguments (`convert_js_file` is harder to test directly, taking a file path as argument). Fix edge case where, when the only reported closure error is about extending `EventTarget`, the script doesn't do what's needed to fix it: Run `find_dependencies` whether or not there is any variable to import. Add unittests and presubmit script. Bug: 1133186 Test: ui/file_manager/base/tools/modules_test.py Change-Id: Ia0ed675576d021b3b952215384e7a491ff7f4430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580970 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
Jiewei Qian authored
This is a preparation for implementing a new LaunchSystemWebApp API, where we use AppService to launch apps and don't return the Browser object hosting the app (because AppService doesn't return it to us). This change is safe for terminal, because LaunchSystemWebApp won't fail if it is called with appropriate parameters after OnAppsSynchronized. The metrics for CrostiniResult::UNKNOWN_ERROR contains other error origins, and don't reflect whether LaunchSystemWebApp fails. Bug: 1154540 Change-Id: I517202293140a7907f8af061ecbffec3dac623e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576861Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#836524}
-
Nancy Wang authored
The RestoreData class is the full restore data in memory to be written to the FullRestoreData file. There will be some separate CLs to convert RestoreData to JSON format, and write the full restore data to a file. BUG=1146900 Change-Id: I7b51b0ba6e1cbe4f7a4b763a52e81f273a74c8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581702Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I3db1da41cad058389067728e80c4f94f7e54e2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589115Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836522}
-
Wei Lee authored
This CL implements the CameraPrivacySwitchObserver on Chrome side and provide an interface in CameraHalDispatcherImpl to let other components in Chrome to add observers for camera privacy switch status changed. Bug: b/167994459 Test: Build successfully Change-Id: I4efe132cd2d0a5988a4ffeb99ab0ca2802ad2a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551882 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#836521}
-
Wei Lee authored
It is a requirement on Android R to pass the CtsVerifier Camera Intents test. Bug: b/173559007 Test: Pass CtsVerifier Camera Intents test. Change-Id: If2e9bc084af62ce634242c1f45eb7e339a15d452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560436 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#836520}
-
Melissa Zhang authored
Bug: 1157709 Change-Id: I67e0fa6488a7bd8c0fa980372dba3a8444dd2c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586170 Auto-Submit: Melissa Zhang <melzhang@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
Moves the timeout mechanism for bfcache-deferred network requests to be per-request, allowing the timer to be stopped when we see that the request finished loading/failed/etc, so we won't evict the page if all the loads have finished. Bug: 1137682 Change-Id: I781f2739133b47a78295c66c5de94d97c6a8bdfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583601Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#836518}
-
