- 22 Sep, 2020 40 commits
-
-
Jazz Xu authored
This CL adds media controls detailed view. When media controls is clicked outside of action buttons, we will navigate user to a detailed view showing all playing media. Bug: 1129784 Change-Id: I9b84089caacc36229664096af0fbf4f8a31b3f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416682 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#809528}
-
evliu authored
This CL moves the Speech On-Device API (SODA) internal repo to the Chromium repo in preparation for dogfooding in accordance with LGPL. Change-Id: I0d073f4e98a2423b86e43b069320dd61546f39d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404156 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#809527}
-
David Black authored
Unpinning an item from its view may result in that view being deleted. If the view is deleted, we shouldn't attempt to update its pin. Bug: 1130086 Change-Id: Ib5c8dbe086b4446161569924b3c81a9bd37d272c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422247 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#809526}
-
Daniel Classon authored
Fixes a bug where the "Remove Account" search tag showed up in search when there was no second account to remove. Bug: 1116553 Change-Id: I800ebc0d667d0417303f0d11458ea152e1849589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422457 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#809525}
-
David Black authored
This CL also adds focus ring for indication of focus. Bug: 1129694 Change-Id: I0140b01dd6d6ef758176b942622d222005a5710e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424824Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#809524}
-
Nina Satragno authored
Add support for PinUvAuthToken on large blobs. https://w3c.github.io/webauthn/#sctn-large-blob-extension Bug: 1114875 Change-Id: I57a094eed4cb0cd3d8b20722804826a46ccf0e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422707 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#809523}
-
Leonard Grey authored
This reverts commit f2f4de88. Reason for revert: Crashing on Win7 bots Example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8868424013558569488/+/steps/capture_unittests/0/logs/Deterministic_failure:_VideoCaptureDeviceMFWinTestWithDXGI.SimpleInit__status_CRASH_/0 Original change's description: > [Win Camera Capture] Use D3D11 with Media Foundation Video Capture > > This CL updates the VideoCaptureDeviceFactoryWin/VideoCaptureDeviceMFWin > implementations to use D3D11 with the MF device source and capture > engine. The VideoCaptureDeviceFactoryWin creates and manages an > IMFDXGIDeviceManager and associated D3D11 device instance. It provides > the IMFDXGIDeviceManager to the MF device source and also plumbs it to > the VideoCaptureDeviceMFWin implementation. The VideoCaptureDeviceMFWin > implementation subsequently provides the IMFDXGIDeviceManager to the MF > capture engine on initialization. > > Providing a MF DXGI device manager to the MF device source and capture > engine is required for zero-copy capture (it allows the Windows frame > server service and MF capture engine to keep captured video frames in > GPU memory and expose MF samples backed by D3D11 textures). > > Bug: 1120900 > Change-Id: Ic5367d03f337daab2220f8d87d1bfe51f6ca8b72 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370092 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Markus Handell <handellm@google.com> > Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> > Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Isuru Pathirana <Isuru.Pathirana@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#809472} TBR=mcasas@chromium.org,stefan@webrtc.org,sunnyps@chromium.org,rafael.cintron@microsoft.com,guidou@chromium.org,chfremer@chromium.org,ilnik@chromium.org,handellm@google.com,Isuru.Pathirana@microsoft.com,handellm@chromium.org Change-Id: I8d3559eb85d195d76263f905ce3884c879254e7f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1120900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424898Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#809522}
-
Yulun Wu authored
All search results will be displayed using primary text coloring. Bug: 1130822 Change-Id: Id55060e52e62d263da50ec8d507b742e812902c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421441Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809521}
-
Fredrik Söderqvist authored
For some LayoutObjects that are "SVG children", we will not create and associate a SVGResourceClient. Check for the presence of such an object FragmentPaintPropertyTreeBuilder::UpdateFilter(). Bug: 109224, 1130986 Change-Id: Iab6e73b26a302282ecbe5235d671fbfe90753d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424124Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#809520}
-
Mason Freed authored
It seems that the kDefaultDocumentClass should work just the same, as nothing currently checks for kViewSourceDocumentClass. Bug: 920571 Change-Id: I63088c00c0fa773f8c597f0f88768a984a6fc994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424628 Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#809519}
-
Natalie Chouinard authored
By default, GMS Core will use best effort matching to provide a font within the same family if the exact match is not available. For this use case, providing a font match for the renderer, only exact matches are valid results, so the query now includes besteffort=false. Bug: 1111148 Change-Id: I9bad598b7c4d9d64ebf3ce9297015e335185b928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419592 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#809518}
-
Xianzhu Wang authored
- Combine kEnableOnly into kDefault. The difference between them was that kDefault respects field trial settings and both --enable-feature and --disable-feature, while kEnableOnly didn't respect the disabled status of field trial and --disable-feature. This doesn't affect the default status of the features. 35 features are changed from kEnableOnly to kDefault. - If applicable, use kDefault for features that used kDisableOnly. The difference between kDisableOnly and kDefault was similar to the above, but for enabled status of field trial and --enable-features. All of the changed features are already enabled by default in Chromium and have status:"stable" in Blink, so the change doesn't affect the default status of the features. The following features are changed from kDisableOnly to kDefault: WebUsb, BackgroundFetch, InstallApp, BlockCredentialedSubresources. - Remove kDisableOnly and kEnableOnlyIfOverriddenFromCommandLine, and add kSetOnlyIfOverridden for origin trial features that require the Chromium feature to be enabled by default and the blink feature to be controlled by origin trials, or for features that are enabled by default in Chromium but not in Blink. The following features are changed to kSetOnlyIfOverridden: NotificationContentImage, Portals, IdleDetection, SmsReceiver, WebNfc. Bug: 1048656 Change-Id: Ifa3e590773212411097d07233b68b3c7a199a54f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419579 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#809517}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/ca11026a032c..2be1c17fda0d $ git log ca11026a0..2be1c17fd --date=short --no-merges --format='%ad %ae %s' 2020-09-22 junyer Migrate from Kokoro to GitHub Actions for Bazel. 2020-09-22 junyer Migrate from Kokoro to GitHub Actions for CMake. 2020-09-22 junyer Remove Travis CI configuration. 2020-09-22 junyer Initial GitHub Actions CI configuration. 2020-09-22 junyer Improve the comments for RE2::FullMatch() et al. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org Change-Id: I4d48c7bf56494987ce64ad8a68a672fdff80da1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424706 Commit-Queue: Paul Wankadia <junyer@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#809516}
-
Andrew Grieve authored
The previous code worked for .apk files created by our build system (where Python performs alignment), but did not work for .apk files that are aligned using Android's zipalign tool (as is the case for bundles). Also changes zipalign overhead to be stored in metadata rather than as a symbol so that the supersize symbols sum matches normalized apk size. Bug: 1130754 Change-Id: Ia852ec1efec4e7a13faa5072cd67cd204148c8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423409 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#809515}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/eb373a50..041c9519 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie832f62eb46c50209ab1aafc841df335e025563c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424446Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809514}
-
Stephen McGruer authored
Bug: 1127055 Change-Id: I656ecf3b2de8962a0d020b2a2548967a18f194bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419131 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#809513}
-
Ken Rockot authored
Generated by running the command in //third_party/metrics_proto/README.chromium Bug: 1127134 Change-Id: I0afff9e9bd3e4e74a0bc547ac397bffcefc67046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424553 Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#809512}
-
rbpotter authored
This will prevent possible collisions, and ensures that files generated by a target all live in that target's output. Note that unpack_pak.py, previously used to create the folder of preprocessed Web UI files, has an equivalent assert. Bug: 1071641 Change-Id: Ic24e2a6c98cc35957c692bfa1a0d40fca1b7423e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424846 Auto-Submit: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809511}
-
Omid Tourzan authored
Bug: 491043 Change-Id: I491dab8627493b91bf4b109707d03130b09c6c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402850 Commit-Queue: Omid Tourzan <oto@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#809510}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/02ffb6f47a21..407b5a54a9b5 2020-09-22 syoussefi@chromium.org Use rstrip when getting footer tags If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1130601 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I66129b9cdef90334a4bbf5e99934b722c4deaa7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424965Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809509}
-
Rune Lillesveen authored
According to spec[1], a mismatching used color-scheme for embedding iframe element and iframe document root element should cause an opaque canvas background for the color-scheme to be painted behind the document background. Modify the ViewPainter to allow painting the base background in an iframe for these cases. Bug: 1058822 Change-Id: I0097d8207c2f697367c477b795bfb2443ebd5cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418322 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#809508}
-
Ghazale Hosseinabadi authored
chrome://extensions/ supports inspect views for the background page. This CL adds the capability to inspect views for an active service worker. Inspecting views of an inactive service worker will be added in a separate CL. Bug: 1107596 Change-Id: I63ba5029817f49955657038e260fe3dac3224d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337075Reviewed-by:
Carlos Pizano <cpu@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Cr-Commit-Position: refs/heads/master@{#809507}
-
Daniel Classon authored
Fix the "Touchpad scroll acceleration" search tag to only show up when the corresponding kAllowScrollSettings flag is enabled. Bug: 1116553 Change-Id: Idc553770da77b33ed7799811798b6bb0e055e0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424828Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Classon <dclasson@google.com> Cr-Commit-Position: refs/heads/master@{#809506}
-
Mohamed Amir Yosef authored
This reverts commit 7e032ee2. Reason for revert: https://ci.chromium.org/p/chrome/builders/ci/linux-autofill-captured-sites-rel/2954 Original change's description: > [Autofill] Fully migrate to the new Autofill server > > The feature "AutofillUseApi" is now enabled by default. > This CL removes it and starts removing dead code upon the removal of > this feature flag. > > Follow up CLs will do more cleanup! > > Bug: 1114655 > Change-Id: Iff96e341280fe35562469d32660446f5568887f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401040 > Reviewed-by: Dominic Battré <battre@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808917} TBR=battre@chromium.org,mamir@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1114655 Change-Id: If370b23b4040ddab1cbde7da0429724ff8a23f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424259Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#809505}
-
John Delaney authored
This change refactors ownership of and references to FrameData's by getting rid of `list` + `map to list iterator` storage which made invalidating references difficult. This adds a new abstraction which either owns a FrameData, or a WeakPtr to a FrameData from another instance. This allows us to never have to worry about accessing invalidated iterators, and not relying on navigation code to delete frames in the proper order. Note that we do not expect the implementation to rely on the WeakPtr invalidation, but this construct makes these errors more apparent via DCHECK. Bug: 1108511 Change-Id: I04d6959ae0bb46a8680f8632741c4b42af1acb5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324603 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809504}
-
Michael Checo authored
Screenshots: - Diagnostics Page (before) http://shortn/_khK2BurTJp - Diagnostics Page (after) http://shortn/_vc4huCgyEv Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I885c8bc77f78bf242ae46b9c8b34121fc17b9980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424823 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#809503}
-
Mark Mentovai authored
8e602f66 (https://chromium-review.googlesource.com/c/2420529) was checked in expediently over the weekend for ${reasons}. This addresses review feedback by refactoring the implementation into library code as needed, and adding full proper tests. Bug: 1130270 Test: chrome/installer/mac/signing/run_mac_signing_tests.py Change-Id: I23a2a2d5ab43a05849f1211f021577cd4ee4b476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422275 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#809502}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2fb4be6e85e6..679e180840fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huangdarwin@google.com,lgrey@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917 Tbr: huangdarwin@google.com,lgrey@google.com Change-Id: I4989e4f151e74c8b00767daf8178a344870d94ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424745Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809501}
-
My Nguyen authored
Proposed new name found in http://go/cros-input-methods Rationale: http://go/cros-input-methods-naming Current view: http://screen/88pFX6hVswESHpL New view: http://screen/ADm7EfmdcEuPfSe Bug: 1113439 Change-Id: I60b9164a76f405ad8d43d5029aa0e4d231095c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421989Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#809500}
-
Olivier Yiptong authored
Consolidate the cache readiness hook implementations in the base class because all the implementations ended up the same. Bug: 1043306 Change-Id: I814c4eb4ca464247336f263ba98af1a1dfd39d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422352 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#809499}
-
Rune Lillesveen authored
Iframes should paint a solid background if the embedding iframe has a used color-scheme different from the used color-scheme of the embedded root element. This CL resolves the background taking the owner_color_scheme_ into account. A follow-up CL will implement the paint side to allow painting the backdrop for iframes. Bug: 1058822 Change-Id: Iadbaeeef32866c150b65a458ebd2a3a78014519d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418854 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#809498}
-
Yi Gu authored
This patches aligns the expiry date with other hit testing metrics. Bug: 1130642 Change-Id: I7a4529982c2f1a824f17b24c53f7df2dfffc73ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424827Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809497}
-
Robbie McElrath authored
This is a followup to crrev.com/c/2412810, which fixed the controls positioning during page loads in every case except the one we were supposed to fix in the original bug. The issue with that CL was that it always set the controls height to be the same as the previous height, or 0 if there weren't controls before. However, the renderer defaults the controls to expanded initially, so collapsing them on first load wasn't the right behavior. To fix this I make onLayout position new controls so that the same amount of them is showing as *the last time a view was set*, and defaults to an expanded view. This is the behavior the renderer follows. Bug: 1128391 Change-Id: I6a2c65629a8d24476e7c2e07158295574cac0c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423007Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#809496}
-
Nathan Zabriskie authored
Currently, shared images in OOPR mode are cleared only during BeginRasterCHROMIUM. This can present some issues when an application triggers a readback of the image before it has been drawn to. This CL changes CanvasResourceProvider::Clear to also support OOPR mode to allow for shared images to be cleared when they're created. Bug: 1023281, 1023259 Change-Id: Ia6bc76efd65156b14a430f7db197868628385325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388434Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#809495}
-
Michael Hansen authored
This updates the Nearby Share subpage and device name dialog to call the settings mojo for reading and writing the device name instead of accessing prefs directly. This is in preparation for a follow-up CL which will add validation and error checking when setting the device name. Bug: b:161297140 Change-Id: If7cad62416c2662e9c070ecaa91b47e43fe3dfae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420773 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#809494}
-
Matthew Denton authored
Adds BrokerProcess:BrokerType to BrokerProcess. It currently only includes SIGNAL_BASED, but will be used to add USER_NOTIF Also adds ForkSignalBasedBroker() in BrokerProcess, in order to factor out the signal mechanism-specific code from BrokerProcess::Init(). Includes some other minor (but related) refactors. Bug: 1117351 Change-Id: Idadeaafb4ef7bb0f952fd0d901cbfb91d59b3486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407059 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#809493}
-
Trevor Perrier authored
Bug: 1127531, 1068667 Change-Id: I4248c6b444906ea5587d985571b70f2231ef3f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342638Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#809492}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/82c70d97576c..3c7133e86f13 2020-09-22 treehugger-gerrit@google.com Merge "Larger default buffer config in UI." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I526878e58bfdef6d13f45a029d2cdac26e67feb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424624Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809491}
-
yjliu authored
Bug: N/A Change-Id: I8b9b5abfdf29006bc01fcdc8c3e5e1b45f1b3033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417404Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809490}
-
George Burgess IV authored
It seems that this constructor call was intended to be used as a scope guard. In order for that to happen, there has to be a variable name here. Bug: 1130379 Change-Id: I1a0df33ddd216ce45cf24238857dbc3d7a8d3913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420918Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#809489}
-