GitLab

Refactor existing code for handling share actions (ShareHelper and
ShareMenuActionHandler) to better fit the MVC model. This is a starting
point for work on the Chrome sharing hub/custom share sheet.

go/chrome-sharing-hub-dd

Bug: 1009124
Change-Id: I6f3825fed98d896507f44d033d953b54cd32131f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850367
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710020}

Bug: 825041
Test: CQ, build
Change-Id: Ieeda5d967ed6ba77334b432810f88a6e01a492bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881688
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Auto-Submit: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710019}

After the primary user requested to enable adb sideloading on the
device, reboot will be necessary to enable the decision is made in fully
trusted environment.

This change adds an OOBE screen for this purpuse.  Upon confirmation, a
DBus message is sent to cryptohome (as a proxy) to enable the flag in
boot lockbox.

Note: Strings are not final and images are placeholder.

      /home/chronos/Local\ State; start ui
      => see confirmation dialog
      => `bootlockboxtool --action=read --key=arc_sideloading_allowed` prints 1
      => `bootlockboxtool --action=read --key=arc_sideloading_allowed` prints 0
      => looks correct.  Clicking "OK" brings us to normal login screen.
      dialog
      => Confirm or cancel doesn't really matter as already enabled.

Test: stop ui; add "EnableAdbSideloadingRequested":true to
Test: click "Enable" brings us to login screen (warning will be added later)
Test: click "Cancel" brings us to login screen (warning will be added later)
Test: Force error state by `$('oobe-adb-sideloading-dialog').uiState_ = 'error'`
Test: (edge case) Enable the feature forcely then show the confirmation
Test: browser_tests --gtest_filter=WizardController*.*
Cq-Depend: chromium:1765656
Bug: chromium:893332
Change-Id: I1135d9e89c37215f0f23dbcdf6244a06c9967f98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804495Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Victor Hsieh <victorhsieh@chromium.org>
Auto-Submit: Victor Hsieh <victorhsieh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710018}

Fix crashes when DCHECKs enabled since we are running into this issue.

Bug: b/143316162
Test: None
Change-Id: Ic4f20131281f1cbc0f7f80f5377804fb40731f46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884818Reviewed-by: Sean Topping <seantopping@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710017}

If reordering bookmark page is closed by clicking 'Close Incognito Tabs' on
notifications, then the runnable posted by recyclerView will be run. But at
that moment, bookmark model has been assigned to null. This CL makes it
only run when view is being attached to window.

Bug: 1017073
Change-Id: I328550a11432a7288b9508227f9634e9719ae357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884350Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#710016}

The attribute value is still parsed for UMA metrics only.

Bug: 953995
Change-Id: If80a818c9722625a07fc25e6f35be6394c587d12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883291Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710015}

Disables the profiler to work around a major performance bug in Trend
Micro's software that gets injected into our processes.

Bug: 1018291, 882982
Change-Id: I04b3b762c3b5cd16258ca6cb63a317e0f33d05ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881980Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710014}

https://webrtc.googlesource.com/src.git/+log/cff20c2615d8..70770accb3e4

git log cff20c2615d8..70770accb3e4 --date=short --no-merges --format='%ad %ae %s'
2019-10-28 saza@webrtc.org Make AudioFrame member instead of raw pointer in APM test fixture

Created with:
  gclient setdep -r src/third_party/webrtc@70770accb3e4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I31f092fdac4790340ed66912ce99fa568d64e4db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884432Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710013}

Ensure that magic window sessions get disconnected when VRServiceImpl is
destroyed. The default destructors don't do so, and this resulted in ID
collisions when the metrics helper is reused across page navigation.

Also add DVLOG(2) lifecycle logging to help with debugging in case we
run into similar issues in the future, the initialization sequence
is a bit complicated.

Bug: 1017959
Change-Id: Ib7876ec10c0db7076b599ec212762cb455ec5c0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884373
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710012}

It is scheduled with a random delay between 0ms and 59999ms. When it is
exactly 0, the delayed task is actually executed as a regular task,
and since it is scheduled just before the task that starts native,
it runs without native, causing a crash.

Moving recordMemoryUsageWithRandomDelay() to after native is initialized
fixes the issue.

https://chromium-review.googlesource.com/c/chromium/src/+/1880172 fixed
this issue incorrectly. This is a corrected version.

Bug: 1017130
Change-Id: Ia79a4c3dcf639ffc01d1eacbfe53d082419c8ed7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884272Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710011}

Both of these methods always returned 0 and are not overridable.

BUG=

Change-Id: I014897e1533442232e6dbfd973186e094077cf87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879721
Auto-Submit: Robert Liao <robliao@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710010}

Switches use of PrintResult in performance_browser_tests to
PerfResultReporter and whitelists the tests for conversion to histograms
before being uploaded to the perf dashboard.

Bug: 923564
Change-Id: Ica64da69d6fe0a0de680c673b63fe54ff235bc1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877151
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710009}

NetworkChangeNotifier::NetworkChangeCalculator::OnIPAddressChanged()
never updated the potentially incorrect |pending_connection_type_|
initial value of CONNECTION_NONE.
This caused detected IP address changes to trigger OnNetworkChanged()
events with incorrect connection types.
This fix sets |pending_connection_type_| accurately.

The issue was observed on home devices, where CONNECTION_NONE state
determines that the device is offline and blocks the OOBE flow.

Bug: 142898314
Change-Id: I8d15bd231beac73fc91963ebe162ae6fb59f6d4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873377
Commit-Queue: Valeriy Balabanov <balabasik@google.com>
Auto-Submit: Valeriy Balabanov <balabasik@google.com>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710008}

This adds calls to MediaExperimentManager when players start / stop,
and receives callbacks when a player is the only one playing.  Right
now, these callbacks are ignored.

Adds a switch "MediaPowerExperiment" to enable tracking players, in
preparation for the power experiment.

This CL also simplifies MediaExperimentManager.

Change-Id: I02aa61971c7ca59093dcf2d7336709e25b8a70a7
Bug: 1017783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879751
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710007}

This is the Mac version of
https://chromium-review.googlesource.com/c/chromium/src/+/1848911 .

Bug: 1016900
Change-Id: I59d2327d0c48f15b929247c0cce76aa35ee88678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877191
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710006}

Bug: 1018725
Change-Id: I293f493fa87b43d3c7809d5cef960bb068588cb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883417Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710005}

Attach a device id for Secondary Account sign-ins on Chrome OS.

Bug: 1012723
Change-Id: Ic7d8fc22bd82c62354d66d4f49e6070bc65e4ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859784Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710004}

https://skia.googlesource.com/skia.git/+log/18f5b1a6dd77..a1991f5e3b58

git log 18f5b1a6dd77..a1991f5e3b58 --date=short --no-merges --format='%ad %ae %s'
2019-10-28 mtklein@google.com experimental support for go/fibers
2019-10-28 robertphillips@google.com Add helper to determine the index buffer that will be used
2019-10-28 jcgregorio@google.com Revert "Add variety of bulk API benchmarks"
2019-10-28 kjlubick@google.com [canvaskit] Use skia's version of png and zlib
2019-10-28 michaelludwig@google.com Add variety of bulk API benchmarks
2019-10-28 kjlubick@google.com [canvaskit] Use newer freetype

Created with:
  gclient setdep -r src/third_party/skia@a1991f5e3b58

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Bug: None
Change-Id: I04dd91f1d67ee96330ac2abc8cbc570f71d88498
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884431Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710003}

in order to make the wpt_internal directory exist on the bot so
that the manifest can be written into it.

Bug: 1018829
Change-Id: I1c15caf5abd37c50839587f7713d7636d56a5cd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884812
Commit-Queue: Luke Z <lpz@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710002}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c3f17f3c2e1..4592a8d52f74


Created with:
  gclient setdep -r src-internal@4592a8d52f74

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I1d63ff9f4d7b834c6fdc4af13985f74cdab0d473
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884510Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710001}

The two fullscreen tests change back to pre-UAv2 expectations.  The
user activation query api test shows consumption in transient state
only.

Fixed: 922725
Change-Id: Ia7402d4ce08a89edef13bcba2dd2c4405739e872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883118Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710000}

This reverts commit 4f3e0042.

Reason for revert: revert as planned

Original change's description:
> Roll src/buildtools/third_party/libc++/trunk/ 5938e0582..78d6a7767 (333 commits)
> 
> This will break CrOS due to a libassistant issue, see bug 996754. The plan is
> to land this, then revert it immediately, then do some prep work on the assistant
> side, and then reland once that prep work is done.
> 
> This CL is necessary to fix the gcc 4.8 build:
> https://chromium.googlesource.com/chromium/llvm-project/libcxx/+/ad464887b93526235ce06bbf97cd396ed6232b9a
> 
> Wanted for this CL, which improves the debugging experience:
> https://chromium.googlesource.com/chromium/llvm-project/libcxx.git/+/78822a68537b5941eb86e11a5066aa549c30998f
> 
> https://chromium.googlesource.com/chromium/llvm-project/libcxx.git/+log/5938e0582bac..78d6a7767ed5
> 
> $ git log 5938e0582..78d6a7767 --date=short --no-merges --format='%ad %ae %s'
> 2019-10-22 z.zoelec2     [libcxx] Remove shared_ptr::make_shared
> 2019-10-21 ldionne [NFC] Fix typos in CMake comment
> 2019-10-19 dimitry Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD
> 2019-10-19 richard-llvm P1152R4: Fix deprecation warnings in libc++ testsuite and in uses of is_invocable that would internally conjure up a deprecated function type.
> 2019-10-15 Casey [libc++][test] Use <version> to get config on MSVC
> 2019-10-14 Casey [libc++][test] Portability fix for std::any tests
> 2019-10-14 Casey [libc++][test] Add license headers to test/support/archetypes.*
> 2019-10-14 Casey [libc++][test] Silence more warnings in variant tests
> 2019-10-13 Casey [libc++][test] std::variant test cleanup
> 2019-10-13 Casey [libc++][test] <=> now has a feature-test macro
> 2019-10-12 Casey [libc++][test] Silence MSVC warning in std::optional test
> 2019-10-11 phosek [libc++] Fix linker script generation
> 2019-10-10 Casey [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer
> 2019-10-09 Casey [libc++][test] Miscellaneous MSVC cleanups
> 2019-10-09 eric Optimize operator=(const basic_string&) for tail call.
> 2019-10-08 ldionne [libc++] Workaround old versions of CMake that don't understand list(JOIN)
> 2019-10-08 ldionne [libc++] Move the linker script generation step to CMake
> 2019-10-08 ldionne [libc++] Make sure we link all system libraries into the benchmarks
> 2019-10-08 ldionne [libc++] TAKE 2: Make system libraries PRIVATE dependencies of libc++
> 2019-10-08 ldionne [libc++] Add missing link-time dependencies to the benchmarks
> 2019-10-08 ldionne [libc++] Use PRIVATE to link benchmark dependencies
> 2019-10-07 z.zoelec2     [libc++] Remove C++03 variadics in shared_ptr (v2)
> 2019-10-04 apl [libc++] Guard cxx_experimental settings behind LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY
> 2019-10-04 ldionne [libc++] Localize common build flags into a single CMake function
> 2019-10-04 saugustine Add an off-by-default option to enable testing for gdb pretty printers.
> 2019-10-04 ldionne [libc++] Make the modules-related flags PUBLIC instead of PRIVATE
> 2019-10-04 ldionne [libc++] Move more CMake flags to per-target definitions
> 2019-10-04 maskray Make libc++ gdb pretty printer Python 3 compatible
> 2019-10-03 eric Attempt to remove linker workaround on the buildbots: Attempt 2
> 2019-10-03 eric Attempt to remove linker workaround on the buildbots.
> 2019-10-03 ldionne [libc++] Add a per-target flag to include the generated config_site
> 2019-10-03 ldionne [libc++] Add missing revision number in ABI changelog
> 2019-10-03 maskray Fix libc++ pretty printer test for Python 3 after D67238 (take 2)
> 2019-10-02 ldionne [libc++] Use functions instead of global variables to set libc++ build flags
> 2019-10-02 ldionne [libc++] Use a function to set warning flags per target
> 2019-10-02 ldionne [libc++] Revert to using PUBLIC instead of PRIVATE when linking system libs
> 2019-10-02 ldionne [libc++] Use PRIVATE instead of PUBLIC when linking against system libs
> 2019-10-02 maskray Fix libc++ pretty printer test for Python 3 after D67238
> 2019-10-01 saugustine Determine endianness at a time when it doesn't inadvertantly clear gdb's wrap_buffer via gdb.execute.
> 2019-10-01 ldionne [NFC] Fix typos in libc++ documentation
> 2019-10-01 ldionne [libc++] Re-apply workaround for D63883
> 2019-10-01 ldionne [libc++] Remove workaround for D63883
> 2019-10-01 ldionne [libc++] Harden usage of static_assert against C++03
> 2019-09-30 eric Refactor default constructor SFINAE in pair and tuple.
> 2019-09-27 ldionne [libc++] Take 2: Implement LWG 3158
> 2019-09-26 ldionne [libc++] Take 2: Implement LWG 2510
> 2019-09-26 dave [libcxx] Do not implicitly #include assert.h
> 2019-09-25 ldionne [libc++] Purge mentions of GCC 4 from the test suite
> 2019-09-25 eric Add forward declaration of operator<< in <string_view> as required.
> 2019-09-25 eric add tests that debug mode catches nullptr->string_view conversions in comparison operators
> (...)
> 2019-06-12 ldionne [libcxx] XFAIL set/multiset CTAD tests on Apple Clang 10
> 2019-06-12 ldionne [libcxx] XFAIL some CTAD tests on AppleClang 10
> 2019-06-12 eric Apply [[nodebug]] to typedefs throughout the STL.
> 2019-06-11 eric Move libc++ specific tests for std::function out of the std directory
> 2019-06-11 eric Add documentation and tests for Clangs C++11 extensions in C++03.
> 2019-06-11 ldionne [libcxx] Mark CTAD tests for set and multiset as unsupported on older Apple Clangs
> 2019-06-11 mclow.lists Mark CTAD fail tests for set/multiset as XFAIL for older compilers that give different error messages
> 2019-06-11 mclow.lists XFAIL a couple of tests on apple-clang-9.1, which is a compiler that I didn't know existed
> 2019-06-11 eric Check in test that demonstrates ABI break for std::function.
> 2019-06-11 ldionne [libc++] Implement deduction guides for <set>
> 2019-06-11 ldionne [libcxx] Make std::tuple<> trivially constructible
> 2019-06-11 ldionne [libcxx] Slightly improved policy for handling experimental features
> 2019-06-11 mclow.lists Add a test for is_base_of and incomplete types. Because this trait uses a compiler intrinsic which was broken in many clangs, have lots of XFAILs.
> 2019-06-11 mclow.lists XFAIL a couple of CTAD tests on clang-6; it gives different error messages than clang 7/8/9
> 2019-06-10 mclow.lists Recommit r362649, which was reverted in r262680 because of bugs in std::to_chars (which have now been fixed). Speedup to_string and to_wstring for integers using stack buffer and SSO
> 2019-06-10 mclow.lists Implement deduction guides for map/multimap. Reviewed as https://reviews.llvm.org/D58587. Thanks to Quuxplusone for the submission.
> 2019-06-10 zy [libc++] Fix leading zeros in std::to_chars
> 2019-06-08 eric update debugging docs to be less out of date
> 2019-06-08 eric Substantially reduce instantiations and debug size of std::function
> 2019-06-08 eric Fix some incorrect std::function tests
> 2019-06-06 vlad Revert "Speedup to_string and to_wstring for integers using stack buffer and SSO."
> 2019-06-05 ldionne [libcxx][test] Include test_workarounds.h where needed
> 2019-06-05 mclow.lists Update issue statuses. Reviewed as https://reviews.llvm.org/D62932
> 2019-06-05 mclow.lists Speedup to_string and to_wstring for integers using stack buffer and SSO. Reviewed as https://reviews.llvm.org/D59178  Thanks to ivafanas for all his work on this patch.
> 2019-06-04 ldionne [libcxx] Add test to check min/max requirement to regular expression
> 2019-06-04 mclow.lists No longer reject inputs when using a locale that has grouping information _and_ the input has no grouping characters at all. We continue to reject cases when the input has grouping characters in the wrong place. Fixes PR#28704
> 2019-06-04 mclow.lists We had a _LIBCPP_ASSERT commented out because gcc 4.9 didn't like it. We (LLVM) now require GCC 5.1, so that's not a problem any more. Re-enable the assertion. Fixes PR#36863
> 2019-06-02 phosek [libcxx] Use libtool when merging archives on Apple platforms
> 2019-05-31 mclow.lists Add include for 'test_macros.h' to all the tests that were missing them. Thanks to Zoe for the (big, but simple) patch. NFC intended.
> 2019-05-30 ldionne [libcxx] Add regex test cases from PR40904
> 2019-05-30 jryans [Docs] Modernize references to macOS
> 2019-05-30 phosek [runtimes] Use _LIBCPP_HAS_COMMENT_LIB_PRAGMA in all relevant files
> 2019-05-30 phosek [libcxx][libcxxabi] Remove the unused CMake checks
> 2019-05-30 phosek [runtimes] Use -Wunknown-pragmas for the pragma check
> 2019-05-30 phosek [runtimes] Check if pragma comment(lib, ...) is supported first
> 2019-05-30 phosek [runtimes] Support ELF dependent libraries feature
> 2019-05-29 ldionne [NFC][libcxx] Remove trailing whitespace
> 2019-05-29 mclow.lists Add additional constraints on midpoint(pointer, pointer). Fixes PR#42037.
> 2019-05-29 eric Fix build breakage on 32-bit machines
> 2019-05-29 eric Rework std::type_info definition to support systems without fully merged type info names.
> 2019-05-28 mclow.lists Fix test that used raw string literals. Doesn't work in C++03
> 2019-05-28 mclow.lists Fix an incorrect 'Throws' in the regex code. Add a test for the new behavior. Reviewed as https://reviews.llvm.org/D61828. Thanks to Mark for the catch and the fix.
> 2019-05-24 eric fix test for older clang versions
> 2019-05-24 eric fix destroying delete test with older apple compilers
> 2019-05-24 eric Update C++2a status for destroying delete
> 2019-05-23 eric P0722R3:  Implement library support for destroying delete
> 2019-05-23 chris.bieneman [CMake] Copy C++ headers before configuring runtimes build
> 2019-05-23 ldionne [libcxx][tests] Fix order checking in unordered_multiset tests.
> 2019-05-22 phosek [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++
> 2019-05-22 ldionne [libcxx][test] Fix order checking in some more unordered_multimap tests
> 
> Created with:
>   roll-dep src/buildtools/third_party/libc++/trunk
> 
> BUG=996754
> R=​thakis
> 
> Change-Id: I6b4d224b3feca206161d642baae7be8da23592ef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881953
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709997}

TBR=thakis@chromium.org,thomasanderson@chromium.org

Change-Id: Ib2cf8d93086f3b6bedc2f81406a620a4f54bfaab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 996754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884754Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709999}

https://dawn.googlesource.com/dawn.git/+log/f6281a5530c0..cab352c2f679

git log f6281a5530c0..cab352c2f679 --date=short --no-merges --format='%ad %ae %s'
2019-10-28 cwallez@chromium.org Make end2end and perf tests use webgpu.h
2019-10-28 bryan.bernhart@intel.com D3D12: Use CheckHRESULT for allocator errors.

Created with:
  gclient setdep -r src/third_party/dawn@cab352c2f679

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: Ib41e3f1e20f6c19ae9169ff14fcf25912cfb7885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884512Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709998}

This will break CrOS due to a libassistant issue, see bug 996754. The plan is
to land this, then revert it immediately, then do some prep work on the assistant
side, and then reland once that prep work is done.

This CL is necessary to fix the gcc 4.8 build:
https://chromium.googlesource.com/chromium/llvm-project/libcxx/+/ad464887b93526235ce06bbf97cd396ed6232b9a

Wanted for this CL, which improves the debugging experience:
https://chromium.googlesource.com/chromium/llvm-project/libcxx.git/+/78822a68537b5941eb86e11a5066aa549c30998f

https://chromium.googlesource.com/chromium/llvm-project/libcxx.git/+log/5938e0582bac..78d6a7767ed5

$ git log 5938e0582..78d6a7767 --date=short --no-merges --format='%ad %ae %s'
2019-10-22 z.zoelec2     [libcxx] Remove shared_ptr::make_shared
2019-10-21 ldionne [NFC] Fix typos in CMake comment
2019-10-19 dimitry Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD
2019-10-19 richard-llvm P1152R4: Fix deprecation warnings in libc++ testsuite and in uses of is_invocable that would internally conjure up a deprecated function type.
2019-10-15 Casey [libc++][test] Use <version> to get config on MSVC
2019-10-14 Casey [libc++][test] Portability fix for std::any tests
2019-10-14 Casey [libc++][test] Add license headers to test/support/archetypes.*
2019-10-14 Casey [libc++][test] Silence more warnings in variant tests
2019-10-13 Casey [libc++][test] std::variant test cleanup
2019-10-13 Casey [libc++][test] <=> now has a feature-test macro
2019-10-12 Casey [libc++][test] Silence MSVC warning in std::optional test
2019-10-11 phosek [libc++] Fix linker script generation
2019-10-10 Casey [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer
2019-10-09 Casey [libc++][test] Miscellaneous MSVC cleanups
2019-10-09 eric Optimize operator=(const basic_string&) for tail call.
2019-10-08 ldionne [libc++] Workaround old versions of CMake that don't understand list(JOIN)
2019-10-08 ldionne [libc++] Move the linker script generation step to CMake
2019-10-08 ldionne [libc++] Make sure we link all system libraries into the benchmarks
2019-10-08 ldionne [libc++] TAKE 2: Make system libraries PRIVATE dependencies of libc++
2019-10-08 ldionne [libc++] Add missing link-time dependencies to the benchmarks
2019-10-08 ldionne [libc++] Use PRIVATE to link benchmark dependencies
2019-10-07 z.zoelec2     [libc++] Remove C++03 variadics in shared_ptr (v2)
2019-10-04 apl [libc++] Guard cxx_experimental settings behind LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY
2019-10-04 ldionne [libc++] Localize common build flags into a single CMake function
2019-10-04 saugustine Add an off-by-default option to enable testing for gdb pretty printers.
2019-10-04 ldionne [libc++] Make the modules-related flags PUBLIC instead of PRIVATE
2019-10-04 ldionne [libc++] Move more CMake flags to per-target definitions
2019-10-04 maskray Make libc++ gdb pretty printer Python 3 compatible
2019-10-03 eric Attempt to remove linker workaround on the buildbots: Attempt 2
2019-10-03 eric Attempt to remove linker workaround on the buildbots.
2019-10-03 ldionne [libc++] Add a per-target flag to include the generated config_site
2019-10-03 ldionne [libc++] Add missing revision number in ABI changelog
2019-10-03 maskray Fix libc++ pretty printer test for Python 3 after D67238 (take 2)
2019-10-02 ldionne [libc++] Use functions instead of global variables to set libc++ build flags
2019-10-02 ldionne [libc++] Use a function to set warning flags per target
2019-10-02 ldionne [libc++] Revert to using PUBLIC instead of PRIVATE when linking system libs
2019-10-02 ldionne [libc++] Use PRIVATE instead of PUBLIC when linking against system libs
2019-10-02 maskray Fix libc++ pretty printer test for Python 3 after D67238
2019-10-01 saugustine Determine endianness at a time when it doesn't inadvertantly clear gdb's wrap_buffer via gdb.execute.
2019-10-01 ldionne [NFC] Fix typos in libc++ documentation
2019-10-01 ldionne [libc++] Re-apply workaround for D63883
2019-10-01 ldionne [libc++] Remove workaround for D63883
2019-10-01 ldionne [libc++] Harden usage of static_assert against C++03
2019-09-30 eric Refactor default constructor SFINAE in pair and tuple.
2019-09-27 ldionne [libc++] Take 2: Implement LWG 3158
2019-09-26 ldionne [libc++] Take 2: Implement LWG 2510
2019-09-26 dave [libcxx] Do not implicitly #include assert.h
2019-09-25 ldionne [libc++] Purge mentions of GCC 4 from the test suite
2019-09-25 eric Add forward declaration of operator<< in <string_view> as required.
2019-09-25 eric add tests that debug mode catches nullptr->string_view conversions in comparison operators
(...)
2019-06-12 ldionne [libcxx] XFAIL set/multiset CTAD tests on Apple Clang 10
2019-06-12 ldionne [libcxx] XFAIL some CTAD tests on AppleClang 10
2019-06-12 eric Apply [[nodebug]] to typedefs throughout the STL.
2019-06-11 eric Move libc++ specific tests for std::function out of the std directory
2019-06-11 eric Add documentation and tests for Clangs C++11 extensions in C++03.
2019-06-11 ldionne [libcxx] Mark CTAD tests for set and multiset as unsupported on older Apple Clangs
2019-06-11 mclow.lists Mark CTAD fail tests for set/multiset as XFAIL for older compilers that give different error messages
2019-06-11 mclow.lists XFAIL a couple of tests on apple-clang-9.1, which is a compiler that I didn't know existed
2019-06-11 eric Check in test that demonstrates ABI break for std::function.
2019-06-11 ldionne [libc++] Implement deduction guides for <set>
2019-06-11 ldionne [libcxx] Make std::tuple<> trivially constructible
2019-06-11 ldionne [libcxx] Slightly improved policy for handling experimental features
2019-06-11 mclow.lists Add a test for is_base_of and incomplete types. Because this trait uses a compiler intrinsic which was broken in many clangs, have lots of XFAILs.
2019-06-11 mclow.lists XFAIL a couple of CTAD tests on clang-6; it gives different error messages than clang 7/8/9
2019-06-10 mclow.lists Recommit r362649, which was reverted in r262680 because of bugs in std::to_chars (which have now been fixed). Speedup to_string and to_wstring for integers using stack buffer and SSO
2019-06-10 mclow.lists Implement deduction guides for map/multimap. Reviewed as https://reviews.llvm.org/D58587. Thanks to Quuxplusone for the submission.
2019-06-10 zy [libc++] Fix leading zeros in std::to_chars
2019-06-08 eric update debugging docs to be less out of date
2019-06-08 eric Substantially reduce instantiations and debug size of std::function
2019-06-08 eric Fix some incorrect std::function tests
2019-06-06 vlad Revert "Speedup to_string and to_wstring for integers using stack buffer and SSO."
2019-06-05 ldionne [libcxx][test] Include test_workarounds.h where needed
2019-06-05 mclow.lists Update issue statuses. Reviewed as https://reviews.llvm.org/D62932
2019-06-05 mclow.lists Speedup to_string and to_wstring for integers using stack buffer and SSO. Reviewed as https://reviews.llvm.org/D59178  Thanks to ivafanas for all his work on this patch.
2019-06-04 ldionne [libcxx] Add test to check min/max requirement to regular expression
2019-06-04 mclow.lists No longer reject inputs when using a locale that has grouping information _and_ the input has no grouping characters at all. We continue to reject cases when the input has grouping characters in the wrong place. Fixes PR#28704
2019-06-04 mclow.lists We had a _LIBCPP_ASSERT commented out because gcc 4.9 didn't like it. We (LLVM) now require GCC 5.1, so that's not a problem any more. Re-enable the assertion. Fixes PR#36863
2019-06-02 phosek [libcxx] Use libtool when merging archives on Apple platforms
2019-05-31 mclow.lists Add include for 'test_macros.h' to all the tests that were missing them. Thanks to Zoe for the (big, but simple) patch. NFC intended.
2019-05-30 ldionne [libcxx] Add regex test cases from PR40904
2019-05-30 jryans [Docs] Modernize references to macOS
2019-05-30 phosek [runtimes] Use _LIBCPP_HAS_COMMENT_LIB_PRAGMA in all relevant files
2019-05-30 phosek [libcxx][libcxxabi] Remove the unused CMake checks
2019-05-30 phosek [runtimes] Use -Wunknown-pragmas for the pragma check
2019-05-30 phosek [runtimes] Check if pragma comment(lib, ...) is supported first
2019-05-30 phosek [runtimes] Support ELF dependent libraries feature
2019-05-29 ldionne [NFC][libcxx] Remove trailing whitespace
2019-05-29 mclow.lists Add additional constraints on midpoint(pointer, pointer). Fixes PR#42037.
2019-05-29 eric Fix build breakage on 32-bit machines
2019-05-29 eric Rework std::type_info definition to support systems without fully merged type info names.
2019-05-28 mclow.lists Fix test that used raw string literals. Doesn't work in C++03
2019-05-28 mclow.lists Fix an incorrect 'Throws' in the regex code. Add a test for the new behavior. Reviewed as https://reviews.llvm.org/D61828. Thanks to Mark for the catch and the fix.
2019-05-24 eric fix test for older clang versions
2019-05-24 eric fix destroying delete test with older apple compilers
2019-05-24 eric Update C++2a status for destroying delete
2019-05-23 eric P0722R3:  Implement library support for destroying delete
2019-05-23 chris.bieneman [CMake] Copy C++ headers before configuring runtimes build
2019-05-23 ldionne [libcxx][tests] Fix order checking in unordered_multiset tests.
2019-05-22 phosek [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++
2019-05-22 ldionne [libcxx][test] Fix order checking in some more unordered_multimap tests

Created with:
  roll-dep src/buildtools/third_party/libc++/trunk

BUG=996754
R=thakis

Change-Id: I6b4d224b3feca206161d642baae7be8da23592ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881953Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709997}

SetPlay does not work if the animation is not loaded. Update it to set
the autoplay attribite if the animation is not loaded yet.

Bug: None
Test: Manual Test
Change-Id: I8132d11b5fd9ae77002f79cab7f0e12ef4e91c91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879855Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709996}

Using wpt-import in Chromium f1bdee58.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Ic6847d750c6afb1700291b673f8ef9442d702c2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884092Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709995}

According to the comments in
https://chromium-review.googlesource.com/c/chromium/src/+/1882109

Also reorder the options so they have the same order in all
platforms, making it easier to see what's different across platforms.

Bug: none
Change-Id: Ibea9ef89a4fd78e31677f0e43036739ec6ad372c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881636
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709994}

This reverts commit 3e7f8dd6.

Reason for revert: Android apk and webview cause many linker issues with Clang coverage on. Bugs created: crbug/1018431, crbug/1018434, crbug/1018780

Original change's description:
> [code coverage] Turn on native coverage on Android coverage CI builder
> 
> Bug: 985574
> Change-Id: I1d5f51adbe51d6022c0b74c71267b89da27958d2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872770
> Commit-Queue: Yun Liu <yliuyliu@google.com>
> Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709811}

TBR=liaoyuke@chromium.org,jbudorick@chromium.org,yliuyliu@google.com

Change-Id: I3dc4bcf4703a35288c32f03d15557f0c5bacd0ed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 985574
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884264Reviewed-by: Yun Liu <yliuyliu@google.com>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#709993}

This fixes an issue where Chrome would launch in msan with gLinux, but the first
time the user types anything into the omnibox, Chrome would hang for several
minutes. The hang was happening because the fontconfig caches were getting
regenerated for an older version of fontconfig. See the detailed explanation
added in BUILD.gn.

BUG=1017974
R=thakis

Change-Id: I50f4c757a3fc66250f348129c03990eba9546a42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880587
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709992}

Bug: 1018860

Change-Id: I75f867e6be9b303c7fcafcc5304788d754bb763b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882314
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709991}

These are equivalent to window.screen[XY], which were measured in
https://chromium-review.googlesource.com/c/chromium/src/+/1384047.

Bug: 915620, 1016935
Change-Id: Iddfee602c9ffd4a360fa5bbca8a0366382c579d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874594
Commit-Queue: David Benjamin <davidben@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709990}

Couple of issues dealt with by this CL:

1) We should be starting the gesture from near the bottom of the page
   instead from the top (as it moves upwards)
2) In TouchInputTransferAcrossReactivation, we might get some scrolling
   in the main page before the first activation. We should be checking
   to see if it has scrolled more than that amount after reactivation

Bug: 1010675
Change-Id: I6289549f1326a80896c8b78e6a66a724ac6dbeff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880077Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709989}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f9d7f08e..32c0b43e

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I8e3cb4789c75874e444377cda0a35eabf3fe0cda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884090Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709988}

This CL is replacing the hardcoded list of parens with a call to the
ICU API to get the codepoints attributes.

Splitting a run on brackets has the side-effect to ensures each
bracket (matching bracket) is rendered with the same font. This
avoid visual mismatch. The code to split text runs on brackets
was introduced to fix this:
  https://bugs.chromium.org/p/chromium/issues/detail?id=396776

Unittests are added with some codepoints that were not included as
brackets and should have been.

Bug: 995789
Change-Id: I268cc62604d755d61da2c87dd597aabfc57b7ef6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881723Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709987}

* Create ax::mojom::Role::kCode, kEmphasis, and kStrong
* Map to accessibility APIs as defined in Core-AAM specification

Because it is up to content authors and toolkits/frameworks to
style these roles as they see fit, font and format information
will be exposed based on authoring. We cannot assume (and thus
should not automatically expose) bold for the strong role or
italics for the emphasis role.

Bug: 1017195
Change-Id: I4fa6d300de27b01abd6c72742c4cf1ac90f63c01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875520Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com>
Cr-Commit-Position: refs/heads/master@{#709986}

https://android.googlesource.com/platform/external/perfetto.git/+log/c2493796361f..a78528cc1f2b

git log c2493796361f..a78528cc1f2b --date=short --no-merges --format='%ad %ae %s'
2019-10-28 eseckler@google.com Merge "processor: Fix chrome build & legacy arg export"

Created with:
  gclient setdep -r src/third_party/perfetto@a78528cc1f2b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I78531682ebb6642c42d9ee2fce45a130acabe430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883781Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709985}

It was the case that if ResetForCrossDocumentRestart is called before
committing, OnCommitTimeout was called which crashed when trying to get
the current RenderFrameHost.

The introduced test failed with the same stack trace in the related bug
before resetting commit timeout.

Bug: 1006677
Change-Id: Ia1d08f792cbd9c3692533d69519cb6da7e21d102
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879913
Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709984}

This reverts commit f87359ae.

Reason for revert: https://crbug.com/1017694

Some legacy IMEs (ex: Yahoo Chinese IME) are broken with this change.

Bug: 1017694
Change-Id: I0dceabbd5ee712c74aab113e912a3e629f79785a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880597Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709983}

Change behavior of auth error bubble and smart lock info bubble to make
them appear on the right and left side.
Make bubbles adjust to the height of virtual keyboard and tray.

Bug: 888696
Change-Id: I882832b892e762db69708a65f4f2dd6063d0ef59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863093
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709982}

http://crrev.com/c/1815988 makes the PopupWindow focusable so that we
can focus on EditText within TabGridDialog. However, there seems to be
some inconsistent behavior when clicking back press in a focused
PopupWindow among different Android APIs. This CL fixes this issue and
adds a regression test.

Bug: 1013974
Change-Id: I07575bb493d8627c6af2e7a64eb47acd08876ca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874461
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709981}