GitLab

Using --gtest_filter=-AudioInputTest.* currently results in no tests being
run, instead of "all tests except for AudioInputTest".

R=skyostil@chromium.org,cjhopman@chromium.org

Review URL: https://codereview.chromium.org/1235713003

Cr-Commit-Position: refs/heads/master@{#338396}

Revert of Revert of Clang on Windows: Remove -Wno-unused-variable. (patchset #1 id:1 of https://codereview.chromium.org/1228093005/)

Reason for revert:
might be better now?

Original issue's description:
> Revert of Clang on Windows: Remove -Wno-unused-variable. (patchset #3 id:40001 of https://codereview.chromium.org/1226573002/)
>
> Reason for revert:
> Broke Clang build on Windows according to http://crbug.com/505319#c30.
>
> Those warnings should be fixed before relanding.
>
> Original issue's description:
> > Clang on Windows: Remove -Wno-unused-variable.
> >
> > Unused variables are now errors. However, since lots of third-party code
> > has unused variables, added a blanket suppression to all third-party
> > code.
> >
> > BUG=505319
> >
> > Committed: https://crrev.com/3371ccbd9d83e1031c5891520e88acbc9c1859a0
> > Cr-Commit-Position: refs/heads/master@{#338242}
>
> TBR=garykac@chromium.org,thakis@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=505319
>
> Committed: https://crrev.com/ff68a3ba6f2dc9b226047b3355c135f73352570e
> Cr-Commit-Position: refs/heads/master@{#338253}

TBR=garykac@chromium.org,mgiuca@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=505319

Review URL: https://codereview.chromium.org/1232543005

Cr-Commit-Position: refs/heads/master@{#338395}

Port forwarding over IPv6 results in this failure: "bind: Cannot assign
requested address", so force usage of IPv4.

R=nyquist@chromium.org

Review URL: https://codereview.chromium.org/1236473005

Cr-Commit-Position: refs/heads/master@{#338394}

No inteded behavior change. Fixes:

..\..\sandbox\win\src\process_mitigations.cc(90,24) :  warning(clang): unused variable 'MEM_EXECUTE_OPTION_ENABLE' [-Wunused-variable]
      static const int MEM_EXECUTE_OPTION_ENABLE = 1;
                       ^
..\..\sandbox\win\src\service_resolver_32.cc(21,12) :  warning(clang): unused variable 'kNop' [-Wunused-const-variable]
const BYTE kNop = 0x90;
           ^
..\..\sandbox\win\src\service_resolver_32.cc(33,11) :  warning(clang): unused variable 'kMaxService' [-Wunused-const-variable]
const int kMaxService = 1000;
          ^

BUG=505319

Review URL: https://codereview.chromium.org/1232723002

Cr-Commit-Position: refs/heads/master@{#338393}

R=thakis@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1225113002.

Cr-Commit-Position: refs/heads/master@{#338392}

BUG=505317
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/1236443005 .

Cr-Commit-Position: refs/heads/master@{#338391}

This updates all the clients of showSnackbar() to use the new variant of
the method that takes a single Snackbar object. The old overloads of
showSnackbar() have been removed.

This also renames removeSnackbarEntry() to removeMatchingSnackbars(),
which seems like a clearer name.

Review URL: https://codereview.chromium.org/1235453002

Cr-Commit-Position: refs/heads/master@{#338390}

Review URL: https://codereview.chromium.org/1229813005

Cr-Commit-Position: refs/heads/master@{#338389}

Currently, the routes in the sink list are only updated when the dialog is opened. We don't update them when we have create new or close existing routes. This change updates the sink list to reflect any active routes immediately when they WebUI knows about them.

BUG=507802

Review URL: https://codereview.chromium.org/1218213007

Cr-Commit-Position: refs/heads/master@{#338388}

Fix adb usage in tools/telemetry/telemetry/core/platform/profiler after https://codereview.chromium.org/1213423003/

BUG=509039

Review URL: https://codereview.chromium.org/1232683002

Cr-Commit-Position: refs/heads/master@{#338387}

Update the references in telemetry/ to use telemetry/third_party instead of
src/third_party/

BUG=472672

Review URL: https://codereview.chromium.org/1229153003

Cr-Commit-Position: refs/heads/master@{#338386}

Calling Layer::Update should not cause changes to tree topology.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1232573005

Cr-Commit-Position: refs/heads/master@{#338385}

BUG=508897

Review URL: https://codereview.chromium.org/1233713003

Cr-Commit-Position: refs/heads/master@{#338384}

BUG=481563

Review URL: https://codereview.chromium.org/1219753007

Cr-Commit-Position: refs/heads/master@{#338383}

The usage of these strings was removed in
https://codereview.chromium.org/1226933004/.

BUG=484806

Review URL: https://codereview.chromium.org/1228343003

Cr-Commit-Position: refs/heads/master@{#338382}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1c59921..abaaf1d

TBR=rjwright@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1231193002

Cr-Commit-Position: refs/heads/master@{#338381}

This is one of the possible M-45 solutions for
http://crbug.com/504191. Unfortunately, it introduces
at most one non-leaking but unnecessary WebContents
per tab being held after the distillation was used on
the tab.

The proper solution discussed with mdjones@ involves
discarding the cached original page WebContents on any
navigation (except going back) and using it for the rapid
back-press.

Given that the direction for M-46 is to switch the Reader
Mode view to be an overlay (like CS) it is understood to be
unnecessary and unfeasible to complicate M-45, as this code
is going to be rewritten anyway.

BUG=504191

Review URL: https://codereview.chromium.org/1229713002

Cr-Commit-Position: refs/heads/master@{#338380}

This also adds support for the normal preferences datatype because that's
the one hardcoded as a user selectable type, but because it doesn't have a
datatype controller on mobile, it will never be turned on (and it therefore
won't be preferred, so we won't receive invalidations for it).

BUG=505542

Review URL: https://codereview.chromium.org/1222203008

Cr-Commit-Position: refs/heads/master@{#338379}

The bug was fixed in paper-icon-button v1.0.2.

BUG=none

Review URL: https://codereview.chromium.org/1234443002

Cr-Commit-Position: refs/heads/master@{#338378}

BUG=504938
NOTRY=true
TBR=mfoltz

Review URL: https://codereview.chromium.org/1232063005

Cr-Commit-Position: refs/heads/master@{#338377}

MemorySanitizer has false positives on tests that use GPU.
See http://dev.chromium.org/developers/testing/memorysanitizer for
more details.

BUG=508959
TBR=caseq

Review URL: https://codereview.chromium.org/1230063009

Cr-Commit-Position: refs/heads/master@{#338376}

BUG=505317
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/1226373006 .

Cr-Commit-Position: refs/heads/master@{#338375}

This CL adds functionality to expand the existing text selection
when the contextual search server returns what the user is most
likely to search for.

BUG=396738

Review URL: https://codereview.chromium.org/1205033005

Cr-Commit-Position: refs/heads/master@{#338374}

The implementation of planned changes to iframe permissions handling
should hinge on the expected impact of the changes.
This rough patch allows us to collect some information about the expected impact
by monitoring how often an iframe requests permissions,
what kinds it requests, and what permissions its parent has or doesn't.

TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1197853005

Cr-Commit-Position: refs/heads/master@{#338373}

Also fixing test failures. Mostly updating test expectations.

Also includes fix for clockless renderer logic that caused some
tests to stall.

BUG=501445

Review URL: https://codereview.chromium.org/1207423003

Cr-Commit-Position: refs/heads/master@{#338372}

Previously the VideoEncoderVpx would pass up to two empty/unchanged
frames to the codec when in lossy-VP9 mode, to allow some quality
top-off even if the desktop is otherwise idle. VideoEncoderVpx now calls
the codec until it reports that no changes were encoded.

This CL also uses a DesktopSize to hold the active-map dimensions.

BUG=134202

Review URL: https://codereview.chromium.org/1213323003

Cr-Commit-Position: refs/heads/master@{#338371}

0 configs already ran on Swarming
15 used to run locally and were converted:
- chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1)
- chromium.chromiumos.json: Linux ChromiumOS Tests (1)
- chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1)
- chromium.fyi.json: Linux Trusty
- chromium.fyi.json: Linux Trusty (dbg)
- chromium.linux.json: Linux Tests
- chromium.linux.json: Linux Tests (dbg)(1)
- chromium.linux.json: Linux Tests (dbg)(1)(32)
- chromium.memory.fyi.json: Linux ChromeOS MSan Tests
- chromium.memory.fyi.json: Linux MSan Tests
- chromium.memory.fyi.json: Linux TSan Tests
- chromium.memory.json: Linux ASan LSan Tests (1)
- chromium.memory.json: Linux Chromium OS ASan LSan Tests (1)
- chromium.webkit.json: Linux ChromiumOS Tests (1)
- chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1)

Ran:
  ./manage.py --convert display_unittests

R=oshima@chromium.org,thakis@chromium.org
BUG=98637

Review URL: https://codereview.chromium.org/1207383007

Cr-Commit-Position: refs/heads/master@{#338370}

BUG=508178
R=msw@chromium.org

Review URL: https://codereview.chromium.org/1229213006

Cr-Commit-Position: refs/heads/master@{#338369}

Also add a filler viewer for easier CSS visualization, with language family
selection.

Specs of reader mode:
https://code.google.com/p/chromium/issues/detail?id=428533#c24

Main changes according to the spec:
- Use Roboto font for sans-serif.
- Remove the gray background of title area.
- Adjust color, line-height, padding, and margin of many elements.
- Change max-width for wide screen, with consideration of pinch-to-zoom.

Other changes:
- Fix wrapping in <pre>.
- Handle <code> in <pre> properly.
- Disable the animation when setting the title.
- Tune colors for three themes (light, dark, sepia).

BUG=428533, 499740

Review URL: https://codereview.chromium.org/1192363006

Cr-Commit-Position: refs/heads/master@{#338368}

This new method allows Chrome to open device nodes without having to
chmod them to a group of which Chrome is a member and allows the
permission broker to set opens on the file descriptor before passing it
to Chrome. This is a win for security and future extensibility.

BUG=None

Review URL: https://codereview.chromium.org/1233753002

Cr-Commit-Position: refs/heads/master@{#338367}

This adds a footer with Chrome branding at the bottom of the menu
for custom tabs to prompt the user the content they are looking at
belongs to a Chrome Tab.

BUG=507522

Review URL: https://codereview.chromium.org/1229223002

Cr-Commit-Position: refs/heads/master@{#338366}

Review URL: https://codereview.chromium.org/1036563002

Cr-Commit-Position: refs/heads/master@{#338365}

Node Browser and out-of-order loading from DB

The fix contains two parts:

1) Changed Sync Node Browser code to handle nodes with unset
PARENT_ID. The parent ID would be unset only for nodes with
flat hierarchy where all the nodes are under the same type
root folder. In that case the parent-child relationship is
determined based on the node's model type.
EntryKernel::ToValue already generated serverModelType field,
although it would be unset for nodes that never synced to
the server. To make it more reliable I changed the field to
modelType and added the code to set it based on combination
of both server and client model type. Most of the change
deals with renaming serverModelType to modelType.

2) When testing the issue #1 with an older account I noticed
issues with ParentChildIndex not associating a few
nodes (with implicit Parent ID) correctly with their
corresponding permanent folders.
The issue turned out to be caused by an arbitrary out-of-order
loading of nodes from the database. When a node with unset Parent ID
was inserted before its permanent folder, ParentChildIndex
would place it in the OrderedChildSet associated with empty ("")
ParentID and this node would essentially be invisible
for the rest of the code querying the index.
To handle this out-of-order insertion correctly, I changed
data organization in ParentChildIndex. There now two data
structures:
a) Parent ID to OrderedChildSet map is still used to organize
collections of children for types with explicit
Parent ID like bookmarks.
b) There is also an array of OrderedChildSet indexed by
model type which contains flat collections of entries for
non-hierarchical types.
c) The latter type of collections are also shared with the
Parent ID to OrderedChildSet map so that querying by
Parent ID still works non-hierarchical types.
The sharing occurs when the index sees an entry that it
recognizes as a type root folder.

BUG=438313
TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/1226213002

Cr-Commit-Position: refs/heads/master@{#338364}

Makes handle ownership a little cleaner.

BUG=426577

Review URL: https://codereview.chromium.org/1227163008

Cr-Commit-Position: refs/heads/master@{#338363}

BUG=456932,449593

Review URL: https://codereview.chromium.org/1224083010

Cr-Commit-Position: refs/heads/master@{#338362}

Add Precache.Fetch.ResponseBytes and Precache.Fetch.PercentCompleted,
recorded by PrecacheFetcher. Tested using HistogramTester.

BUG=499532

Review URL: https://codereview.chromium.org/1212773002

Cr-Commit-Position: refs/heads/master@{#338361}

- Update the service implementation and the matching tests for Custom
  Tabs to the current external AIDL interfaces
- Temporarily import the files in Chrome
- Remove the chromium AIDL files
- Update GYP and GN files

TESTED=unittests and example application
TBR=mariakhomenko@chromium.org

Review URL: https://codereview.chromium.org/1234643002

Cr-Commit-Position: refs/heads/master@{#338360}

The permission broker expects clients to request device access by their
device node path instead of the sysfs device path (though this is
slightly less efficient and perhaps should be changed). The HID
permissions prompt code was sending the device ID (which is the sysfs
path) instead of the device node path. This patch fixes that.

BUG=457899

Review URL: https://codereview.chromium.org/1228103004

Cr-Commit-Position: refs/heads/master@{#338359}

0 configs already ran on Swarming
7 used to run locally and were converted:
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.win.json: Vista Tests (1)
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)
- chromium.win.json: XP Tests (1)

Ran:
  ./manage.py --convert sbox_integration_tests

R=cpu@chromium.org,thakis@chromium.org
BUG=98637

Review URL: https://codereview.chromium.org/1214053003

Cr-Commit-Position: refs/heads/master@{#338358}

1471  Fix -Wreorder warnings in the Windows code.
1470  Default nil or empty version string to CFBundleVersion
1469  Set exception whitelist check as earlier check instead of last check.
1468  Use general instruction/stack pointer convenience method instead of manually
1467  Checking for benign exceptions that trigger a minidump.
1466  This CL adds support for ARM and ARM64 architectures when calculating

BUG=505304
R=wfh@chromium.org
TBR=wfh@chromium.org

Review URL: https://codereview.chromium.org/1230833003 .

Cr-Commit-Position: refs/heads/master@{#338357}