- 13 Jul, 2017 40 commits
-
-
dpapad authored
Change log: https://github.com/google/closure-compiler/compare/a13d0ba6d2b02b2188137b36cb699415bd8784c5...71ab0eecc33e2d8db1ce9ee251cbf174bddc493b chrome_extensions.js: 927e44d6e32d7b2f50ddb2b20f6515b79a0914b3 -> 3444857184440010d5703dfaf6617eca79b2dab4 polymer-1.0.js: cc53ce238def6597f71ddd75e961011edb18e6a3 -> 55e962227e676cd30f81439573771326933aae54 Latest version includes a fix for using let/const with ChromePass, at https://github.com/google/closure-compiler/commit/38f6437482b6d660371342469e9bd062613b25d4. TBR=dbeam@chromium.org BUG: 671426 Change-Id: Icf80fa1dd526e3cb87cc528d84a0a9540bf85e97 Reviewed-on: https://chromium-review.googlesource.com/567678 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam (no longer on Chrome) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#486279}
-
lukasza authored
These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=davidben@chromium.org Review-Url: https://codereview.chromium.org/2980683002 Cr-Commit-Position: refs/heads/master@{#486278}
-
yoichio authored
Range::BoundingRect() returns different Rect depending on whether included Text nodes are selected or not. Since Range itself lives independently from user selection, this function also should be away from Selection. The root cause is InlineTextBox::LocalSelectionRect(), which is called by BoundingRect(), depends on SelectionState. LocalSelectionRect() refers current SelectionState so that paint invalidation invalids wrapping line endings. This patch change LocalSelectionRect(start,end) to have another boolean option which decides if we use current SelectionState. (core/layout/*) This patch also fixes InlineTextBox::GetSelectionState() can update SelectionState by calling LayoutSelection::SelectionStartEnd(). Callers of SelectionStartEnd() must know SelectionState but Commit() in SelectionStartEnd() can change the state. (core/editing/LayoutSelection.*) Bug: 739062 Change-Id: I98987940cd014d302c13d1370111a6664740e646 Reviewed-on: https://chromium-review.googlesource.com/567791 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486277}
-
Michael Lippautz authored
Bug: chromium:742040 Change-Id: Iff715f0c8780ec6e4cb6a00b0515b0064971497a Reviewed-on: https://chromium-review.googlesource.com/568819 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#486276}
-
piotrs authored
This is done with avoiding explicit chrome package name (using component name instead) and using EXTRA_SEND_TO_EXTERNAL_DEFAULT_HANDLER on the intent. With this patch the redirect works, however it takes a long time for CCT to consult ExternalNavigationHandler. This results in suboptimal UX. Same redirect in ChromeTabbedActivity is almost instantaneous. Result is that for _blank links CCT shows up briefly before redirecting to an external app. In a follow up it should be investigated why it is the case and if it cannot be improved, we might need to bypass CCT in such case, which would diverge from existing navigation paths for _blank links in Clank. BUG=740402 Review-Url: https://codereview.chromium.org/2969143002 Cr-Original-Commit-Position: refs/heads/master@{#485831} Committed: https://chromium.googlesource.com/chromium/src/+/727468b41b2fe48bf73983ab0c3aa2632b47d89e Review-Url: https://codereview.chromium.org/2969143002 Cr-Commit-Position: refs/heads/master@{#486275}
-
tzik authored
after a refactoring at http://crrev.com/ad6d8a9bbf9bd5e2. As a follow-up of the refactoring, this CL inlines the alias to its users in //gpu base: :StaticAtomicSequenceNumber is an alias of base::AtomicSequenceNumber Change-Id: I19b104842fd7805c5af9c65c98cc53956c35b84e Reviewed-on: https://chromium-review.googlesource.com/568065 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#486274}
-
tzik authored
Replace base::StaticAtomicSequenceNumber with base::AtomicSequenceNumber in //chrome, //services, //ui after a refactoring at http://crrev.com/ad6d8a9bbf9bd5e2. As a follow-up of the refactoring, this CL inlines the alias to its users in //chrome, //services, //ui. base: :StaticAtomicSequenceNumber is an alias of base::AtomicSequenceNumber Change-Id: Idf3ceef77b47a4a56abe95f15bf32fbadcd8245a Reviewed-on: https://chromium-review.googlesource.com/568062Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#486273}
-
Ramin Halavati authored
traffic_annotation_auditor_unittest expanded to include more tests. Bug: 656607 Bug: 690323 Change-Id: I1cb0bf46a7742c1bbef27cf7e2de3f70e22d48c6 Reviewed-on: https://chromium-review.googlesource.com/566818Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#486272}
-
Andrey Kosyakov authored
This removes usage of the File System API in DevTools and uses blobs instead to manage temporary files. Also gone are: - a bunch of methods to support deferred temporary files and handle asynchrony and potential failures that are no longer there; - mock for temp files and associated readers in tests -- we can now afford to test actual code; - a couple of tests that specifically tested for FS-based temp files. Bug: 490148, 553246 Change-Id: Ie321c713746016c866cdd30fe6940566f0b6ace3 Reviewed-on: https://chromium-review.googlesource.com/569119 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#486271}
-
Fady Samuel authored
This CL moves SurfaceInfo to components/viz/common/surfaces and updates includes, namespaces, and forward declarations appropriately. TBR=sky@chromium.org Bug: 722935 Change-Id: I98694ce38f5595994e2681aa4c3daf83e57ef1da Reviewed-on: https://chromium-review.googlesource.com/568697 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#486270}
-
tzik authored
after a refactoring at http://crrev.com/ad6d8a9bbf9bd5e2. As a follow-up of the refactoring, this CL inlines the alias to its users in //extensions and //ipc. base: :StaticAtomicSequenceNumber is an alias of base::AtomicSequenceNumber Change-Id: Iff95bb5ad709e13086d1feb486bf198ec27f9307 Reviewed-on: https://chromium-review.googlesource.com/567797 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#486269}
-
Eddy Mead authored
that are alias_for have a CSSPropertyID that is the aliased value + 512. Additionally, move the header template to a tmpl file. Change-Id: Iec1d09f15bd6af3fa653b32d86c8decbc4613966 Reviewed-on: https://chromium-review.googlesource.com/567792 Commit-Queue: meade_UTC10 <meade@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#486268}
-
yhirano authored
Requests from PingLoader had the lowest priority, but I changed it unintentionally. This CL restores the original behavior. BUG=739161 Review-Url: https://codereview.chromium.org/2982523002 Cr-Commit-Position: refs/heads/master@{#486267}
-
Darren Shen authored
Currently we hold a const ref& to a ComputedStyle object in BoxPainter:: PaintBoxDecorationBackgroundWithRect. However, this ref could be invalidated during theme painting, which would cause a dangling ref issue when we use the ref later on. This patch removes the weak ref and instead uses StyleRef() to grab a fresh style ref each time. Bug: 712933 Change-Id: Id576005fe63ac3a014002ba5a68acbb6c88382b0 Reviewed-on: https://chromium-review.googlesource.com/566198Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#486266}
-
Mohamad Ahmadi authored
Uses the id property of the PaymentDetails provided to PaymentRequest's constructor or generate a UUID to uniquely identify the PaymentRequest in order to allow multiple PaymentRequest objects to coexist. BUG=602666 Change-Id: I420e9fba0314cc9683b274fea71e0118b31e572e Reviewed-on: https://chromium-review.googlesource.com/565056 Commit-Queue: mahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#486265}
-
Tom Anderson authored
This CL fixes the Linux official builder [1] after something added a new libc dependency. [1] https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/19153 TBR=thestig@chromium.org CC=alancutter@chromium.org NOTRY=true NOTREECHECKS=true Change-Id: I01c3f721f36b0475aeeba7b4da47d257379a24fb Reviewed-on: https://chromium-review.googlesource.com/569410Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#486264}
-
ikilpatrick authored
After inline+float patches these now pass. BUG=635619 TBR=eae@chromium.org Review-Url: https://codereview.chromium.org/2979913002 Cr-Commit-Position: refs/heads/master@{#486263}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1286055c7baf..e4d806cd4821 $ git log 1286055c7..e4d806cd4 --date=short --no-merges --format='%ad %ae %s' 2017-07-12 sullivan Migrate /api/bugs to new api_request_handler. 2017-07-12 martiniss Log trace processing time 2017-07-12 eakuefner [Dashboard] Switch api_request_handler's BadRequestError to 400 instead of 500 2017-07-12 eakuefner [Tracing] Move histogram.Diagnostic to diagnostic.Diagnostic Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia450f22c595ed4422a9a94f9486c7cc6d719d064 Reviewed-on: https://chromium-review.googlesource.com/569460 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486262}
-
oka@chromium.org authored
Bug: 739988 Change-Id: Ic484a862e25700611581989f6e660267a01a2cbe Reviewed-on: https://chromium-review.googlesource.com/562844 Commit-Queue: Keigo Oka <oka@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#486261}
-
ikilpatrick authored
This moves a bunch of code around and some additional comments. Before the code for handling an inflow element was a little difficult to follow. Now most of the code and complexities are inside HandleInflow. Functions which this calls are now relatively simple. BUG=635619 Review-Url: https://codereview.chromium.org/2975973002 Cr-Commit-Position: refs/heads/master@{#486260}
-
Eric Roman authored
It is no longer needed as consumers of WriteToFileNetLogObserver have been switched over to FileNetLogObserver. Bug: 716570 Change-Id: Ia70e04aebc8560f2799a84c8c691538c5beb5db5 Reviewed-on: https://chromium-review.googlesource.com/565450 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486259}
-
Suchit Agrawal authored
Create new BUILD.gn file for media/muxers and moved respective media component changes from media/filters/BUILD.gn file to new BUILD.gn file. BUG=613033 Signed-off-by:
Suchit Agrawal <a.suchit@samsung.com> Change-Id: I7fd8a2cc3573efc81f3bb75409bed2860c0a3d46 Reviewed-on: https://chromium-review.googlesource.com/561236Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org> Cr-Commit-Position: refs/heads/master@{#486258}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/d425a1d013b6..27b3d272a8fc $ git log d425a1d01..27b3d272a --date=short --no-merges --format='%ad %ae %s' 2017-07-13 reed Revert "Experimental blur code with 32 bit fix." 2017-07-11 bsalomon Make RegionOp a non-legacy GrMeshDrawOp Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I94eff3008f737779b0872387271c5f9093864d5c Reviewed-on: https://chromium-review.googlesource.com/569313Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486257}
-
Toni Barzic authored
BUG=741974 Change-Id: I45e157a0ef6f060fe458fec1df481237c6a01c1f Reviewed-on: https://chromium-review.googlesource.com/569443Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#486256}
-
btolsch authored
In particular, /c/b/m/r/discovery cannot be built by itself because of the missing mojo generator dependency. This is useful for minimizing what needs to be built for testing, especially on Windows where building is much slower. Bug: 740319 Change-Id: I1b6aee574afac121b07d20936ff1a4717712fa3e Reviewed-on: https://chromium-review.googlesource.com/566997Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#486255}
-
btolsch authored
This also replaces some uses of small_map::insert with emplace. Bug: None Change-Id: I857ca36847eefe7dcc4a7f90d12c0d99ccf2afd8 Reviewed-on: https://chromium-review.googlesource.com/567599 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#486254}
-
sczs authored
Showcase is intended to be a standalone UI app and as such should not reference //ios/web or //ios/chrome. This CL eliminates the Showcase app creating an IOSChromeMain instance and thus implicitly being an //ios/web embedder, instead directly inlining the minimal parts of that startup that are needed (initializing base::CommandLine and loading resources). As part of that change, this CL eliminates Showcase bundling //ios/web resources. Bug: 738880 Change-Id: Idcd7849927e1d56fa1958de34e145beb362f4c3a Reviewed-on: https://chromium-review.googlesource.com/568243 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#486253}
-
Kent Tamura authored
Bug: 739091 Change-Id: Iff2e9afd1b472bd5acd3259651733ffe7878f542 Reviewed-on: https://chromium-review.googlesource.com/566747Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#486252}
-
Dale Curtis authored
Previously this was only enabled on Android, but we've continued to see issues with sites in the wild wasting power with a silent audio context that they never suspend. BUG=707462,732450 TEST=none Change-Id: I3ceba194be8f98b7b0a7078476fb5f000d262198 Reviewed-on: https://chromium-review.googlesource.com/568817Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#486251}
-
stanisc authored
This changes most of Extensions Store/Policy code to use a dedicated SequencedTaskRunner to post tasks rather than posting on the browser FILE thread. Initially I tried to keep the change limited to the sync related part of the Extensions code. The problem that I ran into is that different types of storage are handled in a generic way on the storage frontend (for example, all them were deleted on FILE thread). So once I migrated the sync storage, I had to modify other storage types as well. Because of that I had to access backend task runner singleton from extensions component so in order to satisfy dependencies I had to move GetBackendTaskRunner() to extensions/browser/api/storage. Some of the tests relied on TestBrowserThreadBundle making all browser threads map to the same physical thread which allowed the test code to satisfy DCHECK_CURRENTLY_ON(BrowserThread::FILE) check while running on the main test thread. With this migration that didn't work anymore so I had to modify ExtensionSettingSyncTest and PolicyValueStoreTest tests to actually post API calls on the right sequence. That was the most difficult part of this change. Other than that the rest of the changes should be straightforward. BUG=689520 Review-Url: https://codereview.chromium.org/2965153002 Cr-Commit-Position: refs/heads/master@{#486250}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a51d9227..1e323b4a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I63a1bd780da7aa81e25d7275df3ee206420938a3 Reviewed-on: https://chromium-review.googlesource.com/569262Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#486249}
-
rdsmith authored
Given that for now the call must remain present but the precise semantics of the call aren't important (see https://codereview.chromium.org/2882063002/#msg64), it's worthwhile having as clean and simple an implementation of reasonable semantics as possible. BUG=None R=mmenke@chromium.org Review-Url: https://codereview.chromium.org/2974363002 Cr-Commit-Position: refs/heads/master@{#486248}
-
yhanada authored
- Added missing data_deps to ui_test.pak. Bug: 737433 Change-Id: I4cb4ad39b8baebeb40ef2bc081741182e2ff2b5b Reviewed-on: https://chromium-review.googlesource.com/567785Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#486247}
-
smut authored
Also rename Chromium Win 10 GCE Tests to Chromium Win 10 GCE Tests (Win 7 Build). Bug: 738255 Change-Id: I526e1be2530e56176fcc6e6ef9b1884ad481b579 Reviewed-on: https://chromium-review.googlesource.com/569310Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#486246}
-
Kenneth Russell authored
deqp/functional/gles3/shaderstruct.html is still failing on Win7/NVIDIA. BUG=668223 TBR=geofflang@chromium.org NOTRY=true Change-Id: Ib689a88c08e94114d947c4ca8e3890bc71508f56 Reviewed-on: https://chromium-review.googlesource.com/569456 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#486245}
-
chrome-release-bot authored
TBR=dimu@chromium.org Change-Id: I1282f598472bd4a462a91202abc9058cdb779c2b Reviewed-on: https://chromium-review.googlesource.com/569405Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#486244}
-
Matthew Halpern authored
This is a reland of b3c9a824 Original change's description: > [GRC] Add Tab-level CPU Usage Attribution Tests > > This CL adds tab-level CPU usage attribution tests for GRC. Tab-level CPU usage attribution is tested under a variety of different coordination unit graph topologies. > > A set of mock coordination unit graph topologies has also been added to the code base as a common set of coordination unit graph topologies has emerged across the coordination unit unittests. > > Bug: 691886 > Change-Id: I2e9178ca5454846320add15f9f004ba0d9df2a9f > Reviewed-on: https://chromium-review.googlesource.com/562549 > Commit-Queue: Matthew Halpern <matthalp@google.com> > Reviewed-by: Zhen Wang <zhenw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485024} Bug: 691886 Change-Id: I91b5a898c4a9a6cf016a851c3637bebff17962ff Reviewed-on: https://chromium-review.googlesource.com/567239 Commit-Queue: Matthew Halpern <matthalp@google.com> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#486243}
-
Toni Barzic authored
Adds api tests for launching lock screen note taking action. Verifies that: * app_launch test * requesting new (lock screen) note action launches the app with action launch event indicating the action is launched from lock screen * the app can create lock screen enabled app window * the created window is maximized by default (and the window can accedd window.current API) * the app background page can observe the app window closure * the app cannot access identity API in lock screen context (even though the app has identity permission) * the app cannot create more than one window per launched action * non_lock_screen_context: * attempt to create lock screen enabled app window fails if called in a context different than lock screen context The cl enables following APIs in lock screen context: * chrome.runtime * to expose onInstalled event - without it the tests hit NOTREACHED when the event is dispatched on the app install. This event is also required in production to instigate initial app's event page (and registration of event listeners). * apps should have access to getManifest, getURL, messaging API (so it can communicate with the event page), getPlatformInfo * chrome.test - to expose testing APIs (needed by API tests) BUG=715781 Change-Id: I850319e98091506204d9e467bd46507b9f4863a8 Reviewed-on: https://chromium-review.googlesource.com/563543 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#486242}
-
Kevin Marshall authored
Update Clang static analysis Markdown doc. This CL adds additional information pertaining to the proper use and maintenance of the Clang static analyzer in Chrome. R=wez@chromium.org Bug: Change-Id: Ie421d79440051d9285d6ead0f42eb2c4d0a69326 Reviewed-on: https://chromium-review.googlesource.com/535305 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#486241}
-
Erik Chen authored
Move mac_sdk_min into build/config/overrides.gni and assert that it is used. This prevents unused arg warnings from subprojects that override it. Bug: 740693 Change-Id: Ib40a52c59c852aab46781a0d44812b07b0e5061c Reviewed-on: https://chromium-review.googlesource.com/566595Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#486240}
-