- 31 Jul, 2018 40 commits
-
-
Thiemo Nagel authored
BUG=none Change-Id: I1c301d05878f51899d734386755b6d4d4bf80117 Reviewed-on: https://chromium-review.googlesource.com/1156590Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#579404}
-
Matt Menke authored
services/network and chrome/ both depend on os_crypt, which creates problems with the component build when the NetworkService is instantiated in-process, and caused https://chromium.googlesource.com/chromium/src/+/41e3c57070c2 to be reverted. It also makes the component build to link os_crypt at least twice, which seems not great. Bug: 789644, 868536 Change-Id: Ie964c51ea2b85a7ace63f76bb39524537fe69e2f Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1155309Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#579403}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f8f625a7. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." bef4d94c "Migrate Background Fetch layout tests to WPT" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22169 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I6b459f0fb855ea4237be487d40f56789a3c98130 Reviewed-on: https://chromium-review.googlesource.com/1156468 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#579402}
-
Takuto Ikuta authored
This is a reland of 1f75f99f Original change's description: > Fix to remove /wd4018 (-Wno-sign-compare) for /build/config > > This is a part of effort to remove /wd4018 warning suppression. > > Master CL is > https://chromium-review.googlesource.com/c/chromium/src/+/1152755 > > This CL was uploaded by git cl split. > > R=dpranke@chromium.org > > Bug: 868248, 588506 > Change-Id: I3c31dc8f72266eda85904c4a860e156fadb2a76e > Reviewed-on: https://chromium-review.googlesource.com/1152840 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579311} Bug: 868248, 588506 Change-Id: Ic673677dfc0800b361d97f6516ee61887635d9d4 Reviewed-on: https://chromium-review.googlesource.com/1156164 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#579401}
-
Ramin Halavati authored
Preferences related to Autofill are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I3ea4b2dc62c6dbb9edeecd691f5a22d48eb52862 Reviewed-on: https://chromium-review.googlesource.com/1156402Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#579400}
-
Erik Chen authored
The implementaiton of HookRealloc needs to both log the free and the alloc. However, the conditional was only checking to see whether it was okay to log an alloc. This could result in missed logging for frees. Change-Id: I26cf132d7ccac275c1b3e80955263a92162b1956 Bug: 853438 Reviewed-on: https://chromium-review.googlesource.com/1155308Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579399}
-
Dave Tapuska authored
Add an API to query user activation state on a posted message event. Add includeUserActivation attribute on the WindowPostMessageOptions so that indication of user gesture behavior can be opted in. https://github.com/dtapuska/useractivation https://github.com/whatwg/html/issues/1983 BUG=846858 TBR=mkwst@chromium.org Change-Id: I2459b21004afbe00c41ddf992533c60728768bb4 Reviewed-on: https://chromium-review.googlesource.com/1131558 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#579398}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/27f30125..45880cd3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5e4697b6c5fb8948c7b878326bdc06a129cb5fb9 Reviewed-on: https://chromium-review.googlesource.com/1156467Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579397}
-
Leonard Grey authored
Background: 1. The bookmark bar has two states: "attached", where it is part of a single block with the rest of the topchrome and "detached" (only shown on the stock NTP) where it appears to be part of the web content. 2. In views toolkit, the logic order of a view's child views determines both its focus traversal order and its z-order. 3. Previously, the bookmark bar was being forcibly ordered before the rest of the topchrome to allow other topchrome views to draw elements (for example, ink drops) on top of it. 4. The combination of 2 and 3 caused tab traversal to be out of order. 5. In Material Refresh, the issue with ink drops is no longer relevant, so the reordering was removed. 6. Except that ChromeOS has an "immersive mode" which hides the top chrome by default but allows it to slide down over the web content on mouse over. 7. Since the detached bookmark bar is supposed to look like web content, it remains visible in immersive mode. 8. ...and since it's no longer z-ordered behind the rest of the topchrome, the tabstrip and toolbar remain out of sight, since they're sliding down behind the bookmark bar. This change reenables reordering in the detached case for ChromeOS because IMO there isn't a good solution to this situation in a world where traversal order and z-order can't be separated. Bug: 857546 Change-Id: I4454ddb12bfcd9ab9b382c3455efb1b5ee5939ca Reviewed-on: https://chromium-review.googlesource.com/1155656Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#579396}
-
Patrick Monette authored
Bug: 852295 Change-Id: I09e0bf24f6206d4f320a58795281e42639505e1c Reviewed-on: https://chromium-review.googlesource.com/1155101 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#579395}
-
Bence Béky authored
Reland https://crrev.com/c/1100900 with minor modification. Patch set 1 is identical to https://crrev.com/c/1100900 (that got reverted). Patch set 3 and 4 fixes the DCHECK issue in line 125. Accept() can be called multiple times on a single instance, and if it returns synchronously, it should not save |callback|. Since this CL is identical so already landed (and reverted) https://crrev.com/c/1100900 except for net/socket/unix_domain_server_socket_posix.cc, owners of other directories are TBR'd. TBR=xunjieli@chromium.org for //services/network/ TBR=caseq@chromium.org for //content/browser/devtools/ TBR=sergeyu@chromium.org for //content/browser/renderer_host/p2p/ Bug: 807724 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Idd9bf763334703eaa258a75cc6ebfd58b6e7ffe3 Reviewed-on: https://chromium-review.googlesource.com/1152047 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#579394}
-
Anita Woodruff authored
- Just testing the bucket counts for now because it would be non-trivial to introduce seams to allow manipulation of the values to be logged from the unit test. - This sets me up nicely to add a new test for the new metric I am adding as part of https://crbug.com/786017 . Bug: 786017 Change-Id: Ic9c538e71f42a12decc2046b8323bc1cb19e81cc Reviewed-on: https://chromium-review.googlesource.com/1154540 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579393}
-
Ned Nguyen authored
This reverts commit 069adb16. Reason for revert: crash rendering.mobile/microsoft_fireflies benchmark test on chromium.perf/android-nexus5x-perf BUG:869188 Original change's description: > Re-land "CC: Make LayerTreeHostImpl::OnMemoryPressure work for the desktop as well" > > This reverts commit a49d91b6. > > The original commit made SessionRestoreTest.MemoryPressureLoadsNotAllTabs crash. > According to my investigation, it was caused by calling SingleThreadProxy::OnCanDrawStateChanged > on the main thread. To avoid it, this CL makes LayerTreeHostImpl::OnMemoryPressure call > OnPurgeMemory on the impl thread through the Proxy. > > Bug: 839687, 860090 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Ifaef5bcb4029da8645f393d85313be4637aea994 > Reviewed-on: https://chromium-review.googlesource.com/1130567 > Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> > Reviewed-by: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578192} TBR=enne@chromium.org,ericrk@chromium.org,gyuyoung.kim@lge.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 839687, 860090 Change-Id: I0468da7dd808d545b4a6fe9d59f94d5427e40228 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1156564Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#579392}
-
Ian Vollick authored
This is a reland of f3f5b838 I think I've finally fixed the root issue and this is ready to land again. Original change's description: > Reland "[ar] Do not refer to ARCore shim in APK merger" > > This is a reland of 58e4a081 > > Original change's description: > > [ar] Do not refer to ARCore shim in APK merger > > > > This hard-coding should no longer be required. > > > > Bug: 839191 > > Change-Id: Id44f0f19da6efcee90ef79ea3e241eb2a7ea5843 > > Reviewed-on: https://chromium-review.googlesource.com/1147706 > > Commit-Queue: Ian Vollick <vollick@chromium.org> > > Reviewed-by: Richard Coles <torne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#577662} > > Bug: 839191 > Change-Id: I42c3d31c0cbe49c1fe2d68c55d0db18dcdc3381d > Reviewed-on: https://chromium-review.googlesource.com/1151567 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578347} Bug: 839191 Change-Id: I2618d967b214fb8f21264d6303837b08729222c4 Reviewed-on: https://chromium-review.googlesource.com/1152275Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#579391}
-
Leonard Ge authored
In this CL, we use the flag that is added in CL:1150026 to test whether telemetry is in compatibility mode, if so, we will not add the field trials configuration to bypass earlier Chromes' configuration file size limit in order to run benchmark on them. Corresponding test case is added as well. Some style change is also included to keep gpylint happy. Bug: chromium:866881 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I97bd81ce14b45afb5995f0c3d925aa3ef4d0810b Reviewed-on: https://chromium-review.googlesource.com/1150032 Commit-Queue: Leonard Ge <wangge@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#579390}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3f1566f6317f..37a1543bfe3a git log 3f1566f6317f..37a1543bfe3a --date=short --no-merges --format='%ad %ae %s' 2018-07-31 treehugger-gerrit@google.com Merge "Fix Zoom Duration on Tap" 2018-07-30 michaschwab@google.com Fix Zoom Duration on Tap Created with: gclient setdep -r src/third_party/perfetto@37a1543bfe3a The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I120a93297c0c7c50a9319840a4167c826648dc2e Reviewed-on: https://chromium-review.googlesource.com/1156484 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579389}
-
Dmitry Gozman authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie5ad888db854272c8be30413697d85b816ce0639 Reviewed-on: https://chromium-review.googlesource.com/1155797Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#579388}
-
Vasilii Sukhanov authored
The CL also updates the actual Autofill Home icons with the required size. Bug: 856662 Change-Id: I3b8df3dec255cb703bd856183de30490640638a1 Reviewed-on: https://chromium-review.googlesource.com/1152983Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579387}
-
Shakti Sahu authored
- Move FilterModel to FilterProperties. - Incorporate showing/hiding the tabs as a new property on the model. Change-Id: I0711ab244aada2ee27d8693408551261911df41e Reviewed-on: https://chromium-review.googlesource.com/1149268 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#579386}
-
David Trainor authored
The pages chip in downloads home was showing up even though the pages were prefetched and did not show up in "My Files". This was because we were considering the suggested pages as PAGES for filter purposes and keeping the chip visible. We now consider all suggested content as PREFETCHED for the purpose of the chips. This is NOT baked into the base Filters.fromOfflineItem(OfflineItemFilter) logic because we do not want to restrict the suggested tag to only pages. Change-Id: Iad2c74b7efd2f55cab06a15e6883d3e8cc0df73e Reviewed-on: https://chromium-review.googlesource.com/1152234Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#579385}
-
Haruka Matsumura authored
This CL fixes a crush bug in Relocate(). It is caused when we relocate backings that were dereferenced in EagerSweep/PreFinalizer/WeapProcessing. The slots are no longer referenced so we can early return and fix the bug. Bug: 869301 Change-Id: Id46854267065744f38f9be567b7d286f2175b99f Reviewed-on: https://chromium-review.googlesource.com/1155329 Commit-Queue: Haruka Matsumura <harukamt@google.com> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#579384}
-
jonross authored
So Reflector doesn't work with VizDisplayCompositor yet at all. See https://crbug.com/601869 for tracking getting this working again. This updates the ReflectorImplTest to exit early when VizDisplayCompositor is enabled. This is so that we can remove the filter files used for content_unittests with Viz. This change then also removes the filter file, and updates the bots. TEST=ReflectorImplTest Bug: 762512 Change-Id: I5fa02925cbe3d961fbfa46f646b68b25da5671ed Reviewed-on: https://chromium-review.googlesource.com/1153300Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#579383}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Iea523564b620467df5c70aeecfe169a6981b5496 Reviewed-on: https://chromium-review.googlesource.com/1156471 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579382}
-
Bence Béky authored
PendingConnectsMap already owns WebSocketTransportConnectJob, and the raw pointer type is not idiomatic for this case. Using release() for taking over ownership and naked deletes when erasing are screaming for unique_ptr<>. Change-Id: Ibdd2a219392bdd332c6c2e477687e8dbdf6e600c Reviewed-on: https://chromium-review.googlesource.com/1155310Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#579381}
-
Oscar Johansson authored
When building using jumbo, files get merged and the usage of "using namespace..." results in the error: using namespace directive in global context in header This commit solves the issue by removing "using namespace" and instead write the complete name when it is used. Bug: 867350 Change-Id: Iba570fbb737819ed515dc686ba65f9e7f9b47653 Reviewed-on: https://chromium-review.googlesource.com/1154538 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham (In Paris) <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#579380}
-
Dan Elphick authored
Previously it would CHECK, which would be fine since this is non-production code, but clusterfuzz strenuously objected. Bug: 868657 Change-Id: I9744b8e36be7d4645a1901656453608d7068671f Reviewed-on: https://chromium-review.googlesource.com/1154978 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#579379}
-
Pavol Marko authored
Ensure to wait until the login manager UI is loaded/available before continuing with the actual test. When UserAffiliationBrowserTest was passing "--login-manager" and "--force-login-manager-in-test" and the test function did not do any substantial work, the test crashed on shutdown. browser_tests --gtest_filter=*UserAffiliationBrowserTest* Bug: 869272 Test: compile browser tests with is_debug=true and run \ Change-Id: I44c35e5df6850d908a694a64b2bd648b008ec5a6 Reviewed-on: https://chromium-review.googlesource.com/1155592Reviewed-by:Lutz Justen <ljusten@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#579378}
-
Bence Béky authored
Bug: 807724 Change-Id: I510e6b677606c30265956a1f290ae0b1ef9b0214 Reviewed-on: https://chromium-review.googlesource.com/1155089Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#579377}
-
Rune Lillesveen authored
Was currently just checked when trying to create the pseudo element. This change should have no effect, but is done in preparation for [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1155591 Bug: 847218 Change-Id: I99fa06bed1256cb6405e6f24a5f116def366acf9 Reviewed-on: https://chromium-review.googlesource.com/1156389Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#579376}
-
kylechar authored
1. Set |stencil_size| to 0 except on Chrome OS. This is copying what happens in GpuProcessTransportFactory. 2. Set |lose_context_when_out_of_memory| to true. We can handle lost contexts in VizProcessContextProvider now. Bug: 866486 Change-Id: I5f3b1332616883df9cb7b78b8e46c71fc85dfa70 Reviewed-on: https://chromium-review.googlesource.com/1155651Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#579375}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/df9e9ae9ee66..304da796abc6 git log df9e9ae9ee66..304da796abc6 --date=short --no-merges --format='%ad %ae %s' 2018-07-31 nisse@webrtc.org Revert "Delete root header file typedefs.h. Part 2." 2018-07-31 nisse@webrtc.org Delete root header file typedefs.h. Part 2. Created with: gclient setdep -r src/third_party/webrtc@304da796abc6 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iad9a4bed4b40294f554ee431bac87e333b2132f1 Reviewed-on: https://chromium-review.googlesource.com/1156253Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579374}
-
Raphael Kubo da Costa authored
Commit 7732d4d0 ("Fix many android layout test bugs") marked some layout tests as failing on Android. It turns out some of them are actually crashing on android_blink_rel, and preventing new WPT imports because rebaseline-cl tries to add duplicate expectations to TestExpectations. Use the results from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_blink_rel/7107 to update the list. TBR=jbudorick@chromium.org NOTRY=True Bug: 824539 Change-Id: I4bd46d9fdc0b3c7e75b6c91ac10792fadef1eab7 Reviewed-on: https://chromium-review.googlesource.com/1156505Reviewed-by:
Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#579373}
-
Friedrich Horschig authored
Before this CL, the renderer emitted a large amount of redundant messages to the browser: Whenever a focused node changes, there would be a message to the PasswordManagerDriver. With this CL, only relevant requests (when a fillable input field is focused) are always sent to the driver. For multiple focus changes to unfillable fields, only the first change results in a message to the driver. This should fix a performance regression (see linked bug). Running the third_party/blink/perf_tests/css/FocusUpdate.html 20 times resulted in the times below which amount to ~10% difference. Without this CL: median 3359.5858379950205 runs/s ranging from 2484 runs/s to 3464 runs/s With this CL: median 3008 runs/s ranging from 2600 runs/s to 3639 runs/s Bug: 866527 Change-Id: Ief36dea9a7a3f30e83ab9c7454124374b95ed52b Reviewed-on: https://chromium-review.googlesource.com/1154541 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579372}
-
Fergal Daly authored
Change-Id: I0a9f90bcbb69cc6dd512ba6cb728ae285878e3b2 Reviewed-on: https://chromium-review.googlesource.com/1156336Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#579371}
-
Peter Beverloo authored
This CL migrates our Background Fetch layout tests to our WPT suite, and adds coverage in various new areas, together with a few minor bug fixes. Tests related to initializing the Service Worker events haven't been included as the event model has just been updated. New tests will be added based on that soon. One file which was removed without being migrated was "credentials-in-url.https.window.js". This was testing the Fetch API as opposed to Background Fetch. Instead, the requirement to propagate exceptions thrown by the Fetch API is tested in fetch.https.window.js. Bug: 864561 Change-Id: I077be6c5bf8c379e3108f4ec3207011582028477 Reviewed-on: https://chromium-review.googlesource.com/1155118 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#579370}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/eb15bd6c..27f30125 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If4f9cc515a6a0870b6072a15dc87b996a8c614ae Reviewed-on: https://chromium-review.googlesource.com/1156251Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579369}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/296b43d7e177..3f1566f6317f git log 296b43d7e177..3f1566f6317f --date=short --no-merges --format='%ad %ae %s' 2018-07-31 hjd@google.com Merge "perfetto-ui: Remove unused file all_tracks.ts" 2018-07-31 hjd@google.com Merge "perfetto-ui: Make UI grid based" 2018-07-30 hjd@google.com perfetto-ui: Make UI grid based 2018-07-30 hjd@google.com perfetto-ui: Remove unused file all_tracks.ts Created with: gclient setdep -r src/third_party/perfetto@3f1566f6317f The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib8367de8022f742d2b2a2b970bb4e42e7da62186 Reviewed-on: https://chromium-review.googlesource.com/1156254 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579368}
-
tzik authored
This CL applies a refactoring tool at //tools/clang/base_bind_rewriters to //components, that updates base::Bind to base::BindOnce where the resulting Callback is immediately converted to OnceCallback. This reduces the number of base::Bind in //components by 921 (from 2749 to 1828). Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia07c5b2987e113efcdeccab8f5b4ec290779d128 Reviewed-on: https://chromium-review.googlesource.com/1151035 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#579367}
-
Marina Ciocea authored
This is a reland of a3ec8289 Original change's description: > Re-enable webrtc audio quality browsertests on windows. > > Tests were previously disabled when they started failing (more context in linked bug). Re-enabling because tests pass locally on win7 machine. > > Bug: 850936 > Change-Id: Ie1ab4e82daf2c0265e932237d3edf6b3399ee803 > Reviewed-on: https://chromium-review.googlesource.com/1139066 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575638} NOTRY=True Bug: 850936 Change-Id: I53579cd78304a845c6ec45500980c1a5cc6f96eb Reviewed-on: https://chromium-review.googlesource.com/1156444 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#579366}
-
Jérôme Lebel authored
Adding list of commands for each switch to toggle from the Google services settings (see the screenshot). To associate those commands to each UISwitch, SyncSwitchItem.commandID is added. GoogleServicesSettingsViewController calls the right command on its |commandHandler| when a switched is toggled. GoogleServicesSettingsMediator implements GoogleServicesSettingsCommandHandler to modify the model when the user toggles the switches. The coordinator sets the mediator to be the command handler for the view controller. Screenshot: https://drive.google.com/open?id=1hvi5LyGjBDODkRQymvC5sbUjSN9tafFz This patch is to replace: crrev.com/c/1146730 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ica05f255bc2af154033a53cd1a1365c43775f9c7 Reviewed-on: https://chromium-review.googlesource.com/1155587 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#579365}
-