- 27 Aug, 2019 40 commits
-
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 121 histograms that show frequent access in the past 90 days. These are the 70% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-02-23. Change-Id: Iad055af9ccafc95bff082623107faca6a5141202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769095 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#690817}
-
Staphany Park authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/ed2eef654373..6a3d632f40a1 git log ed2eef654373..6a3d632f40a1 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 misterg@google.com Googletest export Created with: gclient setdep -r src/third_party/googletest/src@6a3d632f40a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/googletest-chromium-autoroll Please CC isamsonov@google.com,staphany@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng TBR=isamsonov@google.com,staphany@google.com Bug: None Change-Id: Ie0dacd9cdc4c122fa7089c946ed30803a65e0af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771590 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Staphany Park <staphany@chromium.org> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690816}
-
Philip Rogers authored
Now that BlinkGenPropertyTrees has launched, there is no need to track OverscrollBehavior on cc::Layer because it is tracked on cc::ScrollNode. Bug: 994361 Change-Id: Ic87508ed0e67c7be47b87f9313df554be01c891b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773200 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#690815}
-
Alex Keng authored
The leak detector (enabled by --enable-leak-detection) complains because the SVG images created and owned by the UA style sheet are not free'ed at the end of the tests but it's expected because the UA style sheet is a singleton (DEFINE_STATIC_LOCAL) and the SVG images will never be free'ed while a renderer is alive. Since the leak detector is not interested in anything referenced from CSSDefaultStyleSheets [1], this CL addresses the leak by re-creating the default style sheet in CSSDefaultStyleSheets::PrepareForLeakDetection to clean up the SVG resources before the leak detection. This CL also sets flattenhtml=true for IDR_UASTYLE_THEME_CONTROLS_REFRESH_CSS, which was reverted by [2] due to the memory leak. (The reverted CL [3] will be re-landed in a separate CL) TestExpectations is also updated to re-enable password tests which was disabled due to the memory leak. [1] discussion on memory-dev: https://groups.google.com/a/chromium.org/d/topic/memory-dev/LwiD2RBqUpg/discussion [2] https://chromium-review.googlesource.com/c/chromium/src/+/1722789 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1716161 Bug: 988232 Change-Id: I2f289e90f7c16cfe23f501ddc19ea219be7c5bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772657 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#690814}
-
Xianzhu Wang authored
Previously though TransformationMatrix was marked as alignas(16) and the compiler generates machine instructions assuming the alignment, the alignment was not always ensured, e.g. when a TransformationMatrix field was in a GC object (which is allocated by Oilpan which doesn't support alignment at 16-bytes). The program would crash when misalignment happened (which could be random). We had to workaround that by using something like unique_ptr but that is fragile and hard to ensure. The alignment was added in [1] for x86_64 16-byte-aligned SSE2 instructions which were faster than the unaligned counterparts on older architectures. On modern architectures since Sandy Bridge (first CPU shipped in 2011), aligned and unaligned SSE2 instructions have the similar performance [2][3][4]. Now we remove alignas(16) from TransformationMatrix to avoid the alignment trouble. [1] https://chromium.googlesource.com/chromium/src/+/acbc19c46aace2f7980876d96422067f61eb3f01 [2] https://software.intel.com/sites/landingpage/IntrinsicsGuide/#techs=SSE2 (see Performance of _mm_load_pd, _mm_loadu_pd, mm_store_pd, mm_storeu_pd) [3] https://software.intel.com/en-us/forums/intel-isa-extensions/topic/752392 [4] https://www.agner.org/optimize/instruction_tables.pdf Bug: 993638 Change-Id: I24524a1dae259f69c2a47fb0ac97dc517047be03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752840Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#690813}
-
Becca Hughes authored
As per UI review, we should change the swipe to dismiss direction from vertical to horizontal. Therefore, swiping right should dismiss the controls. BUG=998125 Change-Id: I88998ec07b49b9ba5ad316647848a71167f5b8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773441Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#690812}
-
Lei Zhang authored
https://crrev.com/690041 added handling for out of bound indices in PDFiumPage::GetTextRunInfo(), but failed to consider a valid situation where all the text in a text run are whitespaces. In this case, GetTextRunInfo() needs to report the number of characters processed. Add a test case with just a whitespace to test this condition. Also update hello-world.in to have a {{streamlen}} macro and regenerate hello-world.pdf Bug: 997747 Change-Id: Id9e074080b19e4c642cf75fa6b72c5eb969197a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769842Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#690811}
-
Adam Langley authored
Previously, caBLE discovery dealt with a const pointer to a |CableDiscoveryData| because the only possible |CableDiscoveryData| objects were those given via the WebAuthn extension. In the future, we'll need to be able to create |CableDiscoveryData| objects from candidate EIDs because they could also match a QR code. Thus, rejig the functions to return an optional |CableDiscoveryData| rather than a const pointer. The Bluetooth stack returns UUIDs as strings and the previous implementation hex-encoded the expected UUID and matched the resulting string. Since we now need to get the binary EID, the UUID needs to be parsed instead. That leaves the binary-to-string encoding function as something that's only used in a unittest, so the function moves into that unit test in this change. Change-Id: I3e675bcec66bf2416df4945ec1b2487962971729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753697 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#690810}
-
dalyk authored
Some devices may be domain joined but not have any active policies. We should also disable DoH by default for that scenario. Bug: 955454 Change-Id: I50ad015e9e5d072dddcaa72524e5d39ffb2e005c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773397Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#690809}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/8e49d0a2b160..be14352b8322 git log 8e49d0a2b160..be14352b8322 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 zoddicus@users.noreply.github.com Refactor internals of conversion API to be more modular (#785) Created with: gclient setdep -r src/third_party/shaderc/src@be14352b8322 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Ifc810c161e0e637da8bf2fd5a5c87b27de86cbcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773238Reviewed-by:
-
Sean Harrison authored
Bug: 995443 Change-Id: I3e468ccacc4c8391ae6d1616608dcc76fd8335e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766440Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#690807}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f01008997555..c445c7d5c87b git log f01008997555..c445c7d5c87b --date=short --no-merges --format='%ad %ae %s' 2019-08-27 senorblanco@chromium.org Dawn: Remove spirv-tools and spirv-headers rules from Dawn build files. 2019-08-27 mtklein@google.com remove unused sk_sp comparison operators 2019-08-27 michaelludwig@google.com Fix long line Created with: gclient setdep -r src/third_party/skia@c445c7d5c87b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: Iccdeaf45fad85d62e97d26091b70257e965dbe37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773356Reviewed-by:
-
David Bokan authored
Normally, scrolls started from a position: fixed element will chain up to the "viewport", reglardless of DOM ancestry. This is so that scrolling over a banner/menu scrolls the page. The situation is a little different in the root scroller case. There, the "viewport" is composed of the visual viewport, and a non-default layout viewport. e.g. <body> <div id='myrootscroller'>...</div> <div id='fixed'></div> </body> In this case, "viewport" scrolling will scroll |myrootscroller|. In the above case, scrolling over |fixed| shouldn't cause scrolling in |myrootscroller| since that would change semantics on the page which isn't acceptable for an implicitly applied feature (e.g. this is an interop problem). However, in BGPT the scroll_tree_index on a fixed cc::Layer is made to point to the ScrollNode for the nearest ScrollTranslationTransformNode which will always be the visual viewport's, since the Fixed layer translates with the visual viewport. In the compositor, we unconditionally treat "inner/visual viewport" scrolls as scrolling using cc::Viewport which will have the behavior of scrolling both visual and layout viewports (it will scroll |myrootscroller| above). This CL makes two conceptual changes: -The compositor no longer unconditionally scrolls the inner ScrollNode using cc::Viewport. Whether or not the inner ScrollNode should scroll with the cc::Viewport now depends on a Blink-set bit |prevent_viewport_scrolling|. We scroll using cc::Viewport only when this bit is false. The change in LayerTreeHostImpl::TryScroll to scroll the outer viewport even if it has no extent is to compensate for the fact that we no longer unconditionally fallback to viewport scrolling. -Set this bit in Blink during pre-paint based on whether or not we have a non-default root scroller. That is, we only want to provide full viewport scrolling in this case if the root scroller hasn't been changed. This also required some small fixes to tests, in particular, some tests use an awkward layer tree where the outer viewport has no srolling and the visual viewport is scrollable. Inner/Outer scrolling is unusual in these cases because we typically want to scroll both at the same time using cc::Viewport. Changing to explicitly scroll inner only meant these tests break. I've changed them by adding a real scrolling layer as a child of the outer. For more details see: https://docs.google.com/document/d/1bp7nQq76I1HgtWW6fjfTFo__7Sy5XTUsigS-WHpC3B0/edit Note: This is still an issue in main thread scrolling (added tests fail there). I don't believe this is worth fixing there since it would require major changes to allow adding a non-DOM element to the scroll chain and the provided value is low (root scroller is currently only active on Android where main thread scrolling is rare). This should be fixed by scroll unification. Bug: 977954 Change-Id: I644e0d618a21baced50b7b99d543bd517adbd91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752866Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#690805}
-
Xida Chen authored
Right now all the FrameSequenceTrackers are owned by LayerTreeHostImpl, moreover, LayerTreeHostImpl also owns a FrameSequenceTrackerCollection. This CL makes FrameSequenceTrackerCollection owns all the trackers, any operation on the trackers can be done throughput FrameSequenceTrackerCollection. This CL should not cause any behavior change. Bug: None Change-Id: If8b15990ed6c1664af8eaa9c81c1a2888cf40ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769025Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690804}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/605f863173b6..a9da772f0587 git log 605f863173b6..a9da772f0587 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 chrisforbes@google.com Pass draw-to-draw varying state directly to Renderer::draw 2019-08-27 chrisforbes@google.com Do not expose extensions for KHR_shader_draw_parameters and KHR_variable_pointers Created with: gclient setdep -r src/third_party/swiftshader@a9da772f0587 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/132280877 Change-Id: I5b0f1ded5be153b46704afe4630a948c8aed9334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773339Reviewed-by:
-
Min Qin authored
On Q, we never call addCompletedDownload. As a result, there is no download ID, and querying the downloadmanager will always fail. This cause clicking the notification to always open download home, instead of the download itself. BUG=997346 Change-Id: I99ca3d02ce918281ea823785a783c88f3c8df366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769630 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#690802}
-
Peter Kasting authored
* Use constexpr * Use in-declaration initializers * Factor SetSize() out of ProcessInfoHeader(), to facilitate subsequent change that adds color profile decoding between the two. * Factor out a new helper, InitFrame(), to make DecodeBMP() more readable * Reorder DecodePixelData() to follow the class convention of "declare and define methods roughly in called order" * Be consistent about updating |decoded_size_| at the end of helpers, to make it harder to add changes mid-helper that intend to be run repeatedly but aren't (ran into this while adding color profile support) * Functional change: in theory an .ico could contain an OS/2 2.1x bitmap; change from DCHECK() failure on this to setFailed() * Detect top-down BMPs at the same time we're doing other things with the height field * Added some SCOPED_TRACEs to the test code to help track down failures I was getting while writing this Bug: none Change-Id: I5d9a97cdeda66a0236c557cf6345ab8bbea55de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772282Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#690801}
-
Kevin Qin authored
This is the second part of bug 976446 where first part only updates eye and headset related parameters, this cl updates stage related parameters Bug: 976446 Change-Id: I6f18a522a2f929e6c0f1e871eaa7bee85265fd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762587 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#690800}
-
Sam Maier authored
cpu_features GN target moved from android_sdk to android_ndk TBR: minor rename of target Bug: 990407 Change-Id: I82e25a24716d73e17f2e19dd5e83e94b636b8b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756203 Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#690799}
-
Naoki Fukino authored
This CL depends on issue http://crrev.com/c/1763553 to have a preference prefs::kArcVisibleExternalStorages. (will rebase later) prefs::kArcVisibleExternalStorages remembers a list of visible external storage's UUIDs. "Visible" means that the storage is visible to Android apps. (i.e. Android apps can use the external storage to read/write files.) With this CL, Chrome checks visibility of newly mounted storages by reading the preference, and tell the visibility to ARC container using extended MountPointInfo. In addition, when the remembered UUID list changes, all external mount points will be remounted in ARC container to make sure the latest visibility is applied. Bug: 954228 Change-Id: Ief8bd50881462f7e5ae0677883ac119eacf33f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765099 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#690798}
-
Sadrul Habib Chowdhury authored
BUG=986679 Change-Id: I60a17ce118f64291d9bc263ad587c87a651b075a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764560Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#690797}
-
Xing Liu authored
This CL adds a few metrics to track the behavior of background tasks for notification scheduling system. TBR=nikunjb@chromium.org Bug: 963298 Change-Id: Ic6107269db6eb5fbd70bef2836a18336daef55be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762954Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#690796}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/76a93c3325f5..5c81d94fa362 git log 76a93c3325f5..5c81d94fa362 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 geofflang@chromium.org Fix a typo in the GL_NUM_REQUESTABLE_EXTENSIONS_ANGLE enum value. Created with: gclient setdep -r src/third_party/angle@5c81d94fa362 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: I5ba651da99ae31a43b9971e3573b94d1641f433c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773338Reviewed-by:
-
Christopher Cameron authored
AppShimHostManager doesn't actually manage AppShimHosts (the ExtensionAppShimHandler does, confusingly). Rather, it listens for incoming connections from app shim processes. Rename the files and structures to reflect this. Bug: 982024 Change-Id: I0c1e7031da57157da7dfc5bd5dc0c6743a6a89bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772356Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#690794}
-
Ayu Ishii authored
This change fixes flaky failures for SMS browsertests. Tests were previously failing due to the race condition of tests ending before the UKM had been recorded. Verified by running the browsertests consecutively 100 times without any failures. Command: testing/xvfb.py out/ChromeOs/content_browsertests --gtest_filter="SmsBrowserTest.*" --gtest_repeat=100 Bug: 997549 Change-Id: Ic15025412bf6aa766e9443a07a70c2b489a07e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772451 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#690793}
-
David Maunder authored
This is the first CL containing our work to assist the user in closing stale/unused tabs. Bug: 993826 Change-Id: Ib73d7a18ea9f5415289ef3c73cd79cc80f97c3be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753689Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#690792}
-
Daniel Rubery authored
If the BinaryUploadService attempts to read the file before the download code has renamed it to its final location, we can end up having a race condition between the renaming and reading the file contents. So the BinaryUploadService will now wait for the file to be renamed before reading the contents. We'll have to revisit this decision when launching a blocking mode, since then the file isn't renamed until after the upload. Bug: 980784 Change-Id: I5228e8610df9d5db7e84fbfbc2bb53bea79a9e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769677Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#690791}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9d5b5c3f49f3..a203388eab27 git log 9d5b5c3f49f3..a203388eab27 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 lalitm@google.com Merge "trace_processor: move more files to the sqlite folder" Created with: gclient setdep -r src/third_party/perfetto@a203388eab27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ia88663610582d682fc6114f4672742ad2f8dc55b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773341Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ede169e1..d7cac7cb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I610cc31afb0088129233a94379e74e0d212c056b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772553Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690789}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c74d7abaa6bd..9f4081b4ef9b Created with: gclient setdep -r src-internal@9f4081b4ef9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I72977643b356e0633552a85c7e44a5f7c2adafd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773358Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690788}
-
Sergey Ulanov authored
Previously all web_engine processes had the same name, which made it hard to distinguish between processes. Now each process started by web_engine will have the name suffixed with process type, e.g. web_engine_exe:renderer. Change-Id: Ic1fa0f4f7bc87f4789d0d6d85d71d836d89df99f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769996 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#690787}
-
Kush Sinha authored
|AccountManagerMigrator| uses |AccountMigrationRunner| for actually running its migrations. A given instance of |AccountMigrationRunner| silently ignores multiple calls to its |Run| API, which makes it impossible to run migrations multiple times. Fix this by re-creating the |AccountMigrationRunner| object when a migration re-run is required. Bug: 998111 Change-Id: Iead9ce954a5488c5ed3844bbe1077a92c9d80b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769453 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#690786}
-
Stephen McGruer authored
Bug: 900581 Change-Id: Ieda118b47ebb266e7e52db20055de6664ad171bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773183Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#690785}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4271afbc301e..44bd29a3b068 git log 4271afbc301e..44bd29a3b068 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 sakal@webrtc.org Detect leaks of TextureBufferImpl objects. 2019-08-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 925c16d3..abb1ee24 (690586:690691) Created with: gclient setdep -r src/third_party/webrtc@44bd29a3b068 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:b/139745386,chromium:None Change-Id: I0ff411e2f9bdffcb7fae6b0ef8d52a2d5c6fa7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769340Reviewed-by:
-
Allen Bauer authored
Bug: 651648 Change-Id: Ice5dac45a04acfd7e69232e5114c8cc17c302e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773321 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#690783}
-
Mike Jackson authored
In the event there are multiple targets on page, clearing the storage via the applications tab can result in: console.assert(this._databaseNamesBySecurityOrigin[securityOrigin]); firing in Resources.IndexedDBModel.clearForOrigin because only the top level security origin is passed to each target, and the security origins might not match. Repro steps: 1) Load http://nparashuram.com/trialtool/#example=/IndexedDB/trialtool/index.html&selected=#saveData 2) Run the following examples: "Pre Requisities", "Open Database", "Create Object Store", "Add Data" 3) Load the devtools, and clear all site data from the application tab Change-Id: Iccad7f70c61eb6593058280f971849f139f473a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716445 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Cr-Commit-Position: refs/heads/master@{#690782}
-
Doug Arnett authored
Attempting a closer histogram to wait on. Was able to run locally 2000 times without failure whereas previous histogram did fail locally after a couple hundred attempts. Bug: 997697 Change-Id: I1f826945091f6e2fce035755fe62ba781f219adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771045Reviewed-by:
-
Kush Sinha authored
Chrome OS Account Manager migrator currently does not expose the results of its migration runs. Add a |AccountManagerMigrator::GetLastMigrationRunResult|. This will be used to retry migrations in ARC. Bug: 998111 Change-Id: I528c9fe04d144d3c883aebc45f1cd30da1e52bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773218Reviewed-by:
-
Erik Chen authored
All calls to GetWebWidget() should either DCHECK that the WebWidget exists, or else have a conditional with appropriate behavior if the WebWidget does not. Bug: 995981 Change-Id: I32e148efe04c5a889b0b26ad1d7a6ca9eba8752d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771052 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690779}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I57e2099af02b1ba20075d05def0fed08abf73843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773317Reviewed-by:
-
