GitLab

> Style nits
> 
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/189293003

TBR=matthew@dempsky.org

Review URL: https://codereview.chromium.org/190543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255665 0039d316-1c4b-4281-b951-d872f2087c98

For the moment, extension and internal code relies on navigator.language
to return the browser UI language but it should return the preferred
language for fingerprinting reasons, see http://crbug.com/101138.

BUG=348402

Review URL: https://codereview.chromium.org/185423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255663 0039d316-1c4b-4281-b951-d872f2087c98

Currently the visible_rect is implicitly set to the quad's |rect| value
then later changed by the occlusion/culling code. Instead we want to
compute this value up front and set it on the quad when the quad is
created. So add it to the SetNew() method. Currently it should always
be set to the same value as the |rect|.

R=enne
BUG=344962

Review URL: https://codereview.chromium.org/185563008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255662 0039d316-1c4b-4281-b951-d872f2087c98

These are unit tests so they should be in the unit_tests target. A
TODO says this did not work before, but they appear to pass as unit
tests now, so this is just a code move.

BUG=270918
R=droger@chromium.org, hajimehoshi@chromium.org

Review URL: https://codereview.chromium.org/186063007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255661 0039d316-1c4b-4281-b951-d872f2087c98

This change is in support of later changes moving the bookmarks_ui
manifest key from chrome_settings_overrides to chrome_ui_overrides.

BUG=349049
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/188813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255660 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338855
TEST=manual
NOTRY=true
R=jhawkins@chromium.org, zork@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255380

Review URL: https://codereview.chromium.org/187983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255659 0039d316-1c4b-4281-b951-d872f2087c98

The current content/renderer/webcrypto implementation is really generalizable to both
renderers and workers. This commit moves content/renderer/webcrypto to
content/child/webcrypto. Additionally, it adds support in WebKitPlatformSupportImpl for WebCrypto, so both workers and renderers can use it.

BUG=349514

Review URL: https://codereview.chromium.org/188203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255658 0039d316-1c4b-4281-b951-d872f2087c98

BUG=304341
TEST=no change

Review URL: https://codereview.chromium.org/188923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255657 0039d316-1c4b-4281-b951-d872f2087c98

Cache entry cannot be removed when mounted.
This check should be performed before removing metadata entry.

BUG=349380

Review URL: https://codereview.chromium.org/187893006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255656 0039d316-1c4b-4281-b951-d872f2087c98

The new tests are failing:
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%285%29/builds/25532/steps/browser_tests/logs/stdio

> Persist browseraction properties across restarts
> Persist browser action properties across restarts even if other properties are modified before the old ones are loaded. (Note: only properties which are NOT modified are persisted.)
> BUG=348775
> 
> Review URL: https://codereview.chromium.org/186013003

TBR=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/189873005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255655 0039d316-1c4b-4281-b951-d872f2087c98

The format of the license field in
third_party/readability/README.chromium makes the license checker
erroneoulsy flag it as incompatible as it doesn't fit the regex.

Android WebView is now depending on third_party/readability (another
discussion perhaps) and there's no good reason to exclude it from
the WebView build right now.

TBR=nyquist@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/189463006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255651 0039d316-1c4b-4281-b951-d872f2087c98

In the case where there are tasks scheduled to run and we enter
ALLOW_NOTHING mode, we would early out from DidFinishRunningTasks
and keep resources on tasks that were finished between the last schedule
and entering ALLOW_NOTHING mode.

BUG=349553

Review URL: https://codereview.chromium.org/188153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255650 0039d316-1c4b-4281-b951-d872f2087c98

Migrate changes from codereview.chromium.org/181433022.

BUG=344486
TEST=build and run the test on link

Review URL: https://codereview.chromium.org/176843019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255649 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes a crash happening when Chrome shuts down or a capture
device is removed from the system while there are observers observing
the "suspended" property of the AVCaptureDevice going out of scope --
basically leaving the observer observing a zombie.

For that, the CrAVFoundationSuspendObserver registers to observe both
"suspended" and "connected". In the case of "connected" received, it
can only mean disconnected, so both observers are removed. The |device|
pointer is passed to -addObserver:forKeyPath:options:context: as the
|context|, and is received then in the -observeValueForKeyPath:... .

CrAVFoundationSuspendObserver renamed to CrAVFoundationDeviceObserver.

BUG=288562, 348917

Review URL: https://codereview.chromium.org/188383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255648 0039d316-1c4b-4281-b951-d872f2087c98

Previously, tests that involved incognito profiles needed to manually
create them and add them to the parent profile before
GetOffTheRecordProfile was ever called.  However, the documentation for
Profile explicitly states that the incognito profile will be created if
it doesn't already exist when GetOffTheRecordProfile is called. Further,
it was prohibitvely invasive to test code that creates a profile and
expects to be able to do something with its associated incognito
profile.

This commit also updates existing tests to remove unnecessary manual
incognito profile creation.

BUG=318803
R=atwilson@chromium.org, dpolukhin@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/181403006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255647 0039d316-1c4b-4281-b951-d872f2087c98

Our code has dependencies on the Windows implementation of this API until M33 and a recent unexpected change broke it, we need to make sure to be notified of any other potential changes.

We can remove this after M33 is out of stable.

NOTRY=True
BUG=350028

Review URL: https://codereview.chromium.org/189093011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255645 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348006

Review URL: https://codereview.chromium.org/189203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255644 0039d316-1c4b-4281-b951-d872f2087c98

There was this TODO(sky): convert this and InitMessagePumpForUIFactory() to return a
scoped_ptr.

This patch is for doing the same.

R=darin@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/185413019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255643 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332315
TEST=none

Review URL: https://codereview.chromium.org/183923037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255639 0039d316-1c4b-4281-b951-d872f2087c98

These utility functions are now only used in
discardable_memory_allocator_android.cc so they have no reason anymore to live
in discardable_memory_android.cc.

TBR=willchan@chromium.org
BUG=347919

Review URL: https://codereview.chromium.org/189113006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255638 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/188723005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255637 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350016
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/177013006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255636 0039d316-1c4b-4281-b951-d872f2087c98

This cl splits COMMIT_STATE_FRAME_IN_PROGRESS into below two separate
states for more clear.
1) COMMIT_STATE_BEGIN_MAIN_FRAME_SENT
2) COMMIT_STATE_BEGIN_MAIN_FRAME_STARTED

R=brianderson@chromium.org
BUG=347398
TEST=cc_unittests

Review URL: https://codereview.chromium.org/179933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255633 0039d316-1c4b-4281-b951-d872f2087c98

+ Added using statements.
+ Deleted annonmous namespace and include order in congest_control area
  to match internal source code.

R=rch@chromium.org

Review URL: https://codereview.chromium.org/189403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255632 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255631 0039d316-1c4b-4281-b951-d872f2087c98

Chromium base revision: 255605 / 475fd16c
Old Skia revision: 13693
New Skia revision: 13700
Control CL: https://codereview.chromium.org/190753002

This CL was created by Skia's roll_deps.py script.

Bypassing commit queue trybots:
NOTRY=true

Review URL: https://codereview.chromium.org/190763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255630 0039d316-1c4b-4281-b951-d872f2087c98

This adds primitive support to the doc server for
API models living in src/extensions/common/api.

BUG=349953

Review URL: https://codereview.chromium.org/176973009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255629 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255627 0039d316-1c4b-4281-b951-d872f2087c98

Make WaitableCallbackResults ref-counted and a member of WebFileSystemImpl to keep it alive longer than before.
Add CallbacksUnregisterMode argument to RunCallbacks() to keep callbacks registered when necessary.
Initialize next_callbacks_id_ with 1 instead 0 to make 0 usable as an invalid ID.
Implement waitForAdditionalResult().
UnregisterCallbacks() is also responsible to unregister WaitableCallbackResults.

Corresponding patch: https://codereview.chromium.org/178333009/

BUG=347900
TEST=run_webkit_tests.sh http/tests/filesystem/\*
TEST=run_webkit_tests.sh http/tests/inspector/filesystem/\*

Review URL: https://codereview.chromium.org/188533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255625 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the flag to enable non-SFI mode is checked just before launching the plugin in the browser process. However, even if the flag is set, we may need to run the plugin in SFI mode.
For example, trivially, if the plugin provides only SFI-mode binary.
To handle such a case, this CL adds entries to NaCl manifest file so that a plugin developer can declare if their plugin provides SFI-mode/non-SFI mode binaries.
In summary, NaCl works in non-SFI mode if;
1) --enable-nacl-nonsfi-mode is set to true, and
2) the plugin provides the binary for non-SFI mode.
So, some checks are moved from the browser to the renderer.

We need similar, but slightly different, a flag for non-SFI mode. Here is the naming rule:
1) enable_nonsfi_mode -> If non-SFI mode is enabled on the browser.
  (In more precise, if it is running on supported platform, and --enable-nacl-nonsfi-mode is set)
2) uses_nonsfi_mode -> If the specified plugin should run on non-SFI mode.
  This happens when the plugin provides the binary for non-SFI mode, and --enable-nacl-nonsfi-mode
  is set.

Note that, in later CLs, we split non-SFI mode nacl_helper from the current nacl_helper with linking it to the newlib.
Then, the uses_nonsfi_mode will become a flag to decide which helper the host should talk to.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Ran trybot.

Review URL: https://codereview.chromium.org/177113009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255623 0039d316-1c4b-4281-b951-d872f2087c98

BUG=145873, 322664
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/183333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255622 0039d316-1c4b-4281-b951-d872f2087c98

* Add methods EvaluateJavaScriptInContext,
ExecuteJavaScriptInContext.
* Backend classes take an additional context_id argument, which refers to the iframe.
* WebContents has an EnableAllContexts method, to enable access to iframes.
* Add tests testIFrame, and unit test data files host.html, iframe*.html.

BUG=237032
TEST=unittest

Review URL: https://codereview.chromium.org/183863007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255621 0039d316-1c4b-4281-b951-d872f2087c98

Originally these names had been named based on similarly behaving
devices we had in our inventory, change the names of both the variables
and displayed names to be more generic and instead describe their
behavior.

BUG=346367
TEST=device_unittests

Review URL: https://codereview.chromium.org/189753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255620 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255619 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/186843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255618 0039d316-1c4b-4281-b951-d872f2087c98

Switch to using the new Link Doctor API.

The new API allows Link Doctor results to be integrated into Chrome's
own error pages.

BUG=64832
R=tsepez@chromium.org, ttuttle@chromium.org
TBR=pkasting@chomium.org, thakis@chromium.org

Originally Landed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254207

Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=254241

Review URL: https://codereview.chromium.org/184973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255617 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/184853007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255616 0039d316-1c4b-4281-b951-d872f2087c98

Also avoids unnecessary heap allocations by recycling old state vector.
Result is ~100% performance improvement to ScheduleTasks.

BUG=269841
TEST=cc_perftests --gtest_filter=RasterWorkerPoolPerfTests/RasterWorkerPoolPerfTest.ScheduleTasks/0

Review URL: https://codereview.chromium.org/174453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255615 0039d316-1c4b-4281-b951-d872f2087c98

R=creis@chromium.org

Review URL: https://codereview.chromium.org/189063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255614 0039d316-1c4b-4281-b951-d872f2087c98

We are currently removing trying to remove all references to base::Time (wall
clock time) from Chrome/Blink compositor/graphics stack.

This requires multiple two-sided patches. Following the process found at
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/ukaRczAK6t8/0ludyZ1Nu4cJ

The steps are;
 * Adding monotonic only API to Blink's animation delegate interface
   https://codereview.chromium.org/185633002

 * (This Patch) -- Making the delegate adapter use monotonic only API
   https://codereview.chromium.org/185643002

 * Remove the wallClockTime API from Blink/WebKit.
   https://codereview.chromium.org/185393005

BUG=299945

Review URL: https://codereview.chromium.org/185643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255613 0039d316-1c4b-4281-b951-d872f2087c98