GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271049 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=1&start=14757
TBR=
BUG=

Review URL: https://codereview.chromium.org/287063008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271048 0039d316-1c4b-4281-b951-d872f2087c98

The underlying rule is now "long" by default.
Mechanical change:
   git grep -l jni_generator_ptr_type | xargs sed -i /jni_generator_ptr_type/d
Relands crrev.com/270750 (reverted by 270849)

BUG=317523
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/288223005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271047 0039d316-1c4b-4281-b951-d872f2087c98

This also cleans up the main VLOG in renderer_accessibility_complete so
that it uses the new function in ui to convert an AXEvent to a string,
and removes the NDEBUG since this is quite useful logging in release builds.

Instead of the old switch, use --vmodule="*accessibility*=0" to log
accessibility messages that are normally suppressed, possibly combined
with --enable-logging=stderr to send them right to your terminal and
--log-level=2 to optionally suppress most other log messages.

BUG=350457
R=aboxhall@chromium.org, jam@chromium.org

Review URL: https://codereview.chromium.org/284203005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271046 0039d316-1c4b-4281-b951-d872f2087c98

Don't waste space including resources with empty beacons and 0 counters
in uploads.

BUG=356791

Review URL: https://codereview.chromium.org/284283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271045 0039d316-1c4b-4281-b951-d872f2087c98

Make some methods take Node/View* instead of NodeId/ViewId. These
functions needs the Nodes anyway, so no point in converting to id,
then back to node multiple times.

Also remove TODOs that aren't going to happen.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/284113008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271044 0039d316-1c4b-4281-b951-d872f2087c98

We'd grown a couple of copies of code to create various test objects.
Deduplicate them into test_util and call them there.

BUG=356791

Review URL: https://codereview.chromium.org/291493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271043 0039d316-1c4b-4281-b951-d872f2087c98

Chrome treats the user ID passed in via chromeos::switches::kLoginUser as
if someone had authenticated against GAIA using this ID. During GAIA
authentication, the user ID is canonicalized. If authentication is
short-circuited using this switch, the user ID should thus be
canonicalized as well.

BUG=367847
TEST=None

TBR=stevenjb (chrome/browser/extensions/api/networking_private/networking_private_apitest.cc)

Review URL: https://codereview.chromium.org/290123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271042 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:373548
TEST=the warnings are gone.

Review URL: https://codereview.chromium.org/288903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271041 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374058

Review URL: https://codereview.chromium.org/291483005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271040 0039d316-1c4b-4281-b951-d872f2087c98

This dir will be put on the include path for MSVC to pick up when invoked
as fallback compiler.

BUG=345874
NOTRY=true

Review URL: https://codereview.chromium.org/281413006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271039 0039d316-1c4b-4281-b951-d872f2087c98

I was copying the error code out of the URLRequestStatus of a monitored
request whether or not the status was FAILED; in cases where it wasn't,
the error would be something random (often QUIC_PROTOCOL_ERROR).

This change makes sure that we only copy the error code when we should,
and adds a unit test to make sure that beacons for successful requests
contain net::OK even if the error field contains something else.

BUG=356791

Review URL: https://codereview.chromium.org/284103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271038 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366632

Review URL: https://codereview.chromium.org/283963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271037 0039d316-1c4b-4281-b951-d872f2087c98

It is not necessary for WindowTreeHostOzone to call into the event-factory
to explicitly request it to start receiving events. The evdev implementation
can start listening to the events immediately, and the canca implementation
can start listening for events when the dispatcher list changes (this is the
same we do for the libevent based x11 event-source).

BUG=361137
R=spang@chromium.org

Review URL: https://codereview.chromium.org/285303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271036 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373537

Review URL: https://codereview.chromium.org/290653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271035 0039d316-1c4b-4281-b951-d872f2087c98

Changes in this CL:
- Add cdm_factory.h to support platform specific CDM creation.
- Detach BrowserMediaPlayerManager from MediaDrmBridge.
- Store the security origin of CDMs in the manager so that CDMs don't need to
  know it.
- Keep the CDM ID in the manager so that CDMs don't see it.

BUG=338910
TEST=Test page plays and tests still pass.

Review URL: https://codereview.chromium.org/276973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271034 0039d316-1c4b-4281-b951-d872f2087c98

This closed the tree: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/11008/steps/interactive_ui_tests/logs/stdio

> [DevTools] Interactive test for DevTools touch emulation.
> 
> BUG=337142
> 
> Review URL: https://codereview.chromium.org/249613002

TBR=dgozman@chromium.org

Review URL: https://codereview.chromium.org/287153007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271032 0039d316-1c4b-4281-b951-d872f2087c98

This eliminates compile warnings on x64 platform:

cl : Command line warning D9002 : ignoring unknown option '/arch:IA32'

BUG=374053

Review URL: https://codereview.chromium.org/288353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271031 0039d316-1c4b-4281-b951-d872f2087c98

We have been reported that user adding UI was invisible once in M35.
I was not able to find the source of this problem, maybe it is gone
already. I wrote this test, just in case.

BUG=362153
TEST=UserAddingScreenTest.*ScreenVisibility

Review URL: https://codereview.chromium.org/290083005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271030 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367239

Review URL: https://codereview.chromium.org/280753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357693

Review URL: https://codereview.chromium.org/286163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=337142

Review URL: https://codereview.chromium.org/249613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271026 0039d316-1c4b-4281-b951-d872f2087c98

. OnNodeHierarchyChanged() is only sent for nodes the client cares
  about (see ShouldNotifyOnHierarchyChange for exact details).
. OnNodeHierarchyChanged() now includes any nodes not yet known to the
  client.
. Added OnServerChangeIdAdvanced, which is sent if the change id
  advances but the client didn't get a notification (this can happen
  when hierarchy changes are done in other clients that the client
  isn't notified about).
. OnConnectionEstablished now includes the state of the tree.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270925

Review URL: https://codereview.chromium.org/288313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271025 0039d316-1c4b-4281-b951-d872f2087c98

it is very hard to troubleshoot a flaky asynchronous DevTools test without
being able to log something directly to the console output.
With this patch DevTools window is able to do that. Also logging into
Error stream doesn't skew the normal test output so the flaky test
could be tested in a cycle until the first error.

BUG=

Review URL: https://codereview.chromium.org/288663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271024 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky
NOTRY=true

Review URL: https://codereview.chromium.org/290123005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271020 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162827

Review URL: https://codereview.chromium.org/284583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271017 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271016 0039d316-1c4b-4281-b951-d872f2087c98

The DCHECK dereferenced the request's HttpResponseInfo.  It turns out
that when an HttpNetworkTransaction is cancelled and an
HttpResponseDrainer is used, the HttpResponseInfo is deleted with the
HttpStreamParser's knowledge.

This CL also adds a pair of tests for the situation.

BUG=368418

Review URL: https://codereview.chromium.org/284913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271014 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373748
TBR=mukai@chromium.org

Review URL: https://codereview.chromium.org/284203009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271013 0039d316-1c4b-4281-b951-d872f2087c98

This CL:
 * filters the task of Gallery.app itself.
 * allows the gallery.app to load task icons.

BUG=358698
TEST=None

Review URL: https://codereview.chromium.org/282303006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271012 0039d316-1c4b-4281-b951-d872f2087c98

For unittest that only testing functionatility of Append DrawQuads and
SharedQuadState, only creates RenderPass for it.

This CL is first part of clean up QuadSink. Next step would be to use
test occlusion tracker for MockQuadSink.

BUG=
TEST=cc_unittests

Review URL: https://codereview.chromium.org/288273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271011 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372564

Review URL: https://codereview.chromium.org/287003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271008 0039d316-1c4b-4281-b951-d872f2087c98

Two bugs, and general state-machine grotesqueness, prevented auto-reload
histograms from working properly in production:

1. Success could only be reported in OnCommitLoad() if can_auto_reload_page_ was
true, but can_auto_reload_page_ would be set to false in OnStartLoad(), since
OnStartLoad() had no way of knowing that the non-error page load it saw starting
was actually part of an attempt to auto-reload the page. This has been patched
around by tracking is_auto_reloading in committed_error_page_info_; when the
auto reload timer fires, it sets is_auto_reloading to indicate to OnCommitLoad
that auto-reload was running. OnCommitLoad can then use is_auto_reloading and
the loading URL to decide whether the committing load represents a success or
failure for auto-reload.

2. Whenever a non-error load started, OnStartLoad() would call
CancelPendingFetches(), intending to prevent auto-reload from replacing the
starting load with its own; as a side-effect, CancelPendingFetches() would
assume that if there was an existing error page which looked auto-reloadable
that the cancel represented a failure of auto-reload and log a histogram entry.
Unfortunately, this logic would trigger at each reload attempt by auto-reload,
inflating the failure count with nonexistent failures. To prevent this
misbehavior, CancelPendingFetches() is now no longer responsible for logging
auto-reload failures; instead, failures are detected and logged in
OnCommitLoad() (for "user navigated elsewhere" failures), OnStop (for "user
pressed Stop to abort auto-reload" failures), and the NetErrorHelperCore
destructor (for "user closed the tab" failures).

To help clean up the code, statistics are now reported through
ReportAutoReloadSuccess() and ReportAutoReloadFailure().

There are new unit tests covering these cases:
1. Auto-reload succeeding on the first attempt;
2. Auto-reload succeeding on the second attempt;
3. The user manually stopping an auto-reload;
4. The user manually stopping a non-auto-reload load;
5. The user navigating to a different URL;

As part of this cleanup, simplify the state machine; the ambiguous "can_auto_reload_page_" flag is gone, replaced by an implicit state bit in whether the timer is running (or paused) or not.

BUG=

Review URL: https://codereview.chromium.org/259613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271007 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346210

Review URL: https://codereview.chromium.org/283563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271005 0039d316-1c4b-4281-b951-d872f2087c98

Re-landing https://codereview.chromium.org/272183005
with leak fix.

BUG=372673
TBR=michaeln@chromium.org,horo@chromium.org

Review URL: https://codereview.chromium.org/282263008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271004 0039d316-1c4b-4281-b951-d872f2087c98

Remove ArrayBuffer ctor that is not defined.
Add explicit assignment operator for ArrayBufferView.

BUG=none
R=dcarney@chromium.org,mnaganov@chromium.org

Review URL: https://codereview.chromium.org/289003007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271003 0039d316-1c4b-4281-b951-d872f2087c98

When browser navigates to another page, make sure we de-associate
NPObjects of injected Java objects from their old V8 wrappers.

Not doing this leads to potential leaks of JS objects from one
context to another.

BUG=372914
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/286823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271002 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Mac] Unselect generated password when mouse leaves password bounds. (https://codereview.chromium.org/282093006/)

Reason for revert:
Speculative revert, FormFillLatencyAfterSubmit is failing

Original issue's description:
> [Mac] Unselect generated password when mouse leaves password bounds.
> 
> In the Mac implementation of the password generation poup, the password
> row is not unselected when the mouse is moved elsewhere in the popup
> (e.g. over top of the help text).
> 
> The fix is that PasswordSelected() should always be called in
> SetSelectionAtPoint, not just when the mouse is within the password
> bounds. The Views implementation happens to work because it has a
> subview (PasswordRow) which triggers OnMouseExited() when the mouse
> moves outside of the password bounds.
> 
> Also added an optimization that PasswordSelectionUpdated() is only
> called when the value is actually changed, not every time
> PasswordSelected() is called.
> 
> BUG=114092
> R=isherman@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270975

TBR=gcasto@chromium.org,isherman@chromium.org,dubroy@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=114092

Review URL: https://codereview.chromium.org/287063007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271001 0039d316-1c4b-4281-b951-d872f2087c98

Currently, if there is an access to the pipe, whose other side is
already closed, SIGPIPE will be raised in some platform such as linux.
It is unexpected behavior, and causes some test failure.
This is what trusted plugin does in content/app/content_main_runner.cc.

TEST=Ran PPAPINaClPNaClNonSfiTest.Audio locally many times and the flakiness
was gone. Also run trybots.
BUG=371662

Review URL: https://codereview.chromium.org/288063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271000 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371845
TBR=jochen

Review URL: https://codereview.chromium.org/289993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270999 0039d316-1c4b-4281-b951-d872f2087c98