GitLab

As far as I can tell this filters the rest of the unused java classes.

Please revert this CL if you see ClassNotFound Exceptions.

diagnose_bloat summary:
MonochromePublic.apk_Breakdown (-4,097 bytes)
    +1,731 bytes Zip Overhead
        -1 bytes Package metadata size
    -5,827 bytes Java code size
MonochromePublic.apk_Specifics
   -15,137 bytes normalized apk size
   -11,040 bytes main dex size

Bug: 944791
Change-Id: I53219489d0289655a72405ab1e06cbeeb065d4f4
Reviewed-on: https://chromium-review.googlesource.com/944791Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540549}

CFNetDiagnosticDiagnoseProblemInteractively has been deprecated, and
now apparently does nothing. We could consider using
/System/Library/CoreServices/Applications/Wireless Diagnostics.app/,
but that would require a bit more investigation and though, so just
removing the link for now.

Bug: 810215
Change-Id: Iabe0698b17734743c092701eced0297eb71d77b7
Reviewed-on: https://chromium-review.googlesource.com/932722
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540548}

Also, revert change that removed the old icon because UI team changed
their mind.

Bug: 793985
Change-Id: I0600ca9fc724813743672c83b27e9adf0dcb28a2
Reviewed-on: https://chromium-review.googlesource.com/946518Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540547}

In a previous CL, I screwed up while trying to rebase and accidentally
reverted all the changes that was meant to be landed. Please see:

https://chromium-review.googlesource.com/c/chromium/src/+/935195/10..11/tools/code_coverage/coverage.py

So, in this CL re-land those changes, sorry about the inconvenience!

Bug: 814608

Change-Id: I5cb7a87d851aa4d97b05fde9a243677c07eb13d8
Reviewed-on: https://chromium-review.googlesource.com/945422Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540546}

R=zmo@chromium.org

Bug: 815045
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie79595f6dd57ba4e38d8dcac5e48f7ef59500b0b
Reviewed-on: https://chromium-review.googlesource.com/945142Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540545}

The stats are not meaningful. They were already not being collected on Windows.
Stop attempting to collect macOS stats [which have different semantics].

Bug: 815328
Change-Id: Ic25eb3c16be47aa87dfb2769fc97a2079b418d34
Reviewed-on: https://chromium-review.googlesource.com/943184
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540544}

Following the CL:944281, another idea to reduce the number of
failures to manually review.

This patch rebaselines text-only failure where:
* The -expected.txt is a text dump.
* The test also has an expected image, and images match.

This rule is reasonable because during the manual reviews, I usually
review only image differences (results.html only shows image
differences if both are different) and rebaseline if the difference
is good.

From the linux_layout_tests_layout_ng build 4025,
477 have images from 481 text dumps among 1617 text failures.

NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I6a0c1f12f0a967e6240c27794d96a36274b8020d
Reviewed-on: https://chromium-review.googlesource.com/945184
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540543}

The reason I would like to nuke it is that it is mostly
unnecessary. In particular the code can supply a closure to the last
event generating routine instead, which should have the same effect.

This function was added as a work around. In particular the windows event
matching code was looking for l/r/mbuttondown (or up), but if the events
are close enough a double click is generated. So, added logic for that case.

BUG=817112
TEST=none

Cq-Include-Trybots: master.tryserver.chromium.mac:mac_chromium_10.10_macviews
Change-Id: I6f2937501eff6b9b85176d45ce14712bea4a2023
Reviewed-on: https://chromium-review.googlesource.com/940424Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540542}

Bug: 818202
Change-Id: I451982f1773558b4cf11b985b861e21999819658
Reviewed-on: https://chromium-review.googlesource.com/946049Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540541}

Implement HTTP/2 support in websocket_stream.cc::(anonymous
namespace)::Delegate::OnResponseStarted().

Convert many WebSocketStream tests to test over HTTP/2 as well.

Relax requirement for non-empty header keys in SpdyTestUtil, since
URLRequest-based tests send an empty User-Agent header.

Enable WebSockets over HTTP/2 and set some other
HttpNetworkSession::Params flags customary for tests in
WebSocketTestURLRequestContextHost constructor (copied from
SpdySessionDependencies constructor).

Bug: 801564
Change-Id: I24f5bc999c4e62dc1e8feb4b7db94d0f5b38323c
Reviewed-on: https://chromium-review.googlesource.com/940463
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540540}

RenderFrameMetadataObserverImpl was sending a message from the renderer to the
browser whenever any metadata changes. One such piece of data is the scroll
offset. Due to this, when scrolling, there would be an IPC from the renderer
to the browser on each frame.

This was picked up as a regression in the number of tasks.

After analysing the plans for which data will exist in RenderFrameMetadata we
determined that there are some which are high frequency, and some which are low.
Additionally the majority of the usage of the high frequency data is in tests.

In this change RenderFrameMetadataObserverImpl is updated to check for the
difference in RenderFrameMetadata based on high frequency and low frequency
fields. It will always send updates for low frequency fields. However for high
frequency fields, such as root_scroll_offset, it will only send in testing mode.

The currently implemented tests continue to pass with this change.

TEST=NonBlockingEventBrowserTest

Bug: 813970
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I4c21030a703c207519a56a851e052d9087708533
Reviewed-on: https://chromium-review.googlesource.com/934626Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540539}

Disabling test ElementAttributeTest.testCanRetrieveTheCurrentValueOfATextFormField_emailInput

Bug: chromedriver:2286
Change-Id: Id98d85f2ea4af858c172fbb50084922cddca3f15
Reviewed-on: https://chromium-review.googlesource.com/946522Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540538}

Spec: https://drafts.csswg.org/selectors-4/#the-focus-visible-pseudo
Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-wN72ESFsyo

Adds :focus-visible to the list of known CSS pseudo classes. This change also adds a flag,
WasFocusedByMouse(), to UserActionElementSet which is exposed as Node.WasFocusedByMouse().
SelectorChecker will use this flag to check if a node matching :focus should also match
:focus-visible. By default, any node focused by mouse will NOT match :focus-visible. Any
node focused by keyboard will match :focus-visible.

Bug: 817199
R=aboxhall@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1a0aadc8ea653afc964865a277b2d4d2ccabe540
Reviewed-on: https://chromium-review.googlesource.com/897002
Commit-Queue: Rob Dodson <robdodson@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540537}

Bug was introduced here:
https://chromium-review.googlesource.com/920790

Change introducing the bug was not actually related to the fix
in that CL.

Bug: 817706
Change-Id: I9e73f05fe66745b1b7651333a6d715c682018a1a
Reviewed-on: https://chromium-review.googlesource.com/944161Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540536}

Using wpt-import in Chromium 3a0c4853.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13080

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: Idea22a9000dd039a71c5d6c3a2ec3d9cc09e72cd
Reviewed-on: https://chromium-review.googlesource.com/946269
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540535}

By doing a detailed dig-in, it was found that both the copy image operation in
main thread and worker thread will call CopyToPlatformTexture and pass in the
same set of parameters wrapped in different classes. This CL abandons one of
these routes that uses MakeImageSnapshot() and adopt the other route that use
our latest one-stop resource manager class--CanvasResourceProvider, as well as
using ContextProviderWrapper as a unified context provider for both main and
worker thread.

Bug: 794706
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Idb5b64d0d10b95abde14cab0680695348505e811
Reviewed-on: https://chromium-review.googlesource.com/943761Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540534}

Bug: 803714
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib2182f9ce842f4b515eb7d14322139bed9348e9c
Reviewed-on: https://chromium-review.googlesource.com/931743
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540533}

Two new tests are failing on viz_browser_tests, this filters them out. They've
been triaged to appropriate bugs

TBR=kylechar@chromium.org

Bug: 794961
Change-Id: I4693c03eac9e8f895b8d6a517cf83bba3066585e
Reviewed-on: https://chromium-review.googlesource.com/946512Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540532}

BUG=818069

Change-Id: Ie4989031929e5b65a0a783809d3ee588227e6a75
Reviewed-on: https://chromium-review.googlesource.com/944051Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540531}

All it does right now is verify that starting a Background Fetch request
from JavaScript makes the (real) download service accept a request. It
will provide the base for various other integration tests to follow.

Change-Id: Ib748ba394d4933d486617c4fc77a643ed9cf8d62
Reviewed-on: https://chromium-review.googlesource.com/940121Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540530}

Bug: 801006
Change-Id: Ic75538c44814c912ab623af4959f74cd081000f7
Reviewed-on: https://chromium-review.googlesource.com/939668
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540529}

This CL migrates renderer to browser IPC messages.

Also, This CL registers MediaStreamTrackMetricsHost as a Mojo interface to be
exposed to the renderer from RenderProcessHostImpl. The host is created
whenever a request is made from the renderer.

Bug: 787422
Change-Id: I113b774858633d787f300099177277835af69da2
Reviewed-on: https://chromium-review.googlesource.com/795524Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540528}

We've now triagged all of the Mac specific failures that have been seen when
running viz tests on Mac FYI bots. This updates the filter files to document
which bug is tracking the failures for which tests.

TBR=kylechar@chromium.org

Bug: 760181
Change-Id: I0ef68761fd8be57619d35ed9a8de87dbfbd59132
Reviewed-on: https://chromium-review.googlesource.com/946127Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540527}

Missing include guards tend to break jumbo builds and makes
everyone involved sad so better to have a presubmit check for it.

There is a risk that this triggers on correct code so it includes
a way to disable it per source file. Include the string
"no-include-guard-because-multiply-included" and there won't
be any warning for that file.

By popular demand there will also be a warning if the name of
the include guard doesn't follow the coding standards, but since
mistakes are common, that check is only enabled for new files.

Bug: 814776
Change-Id: Id18b3d43288b9a064e537460d667957b355bbd33
Reviewed-on: https://chromium-review.googlesource.com/931761
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540526}

Currently CopyOutputRequests given to CompositorFrameSinkSupport end up in whatever
surface happens to be the last activated surface at the time. This could result in
several bad scenarios such as CopyOutputRequests being dropped, handled late,
applied on an old surface taking a stale snapshot, or force SurfaceAggregator to
draw two surfaces of one frame sink at the same time.  Always move CopyOutputRequests
given to CompositorFrameSinkSupport to the surface that SurfaceAggregator will draw.

Bug: 817364
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I2a4dffdb17c3b76260ab40a456604c1a73ca1c07
Reviewed-on: https://chromium-review.googlesource.com/943940
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540525}

This reverts commit cbd2ab58.

Reason for revert: Crashing tablet tester:
https://ci.chromium.org/buildbot/chromium.android/KitKat%20Tablet%20Tester/


Original change's description:
> Fix URL bar text being cropped by action buttons.
> 
> A recent change to the layout of the URL bar and the action buttons
> container broke the calculation and application of margin to the URL bar
> to avoid overlap between the action buttons and the URL bar.
> 
> This CL fixes the calculation of the new action container's width and
> the appropriate margin to apply to the URL bar, fixing the issue where
> text in the URL bar was hidden underneath the action container.
> 
> Bug: 816432,816376
> Change-Id: Ic1793f29885392aae97f1b767b65276b597795e7
> Reviewed-on: https://chromium-review.googlesource.com/938383
> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540394}

TBR=mariakhomenko@chromium.org,tedchoc@chromium.org,twellington@chromium.org,thildebr@chromium.org

Change-Id: Ic2b3820e4ae978af5d3610b67133c2e4272cda3e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 816432, 816376, 818187
Reviewed-on: https://chromium-review.googlesource.com/946428Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540524}

base::MakeUnique no longer exists.

Finally, add a link to Google/Abseil C++ TOTW 126, which further
explains the guidance around make_unique.

Bug: 755727
Change-Id: I953cff07f88d8d3dcf4f3c31870abc25397e8107
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/944918Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540523}

Bug: 641225
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3d6d153c1e9bf480f3a736fc1cfd8c1cebac8a19
Reviewed-on: https://chromium-review.googlesource.com/934522Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540522}

This implements an origin trial for signature-based SRI. It introduces
a flag in IntegrityMetadataSet to store whether signature are enabled,
because origin trials are enabled/disbabled based on a request's Origin,
but the Resource instance itself isn't bound to such an origin. Hence,
that information needs to be passed in.

Change-Id: I5780c614044165231e948fdf01ec09f3355671f5
Bug: 753349
Reviewed-on: https://chromium-review.googlesource.com/924187
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540521}

Rename animation_player_unittest.cc to animation_unittest.cc

Bug: 807667
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I9e15c5275330c06516c13ab55f41d4f97802bfd7
Reviewed-on: https://chromium-review.googlesource.com/945409Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540520}

Due to a bad refactoring, ScriptResource was setting data on a cache
handler field it owned, rather than the cache handler of the Resource.

Bug: chromium:783124
Change-Id: I364b1d704821d9c14ad67b2af449c6f5b9aeca43
Reviewed-on: https://chromium-review.googlesource.com/946249Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540519}

This CL is Step 3 & Step 4 from the description of crbug.com/800318.

Bug: 800318
Change-Id: I50d8936f80d193044c159a7d0f12285aaecfdeb6
Reviewed-on: https://chromium-review.googlesource.com/927361
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540518}

The default chunk size is not 200 anymore, for a number of
months.

Change-Id: I8370e472628ddcf1c49bdc09d989bdadf3ea78b3
Reviewed-on: https://chromium-review.googlesource.com/946097
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Jens Widell <jl@opera.com>
Cr-Commit-Position: refs/heads/master@{#540517}

[Password Manager] Merge code of |PasswordUpdatePendingView| and |PasswordPendingView| into |PasswordPendingView|

This CL is Step 2 from the description of crbug.com/800318.

Bug: 800318
Change-Id: I8b71209a8ab820c54a5a122ce0b4b907abd036bb
Reviewed-on: https://chromium-review.googlesource.com/926601
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540516}

https://chromium.googlesource.com/catapult.git/+log/414af52e1273..406b235a95c4

$ git log 414af52e1..406b235a9 --date=short --no-merges --format='%ad %ae %s'
2018-03-01 erikchen Fix logic in memory dump event.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I3779e6a02155825ae99d0d78ef577b5f2aad1648
Reviewed-on: https://chromium-review.googlesource.com/946111Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540515}

This should have landed with
https://chromium-review.googlesource.com/c/chromium/src/+/761239
and fixes an isssue where users can add new credit cards in
Settings/Autofill even if credit cards are disabled.

Bug: 700812
Change-Id: Iccd242ae2f5aef910081199dbbf1a67328953b63
Reviewed-on: https://chromium-review.googlesource.com/944505Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Cait Phillips <caitkp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540514}

The frame could be gone since TEXTFIELD_CHANGED is posted in
FormTracker.

Note: This crash isn't introduced by FormTracker, the TEXTFIELD_CHANGED
has been posted for a long time.

Bug: 818005
Change-Id: I9ea9e100219940d5f975183543acd9263cd0af49
Reviewed-on: https://chromium-review.googlesource.com/945074
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540513}

BUG=810302
TBR=grt@chromium.org

Change-Id: Iabaf1bb1466db928e48f80eed48c0b4f7b3fab04
Reviewed-on: https://chromium-review.googlesource.com/946094Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540512}

BUG=818170
TBR=grt@chromium.org

Change-Id: If59a726f649a32efe7498405e29c0335e3231f09
Reviewed-on: https://chromium-review.googlesource.com/946248Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540511}

Previously we run animation on pending tree upon impl side invalidation
to calculate valid animation state. However it's unnecessary because the
recycle tree that the pending tree is relying on has already been
updated.

Accordingly, the animation logic should stay in CommitComplete to avoid
extra cost.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I3182c3d1a2f9f13bc2758d216d1dd8bbade8f1ab
Bug: 791279
Reviewed-on: https://chromium-review.googlesource.com/919602
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540510}