- 16 Jun, 2018 40 commits
-
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d683d7ced42d..79d42dfb1174 git log d683d7ced42d..79d42dfb1174 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 iannucci@chromium.org Third whitespace change to test builder. 2018-06-15 iannucci@chromium.org More testing whitespace. 2018-06-15 iannucci@chromium.org Whitespace change to test new builder. Created with: gclient setdep -r src/third_party/depot_tools@79d42dfb1174 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:790434,chromium:790434,chromium:790434 TBR=agable@chromium.org Change-Id: I6d781e278eb7a31efdf9072b14959b83adddd9b9 Reviewed-on: https://chromium-review.googlesource.com/1103500Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567892}
-
Cheng-Yu Lee authored
LogMemory() calls memory::OomMemoryDetails::Log(), which is an async call and may take a long time (only 60% returns < 1s, 10% returns > 5s). When we're running out of memory, we need to discard tab faster. BUG=850545 Change-Id: Ia652b2a80f968b0e437904bb6bc2c7c131c1958d Reviewed-on: https://chromium-review.googlesource.com/1097038Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Cheng-Yu Lee <cylee@chromium.org> Cr-Commit-Position: refs/heads/master@{#567891}
-
Iker Jamardo authored
This reverts commit 91a0deb0. Reason for revert: Added conditional checks for strings. Original change's description: > Revert "Check if ARCore is installed or needs update." > > This reverts commit 703de90c. > > Reason for revert: lint errors (http://crbug.com/852189) > > Original change's description: > > Check if ARCore is installed or needs update. > > > > When requesting a session and after the camera permission is confirmed > > to have been granted, check if ARCore is installed and if the version > > used in Chromium is compatible with it. If ARCore is not installed > > or an update is required, a prompt will be shown. > > > > Bug: 838954 > > Change-Id: I35ae39041e7958743bba9cc1c71f5af817bf4240 > > Reviewed-on: https://chromium-review.googlesource.com/1074494 > > Reviewed-by: Theresa <twellington@chromium.org> > > Reviewed-by: agrieve <agrieve@chromium.org> > > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > > Reviewed-by: Peter Kasting <pkasting@chromium.org> > > Reviewed-by: Evan Stade <estade@chromium.org> > > Reviewed-by: Klaus Weidner <klausw@chromium.org> > > Commit-Queue: Iker Jamardo <ijamardo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#566589} > > TBR=ddorwin@chromium.org,vollick@chromium.org,pkasting@chromium.org,yfriedman@chromium.org,bshe@chromium.org,mthiesse@chromium.org,estade@chromium.org,twellington@chromium.org,agrieve@chromium.org,klausw@chromium.org,billorr@chromium.org,lincolnfrog@chromium.org,ijamardo@chromium.org > > Change-Id: I1f88a1de68d4929a842a4c7bf95aa90a7f48bcba > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 838954 > Bug: 852189 > Reviewed-on: https://chromium-review.googlesource.com/1098335 > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Commit-Queue: Nate Fischer <ntfschr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566635} Bug: 838954, 852189 Change-Id: I33fd3d06d749e3f522e3eb4403462112f67295f3 Reviewed-on: https://chromium-review.googlesource.com/1100487Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Iker Jamardo <ijamardo@chromium.org> Cr-Commit-Position: refs/heads/master@{#567890}
-
Devlin Cronin authored
With runtime host permissions, the webRequest API only delivers events for the requests that an extension has access to. As the user grants the extension access (either through the activeTab-like mechanism or through allowing the extension to always run a site), the extension should be able to run on that page. However, the webRequest API traditionally requires access to the URL that is being requested. This means that if the user allows the extension to always run on example.com, but example.com includes a script from chromium.org, that script request will not be visible to the extension. This is a pretty significant breakage for any extension using webRequest with activeTab or runtime host permissions. Instead, relax the restriction so that the extension has access to the request if it a) would normally have access, but it was withheld (via runtime host permissions) and b) it has access to the initiator of the request. This will allow the extension to intercept a request made by example.com to chromium.org. Note that this won't apply to requests made by cross-origin subframes, since the initiator won't be the same as the top-level frame's origin. Bug: 851722 Change-Id: Ibd4dab7e69672782cae2c63f5d4f7d156cd05e0b Reviewed-on: https://chromium-review.googlesource.com/1103003 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#567889}
-
Tomasz Śniatowski authored
https://chromium-review.googlesource.com/959446 broke the ability to reliably override mojo_media_services or mojo_media_host with gn args. Fix by calculating the default values before declare_args in helper variables, having args overrides apply, and asserting the constraints on defaults only. Fixes gn gen with args such as target_os="android" mojo_media_services=["cdm"] which would fail with a "Replacing nonempty list" gn error. Change-Id: Ia6aeaedfb4c40ba681e9c1500545ddd55cbdb0f1 Reviewed-on: https://chromium-review.googlesource.com/1092731 Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#567888}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6ae5d74e8671..7675b369322e git log 6ae5d74e8671..7675b369322e --date=short --no-merges --format='%ad %ae %s' 2018-06-15 halcanary@google.com SkPDF: Annotations should be indirect objects 2018-06-15 bungeman@google.com Work around signed-unsigned comparison warning. 2018-06-15 fmalita@chromium.org [skjson] Detect end-of-input for unbalanced strings 2018-06-15 egdaniel@google.com Add include/config to vulkan memory allocator build. 2018-06-15 bungeman@google.com Work around signed-unsigned comparison warning. 2018-06-15 bungeman@google.com Remove string.h from SkTypes.h 2018-06-15 brianosman@google.com Include sRGB -> Linear in the cached "from sRGB" xform 2018-06-15 bungeman@google.com Work around signed-unsigned comparison warning. 2018-06-15 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 06a2262078b2..50cf2be0758b (3 commits) 2018-06-15 bungeman@google.com Work around signed-unsigned comparison warning. Created with: gclient setdep -r src/third_party/skia@7675b369322e The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I26b81e67115fd19c49e4fdb86d56273f285d6008 Reviewed-on: https://chromium-review.googlesource.com/1103498Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567887}
-
Ned Nguyen authored
Forgot to remove this story in https://chromium-review.googlesource.com/c/chromium/src/+/1101922 TBR=kouhei@chromium.org Change-Id: I72b38dcbb165b29e446b75ba02351d5a1afcab69 Reviewed-on: https://chromium-review.googlesource.com/1103698Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#567886}
-
Joel Einbinder authored
The behavior of `contain: layout` changed, and now it seems to prevent scrollbars from appearing. See https://crbug.com/843320 A follow up patch will fix this for old frontends. Bug: 851622 Change-Id: I91534d8b9f42d37766147ff31ce941916c8ed713 Reviewed-on: https://chromium-review.googlesource.com/1101404Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#567885}
-
Peter Collingbourne authored
The NDK include path is implied by the --sysroot flag, which we're already passing everywhere. Change-Id: I1fefe343e680e899723e05fcd22c2229d8a06f38 Reviewed-on: https://chromium-review.googlesource.com/1103585 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#567884}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=stevenjb@chromium.org Change-Id: I0707f7b2a65a28f94b3010f96c8957ff95f99e9b Reviewed-on: https://chromium-review.googlesource.com/1103532Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#567883}
-
Morten Stenshorne authored
Floats and out-of-flow objects need to be true layout siblings of the inlines, or rendering will be wrong. This means that such objects should never be siblings of anonymous blocks, but rather inside them. This already works correctly for initial layout tree building, and also for many DOM manipulations. However, code was missing to satisfy this requirement if we removed a regular block that was a sibling of an anonymous block and either a float or out-of-flow positioned object. This even caused a crash triggered by ruby code, which ended up mixing inline and block children within the same container. That is not allowed. This happened in the MoveAllChildrenIncludingFloatsTo() call inside LayoutRubyBase::MoveBlockChildren(). Added a DCHECK to MoveAllChildrenIncludingFloatsTo() (which could fail prior to this fix); When moving children from one container to another, either both or none of the containers must have inline children. Bug: 852640 Change-Id: I51d3de12c73ddd07d6b4c1aa55221b4f92359ca7 Reviewed-on: https://chromium-review.googlesource.com/1102690Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#567882}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/31767de5cf0a..f3ce003c2baa git log 31767de5cf0a..f3ce003c2baa --date=short --no-merges --format='%ad %ae %s' 2018-06-15 benjhayden@chromium.org Translate between test paths and descriptors. 2018-06-15 benjhayden@chromium.org Support timestamps with microseconds. Created with: gclient setdep -r src/third_party/catapult@f3ce003c2baa The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9acc766b5c015a9d319744e8969e85ee92d97aad Reviewed-on: https://chromium-review.googlesource.com/1103497Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567881}
-
Kevin Marshall authored
This functionality will be used by the ContextProvider service to bind an arbitrary, client-supplied directory handle to the "/data" directory of the child Context processes. * Adds a helper function for extracting file handles from File objects. * Adds unit tests. * Migrates some uses of ScopedZxHandle to zx::handle. Bug: 850743, 852541 Change-Id: Iada1775485745124822e32b9ac81aefaff6b9059 Reviewed-on: https://chromium-review.googlesource.com/1091803 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#567880}
-
Matt Menke authored
The old code hooked up things to the URLRequestContext that hadn't been ported over to work with the NetworkService yet, when the NetworkService was enabled. This CL just does the minimum setup that's needed to not crash. It also makes requests made with the in-process URLRequestContext fail when the network service is enabled. These changes will help identify code that still depends on the legacy path, and allow for some cleanup of URLRequestContextBuilderMojo and NetworkContext. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I4c3f40e6dc3c235844846bff7d1d43d0b1c986d0 Bug: 825242 Reviewed-on: https://chromium-review.googlesource.com/1096075 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#567879}
-
Malay Keshav authored
This patch performs multiple tasks: - Modify the protocol that generates a ManagedDisplayInfo to use zoom factor instead of ui scale. When display zoom feature is disabled, it reverts back to the old string format. - Add a DCHECK in computing the effective Ui scale to ensure that it is 1 when display zoom is enabled. - Update all tests that fail due to this assertion. This is done mostly by creating a new test class with the display zoom feature disabled. OTOH, the tests that we want to keep in display zoom mode are modified to fit the assertion. We want to make sure that both ui scale and display zoom works for a few milestones before we completely deprecate and remove ui scale. Bug: 823922 Change-Id: I9bab4f6cb0884242d5f9427ba004f4c677835b64 Component: Managed Display Info, ui scale, display zoom Reviewed-on: https://chromium-review.googlesource.com/1099476Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#567878}
-
Robert Sesek authored
The renderers need to talk to the CVMS server (OpenCL compiler), which then outputs codesigned blobs that can be loaded in to the process. This is required for drawing the form controls. In addition, another Metal bundle location (in /Library) is permitted. Bug: 850021, 847518 Change-Id: I67106972baf5fc55fccd8f7deff3f47cbea076b5 Reviewed-on: https://chromium-review.googlesource.com/1103127Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#567877}
-
Jared Saul authored
For Milestone 4 of the Partial Data Project, Chrome should explicitly request that the user confirms their cardholder name (prepopulated with the name from their Google Account) when name is missing and the user does not have a Google Payments account. This CL is actually going to be extremely similar to the original CVC fix flow, which was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1034103. Feel free to cross-reference these CLs, as most everything I took out in that CL is simply getting put back in this one, except this time it's name instead of CVC. Surprise! Bug: 848955 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I08e94c1a16b7b1da403ea5a8f26d1e2d423c210e Reviewed-on: https://chromium-review.googlesource.com/1083880 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#567876}
-
Joel Einbinder authored
Bug: 835492 Change-Id: I172ab5075523f86eca85b4013dc0b77a82650dad Reviewed-on: https://chromium-review.googlesource.com/1103543Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#567875}
-
Krzysztof Olczyk authored
Promise for MediaCapabilities::decodingInfo() is resolved by blink::WebMediaCapabilitiesQueryCallbacks which is passed to WebMediaCapabilitiesClientImpl::DecodingInfo in //media/blink, which, in some cases, means to resolve it in the callback of an async mojo call. However, if the connections is lost meanwhile, neither OnSuccess nor OnError is called and, in the result, the promise resolver remains in pending state. This patch makes sure the OnError is called when mojo connection gets dropped. Bug: 847211 Change-Id: I018792c56a3d3074b042e4318d9a8b85b3c16360 Reviewed-on: https://chromium-review.googlesource.com/1075308Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#567874}
-
Ken Rockot authored
Suppresses log spam about "native service" failures when the service in question is content_renderer. This is because, unlike for any other service in the system, hitting the native service launcher codepath for content_renderer is simply an innocuous side effect of some raciness between browser features and renderer termination. Bug: None Change-Id: I8f73c7ecbe167c160e9df0f3aac3214063997d39 Reviewed-on: https://chromium-review.googlesource.com/1103155Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#567873}
-
Erik Chen authored
This reverts commit a5e2fb1d. Reason for revert: Causes massive memory leaks when the logic is triggered. See https://bugs.chromium.org/p/chromium/issues/detail?id=851506#c26 Original change's description: > Show favicon even if there's no enough space > > In this case, we will do: > 1. Align favicon ceter. > 2. Clip favicon to the tab's shape with 1 DIP padding. > > In order to do this, a mask layer is set to icon view. > When there's a attention icon, tab shaped mask and > circular mask will be combined and then set. > > Bug: 813637 > Change-Id: Idbadfcec44ef61d8a2213df4a87b533885e18a25 > Reviewed-on: https://chromium-review.googlesource.com/938875 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: SangWoo Ko <sangwoo108@gmail.com> > Cr-Commit-Position: refs/heads/master@{#541323} TBR=ellyjones@chromium.org,sangwoo108@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 813637, 851506 Change-Id: I0712eeb68e84db335ead345c4aa6e39600a85c4b Reviewed-on: https://chromium-review.googlesource.com/1103677 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567872}
-
Daniel Murphy authored
Previously, the process id was just the last-bound namespace process. With site-isolation turned on, multiple processes bind to the same namespace, so when 'old' ones opened up their storage area, they would check the wrong process id and fail. This stores the process id as the 'Context' on the binding set. Bug: 848281 Change-Id: I5d4a082494f618c361f0ce845a641679330841fe Reviewed-on: https://chromium-review.googlesource.com/1103553Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#567871}
-
Evan Stade authored
For top level client windows, the cursor is stored in WmNativeWidgetAura. For embed roots, it's stored in ServerWindow. CompoundEventFilter will retrieve the stored cursor while handling mouse events by using aura::WindowDelegate::GetCursor. Depending on the target of the mouse event, the WindowDelegate will be either WindowDelegateImpl (which retrieves it from ServerWindow or delegates to the top level's delegate) or WmNativeWidgetAura (which returns its own copy of the cursor). To test, hover over input field of KSV via: 1. chrome --keyboard-shortcut-viewer-app Ctrl+Alt+/ or 2. ash_shell_with_content Bug: 837705 Change-Id: I247b41937aada5a9b161eb469d8230d06890a63b Reviewed-on: https://chromium-review.googlesource.com/1068661 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#567870}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=stevenjb@google.com Change-Id: If37d7d24e9e5431a03a5e9e533dae38c8fd2f82c Reviewed-on: https://chromium-review.googlesource.com/1103526Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#567869}
-
Steve Kobes authored
This patch reduces preprocessed size of paint_layer_scrollable_area.h from 6.3 MB to 3.8 MB, avoiding transitive inclusion of chrome_client.h and float_clip_rect.h with tricks similar to crrev.com/567547. (Since crrev.com/567732, more source files include PLSA's header.) Bug: 242216,823365 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I969088b6f75b80d3279b0beb3cc701eb16e6ed6a Reviewed-on: https://chromium-review.googlesource.com/1103235Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#567868}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I1e42ea03a697e3b78a146e9b0b996f075f676083 Reviewed-on: https://chromium-review.googlesource.com/1103528Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#567867}
-
Joel Einbinder authored
Bug: 829244 Change-Id: Idc426e6f0963a30340569c2d2835266d325f290e Reviewed-on: https://chromium-review.googlesource.com/1079719Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#567866}
-
Rohit Rao authored
The new location bar implementation requires that the UIRefreshPhase1 experiment also be enabled. When UIRefreshPhase1 is disabled, also disable RefreshLocationBar. BUG=853408 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia0266255cd59ca7487d766928846439a2ac8eed0 Reviewed-on: https://chromium-review.googlesource.com/1103524 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567865}
-
John Budorick authored
TBR=martiniss@chromium.org Bug: 790641 Change-Id: I21d8ef56ad34ab60016edaf421c4dc0a5a0da26a Reviewed-on: https://chromium-review.googlesource.com/1103658Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#567864}
-
Dirk Pranke authored
BUG=853360 TBR=robliao@chromium.org NOTRY=true Change-Id: Iac99d5fa87605d7a01cd2e2d232d4c154525446b Reviewed-on: https://chromium-review.googlesource.com/1103312 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567863}
-
Zhongyi Shi authored
This test case tests that a session will not be migrated to a broken socket when path degrading is detected with connection migration turning on. Bug: 843299 Change-Id: Ie5227808423b1dc9feed1344d85067a939bef133 Reviewed-on: https://chromium-review.googlesource.com/1101935Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#567862}
-
Zhongyi Shi authored
Fix test setup in MigrateOnWriteErrorWithNetworkMadeDefaultQueuedLater to test the network disconnected notification. Bug: 818259, 843299 Change-Id: I961c780dabc7628a598b1cab03231307fb705891 Reviewed-on: https://chromium-review.googlesource.com/1102988 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#567861}
-
Hwanseung Lee authored
replace std::find() with base::containsValue() at components/payments Bug: 561800 Change-Id: Id11c844383e792b608eaa2e0bec6a389821e927c Reviewed-on: https://chromium-review.googlesource.com/1102283Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#567860}
-
Dirk Pranke authored
We want to shut off most of the chromium.webkit builders and merge their tests into the main builders, but currently the tryserver.blink builders mirror them, and the tryserver.blink builders need to stick around so we can generate baselines. This CL adds a bunch of dummy builder entries on chromium.fyi so that we can switch the tryservers to mirror them, instead. Then we'll be free to delete the chromium.webkit builders. This CL also adds some placeholder entries to mb_config.pyl so that we can rename the tryserver.blink bots to match the new naming scheme. R=hinoka@chromium.org BUG=853040 NOTRY=true Change-Id: I2e10feb13473a149a74a69915fcac0d80ec6cd28 Reviewed-on: https://chromium-review.googlesource.com/1101999 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#567859}
-
karandeepb authored
This CL replaces the usages of 'blacklist' and 'whitelist' in the Declarative Net Request code. It introduces the following changes to the public API: - RuleActionType blacklist -> RuleActionType block - RuleActionType whitelist -> RuleActionType allow - MAX_NUMBER_OF_WHITELISTED_PAGES -> MAX_NUMBER_OF_ALLOWED_PAGES - addWhitelistedPages -> addAllowedPages - removeWhitelistedPages -> removeAllowedPages - getWhitelistedPages -> getAllowedPages As a result of this change, existing extensions using the Declarative Net Request API will need to be updated. Usages of these terms in enums and preference keys are kept as-is. BUG=850774, 842296 Change-Id: Id4aaac5ec3123fd56a1591e22025a455d7cb6941 Reviewed-on: https://chromium-review.googlesource.com/1094141 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567858}
-
Ryan Tseng authored
For migrated LUCI builders. Bug: 840631 TBR: dpapad, sky Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8bd70004c4d90f96cac332ff2548b6d87a7f4d05 Reviewed-on: https://chromium-review.googlesource.com/1102907 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567857}
-
Dirk Pranke authored
TBR=robliao@chromium.org BUG=853360 NOTRY=true Change-Id: Id50cc9e6fc255f2bdafad60468540209075db893 Reviewed-on: https://chromium-review.googlesource.com/1103615Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567856}
-
Malay Keshav authored
This patch records UMA metrics for any change to the internal display's zoom factor. It does not record temporary zoom factor changes by debouncing signals that are within a small interval and only allowing the last signal to pass through. Bug: 849894 Change-Id: I2dc7d31e9910855ca4a59834a56d8322641a9f5b Component: Display Manager, UMA, Zoom Reviewed-on: https://chromium-review.googlesource.com/1093270Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#567855}
-
Mina Almasry authored
This was missed when switching from audio master AV sync to video master AV sync. When setting playback rate, we only set the rate of the master, and have the AV sync detect that and adjust the follower. TODO is to proactively tell AvSync that we changed the rate, so it doesn't have to discover that on its own. Bug: b/110230181, b/78193238 Test: On device Change-Id: I734030a68e5d670ec2c35b966f931e687630458a Reviewed-on: https://chromium-review.googlesource.com/1101997 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#567854}
-
Kevin Marshall authored
* Fix to broken host tool "fvm verify" tested (outcome: works). * SDK method rename; "zx_get_startup_handle" to "zx_take_startup_handle". Bug: 852876,707030 Change-Id: Ib635c807ae92dedc76c65c34ab9d3829e8a7e5c0 Reviewed-on: https://chromium-review.googlesource.com/1102834Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#567853}
-